06cf0406fe
Previously we rely on the v8util.setDestructor to dereference the remote objects in JavaScript, however as documented in V8, it is forbidden to call V8 APIs in object's destructor (e.g. the weak callback), and doing so would result in crashs. This commit removes the JavaScript setDestructor method, and avoids doing the dereference work with V8.
44 lines
1.3 KiB
C++
44 lines
1.3 KiB
C++
// Copyright (c) 2016 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ATOM_COMMON_API_REMOTE_CALLBACK_FREER_H_
|
|
#define ATOM_COMMON_API_REMOTE_CALLBACK_FREER_H_
|
|
#include "atom/common/api/object_life_monitor.h"
|
|
#include "content/public/browser/web_contents_observer.h"
|
|
|
|
namespace atom {
|
|
|
|
class RemoteCallbackFreer : public ObjectLifeMonitor,
|
|
public content::WebContentsObserver {
|
|
public:
|
|
static void BindTo(v8::Isolate* isolate,
|
|
v8::Local<v8::Object> target,
|
|
int object_id,
|
|
content::WebContents* web_conents);
|
|
|
|
protected:
|
|
RemoteCallbackFreer(v8::Isolate* isolate,
|
|
v8::Local<v8::Object> target,
|
|
int object_id,
|
|
content::WebContents* web_conents);
|
|
~RemoteCallbackFreer() override;
|
|
|
|
void RunDestructor() override;
|
|
|
|
// content::WebContentsObserver:
|
|
void WebContentsDestroyed() override;
|
|
|
|
private:
|
|
int GetRendererProcessID();
|
|
|
|
content::WebContents* web_contents_;
|
|
int renderer_process_id_;
|
|
int object_id_;
|
|
|
|
DISALLOW_COPY_AND_ASSIGN(RemoteCallbackFreer);
|
|
};
|
|
|
|
} // namespace atom
|
|
|
|
#endif // ATOM_COMMON_API_REMOTE_CALLBACK_FREER_H_
|