* chore: fix cpplint 'include_what_you_use' warnings Typically by including <memory>, <utility> etc. * chore: fix 'static/global string constant' warning Use C style strings instead of std::string. Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables /home/charles/electron/electron-gn/src/electron/script/cpplint.js * refactor: remove global string variables. Fix 'global string variables are not permitted' linter warnings by using the base::NoDestructor<> wrapper to make it explicit that these variables are never destroyed. The style guide's take on globals with nontrivial destructors: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables * fix: initializer error introduced in last commit * fix: remove WIP file that was included by accident * fix: include order * fix: include order * fix: include order * fix: include order, again
		
			
				
	
	
		
			84 lines
		
	
	
	
		
			2.5 KiB
			
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			84 lines
		
	
	
	
		
			2.5 KiB
			
		
	
	
	
		
			C++
		
	
	
	
	
	
// Copyright (c) 2014 GitHub, Inc.
 | 
						|
// Use of this source code is governed by the MIT license that can be
 | 
						|
// found in the LICENSE file.
 | 
						|
 | 
						|
#include "atom/browser/api/atom_api_menu_views.h"
 | 
						|
 | 
						|
#include <memory>
 | 
						|
 | 
						|
#include "atom/browser/native_window_views.h"
 | 
						|
#include "atom/browser/unresponsive_suppressor.h"
 | 
						|
#include "ui/display/screen.h"
 | 
						|
 | 
						|
using views::MenuRunner;
 | 
						|
 | 
						|
namespace atom {
 | 
						|
 | 
						|
namespace api {
 | 
						|
 | 
						|
MenuViews::MenuViews(v8::Isolate* isolate, v8::Local<v8::Object> wrapper)
 | 
						|
    : Menu(isolate, wrapper), weak_factory_(this) {}
 | 
						|
 | 
						|
MenuViews::~MenuViews() = default;
 | 
						|
 | 
						|
void MenuViews::PopupAt(TopLevelWindow* window,
 | 
						|
                        int x,
 | 
						|
                        int y,
 | 
						|
                        int positioning_item,
 | 
						|
                        const base::Closure& callback) {
 | 
						|
  auto* native_window = static_cast<NativeWindowViews*>(window->window());
 | 
						|
  if (!native_window)
 | 
						|
    return;
 | 
						|
 | 
						|
  // (-1, -1) means showing on mouse location.
 | 
						|
  gfx::Point location;
 | 
						|
  if (x == -1 || y == -1) {
 | 
						|
    location = display::Screen::GetScreen()->GetCursorScreenPoint();
 | 
						|
  } else {
 | 
						|
    gfx::Point origin = native_window->GetContentBounds().origin();
 | 
						|
    location = gfx::Point(origin.x() + x, origin.y() + y);
 | 
						|
  }
 | 
						|
 | 
						|
  int flags = MenuRunner::CONTEXT_MENU | MenuRunner::HAS_MNEMONICS;
 | 
						|
 | 
						|
  // Don't emit unresponsive event when showing menu.
 | 
						|
  atom::UnresponsiveSuppressor suppressor;
 | 
						|
 | 
						|
  // Show the menu.
 | 
						|
  int32_t window_id = window->weak_map_id();
 | 
						|
  auto close_callback = base::Bind(
 | 
						|
      &MenuViews::OnClosed, weak_factory_.GetWeakPtr(), window_id, callback);
 | 
						|
  menu_runners_[window_id] =
 | 
						|
      std::make_unique<MenuRunner>(model(), flags, close_callback);
 | 
						|
  menu_runners_[window_id]->RunMenuAt(
 | 
						|
      native_window->widget(), NULL, gfx::Rect(location, gfx::Size()),
 | 
						|
      views::MENU_ANCHOR_TOPLEFT, ui::MENU_SOURCE_MOUSE);
 | 
						|
}
 | 
						|
 | 
						|
void MenuViews::ClosePopupAt(int32_t window_id) {
 | 
						|
  auto runner = menu_runners_.find(window_id);
 | 
						|
  if (runner != menu_runners_.end()) {
 | 
						|
    // Close the runner for the window.
 | 
						|
    runner->second->Cancel();
 | 
						|
  } else if (window_id == -1) {
 | 
						|
    // Or just close all opened runners.
 | 
						|
    for (auto it = menu_runners_.begin(); it != menu_runners_.end();) {
 | 
						|
      // The iterator is invalidated after the call.
 | 
						|
      (it++)->second->Cancel();
 | 
						|
    }
 | 
						|
  }
 | 
						|
}
 | 
						|
 | 
						|
void MenuViews::OnClosed(int32_t window_id, base::Closure callback) {
 | 
						|
  menu_runners_.erase(window_id);
 | 
						|
  callback.Run();
 | 
						|
}
 | 
						|
 | 
						|
// static
 | 
						|
mate::WrappableBase* Menu::New(mate::Arguments* args) {
 | 
						|
  return new MenuViews(args->isolate(), args->GetThis());
 | 
						|
}
 | 
						|
 | 
						|
}  // namespace api
 | 
						|
 | 
						|
}  // namespace atom
 |