mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
electron/spec
History
Erick Zhao e03a40026a fix: correct triggeredByAccelerator Event property behavior (#18865) 
Fixes #18808

Previously, the triggeredByAccelerator flag would be entirely coupled with whether or not the modifier keys were being used or not.

This PR swaps out the ui::EventFlagsFromModifiers([event modifierFlags])) call in the macOS code to ui::EventFlagsFromNSEventWithModifiers(event, [event modifierFlags])). The latter outputs flags that take into account mouse click events on top of modifier flags (see Chromium documentation).

The business logic to detect triggeredByAccelerator is then changed to exclude any mouse click flags.
2019-06-28 14:38:17 -07:00
..
configs ci: run more Chromium unit tests (#15363) 2018-10-25 14:28:50 -04:00
fixtures test: move protocol specs to main process (#18923) 2019-06-27 14:20:29 -07:00
static ci: make console.warn work in tests (#18771) 2019-06-13 15:56:58 -07:00
ts-smoke feat: allow setting working directory in app.setUserTasks() / app.setJumpList() (#18148) 2019-05-13 19:17:12 +03:00
.eslintrc chore: replace standard with eslint-config-standard and add custom rules (#14636) 2018-09-16 03:51:23 +10:00
api-auto-updater-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-browser-view-spec.js chore: finish replacing assert with expect in tests (#18215) 2019-05-20 12:04:18 -05:00
api-browser-window-affinity-spec.js test: promisify a bunch of tests (#16051) 2018-12-18 23:44:03 -07:00
api-browser-window-spec.js spec: move more BrowserWindow specs to main runner (#18610) 2019-06-20 08:38:21 +09:00
api-clipboard-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-content-tracing-spec.js feat: [contentTracing] allow calling stopTracing() with no arguments (#18411) 2019-05-28 14:15:42 -07:00
api-crash-reporter-spec.js fix: use crashpad on Windows (#18483) 2019-06-13 15:42:21 +09:00
api-debugger-spec.js chore: remove promisification deprecation callbacks (#17907) 2019-04-30 07:08:32 -07:00
api-deprecate-spec.js chore: remove duplicate internal deprecations module (just use deprecate) (#18352) 2019-05-21 00:40:49 +02:00
api-desktop-capturer-spec.js chore: remove promisification deprecation callbacks (#17907) 2019-04-30 07:08:32 -07:00
api-dialog-spec.js fix: set window to null when no window is passed (#18240) 2019-05-21 09:08:22 -05:00
api-global-shortcut-spec.js feat: allow registering multiple shortcuts (#15542) 2018-11-07 09:40:38 -08:00
api-in-app-purchase-spec.js chore: remove promisification deprecation callbacks (#17907) 2019-04-30 07:08:32 -07:00
api-ipc-main-spec.js chore: remove special handling for dialog methods in remote module (#17412) 2019-03-19 11:59:33 -07:00
api-ipc-renderer-spec.js fix: emit IPC event in correct context if isolation and sandbox enabled (#16352) 2019-01-12 14:19:20 +01:00
api-menu-item-spec.js chore: finish replacing assert with expect in tests (#18215) 2019-05-20 12:04:18 -05:00
api-menu-spec.js fix: correct triggeredByAccelerator Event property behavior (#18865) 2019-06-28 14:38:17 -07:00
api-native-image-spec.js refactor: make templateImage a property on nativeImage (#18124) 2019-05-07 06:52:07 -07:00
api-notification-dbus-spec.js chore: bump chromium to 964c4bca8de5c320534d95606c861 (master) (#18440) 2019-05-28 13:18:10 -07:00
api-notification-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-power-monitor-spec.js chore: bump chromium to 964c4bca8de5c320534d95606c861 (master) (#18440) 2019-05-28 13:18:10 -07:00
api-power-save-blocker-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-process-spec.js feat: add process.getBlinkMemoryInfo() (#17762) 2019-05-30 11:50:35 +02:00
api-remote-spec.js test: move some remote specs to the main runner (#18636) 2019-06-07 10:43:32 -07:00
api-shell-spec.js fix: properly pass openExternal activate option (#18657) 2019-06-10 07:40:05 -07:00
api-subframe-spec.js spec: remove unused variables (#18947) 2019-06-24 13:41:20 -05:00
api-system-preferences-spec.js refactor: convert browser window state fns to props (#18618) 2019-06-04 22:44:16 -07:00
api-touch-bar-spec.js chore: finish replacing assert with expect in tests (#18215) 2019-05-20 12:04:18 -05:00
api-view-spec.js chore: update to standard 12 2018-09-14 14:57:01 +10:00
api-web-contents-spec.js Revert "feat: only allow bundled preload scripts (#17308)" (#18091) 2019-06-20 08:39:12 +09:00
api-web-contents-view-spec.js chore: finish replacing assert with expect in tests (#18215) 2019-05-20 12:04:18 -05:00
api-web-frame-spec.js fix: contractions handling in spellchecker (#18506) 2019-05-30 21:19:10 -07:00
api-web-request-spec.js chore: finish replacing assert with expect in tests (#18215) 2019-05-20 12:04:18 -05:00
asar-spec.js refactor: remove electron.asar and embed JS in binary (#18577) 2019-06-03 17:03:59 -07:00
BUILD.gn ci: run unittests on clean Chromium (#15125) 2018-10-22 16:12:19 -04:00
chrome-api-spec.js chore: finish replacing assert with expect in tests (#18215) 2019-05-20 12:04:18 -05:00
chromium-spec.js spec: deflake focus handling test (#18809) 2019-06-15 16:15:15 +09:00
content-script-spec.js chore: remove promisification deprecation callbacks (#17907) 2019-04-30 07:08:32 -07:00
events-helpers.js fix: we can not use ts-node apaprently 2019-03-14 13:39:53 -07:00
expect-helpers.js chore: finish replacing assert with expect in tests (#18215) 2019-05-20 12:04:18 -05:00
internal-spec.js refactor: bundle the browser and renderer process electron code (#18553) 2019-06-02 13:03:03 -07:00
modules-spec.js chore: finish replacing assert with expect in tests (#18215) 2019-05-20 12:04:18 -05:00
network-helper.js fix: lost window.opener after cross-origin navigation (#18173) 2019-06-03 13:23:15 -07:00
node-spec.js fix: override the timers module impls to activate the uv loop (#18948) 2019-06-24 10:18:29 -07:00
package.json build: ensure consistent lock files across multiple machines (#17955) 2019-04-30 13:59:47 -07:00
security-warnings-spec.js feat: add security warning for remote module with remote content (#18822) 2019-06-17 14:21:30 -07:00
version-bump-spec.js build: clean up scripts folder, move release scripts, move zip manifest logic (#18945) 2019-06-24 10:18:04 -07:00
webview-spec.js feat: add removeInsertedCSS (#16579) 2019-06-17 11:39:35 -04:00
window-helpers.js test: move beforeunload tests to main runner and fix flake (#18432) 2019-05-29 13:38:14 -07:00
yarn.lock build: ensure consistent lock files across multiple machines (#17955) 2019-04-30 13:59:47 -07:00