ec98e95b8a
fix: performance problem in crashReporter.start() on macOS
This change reduces the duration of crashReporter.start() on Intel macOS
from 622 milliseconds to 257 milliseconds!
Backports https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386
posix: Replace DoubleForkAndExec() with ForkAndSpawn()
The DoubleForkAndExec() function was taking over 622 milliseconds to run
on macOS 11 (BigSur) on Intel i5-1038NG7. I did some debugging by adding
some custom traces and found that the fork() syscall is the bottleneck
here, i.e., the first fork() takes around 359 milliseconds and the
nested fork() takes around 263 milliseconds. Replacing the nested fork()
and exec() with posix_spawn() reduces the time consumption to 257
milliseconds!
See https://github.com/libuv/libuv/pull/3064 to know why fork() is so
slow on macOS and why posix_spawn() is a better replacement.
Another point to note is that even base::LaunchProcess() from Chromium
calls posix_spawnp() on macOS -
8f8d82dea0:base/process/launch_mac.cc;l=295-296
Change-Id: I25c6ee9629a1ae5d0c32b361b56a1ce0b4b0fd26
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Fixes: https://github.com/electron/electron/issues/34321
Signed-off-by: Darshan Sen <raisinten@gmail.com>
114 lines
4.7 KiB
Text
114 lines
4.7 KiB
Text
build_gn.patch
|
|
dcheck.patch
|
|
accelerator.patch
|
|
blink_file_path.patch
|
|
blink_local_frame.patch
|
|
can_create_window.patch
|
|
disable_hidden.patch
|
|
dom_storage_limits.patch
|
|
render_widget_host_view_base.patch
|
|
render_widget_host_view_mac.patch
|
|
webview_cross_drag.patch
|
|
gin_enable_disable_v8_platform.patch
|
|
disable-redraw-lock.patch
|
|
enable_reset_aspect_ratio.patch
|
|
v8_context_snapshot_generator.patch
|
|
boringssl_build_gn.patch
|
|
pepper_plugin_support.patch
|
|
gtk_visibility.patch
|
|
sysroot.patch
|
|
resource_file_conflict.patch
|
|
scroll_bounce_flag.patch
|
|
mas_blink_no_private_api.patch
|
|
mas_no_private_api.patch
|
|
mas-cgdisplayusesforcetogray.patch
|
|
mas_disable_remote_layer.patch
|
|
mas_disable_remote_accessibility.patch
|
|
mas_disable_custom_window_frame.patch
|
|
mas_avoid_usage_of_private_macos_apis.patch
|
|
mas_use_public_apis_to_determine_if_a_font_is_a_system_font.patch
|
|
chrome_key_systems.patch
|
|
add_didinstallconditionalfeatures.patch
|
|
desktop_media_list.patch
|
|
proxy_config_monitor.patch
|
|
gritsettings_resource_ids.patch
|
|
isolate_holder.patch
|
|
notification_provenance.patch
|
|
dump_syms.patch
|
|
command-ismediakey.patch
|
|
printing.patch
|
|
support_mixed_sandbox_with_zygote.patch
|
|
unsandboxed_ppapi_processes_skip_zygote.patch
|
|
build_add_electron_tracing_category.patch
|
|
worker_context_will_destroy.patch
|
|
frame_host_manager.patch
|
|
crashpad_pid_check.patch
|
|
network_service_allow_remote_certificate_verification_logic.patch
|
|
disable_color_correct_rendering.patch
|
|
add_contentgpuclient_precreatemessageloop_callback.patch
|
|
picture-in-picture.patch
|
|
disable_compositor_recycling.patch
|
|
allow_new_privileges_in_unsandboxed_child_processes.patch
|
|
expose_setuseragent_on_networkcontext.patch
|
|
feat_add_set_theme_source_to_allow_apps_to.patch
|
|
add_webmessageportconverter_entangleandinjectmessageportchannel.patch
|
|
ignore_rc_check.patch
|
|
remove_usage_of_incognito_apis_in_the_spellchecker.patch
|
|
allow_disabling_blink_scheduler_throttling_per_renderview.patch
|
|
hack_plugin_response_interceptor_to_point_to_electron.patch
|
|
feat_add_support_for_overriding_the_base_spellchecker_download_url.patch
|
|
feat_enable_offscreen_rendering_with_viz_compositor.patch
|
|
gpu_notify_when_dxdiag_request_fails.patch
|
|
feat_allow_embedders_to_add_observers_on_created_hunspell.patch
|
|
feat_add_onclose_to_messageport.patch
|
|
allow_in-process_windows_to_have_different_web_prefs.patch
|
|
refactor_expose_cursor_changes_to_the_webcontentsobserver.patch
|
|
crash_allow_setting_more_options.patch
|
|
breakpad_treat_node_processes_as_browser_processes.patch
|
|
upload_list_add_loadsync_method.patch
|
|
breakpad_allow_getting_string_values_for_crash_keys.patch
|
|
crash_allow_disabling_compression_on_linux.patch
|
|
allow_setting_secondary_label_via_simplemenumodel.patch
|
|
feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
|
|
fix_patch_out_profile_refs_in_accessibility_ui.patch
|
|
skip_atk_toolchain_check.patch
|
|
worker_feat_add_hook_to_notify_script_ready.patch
|
|
chore_provide_iswebcontentscreationoverridden_with_full_params.patch
|
|
fix_properly_honor_printing_page_ranges.patch
|
|
chore_expose_v8_initialization_isolate_callbacks.patch
|
|
export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch
|
|
fix_export_zlib_symbols.patch
|
|
don_t_use_potentially_null_getwebframe_-_view_when_get_blink.patch
|
|
web_contents.patch
|
|
webview_fullscreen.patch
|
|
disable_unload_metrics.patch
|
|
fix_add_check_for_sandbox_then_result.patch
|
|
extend_apply_webpreferences.patch
|
|
build_libc_as_static_library.patch
|
|
build_do_not_depend_on_packed_resource_integrity.patch
|
|
refactor_restore_base_adaptcallbackforrepeating.patch
|
|
hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch
|
|
don_t_run_pcscan_notifythreadcreated_if_pcscan_is_disabled.patch
|
|
logging_win32_only_create_a_console_if_logging_to_stderr.patch
|
|
fix_media_key_usage_with_globalshortcuts.patch
|
|
feat_expose_raw_response_headers_from_urlloader.patch
|
|
chore_do_not_use_chrome_windows_in_cryptotoken_webrequestsender.patch
|
|
process_singleton.patch
|
|
fix_expose_decrementcapturercount_in_web_contents_impl.patch
|
|
add_ui_scopedcliboardwriter_writeunsaferawdata.patch
|
|
feat_add_data_parameter_to_processsingleton.patch
|
|
load_v8_snapshot_in_browser_process.patch
|
|
fix_adapt_exclusive_access_for_electron_needs.patch
|
|
fix_aspect_ratio_with_max_size.patch
|
|
fix_dont_delete_SerialPortManager_on_main_thread.patch
|
|
fix_crash_when_saving_edited_pdf_files.patch
|
|
port_autofill_colors_to_the_color_pipeline.patch
|
|
build_disable_partition_alloc_on_mac.patch
|
|
fix_non-client_mouse_tracking_and_message_bubbling_on_windows.patch
|
|
build_make_libcxx_abi_unstable_false_for_electron.patch
|
|
introduce_ozoneplatform_electron_can_call_x11_property.patch
|
|
make_gtk_getlibgtk_public.patch
|
|
build_disable_print_content_analysis.patch
|
|
custom_protocols_plzserviceworker.patch
|
|
feat_filter_out_non-shareable_windows_in_the_current_application_in.patch
|
|
posix_replace_doubleforkandexec_with_forkandspawn.patch
|