mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
electron/atom/browser/api
History
trop[bot] 02b1069fd8 fix: Invalidate weak ptrs before window Javascript object is destroyed (backport: 3-0-x) (#14591) 
* fix: Invalidate weak ptrs before window Javascript object is destroyed

* chore: add regression test for #14513

This test is similar to the original gist at https://gist.github.com/bpasero/a02a645e11f4946dcca1331d0299149d -- the key is to open multiple windows and add an `app.on('browser-window-focus') listener that accesses window.id.

* fix: last commit didn't test the right thing.

The test needs to run in the main process to reproduce the
conditions reported in #14513
2018-09-12 15:22:05 -05:00
..
atom_api_app.cc fix: add method and referrer properties to app login event (backport: 3-0-x) (#14277) 2018-08-23 20:47:16 +09:00
atom_api_app.h fix: add method and referrer properties to app login event (backport: 3-0-x) (#14277) 2018-08-23 20:47:16 +09:00
atom_api_app_mas.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
atom_api_auto_updater.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_auto_updater.h [chromium-style] override / virtual warnings 2018-04-19 11:12:10 -07:00
atom_api_box_layout.cc Add View.addChildView API 2018-05-24 15:36:29 +09:00
atom_api_box_layout.h Add View.addChildView API 2018-05-24 15:36:29 +09:00
atom_api_browser_view.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
atom_api_browser_view.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
atom_api_browser_window.cc fix: window.setVibrancy parameter passing (backport: 3-0-x) (#13863) 2018-07-30 13:02:32 +10:00
atom_api_browser_window.h fix: window.setVibrancy parameter passing (backport: 3-0-x) (#13863) 2018-07-30 13:02:32 +10:00
atom_api_browser_window_mac.mm fix: use InspectableWebContentsView as content view 2018-07-16 13:40:48 +00:00
atom_api_browser_window_views.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_button.cc feat: add LabelButton API 2018-06-18 16:51:36 +09:00
atom_api_button.h feat: add LabelButton API 2018-06-18 16:51:36 +09:00
atom_api_content_tracing.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_cookies.cc fix: notify request context shutdown on IO before cleanup (#14092) 2018-08-22 08:24:56 -07:00
atom_api_cookies.h fix: notify request context shutdown on IO before cleanup (#14092) 2018-08-22 08:24:56 -07:00
atom_api_debugger.cc backport debugger fix (#14481) 2018-09-06 10:57:41 -07:00
atom_api_debugger.h backport debugger fix (#14481) 2018-09-06 10:57:41 -07:00
atom_api_desktop_capturer.cc fix: ensure DirectX capturer is supported. (backport: 3-0-x) (#13738) 2018-07-20 14:25:29 +10:00
atom_api_desktop_capturer.h fix: ensure DirectX capturer is supported. (backport: 3-0-x) (#13738) 2018-07-20 14:25:29 +10:00
atom_api_dialog.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_download_item.cc Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
atom_api_download_item.h Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
atom_api_global_shortcut.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_global_shortcut.h Pass FunctionTemplate in BuildPrototype 2016-08-02 18:08:12 +09:00
atom_api_in_app_purchase.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_in_app_purchase.h Improve in-app purchase for MacOS (#12464) 2018-04-05 15:33:13 +09:00
atom_api_label_button.cc feat: add LabelButton API 2018-06-18 16:51:36 +09:00
atom_api_label_button.h feat: add LabelButton API 2018-06-18 16:51:36 +09:00
atom_api_layout_manager.cc Add LayoutManager/BoxLayout APIs 2018-05-24 15:36:29 +09:00
atom_api_layout_manager.h Add LayoutManager/BoxLayout APIs 2018-05-24 15:36:29 +09:00
atom_api_menu.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
atom_api_menu.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
atom_api_menu_mac.h [chromium-style] out-of-line default constructors and destructors 2018-04-19 11:12:58 -07:00
atom_api_menu_mac.mm Fix: Prevent menu update while it's open (#12809) 2018-05-17 11:19:28 +10:00
atom_api_menu_views.cc refactoring: use std::make_unique<T> (#13245) 2018-06-18 16:32:55 +09:00
atom_api_menu_views.h [chromium-style] out-of-line default constructors and destructors 2018-04-19 11:12:58 -07:00
atom_api_net.cc Upgrade to node v9.3.0 (#11507) 2018-02-23 10:22:00 +09:00
atom_api_net.h Fixing code review issues. 2016-10-25 12:41:01 +02:00
atom_api_net_log.cc feat: netLog API for dynamic logging control (#13068) 2018-06-19 11:45:58 +10:00
atom_api_net_log.h feat: netLog API for dynamic logging control (#13068) 2018-06-19 11:45:58 +10:00
atom_api_notification.cc REVIEW: Remove the notification close-closure in favour of an explicit method 2018-06-19 11:49:40 +10:00
atom_api_notification.h Organize code 2018-02-10 03:19:47 -08:00
atom_api_power_monitor.cc Screen Lock / Unlock events (#12714) 2018-05-01 02:04:27 +10:00
atom_api_power_monitor.h Screen Lock / Unlock events (#12714) 2018-05-01 02:04:27 +10:00
atom_api_power_monitor_mac.mm Fix chromium-style errors (#12802) 2018-05-03 09:04:22 -05:00
atom_api_power_monitor_win.cc Screen Lock / Unlock events (#12714) 2018-05-01 02:04:27 +10:00
atom_api_power_save_blocker.cc Remove redundant device::PowerSaveBlocker enums. 2018-06-19 11:49:41 +10:00
atom_api_power_save_blocker.h Remove redundant device::PowerSaveBlocker enums. 2018-06-19 11:49:41 +10:00
atom_api_protocol.cc [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
atom_api_protocol.h fix: notify request context shutdown on IO before cleanup (#14092) 2018-08-22 08:24:56 -07:00
atom_api_render_process_preferences.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_render_process_preferences.h clang-format atom files 2018-04-18 20:48:45 -04:00
atom_api_screen.cc remove screen.getMenuBarHeight() deprecation 2018-05-23 09:11:48 -07:00
atom_api_screen.h remove screen.getMenuBarHeight() deprecation 2018-05-23 09:11:48 -07:00
atom_api_session.cc fix: notify request context shutdown on IO before cleanup (#14092) 2018-08-22 08:24:56 -07:00
atom_api_session.h Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
atom_api_system_preferences.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_system_preferences.h clang-format atom files 2018-04-18 20:48:45 -04:00
atom_api_system_preferences_mac.mm clang-format objc files (#12673) 2018-04-20 11:47:04 -07:00
atom_api_system_preferences_win.cc also format missing .cc files 2018-04-18 20:48:45 -04:00
atom_api_text_field.cc feat: add SetText for TextField 2018-06-18 16:51:36 +09:00
atom_api_text_field.h feat: add SetText for TextField 2018-06-18 16:51:36 +09:00
atom_api_top_level_window.cc fix: Invalidate weak ptrs before window Javascript object is destroyed (backport: 3-0-x) (#14591) 2018-09-12 15:22:05 -05:00
atom_api_top_level_window.h fix: notify focus change right away rather not on next tick (#14453) 2018-09-07 14:30:41 -04:00
atom_api_tray.cc fix: don't crash on tray.setContextMenu(null) (#14331) 2018-08-27 13:27:41 -07:00
atom_api_tray.h add getter for ignoreDoubleClickEvents field 2018-05-03 13:49:33 -07:00
atom_api_url_request.cc feat: add getUploadProgress API to the net API (#14446) 2018-09-04 12:26:50 -05:00
atom_api_url_request.h feat: add getUploadProgress API to the net API (#14446) 2018-09-04 12:26:50 -05:00
atom_api_view.cc Put View APIs under a build flag 2018-05-24 15:44:07 +09:00
atom_api_view.h Put View APIs under a build flag 2018-05-24 15:44:07 +09:00
atom_api_web_contents.cc fix: use render client id to track deleted render process hosts (backport: 3-0-x) (#14557) 2018-09-11 19:56:20 -07:00
atom_api_web_contents.h Print error when removed webview attribute is used (backport: 3-0-x) (#14274) 2018-08-23 15:42:08 +09:00
atom_api_web_contents_mac.mm Include missing header 2018-06-19 11:49:41 +10:00
atom_api_web_contents_osr.cc Update OSR code 2018-06-19 11:49:44 +10:00
atom_api_web_contents_view.cc Add LayoutManager/BoxLayout APIs 2018-05-24 15:36:29 +09:00
atom_api_web_contents_view.h WebContents may be managed by multiple owners 2018-05-21 10:53:09 +09:00
atom_api_web_request.cc fix: notify request context shutdown on IO before cleanup (#14092) 2018-08-22 08:24:56 -07:00
atom_api_web_request.h clang-format atom files 2018-04-18 20:48:45 -04:00
atom_api_web_view_manager.cc fix: use OOPIF for webview tag (#13869) (#14156) 2018-08-17 08:21:36 -07:00
event.cc perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 2018-06-13 17:38:31 +10:00
event.h perf: don't use JSON to send the result of ipcRenderer.sendSync. (#8953) 2018-06-13 17:38:31 +10:00
event_emitter.cc update native-mate ref 2018-06-19 11:49:41 +10:00
event_emitter.h clang-format atom files 2018-04-18 20:48:45 -04:00
event_subscriber.cc [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
event_subscriber.h Fix up #includes to work with both GYP and GN 2018-05-10 13:38:40 -07:00
frame_subscriber.cc fix: don't invoke callback after FrameSubscriber is destroyed 2018-07-13 09:56:07 +00:00
frame_subscriber.h fix: don't invoke callback after FrameSubscriber is destroyed 2018-07-13 09:56:07 +00:00
save_page_handler.cc Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
save_page_handler.h Move download_item.h from content/public to components/download 2018-06-19 11:49:40 +10:00
trackable_object.cc Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00
trackable_object.h Refactoring: use C++11 class member variable initialization 2018-05-22 00:18:38 +02:00