
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: 4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
23 lines
697 B
C++
23 lines
697 B
C++
// Copyright (c) 2015 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ELECTRON_SHELL_COMMON_KEYBOARD_UTIL_H_
|
|
#define ELECTRON_SHELL_COMMON_KEYBOARD_UTIL_H_
|
|
|
|
#include <optional>
|
|
#include <string_view>
|
|
|
|
#include "ui/events/keycodes/keyboard_codes.h"
|
|
|
|
namespace electron {
|
|
|
|
// Return key code of the |str|, if the original key is a shifted character,
|
|
// for example + and /, set it in |shifted_char|.
|
|
// pressed.
|
|
ui::KeyboardCode KeyboardCodeFromStr(std::string_view str,
|
|
std::optional<char16_t>* shifted_char);
|
|
|
|
} // namespace electron
|
|
|
|
#endif // ELECTRON_SHELL_COMMON_KEYBOARD_UTIL_H_
|