f36ceae024
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: 4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
39 lines
1.2 KiB
C++
39 lines
1.2 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ELECTRON_SHELL_COMMON_GIN_HELPER_ERROR_THROWER_H_
|
|
#define ELECTRON_SHELL_COMMON_GIN_HELPER_ERROR_THROWER_H_
|
|
|
|
#include <string_view>
|
|
|
|
#include "base/memory/raw_ptr.h"
|
|
#include "v8/include/v8.h"
|
|
|
|
namespace gin_helper {
|
|
|
|
class ErrorThrower {
|
|
public:
|
|
explicit ErrorThrower(v8::Isolate* isolate);
|
|
ErrorThrower();
|
|
~ErrorThrower() = default;
|
|
|
|
void ThrowError(std::string_view err_msg) const;
|
|
void ThrowTypeError(std::string_view err_msg) const;
|
|
void ThrowRangeError(std::string_view err_msg) const;
|
|
void ThrowReferenceError(std::string_view err_msg) const;
|
|
void ThrowSyntaxError(std::string_view err_msg) const;
|
|
|
|
v8::Isolate* isolate() const { return isolate_; }
|
|
|
|
private:
|
|
using ErrorGenerator = v8::Local<v8::Value> (*)(v8::Local<v8::String> err_msg,
|
|
v8::Local<v8::Value> options);
|
|
void Throw(ErrorGenerator gen, std::string_view err_msg) const;
|
|
|
|
raw_ptr<v8::Isolate> isolate_;
|
|
};
|
|
|
|
} // namespace gin_helper
|
|
|
|
#endif // ELECTRON_SHELL_COMMON_GIN_HELPER_ERROR_THROWER_H_
|