From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: VerteDinde Date: Sun, 20 Nov 2022 21:45:20 -0800 Subject: fix: enable crashpad for ELECTRON_RUN_AS_NODE linux processes Passes the crashpad handler PID and crashdump signal file descriptor to child processes spawned with `ELECTRON_RUN_AS_NODE` which is used by the crashpad client to connect with the handler process. diff --git a/lib/child_process.js b/lib/child_process.js index 655349b6fa17217a9202616224032a36fd01e284..bf62c5adf0e0d75cb50636f365f71db82c29ba29 100644 --- a/lib/child_process.js +++ b/lib/child_process.js @@ -62,6 +62,7 @@ let debug = require('internal/util/debuglog').debuglog( ); const { Buffer } = require('buffer'); const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap'); +const { getCrashdumpSignalFD, getCrashpadHandlerPID } = process._linkedBinding('electron_common_crashpad_support'); const { AbortError, @@ -156,7 +157,6 @@ function fork(modulePath, args = [], options) { ArrayPrototypeSplice(execArgv, index - 1, 2); } } - args = [...execArgv, modulePath, ...args]; if (typeof options.stdio === 'string') { @@ -637,6 +637,22 @@ function normalizeSpawnArguments(file, args, options) { 'options.windowsVerbatimArguments'); } + const env = options.env || { ...process.env }; + + if ((process.platform === 'linux') && + ObjectPrototypeHasOwnProperty(env, 'ELECTRON_RUN_AS_NODE') && + (file === process.execPath)) { + // On Linux, pass the file descriptor which crashpad handler process + // uses to monitor the child process and PID of the handler process. + // https://source.chromium.org/chromium/chromium/src/+/110.0.5415.0:components/crash/core/app/crashpad_linux.cc;l=199-206 + const fd = getCrashdumpSignalFD(); + const pid = getCrashpadHandlerPID(); + if (fd !== -1 && pid !== -1) { + env.CRASHDUMP_SIGNAL_FD = fd; + env.CRASHPAD_HANDLER_PID = pid; + } + } + if (options.shell) { validateArgumentNullCheck(options.shell, 'options.shell'); const command = ArrayPrototypeJoin([file, ...args], ' '); @@ -670,8 +686,6 @@ function normalizeSpawnArguments(file, args, options) { ArrayPrototypeUnshift(args, file); } - // Shallow copy to guarantee changes won't impact process.env - const env = options.env || { ...process.env }; const envPairs = []; // process.env.NODE_V8_COVERAGE always propagates, making it possible to