From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Wed, 4 Mar 2020 11:18:03 -0800 Subject: feat: add onclose to MessagePort This adds the 'onclose' event to MessagePort. This is [proposed](https://github.com/w3ctag/design-reviews/issues/269#issuecomment-407584290) in w3c and has been discussed for years without conclusion. I'd like to get this standardised, but in lieu of that, this makes MessagePort a whole bunch more useful! diff --git a/third_party/blink/renderer/core/messaging/message_port.cc b/third_party/blink/renderer/core/messaging/message_port.cc index 9e9de51e37ee46266c647bd9c0c27e02a42bf5f1..d16727bed1a99b8171d0c7c5c5b7f38289ae9e55 100644 --- a/third_party/blink/renderer/core/messaging/message_port.cc +++ b/third_party/blink/renderer/core/messaging/message_port.cc @@ -158,6 +158,7 @@ void MessagePort::close() { Entangle(pipe.TakePort0()); } closed_ = true; + DispatchEvent(*Event::Create(event_type_names::kClose)); } void MessagePort::Entangle(MessagePortDescriptor port) { diff --git a/third_party/blink/renderer/core/messaging/message_port.h b/third_party/blink/renderer/core/messaging/message_port.h index 7a83dce5113dc77d3654997db09ff9bc4cfeb3e2..85987f99ee144060cee11719726eb823bf58c645 100644 --- a/third_party/blink/renderer/core/messaging/message_port.h +++ b/third_party/blink/renderer/core/messaging/message_port.h @@ -120,6 +120,13 @@ class CORE_EXPORT MessagePort : public EventTargetWithInlineData, return GetAttributeEventListener(event_type_names::kMessageerror); } + void setOnclose(EventListener* listener) { + SetAttributeEventListener(event_type_names::kClose, listener); + } + EventListener* onclose() { + return GetAttributeEventListener(event_type_names::kClose); + } + // A port starts out its life entangled, and remains entangled until it is // closed or is cloned. bool IsEntangled() const { return !closed_ && !IsNeutered(); } diff --git a/third_party/blink/renderer/core/messaging/message_port.idl b/third_party/blink/renderer/core/messaging/message_port.idl index 6fab27fcdf1c333739b6ffe88b3cc4eed3301ee4..3f1f181d9b8a66997136f870f55c97c08294b6eb 100644 --- a/third_party/blink/renderer/core/messaging/message_port.idl +++ b/third_party/blink/renderer/core/messaging/message_port.idl @@ -40,4 +40,5 @@ // event handlers attribute EventHandler onmessage; attribute EventHandler onmessageerror; + attribute EventHandler onclose; };