From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Nitish Sakhawalkar Date: Thu, 11 Apr 2019 11:50:49 -0700 Subject: fix: export DebugOptions This exports DebugOptions so we can parse args like `--inspect-brk`. diff --git a/src/node_options.cc b/src/node_options.cc index 35cac18a916c2ce104a3e7b6760d0280b33c2892..2dd90e9a8cf9381c8608b73ead247bcf86b72ab9 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -210,11 +210,6 @@ void EnvironmentOptions::CheckOptions(std::vector* errors) { namespace options_parser { -class DebugOptionsParser : public OptionsParser { - public: - DebugOptionsParser(); -}; - class EnvironmentOptionsParser : public OptionsParser { public: EnvironmentOptionsParser(); diff --git a/src/node_options.h b/src/node_options.h index 8937bfd9011e4795d22e232886e18183d698b8d4..40c19ea6ff4d98a1a1da59bca76087209445af81 100644 --- a/src/node_options.h +++ b/src/node_options.h @@ -59,7 +59,7 @@ struct InspectPublishUid { // to keep them separate since they are a group of options applying to a very // specific part of Node. It might also make more sense for them to be // per-Isolate, rather than per-Environment. -class DebugOptions : public Options { +class NODE_EXTERN DebugOptions : public Options { public: DebugOptions() = default; DebugOptions(const DebugOptions&) = default; @@ -244,7 +244,7 @@ class PerProcessOptions : public Options { namespace options_parser { -HostPort SplitHostPort(const std::string& arg, +HostPort NODE_EXTERN SplitHostPort(const std::string& arg, std::vector* errors); void GetOptions(const v8::FunctionCallbackInfo& args); @@ -437,6 +437,11 @@ class OptionsParser { friend void GetOptions(const v8::FunctionCallbackInfo& args); }; +class NODE_EXTERN DebugOptionsParser : public OptionsParser { + public: + DebugOptionsParser(); +}; + using StringVector = std::vector; template void Parse(