From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Fri, 25 Oct 2019 11:23:03 -0700 Subject: add WebMessagePortConverter::EntangleAndInjectMessagePortChannel This adds a method to the public Blink API that would otherwise require accessing Blink internals. Its inverse, which already exists, is used in Android WebView. diff --git a/third_party/blink/public/web/web_message_port_converter.h b/third_party/blink/public/web/web_message_port_converter.h index ad603aa7c557bfd4f571a541d70e2edf9ae757d9..d4b0bf8f5e8f3af9328b0099b65d9963414dfcc1 100644 --- a/third_party/blink/public/web/web_message_port_converter.h +++ b/third_party/blink/public/web/web_message_port_converter.h @@ -13,6 +13,7 @@ class Isolate; template class Local; class Value; +class Context; } // namespace v8 namespace blink { @@ -25,6 +26,9 @@ class WebMessagePortConverter { // neutered, it will return nullopt. BLINK_EXPORT static base::Optional DisentangleAndExtractMessagePortChannel(v8::Isolate*, v8::Local); + + BLINK_EXPORT static v8::Local + EntangleAndInjectMessagePortChannel(v8::Local, MessagePortChannel); }; } // namespace blink diff --git a/third_party/blink/renderer/core/exported/web_message_port_converter.cc b/third_party/blink/renderer/core/exported/web_message_port_converter.cc index 333760d667f6b98b3e7674bf9082f999743dadfa..749a5c06ad468ee1ceb602944d3090ae9bbe616d 100644 --- a/third_party/blink/renderer/core/exported/web_message_port_converter.cc +++ b/third_party/blink/renderer/core/exported/web_message_port_converter.cc @@ -6,6 +6,7 @@ #include "third_party/blink/public/common/messaging/message_port_channel.h" #include "third_party/blink/renderer/bindings/core/v8/script_value.h" +#include "third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h" #include "third_party/blink/renderer/bindings/core/v8/v8_message_port.h" #include "third_party/blink/renderer/core/messaging/message_port.h" @@ -21,4 +22,15 @@ WebMessagePortConverter::DisentangleAndExtractMessagePortChannel( return port->Disentangle(); } +v8::Local +WebMessagePortConverter::EntangleAndInjectMessagePortChannel( + v8::Local context, + MessagePortChannel port_channel) { + auto* execution_context = ToExecutionContext(context); + CHECK(execution_context); + auto* port = MakeGarbageCollected(*execution_context); + port->Entangle(std::move(port_channel)); + return ToV8(port, context->Global(), context->GetIsolate()); +} + } // namespace blink