From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Nitish Sakhawalkar Date: Thu, 11 Apr 2019 11:50:49 -0700 Subject: fix: export DebugOptions diff --git a/src/node_options.cc b/src/node_options.cc index e2a39626b69fd3380febc258fb25efc0cea2a08e..f4dc3d7df5a33ce92ca52e901283db5aa9f143b4 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -204,11 +204,6 @@ void EnvironmentOptions::CheckOptions(std::vector* errors) { namespace options_parser { -class DebugOptionsParser : public OptionsParser { - public: - DebugOptionsParser(); -}; - class EnvironmentOptionsParser : public OptionsParser { public: EnvironmentOptionsParser(); diff --git a/src/node_options.h b/src/node_options.h index dbd85b2d584be57619fc5c8d019140f67514f427..5fb23cfda7aebca507174555b78c9a73e837dda0 100644 --- a/src/node_options.h +++ b/src/node_options.h @@ -59,7 +59,7 @@ struct InspectPublishUid { // to keep them separate since they are a group of options applying to a very // specific part of Node. It might also make more sense for them to be // per-Isolate, rather than per-Environment. -class DebugOptions : public Options { +class NODE_EXTERN DebugOptions : public Options { public: DebugOptions() = default; DebugOptions(const DebugOptions&) = default; @@ -240,7 +240,7 @@ class PerProcessOptions : public Options { namespace options_parser { -HostPort SplitHostPort(const std::string& arg, +HostPort NODE_EXTERN SplitHostPort(const std::string& arg, std::vector* errors); void GetOptions(const v8::FunctionCallbackInfo& args); @@ -433,6 +433,11 @@ class OptionsParser { friend void GetOptions(const v8::FunctionCallbackInfo& args); }; +class NODE_EXTERN DebugOptionsParser : public OptionsParser { + public: + DebugOptionsParser(); +}; + using StringVector = std::vector; template void Parse(