From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Tue, 16 Apr 2019 10:43:04 -0700 Subject: build_gn.patch diff --git a/BUILD.gn b/BUILD.gn index 086cb460be65f970b6a3c33d86dd1e2254251b9a..c681ae4b50e85f7a62941e6dcf90f9d59f7b83ed 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -278,7 +278,7 @@ config("internal_config") { ":v8_header_features", ] - if (is_component_build) { + if (is_component_build || is_electron_build) { defines += [ "BUILDING_V8_SHARED" ] } } @@ -3780,7 +3780,7 @@ if (current_toolchain == v8_generator_toolchain) { "src/interpreter/bytecodes.h", ] - configs = [ ":internal_config" ] + configs = [ ":internal_config_base" ] deps = [ ":v8_libbase", @@ -3801,6 +3801,8 @@ if (v8_use_snapshot && current_toolchain == v8_snapshot_toolchain) { configs = [ ":internal_config" ] + configs += [ "//electron/build/config:build_time_executable" ] + deps = [ ":v8_base_without_compiler", ":v8_compiler_for_mksnapshot",