From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Thu, 26 May 2022 10:45:49 -0400 Subject: allow disabling of v8 sandboxed pointers V8 sandboxed pointers are incompatible with Node due to changes like https://chromium-review.googlesource.com/c/v8/v8/+/3114136, so for now we need a way to disable v8 sandboxed pointers. diff --git a/BUILD.gn b/BUILD.gn index 114cfd757b60c14cfb7a6bc9f9f69765363c9c6c..5e8a6bb2c26c3e5701e628cbf4bfcf9b2eb6b82f 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -501,18 +501,6 @@ if (v8_enable_sandbox == "") { v8_enable_external_code_space } -# Enable sandboxed pointers on desktop when the sandbox is enabled. -if (v8_enable_sandbox) { - # When sanitizers are enabled, PartitionAlloc forwards allocations to malloc - # instead of allocating from its Pools and so isn't compatible with the - # sandbox. As such, disable the sandbox there. See https://crbug.com/1323174 - if (!is_asan && !is_hwasan && !is_lsan && !is_tsan && !is_msan) { - v8_enable_sandboxed_pointers = - target_os != "fuchsia" && target_os != "android" && - target_os != "chromeos" - } -} - # Enable all available sandbox features if sandbox future is enabled. if (v8_enable_sandbox_future) { v8_enable_sandboxed_pointers = true