From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Tue, 16 Apr 2019 10:43:04 -0700 Subject: build_gn.patch We force V8 into 'shared library' mode so that it exports its symbols, which is necessary for native modules to load. Also, some fixes relating to mksnapshot on ARM. diff --git a/BUILD.gn b/BUILD.gn index 1ed2de137f7cec05fe583372d6bc096a4cec8ab0..f005e7f0d819f9aa5c434829e6d16e6bd7c4797e 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -311,7 +311,7 @@ config("internal_config") { ":v8_tracing_config", ] - if (is_component_build) { + if (is_component_build || is_electron_build) { defines += [ "BUILDING_V8_SHARED" ] } } @@ -4004,7 +4004,7 @@ if (current_toolchain == v8_generator_toolchain) { "src/interpreter/bytecodes.h", ] - configs = [ ":internal_config" ] + configs = [ ":internal_config_base" ] deps = [ ":v8_libbase", @@ -4037,6 +4037,8 @@ if (current_toolchain == v8_snapshot_toolchain) { configs = [ ":internal_config" ] + configs += [ "//electron/build/config:build_time_executable" ] + deps = [ ":v8_base_without_compiler", ":v8_compiler_for_mksnapshot",