From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Alexey Kuts Date: Fri, 26 Jul 2019 22:32:54 +0300 Subject: remove references to Profile from PreconnectManager The PreconnectManager in Chrome only depends on Profile for testing purposes; this patch removes that dependency so we can reuse it. Ideally we would change this class in upstream to not depend on Profile. diff --git a/chrome/browser/predictors/preconnect_manager.cc b/chrome/browser/predictors/preconnect_manager.cc index 7cbe5b3ebac99849dc784e1dc587b3a091abbf49..6de33ea6f7e452cdfbf3271827a943828e93fb8f 100644 --- a/chrome/browser/predictors/preconnect_manager.cc +++ b/chrome/browser/predictors/preconnect_manager.cc @@ -69,7 +69,7 @@ PreresolveJob::PreresolveJob(PreresolveJob&& other) = default; PreresolveJob::~PreresolveJob() = default; PreconnectManager::PreconnectManager(base::WeakPtr delegate, - Profile* profile) + content::BrowserContext* profile) : delegate_(std::move(delegate)), profile_(profile), inflight_preresolves_count_(0) { @@ -329,11 +329,13 @@ network::mojom::NetworkContext* PreconnectManager::GetNetworkContext() const { if (network_context_) return network_context_; +#if 0 if (profile_->AsTestingProfile()) { // We're testing and |network_context_| wasn't set. Return nullptr to avoid // hitting the network. return nullptr; } +#endif return profile_->GetDefaultStoragePartition()->GetNetworkContext(); } diff --git a/chrome/browser/predictors/preconnect_manager.h b/chrome/browser/predictors/preconnect_manager.h index dbdde3dfd9bb160486a1d06f16ef86548798b61c..a4373ebdbe8bb833c3b782e3d3cb27a5116f976d 100644 --- a/chrome/browser/predictors/preconnect_manager.h +++ b/chrome/browser/predictors/preconnect_manager.h @@ -22,6 +22,10 @@ class Profile; +namespace content { +class BrowserContext; +} + namespace network { namespace mojom { class NetworkContext; @@ -145,7 +149,7 @@ class PreconnectManager { bool success) {} }; - PreconnectManager(base::WeakPtr delegate, Profile* profile); + PreconnectManager(base::WeakPtr delegate, content::BrowserContext* profile); virtual ~PreconnectManager(); // Starts preconnect and preresolve jobs keyed by |url|. @@ -210,7 +214,7 @@ class PreconnectManager { network::mojom::NetworkContext* GetNetworkContext() const; base::WeakPtr delegate_; - Profile* const profile_; + content::BrowserContext* const profile_; std::list queued_jobs_; PreresolveJobMap preresolve_jobs_; std::map> preresolve_info_;