mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
28717 commits 1 branch 183 tags 5.3 GiB
Commit graph

28717 commits

This branch
This branch
All branches
Author SHA1 Message Date
trop[bot]
941965016e
fix: WebContentsView removal should compare directly (#44671) 
* fix: WebContentsView removal should compare directly

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* fixup view comparision

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* chore: use erase_if

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* Apply review suggestions

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-11-15 13:09:38 +01:00
Keeley Hammond
b88e1aba10
refactor: unfilter unresponsive events (#44667) 
refactor: unfilter unresponsive events (#44629)

* feat: internal -unresponsive event

* Reland "refactor: JSify BrowserWindow unresponsive handling"

This reverts commit ef7ae78ed4.

* fix: emit unresponsive if close not prevented

---------
 2024-11-14 16:59:22 -08:00
trop[bot]
e95e6fac0d
build: fix python warnings "SyntaxWarning: invalid escape sequence '\w'" (#44660) 
* fix: SyntaxWarning: invalid escape sequence '\w'

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* chore: remove some unused imports

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: E711 warning 'Comparison to should be '

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-14 07:28:08 -06:00
Pedro Pontes
3eb1f02adb
chore: cherry-pick 1 changes from 0-M131 (#44647) 
chore: [33-x-y] cherry-pick 1 changes from 0-M131

* 923797bac925 from chromium
 2024-11-13 12:35:47 -06:00
trop[bot]
040e9c317e
fix: WCO buttons hidden on Linux in fullscreen (#44640) 
Closes https://github.com/electron/electron/issues/44569.

Fixes an issue where the WCO buttons were hidden on Linux in  fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-11-13 16:54:37 +01:00
trop[bot]
eddae27077
fix: add theme data source for devtools. (#44635) 
* fix: add theme data source for devtools.

Co-authored-by: Bill Shen <shenyb32768@gmail.com>

* chore: add ut.

Co-authored-by: bill.shen <shenyb32768@gmail.com>

* chore: remove recording histograms

Co-authored-by: Bill Shen <shenyb32768@gmail.com>

* fix: add theme data source for devtools.

Co-authored-by: Bill Shen <shenyb32768@gmail.com>

* chore: separate files

Co-authored-by: Bill Shen <shenyb32768@gmail.com>

* chore: separate files

Co-authored-by: Bill Shen <shenyb32768@gmail.com>

* chore: remove pragma once

Co-authored-by: Bill Shen <shenyb32768@gmail.com>

* chore: fix lint issue.

Co-authored-by: bill.shen <shenyb32768@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Bill Shen <shenyb32768@gmail.com>
 2024-11-13 16:04:39 +01:00
electron-roller[bot]
5e07ab9728
chore: bump chromium to 130.0.6723.127 (33-x-y) (#44638) 
chore: bump chromium in DEPS to 130.0.6723.127

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
 2024-11-13 15:33:51 +01:00
trop[bot]
3e4c5dcc28
test: exercise fuller globalShortcut matrix (#44625) 
test: test fuller globalShortcut matrix

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-11-12 18:24:10 -06:00
trop[bot]
2f20dbea55
fix: segfault when moving WebContentsView between BrowserWindows (#44613) 
* fix: segfault when moving WebContentsView between BrowserWindows

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* chore: actually enable fix

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* fixup segfault when moving WebContentsView between BrowserWindows

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-11-11 22:09:29 -05:00
electron-roller[bot]
c9d026e19b
chore: bump chromium to 130.0.6723.118 (33-x-y) (#44591) 
chore: bump chromium in DEPS to 130.0.6723.118

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
 2024-11-07 11:14:43 -05:00
reito
65cd09ffaf
feat: GPU shared texture offscreen rendering (33-x-y) (#44511) 
* feat: GPU shared texture offscreen rendering

* fix: EmitWarning in node utils.

Signed-off-by: reito <cnschwarzer@qq.com>

* fix: resolve conflict and reformat

---------

Signed-off-by: reito <cnschwarzer@qq.com>
 2024-11-07 09:41:09 -05:00
electron-roller[bot]
c8dc8717a4
chore: bump chromium to 130.0.6723.116 (33-x-y) (#44583) 
chore: bump chromium in DEPS to 130.0.6723.116

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
 2024-11-06 13:20:11 -05:00
trop[bot]
6e44a274e9
chore: remove executable flag from docs/api/app.md file permissions (#44578) 
chore: set docs/api/app.md file permissions to 644

md files should not be executable

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-05 12:01:25 -05:00
trop[bot]
743fe6f4b4
test: fixup flaky session tests (#44565) 
test: fixup broken tests in 32-x-y (#44389)

* test: fixup broken tests in 32-x-y

* test: fixup additional failing test

(cherry picked from commit c61bb1654e)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-11-04 19:21:59 -05:00
trop[bot]
bd81baaf04
fix: remove use of banned std::to_string() (#44563) 
Use base::NumberToString() instead

Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-04 18:00:39 -06:00
trop[bot]
6e1d940ef3
docs: capitalize POSIX and Windows correctly (#44558) 
* docs: capitalize POSIX correctly

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* docs: capitalize Windows correctly

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-04 17:01:50 -05:00
trop[bot]
be69311692
build: add new status to verify if all the required gha jobs have run (#44553) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-11-04 16:41:12 -05:00
trop[bot]
fcf0c115cb
chore: remove use of banned absl::optional (#44551) 
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5805666

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-04 16:40:21 -05:00
trop[bot]
4fad573746
build: remove unused lint package (#44535) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
 2024-11-04 13:26:25 -05:00
Charles Kerr
c600be6439
fix: crash when generating shortcut text for super accelerator (33-x-y) (#44520) 
* fix: crash when generating shortcut text for super accelerator (#44341)

* chore: e sync patches
 2024-11-04 10:25:04 -05:00
trop[bot]
a7ab89ee9e
docs: fix apostrophe typo "Electrons" -> "Electron's" (#44536) 
s/Electrons/Electron's/

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-03 09:32:57 -06:00
trop[bot]
7930412006
refactor: remove unused C string ToV8() gin converter (#44522) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-02 10:34:39 -05:00
trop[bot]
8b38c78e94
perf: use v8::String::NewFromUtf8Literal in ToV8() gin converter (#44519) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-11-01 16:52:57 -05:00
trop[bot]
f3a2c1dee7
docs: add custom titlebar example (#44507) 
* docs: add custom titlebar example

* docs: add links and other small edits

* docs: add panel window docs

* docs: remove panel example

* docs: specify expected emphasis style

* docs: responding to feedback

* docs: fix section names in links

* docs: rework baseWindow note

* docs: making window customization its own section

* responding to feedback

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Anny Yang <anny@electronjs.org>
 2024-11-01 12:47:27 -05:00
trop[bot]
50eb34423f
build: handle out of disk space on source cache (#44492) 
* build: handle out of disk space on source cache

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* build: add cron job to free up source cache disk space

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-31 17:17:48 -05:00
trop[bot]
03acaade4e
fix: EventSource undefined in Renderer/Worker (#44496) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-31 17:16:36 -05:00
electron-roller[bot]
532e5cc1f6
chore: bump chromium to 130.0.6723.91 (33-x-y) (#44477) 
chore: bump chromium in DEPS to 130.0.6723.91

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-31 10:44:44 -04:00
trop[bot]
ae9f2df082
feat: add WebFrameMain detached property (#44209) 
* feat: add WebFrameMain detached property

fix: throw instead of returning null senderFrame

test: detached frames

fix: ensure IPCs of pending deletion RFHs are dispatched

fix: lookup WFM by FTN ID to dispatch IPCs

feat: add frame.isDestroyed()

return null

fix: return undefined

docs: add null to all frame properties

refactor: option c, return null and emit warning

refactor: add routingId & processId to navigation events

test: null frame property

docs: clarify warning message

better wording

clarify null frame

fix: browserwindow spec

* maybe fix 🤷

* fix: use updated util #43722

* docs: add notice for frame change of behavior

* docs: clarify why frame properties may be null

* lint

* wip

* fix: content::FrameTreeNodeId lookup and converter

* refactor: avoid holey array deoptimization

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
 2024-10-31 12:07:50 +01:00
trop[bot]
4507774c51
fix: update shell.openExternal to correctly focus on external window (#44468) 
fix: update shell.openExternal to correctly focus on external window (#44408)

* fix: Use openURL:configuration:completionHandler instead of openUrl

* test: add a test

* fix: add dispatch_async to replace GetUIThreadTaskRunner

* refactor: remove unused import

* fix: update to use BindPostTaskToCurrentDefault

* test: add regression test for window focus

* refactor: update to explicit task runner

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
 2024-10-31 12:05:51 +01:00
trop[bot]
4f13824bc9
perf: remove isolate scope from DidProcessTask() (#44473) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-31 11:30:24 +01:00
trop[bot]
b184a5668b
docs: fix win.setContentView() arg type (#44480) 
fix: setContentView type

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-30 16:26:36 -04:00
trop[bot]
828d29526a
docs: fix win.getContentView() return type (#44463) 
docs: fix win.getContentView() return type

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-29 17:00:25 -04:00
trop[bot]
b0614f80d7
build: fix python util verbose mode logic (#44454) 
build: fix verbose mode logic

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-29 21:41:19 +01:00
trop[bot]
cab11e6de0
build: improve gen-libc++-filenames output (#44444) 
build: improve gen-libc++-filenames output

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-29 12:33:37 +01:00
trop[bot]
d435ff9128
fix: keep gdk_pixbuf a dynamic dependency (#44436) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2024-10-29 00:32:40 -05:00
trop[bot]
a6b34dca26
perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals (#44429) 
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals

the string length is known at compile time and no need to call ToLocalChecked()

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: string length is known when calling NewFromUtf8(), so use it

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* perf: remove unnecessary calls to c_str()

these just force the code being called to have to recalculate the string length

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-28 11:06:10 -05:00
trop[bot]
ec070e57e0
fix: crash on netlog connection error (#44420) 
* fix: crash on netlog connection error

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* refactor: remove default PromiseBase constructor

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* Revert "refactor: remove default PromiseBase constructor"

This reverts commit 9292324a0d5f9e63ba8f73f63dfff1d48eb2f38f.

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

* remove dcheck

Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
 2024-10-28 14:37:58 +01:00
trop[bot]
359cfecce0
test: deflake flaky tests on linux (#44402) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-25 11:22:05 -04:00
John Kleinschmidt
6b79679e5b
build: update linux container (#44396) 
build: update linux container (#44392)

(cherry picked from commit a0f51d816e7b66e1f60943c672b53bbede94a34a)
 2024-10-24 20:40:20 -05:00
trop[bot]
964c1a1df8
fix: -Wunsafe-buffer-usage warning in didRegisterForRemoteNotificationsWithDeviceToken (#44381) 
* chore: move as_byte_span() to new shell/common/mac_util.h

this way it can be used by multiple mm files

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: use base::HexEncode() instead of rolling our own

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fixup! chore: move as_byte_span() to new shell/common/mac_util.h

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fixup! chore: move as_byte_span() to new shell/common/mac_util.h

fix: move mac_util to the right place in filenames.gni

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
 2024-10-23 20:44:47 -05:00
trop[bot]
3b3f72e974
test: fixup flaky tests (#44378) 
* test: fixup flaky test

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* test: disable flaky protocol speed test on macOS

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* test: fixup flaky test in api-browser-window-spec.ts

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-23 17:16:58 -04:00
electron-roller[bot]
64fd436375
chore: bump chromium to 130.0.6723.69 (33-x-y) (#44373) 
chore: bump chromium in DEPS to 130.0.6723.69

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
 2024-10-23 16:08:24 -04:00
trop[bot]
34045394e0
docs: clarify utilityProcess child.pid value (#44364) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-22 19:22:05 +02:00
trop[bot]
777d447018
fix: software compositing infinite loop (#44352) 
* fix: software compositing infinite loop

Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>

Co-authored-by: Sam Maddock <smaddock@slack-corp.com>

* chore: update patches

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
 2024-10-21 19:29:46 -07:00
trop[bot]
e0d14a6d89
build: fixup reclient use for prod builds (#44342) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
 2024-10-21 17:17:03 -04:00
trop[bot]
739df86774
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44324) 
fix: respect setAlwaysOnTop before showInactive on Linux under X11 (#44078)

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <31829097+cptpcrd@users.noreply.github.com>
 2024-10-18 17:20:13 -04:00
John Kleinschmidt
9a087b9c56
chore: fixup reclient read only access on forks (#44304) 
chore: fixup reclient read only access on forks (#44280)
 2024-10-18 15:39:59 +02:00
trop[bot]
8b3f2c5d7c
fix: trace-startup crashing child process on macOS (#44276) 
* fix: trace-startup crashing child process on macOS

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* chore: disable test on linux arm

* chore: also disable on linux arm64

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2024-10-17 22:23:30 -04:00
trop[bot]
ad9bf6b041
fix: Linux crash after webContents.print() with no parent window (#44285) 
fix: Linux crash after print with no parent window

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2024-10-17 22:21:57 -04:00
trop[bot]
32822cd747
build: remove dead code in prepare release script (#44289) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
 2024-10-17 17:10:49 -04:00