Commit graph

2853 commits

Author SHA1 Message Date
evgenyzinoviev
b75dccb0be arguments handing rewritten, doc updated 2016-01-15 17:31:31 +01:00
Cheng Zhao
63278aeec2 Merge pull request #4118 from Ivshti/patch-1
Ensure we close FD on Windows
2016-01-15 23:58:57 +08:00
Cheng Zhao
0937144849 Merge pull request #4111 from evgenyzinoviev/movable
Added an option to prevent a window from being moved on OS X
2016-01-15 23:24:22 +08:00
Ivo Georgiev
7586078d0a Ensure we close FD on Windows 2016-01-15 16:54:29 +02:00
Cheng Zhao
9ccc7ee30d Small ajustments on lifetime of webContents 2016-01-15 16:36:35 +08:00
Cheng Zhao
c10c419f1d No need to call sender.callbacks.remove
The IDWeakMap automatically removes the key when object is garbage
collected.
2016-01-15 16:36:35 +08:00
Cheng Zhao
3875b30fcf Merge pull request #4109 from atom/const
[WIP] Use `const` for requires
2016-01-15 16:32:07 +08:00
Cheng Zhao
39225ac5ec Bump v0.36.4 2016-01-15 14:27:19 +08:00
evgenyzinoviev
2598b00b41 Animate window resizing on OS X 2016-01-15 05:59:58 +01:00
evgenyzinoviev
cda88db77c Added option to prevent a window from being moved on OS X 2016-01-15 03:58:57 +01:00
Jessica Lord
003de0debe Clean up variable declarations 2016-01-14 18:07:29 -08:00
Jessica Lord
5a4a8e1fa7 🔥 stray ref 2016-01-14 17:03:55 -08:00
Jessica Lord
ae2893ceaa Inline var 2016-01-14 15:44:33 -08:00
Jessica Lord
5412ecdcc1 Use const 2016-01-14 14:52:05 -08:00
Jessica Lord
ab8908a4af Use const 2016-01-14 14:41:46 -08:00
Jessica Lord
1779701445 Use const 2016-01-14 14:40:12 -08:00
Jessica Lord
3a0fb42737 Use const 2016-01-14 14:33:45 -08:00
Jessica Lord
9103253f62 Use const 2016-01-14 14:26:10 -08:00
Kevin Sawicki
030d2a843c Remove extra newlines around comments 2016-01-14 11:10:12 -08:00
Kevin Sawicki
990dc30e8d Use // for multi-line comments 2016-01-14 10:44:21 -08:00
Kevin Sawicki
f4af744519 Use // for single line comments 2016-01-14 10:35:29 -08:00
Cheng Zhao
26350f4ccb GetHttpCacheInIO => DoCacheActionInIO 2016-01-14 20:48:14 +08:00
Robo
10e4698baa session: api to get current cache size 2016-01-14 17:15:45 +05:30
Robo
8b38bbcf18 webview: respect properties provided during webview creation 2016-01-13 22:40:55 +05:30
Cheng Zhao
489539d62e Merge pull request #4071 from deepak1556/session_flush_data_patch
session: api to flush DOMStorage data
2016-01-13 16:18:37 +08:00
Cheng Zhao
8ae836d82d Unlisten the zoom-level-changed event when webview is detached 2016-01-13 14:58:16 +08:00
Cheng Zhao
44b8343585 Fix crash when closing page with webview 2016-01-13 14:47:39 +08:00
Cheng Zhao
af02739c4e Change webview's zoom level on JavaScript side 2016-01-13 12:50:02 +08:00
Cheng Zhao
350c572a8c Handle default parameter of executeJavaScript in C++ 2016-01-13 12:17:56 +08:00
Cheng Zhao
55dfddba77 Handle executeJavaScript in JavaScript 2016-01-13 12:11:46 +08:00
Cheng Zhao
5b7d1a9890 Add insertText to WebContents 2016-01-13 11:55:49 +08:00
Robo
8433d94cac session: api to flush DOMStorage data 2016-01-13 08:56:00 +05:30
Cheng Zhao
5567baf335 Add webFrame.insertText API 2016-01-13 11:21:16 +08:00
Kevin Sawicki
b547a38b3f Add wrapper functions to mirror old CoffeeScript 2016-01-12 16:24:06 -08:00
Kevin Sawicki
ab73f4c94a Copy JS files to tempdir before packing asar 2016-01-12 16:24:06 -08:00
Kevin Sawicki
1f9691ae13 Convert all source files to JavaScript 2016-01-12 16:24:06 -08:00
Kevin Sawicki
403870a27e Migrate to block comments 2016-01-12 16:22:34 -08:00
Cheng Zhao
eb63e6b9a7 Destroy the native class when webContents is destroyed 2016-01-12 21:10:24 +08:00
Cheng Zhao
c7a89b6e29 Merge pull request #4058 from kyku/master
Pass --touch-devices to chromium contents under X11
2016-01-11 22:57:00 +08:00
Cheng Zhao
9e82334b67 Merge pull request #4057 from princejwesley/browser-window
Return null for no focused window when calling BrowserWindow.getFocusedWindow
2016-01-11 22:53:38 +08:00
Cheng Zhao
192fa4c86b Cleanup docs and code of setProxy 2016-01-11 22:45:34 +08:00
Cheng Zhao
34c9279fc5 Merge pull request #4046 from deepak1556/session_proxy_patch
session: allow user to isolate pac script and proxy bypass rules
2016-01-11 21:49:15 +08:00
Cheng Zhao
26bd97d6cf Fix style issues of #4029 2016-01-11 21:12:07 +08:00
Cheng Zhao
edcd34d4ce Merge pull request #4029 from leethomas/show-message-box-default-button
Show message box default button
2016-01-11 20:58:03 +08:00
Krzysztof
440c588a33 Pass --touch-devices to chromium contents under X11 2016-01-11 12:23:53 +01:00
Cheng Zhao
91ca84d106 Merge pull request #4050 from etiktin/cosmetic
Remove unneeded extra semicolons (;; -> ;)
2016-01-11 15:41:06 +08:00
Prince J Wesley
018ae5189b Return null for no focused window when calling BrowserWindow.getFocusedWindow() 2016-01-11 12:58:44 +05:30
Robo
8557cd223c maintain api compatibility 2016-01-11 12:24:01 +05:30
Cheng Zhao
1944472c2f docs: Make win.getNativeWindowHandle more clear 2016-01-11 13:43:24 +08:00
Cheng Zhao
54e1d7b3bf Merge pull request #4023 from omrilitov/master
Added getNativeWindowHandle method
2016-01-11 13:32:29 +08:00
leethomas
fee301e768 follow style guidelines 2016-01-10 19:15:40 -08:00
Eran Tiktin
29939dc0b7 Remove unneeded extra semicolons (;; -> ;) 2016-01-11 02:11:40 +02:00
leethomas
803b06b7de 🏁 support defaultId for dialog boxes on Windows 2016-01-10 15:55:26 -08:00
leethomas
ae5c6add11 rename all references to default_button_index -> default_id to keep consistent with cancel_id 2016-01-10 15:33:27 -08:00
Robo
be50ca2653 session: allow user to isolate pac script and proxy bypass rules 2016-01-11 03:55:56 +05:30
leethomas
dfce803045 🏁 update windows message_box function signatures to accept default_button_index....and do nothing with it 2016-01-08 08:23:06 -08:00
leethomas
22c455175a 🐧 add default button index for linux/gtk 2016-01-08 08:22:10 -08:00
leethomas
f1edd5f26f 🍎 add default button index for osx 2016-01-08 08:21:54 -08:00
Cheng Zhao
df27cda36c Bump v0.36.3 2016-01-08 13:40:47 +08:00
Cheng Zhao
ec4c5e58ff Initialize resource bundle on browser process separately 2016-01-08 12:06:06 +08:00
Cheng Zhao
5f6a8a7c24 Merge pull request #4009 from atom/remove-getobject-handler
Remove custom WM_GETOBJECT handler
2016-01-08 09:55:24 +08:00
Omri Litov
943e46f3bd Fix linux and mac build errors 2016-01-08 00:27:53 +02:00
Omri Litov
3f0c007578 Added getNativeWindowHandle 2016-01-07 22:38:35 +02:00
Cheng Zhao
3a32dc5da7 Fix "name" of Error object not serialized
Close #3364.
2016-01-07 16:35:05 +08:00
Cheng Zhao
10f663d017 Fix hiding fullscreen button on EL Capitan 2016-01-07 15:46:40 +08:00
Cheng Zhao
3f2b26ddb7 Add blinkFeatures option 2016-01-07 14:10:18 +08:00
Cheng Zhao
bd20b3f32a Rely on content switches for implementing experimental features 2016-01-07 12:49:00 +08:00
Cheng Zhao
16d23bbda5 Remove pageVisibility option
The original purpose of this option is not working anymore, also adds
docs on the current way to disable process backgrounding.
2016-01-07 12:28:20 +08:00
Cheng Zhao
c6e03f8390 Remove overlayScrollbars and sharedWorker options
They are already enabled by default.
2016-01-07 12:17:19 +08:00
Paul Betts
705001a50e Remove custom WM_GETOBJECT
As of Chromium 47 this seems to be handled automatically, nvda still reports
elements and the typing lag issue described in #4001 is fixed
2016-01-06 10:37:12 -08:00
Cheng Zhao
3ca5b0ce23 win: Don't change transparent window's style
Close #1952.
2016-01-06 23:02:33 +08:00
Cheng Zhao
89fccb7eb2 Fix crash when request failed 2016-01-06 21:07:07 +08:00
Cheng Zhao
c4071a7f66 Throw ENOTDIR when calling mkdir inside asar archive 2016-01-06 12:04:16 +08:00
leethomas
59eda67ba4 🍎🐛 make displaying alternate tray image depend on mouse down event instead of highlight state 2016-01-05 09:49:27 -08:00
Cheng Zhao
2b6ac966c0 Do not write our own filter code
The Win32 API has done everything for us, there is no need to do this
oursevles.
2016-01-05 13:45:34 +08:00
Cheng Zhao
698700716b Show menu by clicking the menu button 2016-01-05 12:05:27 +08:00
Cheng Zhao
43bfce26a7 Do not behave like bookmarkbar menu 2016-01-05 11:57:58 +08:00
Cheng Zhao
0df03a23a3 Pass origin in capturePage 2016-01-04 20:06:36 +08:00
Cheng Zhao
7a1717156e Revert "browser: dont lose coordinates in capturepage src rect"
This reverts commit 3c5e5053e3.
2016-01-04 19:37:25 +08:00
Cheng Zhao
4844e68ba1 Rename did-navigate-to-different-page to did-navigate 2016-01-04 12:09:11 +08:00
Cheng Zhao
941232a76b Merge pull request #3975 from leethomas/add-webview-navigation-events
Add webview navigation events
2016-01-04 11:24:27 +08:00
Cheng Zhao
6ff79eddb4 Merge pull request #3958 from deepak1556/content_strings_localzation_patch
browser: provide localized string from resourcebundle
2016-01-04 10:59:09 +08:00
Cheng Zhao
14db4a1946 Add isDevToolsFocused to webview 2016-01-04 10:46:30 +08:00
leethomas
911e60b507 add did-navigate-in-page event to webview & webcontents (triggers on hash/ref changes, anchor links...), pass url into events 2016-01-01 17:13:39 -08:00
leethomas
9f6319dd71 add will-navigate, did-navigate-to-different-page events to webview 2016-01-01 13:36:35 -08:00
leethomas
54c8c3e3fc 📝 update webview docs to include devtools-* events 2016-01-01 04:49:34 -08:00
leethomas
96d68b9285 🐛 add isDevToolsFocused to WebContents to fix #3928, add devtools-[focused|open|close] events to WebView to fix #3783. 2015-12-31 22:21:54 -08:00
Cheng Zhao
8aced2c31e Add comment on why checking empty set 2015-12-31 18:58:16 +08:00
Cheng Zhao
b308cd6f96 Merge pull request #3967 from leethomas/fix-osx-crash-when-extensions-empty
🍎 fix #3864 where saving a file causes a crash if file extensio…
2015-12-31 18:51:55 +08:00
Cheng Zhao
be2f900d93 Merge pull request #3968 from leethomas/fix-window-submenu-crashes
🍎 only add sub menus to Window when they actually have menu ite…
2015-12-31 18:51:45 +08:00
Cheng Zhao
af5e76f6ae Merge pull request #3959 from deepak1556/remote_object_patch
remote: support arguments of type Date
2015-12-31 18:46:22 +08:00
leethomas
eac2f6fec3 🍎 only add sub menus to Window when they actually have menu items. fixes #3873 2015-12-30 19:38:14 -08:00
leethomas
ba26a4b4e6 🍎 fix #3864 where saving a file causes a crash if file extension array is empty 2015-12-30 13:26:38 -08:00
Robo
1585a7a0ad browser: provide localized string from resourcebundle 2015-12-30 10:58:46 +05:30
Cheng Zhao
cb5d79e0df Merge pull request #3957 from atom/widevine
Merge #3830
2015-12-30 12:46:19 +08:00
Nishanth Shanmugham
20d03b10d9 osx: Implement clear recent documents
Fixes #3932
2015-12-29 18:36:16 -06:00
Robo
72374b6e31 remote: support arguments of type Date 2015-12-30 01:41:31 +05:30
Cheng Zhao
c0f0685296 Merge pull request #3944 from nishanths/feature/tray-file-drop-osx-dock
tray: Support file-drop from OS X Dock
2015-12-29 19:59:24 +08:00
Cheng Zhao
c76db0ba1d Fix coding styles 2015-12-29 18:59:27 +08:00
Robo
2e78aba090 webFrame: support fetch api for schemes that are privileged. 2015-12-29 15:57:59 +05:30
Nishanth Shanmugham
2bbf86c524 tray: Support file-drop from OS X Dock
A long-standing Apple bug does not call `prepareForDragOperation:sender`
for file drag-and-drop operations from the Dock. So we manually
call our custom `handleDrop:sender` for all drag-and-drop cases (that
is, from the Dock and from Finder).

References to the bug in question:
- http://stackoverflow.com/q/9534543/3309046
- http://openradar.appspot.com/radar?id=1745403

However, we still need to return YES from `prepareForDragOperation:sender`,
otherwise the "drag failed" animation occurs. For the same reason, we also
return YES from `performDragOperation:sender`.
2015-12-29 03:27:59 -06:00
Cyrille Lebeaupin
9d878ad6b2 Add widevine third party
Add 2 new command options to use widevine:
- widevine-cdm-path: Path to widevine plugin
- widevine-cdm-version: Version of the widevine plugin
2015-12-29 14:50:59 +08:00
Cheng Zhao
2294a5ce69 Leak FunctionTemplateHandle
They are cached through the app's lifetime, and freeing them at the
right time is complicate, so just leak them.
2015-12-29 10:40:10 +08:00
Cheng Zhao
d8d963b780 Cache function templates created by CreateObjectWithName 2015-12-29 10:29:48 +08:00
Cheng Zhao
ffc2870ccb Fix circular reference caused by Object.defineProperty 2015-12-29 10:17:35 +08:00
Cheng Zhao
3d2163230b Optimize the case when creating plain object 2015-12-28 22:51:40 +08:00
Cheng Zhao
6785870dde Variables are not shadowed in inline class 2015-12-28 22:51:40 +08:00
Cheng Zhao
b5fd491c2d Fix circular reference caused by RemoteMemberFunction 2015-12-28 22:51:40 +08:00
Cheng Zhao
9ffe502fb1 Bump v0.36.2 2015-12-25 13:45:07 +08:00
Robo
ab9d1bf97e renderer: dont fork the process when there is server redirect 2015-12-25 02:19:56 +05:30
Cheng Zhao
e96f89133c Reset whole headers when requestHeaders is set 2015-12-24 16:59:13 +08:00
Cheng Zhao
6aa3464aad Merge pull request #3912 from tylergibson/FixingMoveItemToTrash-Windows7
Adding check for Windows version and alternate flags for Windows Vista/7
2015-12-24 15:32:09 +08:00
Tyler Gibson
2d0e1c313a Adding check for Windows version and alternate flags for Windows Vista/7 2015-12-24 06:08:43 +00:00
Cheng Zhao
7bd9f2e5d0 Fix converting string to NSURL 2015-12-24 12:43:07 +08:00
Cheng Zhao
d3d8ab7c66 linux: Fix pressing Alt not toggling window menu bar 2015-12-24 11:43:14 +08:00
Cheng Zhao
a6074f89a3 Merge pull request #3900 from bbondy/theme-color
Theme color
2015-12-23 16:09:57 +08:00
Cheng Zhao
e90435e236 Remove visual artifacts of hidden-inset window 2015-12-23 12:38:11 +08:00
Brian R. Bondy
29b00ae0d6 Add tests for did-change-theme-color event 2015-12-22 23:05:03 -05:00
Cheng Zhao
79b507bda6 Merge pull request #3890 from jaanus/hidden-inset-fullscreen-fix
Fixes #2810: correct look of hidden-inset windows in full screen.
2015-12-23 11:26:06 +08:00
Cheng Zhao
3e1edfc9d0 Cancel callback in OnComplete event 2015-12-23 10:20:59 +08:00
Brian R. Bondy
11b2015535 Add did-change-theme-color event to webview 2015-12-22 17:28:22 -05:00
jaanus
aa2f7aaf3a Fixes #2810: correct look of hidden-inset windows in full screen.
`hidden` and `hidden-inset` windows differ only by the hidden-inset window having a toolbar. Yet, the toolbar yields an incorrect look in fullscreen mode. So, we hide and recreate the toolbar for such windows when going to/from fullscreen.

There are some visible artifacts during the fullscreen animations, as the toolbar gets created and destroyed. When entering fullscreen, you see a toolbar that then disappears. When going back to normal window, you see the traffic light buttons jump around a little bit. Yet, this is definitely better than the current broken fullscreen look.
2015-12-22 20:31:55 +02:00
Cheng Zhao
c8c4381085 Cancel callback when URLRequest is destroyed 2015-12-22 23:35:23 +08:00
Cheng Zhao
c4931bb2d1 Merge pull request #3865 from deepak1556/visibility_api_patch
browser: fix document.hidden value
2015-12-22 19:04:23 +08:00
Robo
61004f0e46 fix cpplint warning 2015-12-21 19:16:02 +05:30
Robo
cc7040d75f add test 2015-12-21 18:47:52 +05:30
Robo
ff51e4033a browser: fix value of document.hidden 2015-12-21 17:43:46 +05:30
Robo
d162180196 add api to webview 2015-12-21 17:13:23 +05:30
Robo
39e615ed87 webContents: adding findInPage api 2015-12-21 17:09:56 +05:30
Cheng Zhao
144b73c267 Merge pull request #3877 from bbondy/master
Add media play events to webview
2015-12-21 18:22:30 +08:00
Cheng Zhao
fa8d251370 Merge pull request #3875 from deepak1556/history_navigation_patch
navigaton: handle history operations from renderer
2015-12-21 18:18:45 +08:00
Cheng Zhao
99a661e2d2 Code cleanup of browser_mac.mm 2015-12-21 10:52:49 +08:00
Cheng Zhao
8d094d99da Merge pull request #3853 from jrehbein/fix-issue-3739-mac-dockshow
DockShow workaround for issue #3739
2015-12-21 10:38:52 +08:00
Brian R. Bondy
fed0c43970 Add media play events to webview 2015-12-19 22:37:51 -05:00
Robo
7b03ac6d61 navigaton: handle history operations from renderer 2015-12-20 01:23:47 +05:30
Cheng Zhao
bff2861311 Bump v0.36.1 2015-12-18 13:16:30 +08:00
Cheng Zhao
62c4a471d9 Merge pull request #3854 from deepak1556/browser_client_crash_patch
browser: check for rvh existence
2015-12-18 12:10:41 +08:00
Cheng Zhao
7d000807c5 Merge pull request #3849 from herrmannplatz/improvement/escape-url-openexternal
escape url string
2015-12-18 09:45:39 +08:00
Robo
836c13b330 browser: check for rvh existence 2015-12-18 04:45:32 +05:30
Jeff Rehbein
a39834740c DockShow workaround
Implemented workaround in DockShow for TransformProcessType bugginess
based on discussion at http://stackoverflow.com/questions/7596643/
2015-12-17 14:00:04 -06:00
rehez
9eb797296c escape url string 2015-12-17 16:23:30 +01:00
Cheng Zhao
353f08e477 Remove sync call in remote module 2015-12-17 22:03:16 +08:00
Cheng Zhao
0282d424bf Pass opener ID in command line 2015-12-17 21:27:14 +08:00
Cheng Zhao
71303d4804 Fix context menu not working in devtools 2015-12-16 22:57:03 +08:00
Cheng Zhao
c6634b1ea5 Don't pump message loop when sending sync msg
In old days sending sync message to browser process requires pumping
message loop in the renderer process, but now in Chrome 47 it is not
true anymore. And even when we do it, the Send method may fail
sometimes, so this change seems to be required for the Chrome 47
upgrade.
2015-12-16 22:38:04 +08:00
Kevin Sawicki
67c0de36a3 📝 Add missing period 2015-12-15 16:47:19 -08:00
Kevin Sawicki
d44a9d1fcc 🎨 Remove parens 2015-12-15 16:46:53 -08:00
Kevin Sawicki
aedfd3bf0e Add specs for companyName/submitURL being required 2015-12-15 16:44:38 -08:00
Kevin Sawicki
80e9631220 Use better signature match in deprecation message 2015-12-15 16:27:01 -08:00
Kevin Sawicki
524649797f Make companyName and submitURL required options 2015-12-15 16:22:31 -08:00