wanted002
e14964ccd0
feat: add setter and getter apis to specify udp port range for webrtc ( #39046 )
...
* feat:Add setter and getter apis to specify udp port range for webrtc (issue#9042)
* lint error fix for PR#39046
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for codereview
* fix lint error
* fix lint errors in file api-web-contents-spec.ts
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from itsananderson
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from jkleinsc
* fix lint error
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from codebyter
2023-08-24 17:21:22 -04:00
Athul Iddya
33000c4b42
feat: enable WaylandWindowDecorations by default ( #39582 )
2023-08-24 17:02:05 -04:00
Shelley Vohr
33e66b5cd0
fix: ensure windows respect fullscreenability with different resizability values ( #39620 )
...
* fix: ensure child windows respect fullscreenability/resizability when parent is fullscreen
* test: add an extra resize test
2023-08-24 16:54:08 -04:00
Charles Kerr
35969939a1
refactor: node::Environment self-cleanup ( #39604 )
...
* chore: savepoint
* chore: turn raw_ptr tests back off
2023-08-23 09:56:16 -04:00
Shelley Vohr
a8999bc529
fix: ensure BrowserView
bounds are always relative to window ( #39605 )
...
fix: ensure BrowserView bounds are always relative to window
2023-08-23 09:55:31 -04:00
Shelley Vohr
522bba3dc6
chore: cleanup arc migration helpers ( #39606 )
2023-08-23 09:54:21 -04:00
Bruno Henrique da Silva
2481f94b4e
fix: instantiate tab video tracks from BrowserCaptureMediaStreamTrack ( #39074 )
...
return BrowserCaptureMediaStreamTrack instead of MediaStreamTrack
2023-08-23 10:49:24 +02:00
Shelley Vohr
e1d63794e5
fix: chrome.tabs
'url' and 'title' are privileged information ( #39595 )
...
fix: tabs url and title are privileged information
2023-08-22 14:56:58 +02:00
Milan Burda
c1898c39bf
chore: remove obsolete "simple" object annotations for the remote module ( #39486 )
2023-08-22 13:43:30 +09:00
Charles Kerr
3a91d1f1e1
fix: dangling raw_ptr in ElectronBrowserMainParts dtor ( #39539 )
...
* fix: dangling raw_ptr in ElectronBrowserMainParts dtor
* fixup! fix: dangling raw_ptr in ElectronBrowserMainParts dtor
Browser::WhenReady() holds a reference to JsEnv isolate so must come after
2023-08-21 10:29:25 +02:00
Milan Burda
09190085c0
refactor: add gin_helper::Dictionary::CreateEmpty() helper ( #39547 )
2023-08-21 10:43:41 +09:00
tr2-harada
9937a2bbe8
fix: explorer restart does not recreated thumbnail toolbar buttons ( #39551 )
...
fix: explorer restart does not recreated thumbnail toolbar buttons.
2023-08-21 09:43:49 +09:00
Athul Iddya
c75e193a3e
fix: use tiled edges to calculate frame inset sizes in Linux ( #39523 )
...
Adapt to the window frame size calculation changes in CL 3970920 by
setting the inset sizes to 0 for tiled edges.
2023-08-17 14:26:49 -04:00
Charles Kerr
213388cd87
refactor: prefer Sorted variant of MakeFixedFlatSet() ( #39537 )
...
perf: prefer Sorted variant of MakeFixedFlatSet()
https://chromium-review.googlesource.com/c/chromium/src/+/4660000
says that the sorted version is simpler at compile time because it
can skip MakeFixedFlatSet()'s compile-time dynamic sorting.
2023-08-17 08:58:04 -05:00
Shelley Vohr
00746e662b
feat: allow headers to be sent with webContents.downloadURL()
( #39455 )
...
feat: allow headers to be sent with webContents.downloadURL()
2023-08-17 14:17:55 +02:00
Charles Kerr
dd8df3b0c4
fix: destruction order of js env fields ( #39521 )
...
isolate_ depends on isolate_holder_ and so must be destroyed first.
2023-08-16 23:06:24 -05:00
Shelley Vohr
1eb398b328
fix: crash when calling BrowserWindow.moveTop()
on modal children ( #39499 )
...
fix: crash when calling moveTop() on modal children
2023-08-16 13:28:29 +02:00
electron-roller[bot]
0c45d160d6
chore: bump chromium to 118.0.5949.0 (main) ( #39505 )
...
* chore: bump chromium in DEPS to 118.0.5949.0
* chore: update mas_disable_remote_accessibility.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4705386
no manual code changes; existing patch applied with fuzz
* chore: update printing.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4779059
no manual code changes; existing patch applied with fuzz
* chore: add OffScreenRenderWidgetHostView::InvalidateLocalSurfaceIdAndAllocationGroup()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4563504
Add an impl for a new pure virtual method that was added upstream.
Local impl inspired by upstream implementations in same CL
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-08-15 15:44:24 -04:00
Shelley Vohr
22429e2112
refactor: clean up Node.js cli arg parsing ( #39465 )
...
* refactor: clean up Node.js arg parsing
* chore: feedback from review
2023-08-15 14:49:21 -04:00
electron-roller[bot]
c3036d4557
chore: bump chromium to 117.0.5938.0 (main) ( #39375 )
...
* chore: bump chromium in DEPS to 117.0.5929.0
* chore: bump chromium in DEPS to 117.0.5931.0
* chore: bump chromium in DEPS to 117.0.5932.0
* chore: update patches
* 4728317: Prevent PrintRenderFrameHelper from printing when already printing
| https://chromium-review.googlesource.com/c/chromium/src/+/4728317
* 4739501: Use base::SequenceBound to manage SerialPortManagerImpl |
https://chromium-review.googlesource.com/c/chromium/src/+/4739501
* 4702051: Allow overriding source in install-sysroot.py | https://chromium-review.googlesource.com/c/chromium/src/+/4702051
* chore: update filenames.libcxx.gni
* 4727002: Rename "enable_arc2" to "enable_arc" |
https://chromium-review.googlesource.com/c/chromium/src/+/4727002
* chore: bump chromium in DEPS to 117.0.5934.0
* 4736873: Rename ColorSpaces methods on display::Display | https://chromium-review.googlesource.com/c/chromium/src/+/4736873
* 4727203: Replace bool with an enum in as suggested in DevtoolsManagerDelegate. | https://chromium-review.googlesource.com/c/chromium/src/+/4727203
* 4744479: [DevTools] Add 'generateTaggedPDF' option to DevTools Page.printToPDF | https://chromium-review.googlesource.com/c/chromium/src/+/4744479
* 4735893: Don't share WebUSB permissions with webviews | https://chromium-review.googlesource.com/c/chromium/src/+/4735893
* revert: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 117.0.5936.0
* chore: update patches
* 4746465: SAA: Query for embargoed StorageAccess permissions | https://chromium-review.googlesource.com/c/chromium/src/+/4746465
* 4666325: Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src. | https://chromium-review.googlesource.com/c/chromium/src/+/4666325
* chore: bump chromium in DEPS to 117.0.5938.0
* chore: bump chromium in DEPS to 118.0.5939.0
* chore: update patches
* Send line bounds through CursorAnchorInfo on requestCursorUpdate
https://chromium-review.googlesource.com/c/chromium/src/+/4394588
* Fixup lint for Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src
* 4700305: [mac] Fix override of CHILD_PROCESS_EXE
https://chromium-review.googlesource.com/c/chromium/src/+/4700305
Needed because of 4729689: Reland "Remove redundant existence check in PathService" | https://chromium-review.googlesource.com/c/chromium/src/+/4729689
* 4753759: More consistent icon handling for menus.
https://chromium-review.googlesource.com/c/chromium/src/+/4753759
* chore: bump chromium in DEPS to 118.0.5941.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5938.0
* test: update nan-spec-runner cflags
* build: fix isystem include path in nan-spec-runner
* fixup! 4666325: Move buildtools/third_party/lib*/trunk source paths to third_party/lib*/src. | https://chromium-review.googlesource.com/c/chromium/src/+/4666325
fix a few more instances of the old path
libc++.a and libc++abi.a are still in buildtools/
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2023-08-15 10:49:41 -05:00
Robo
bee5d94886
feat: support dns-result-order Node.js cli flag ( #39376 )
...
* feat: support dns-result-order Node.js cli flag
* chore: update docs
Co-authored-by: Erick Zhao <erick@hotmail.ca>
* chore: remove patch
---------
Co-authored-by: Erick Zhao <erick@hotmail.ca>
2023-08-15 12:19:45 +02:00
electron-roller[bot]
ef5d5f888d
chore: bump node to v18.17.1 (main) ( #39457 )
...
* chore: bump node in DEPS to v18.17.1
* chore: update patches
* policy: disable process.binding() when enabled
d4570fae35
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-08-15 10:06:55 +02:00
wgsheng
127584dc37
feat: add a 'title' parameter to openDevTools()
( #39047 )
...
* [Feature Request]: Add a parameter to openDevTools() that sets the DevTools window title bar
* all titles->title
* add GetDevToolsTitle(),update docs
* fix:lint error
* fix:lint error
* add setDevToolTitle
* lint errror
* lint errror
* ling errror (.md)
* build error
* build error in mac
* build error
* build error
* change docs
* std::string->std::u16string
* lint error
* build error
* build error
2023-08-15 14:32:53 +09:00
Shelley Vohr
8e3dcc8b17
refactor: update WebContentsZoomController
( #39428 )
...
refactor: update WebContentsZoomController
2023-08-15 10:33:30 +09:00
David Sanders
d166182865
chore: remove deprecated systemPreferences color scheme events ( #39341 )
2023-08-14 10:37:18 +02:00
Cheng Zhao
cf658b700d
fix: use nested run loop in clipboard.readImage ( #39466 )
2023-08-14 10:35:37 +02:00
Shelley Vohr
70508b5273
chore: update _api_features
manifest requirements ( #39412 )
...
chore: update api_resources manifest requirements
2023-08-09 10:38:13 -04:00
Shelley Vohr
d9329042e2
feat: add support for chrome.tabs.query
( #39330 )
...
* feat: add support for tabs.query
* fix: scope to webContents in current session
* test: add test for session behavior
2023-08-09 14:47:19 +02:00
Shelley Vohr
5e59ddca1a
chore: update chrome.runtime.getPlatformInfo
impl ( #39392 )
...
chore: update chrome.runtime.getPlatformInfo impl
2023-08-08 22:29:03 +02:00
Shelley Vohr
1b3c63145c
chore: remove i18n JSON spec ( #39391 )
2023-08-08 14:02:16 -04:00
Robo
eecfaec8c9
fix: crash when closing active macOS native tab ( #39394 )
...
fix: crash when closing current active macOS native tab
2023-08-08 17:45:03 +09:00
Shelley Vohr
8f4f82618c
fix: removeBrowserView
draggable region removal ( #39387 )
...
fix: removeBrowserView draggable region removal
Closes https://github.com/electron/electron/issues/39377 .
2023-08-08 10:23:14 +02:00
Shelley Vohr
67523a47b4
fix: chrome.tabs.update
return value ( #39365 )
...
fix: chrome.tabs.update return value
2023-08-07 10:03:45 +02:00
Shelley Vohr
dc707ee938
fix: macOS tray button selection with VoiceOver ( #39352 )
2023-08-07 09:52:18 +02:00
Shelley Vohr
2e0517c0ad
feat: allow more Node.js cli flags in main process ( #39344 )
...
* feat: allow more Node.js cli flags in main process
* docs: update cli switch documentation
2023-08-04 19:59:40 +09:00
electron-roller[bot]
c5b9f766f3
chore: bump chromium to 117.0.5923.0 (main) ( #39304 )
...
* chore: bump chromium in DEPS to 117.0.5921.0
* chore: update chromium patches
* 4721409: Remove redundant ARC configuration in /components | https://chromium-review.googlesource.com/c/chromium/src/+/4721409
* 4643750: Add V8_LOW_PRIORITY_TQ for main thread | https://chromium-review.googlesource.com/c/chromium/src/+/4643750
* 4022621: Re-register status item when owner of status watcher is changed | https://chromium-review.googlesource.com/c/chromium/src/+/4022621
* chore: update V8/boringssl patches
* fixup! 4643750: Add V8_LOW_PRIORITY_TQ for main thread | https://chromium-review.googlesource.com/c/chromium/src/+/4643750
* chore: bump chromium in DEPS to 117.0.5923.0
* build [debug]: remove assert
4722125: Update enterprise content analysis buildflags usage | https://chromium-review.googlesource.com/c/chromium/src/+/4722125
* chore: manually rollback to 117.0.5921.0
* build [arc]: ARC conversion in auto_updater
* build [arc]: ARC conversion in browser/api
* build [arc]: ARC conversion in notifications/mac
* build [arc]: ARC conversion in in_app_purchase
* build [arc]: ARC conversion in browser/ui
* build [arc]: ARC conversion in ui/cocoa
* build [arc]: ARC conversion in shell/common
* build [arc]: ARC conversion in OSR
* build [arc]: ARC conversion in login_helper
* build [arc]: ARC conversion in app_mas
* build [arc]: fix up ARC syntax (thanks @codebytere!)
* 4726946: [Extensions] Work around dangling BrowserContext pointer. | https://chromium-review.googlesource.com/c/chromium/src/+/4726946
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
2023-08-04 10:47:29 +02:00
Shelley Vohr
6d0e8044eb
fix: update chrome.tabs
for Manifest v3 ( #39317 )
2023-08-03 18:34:02 +02:00
Shelley Vohr
f8b05bc127
feat: support minimum_chrome_version
manifest key ( #39256 )
...
feat: support minimum_chrome_version extension key
2023-08-03 11:38:31 -04:00
Robo
e96b1613a4
fix: destroy message port backend when JS env exits ( #39335 )
2023-08-03 14:30:19 +02:00
Shelley Vohr
303b707fbf
fix: update chrome.i18n
for Manifest v3 ( #39291 )
...
fix: update chrome.i18n for Manifest v3
2023-08-02 11:02:16 +02:00
Shelley Vohr
1f19a74417
fix: potential crash calling tray.popUpContextMenu()
( #39231 )
...
fix: potential crash calling tray.popUpContextMenu
2023-08-01 15:07:30 +09:00
Shelley Vohr
c8f7a0e052
fix: Chrome Extensions service worker host registration ( #39290 )
2023-08-01 15:04:38 +09:00
David Sanders
b2c62d6ad1
fix: initial dark mode title bar on Windows 10 ( #39287 )
2023-07-31 22:02:23 -07:00
electron-roller[bot]
cfc0826b65
chore: bump chromium to 117.0.5913.0 (main) ( #39172 )
...
* chore: bump chromium in DEPS to 117.0.5899.0
* 4686653: webui: Filter out non-chrome scheme URLs in WebUIConfigMap
https://chromium-review.googlesource.com/c/chromium/src/+/4686653
* 4696355: Remove deprecated version of base::CommandLine::CopySwitchesFrom()
https://chromium-review.googlesource.com/c/chromium/src/+/4696355
* chore: fixup patch indices
* 4603888: Reland "Enable raw_ref check on linux"
https://chromium-review.googlesource.com/c/chromium/src/+/4603888
* chore: bump chromium in DEPS to 117.0.5901.0
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5903.0
* chore: bump chromium in DEPS to 117.0.5903.2
* chore: bump chromium in DEPS to 117.0.5905.0
* 4706792: Printing: Add debug code for a DispatchBeforePrintEvent() failure
https://chromium-review.googlesource.com/c/chromium/src/+/4706792
* 4704786: Refactor libunwind build rules/flags
https://chromium-review.googlesource.com/c/chromium/src/+/4704786
* 4701710: [Linux Ui] Set toolkit dark preference based on FDO dark preference
https://chromium-review.googlesource.com/c/chromium/src/+/4701710
* chore: fixup patch indices
* chore: bump chromium in DEPS to 117.0.5907.0
* chore: bump chromium in DEPS to 117.0.5909.2
* chore: update patches
* chore: bump chromium in DEPS to 117.0.5911.0
* chore: update patches
* chore: build-what-we-include
* fix: set allowFileAccess on devtools extensions correctly
Ref: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4714725
* 4670615: Reland "[iterator-helpers] Shipping iterator helpers"
https://chromium-review.googlesource.com/c/v8/v8/+/4670615
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>
2023-07-31 10:47:32 -07:00
Shelley Vohr
695fcf3cb2
fix: reparenting after BrowserWindow.destroy()
( #39062 )
...
fix: reparenting after BrowserWindow.destroy()
2023-07-26 16:47:32 +02:00
Athul Iddya
fa5b1be6f3
fix: delete desktop capturers when they're not needed ( #39194 )
...
* fix: delete desktop capturers when they're not needed
Delete desktop capturer objects by resetting the DesktopMediaList
objects that own them after the sources have been collected. Capturers
that are not delegated are already being reset via a patch on
NativeDesktopMediaList. That is not safe for delegated capturers as
thumbnail generation depends on user events. Deleting the
DesktopMediaList operation is safe for all capturers and releases OS
capture resources as soon as possible.
* fix: add a patch to clean up PipeWire resources
Adding a patch to workaround a Chromium issue:
https://bugs.chromium.org/p/chromium/issues/detail?id=1467060
The patch can be removed when the issue is resolved.
2023-07-26 10:40:19 +02:00
Shelley Vohr
38c3d8df29
fix: traffic lights not working when child windows are restored via parent window ( #39225 )
2023-07-26 10:10:34 +02:00
Shelley Vohr
12548294c0
fix: resizable: false
should disable fullscreen button at start ( #39086 )
...
fix: resizable should disable fullscreen button at start
2023-07-25 12:18:36 -04:00
Milan Burda
3df6d337f3
feat: add senderIsMainFrame
to messages sent via ipcRenderer.sendTo()
( #38868 )
...
* feat: add isMainFrame to events emitted via ipcRenderer.sendTo()
* chore: rename isMainFrame to senderIsMainFrame
2023-07-24 14:27:30 +02:00
Athul Iddya
9cd5de7588
fix: use generic capturer to list both screens and windows when possible ( #39111 )
...
Screensharing with PipeWire via XDG Desktop Portal requires explicit
user permission via permission dialogs. Chromium has separate tabs for
screens and windows and thus its portal implementation requests
permissions separately for each. However, the screencast portal has no
such limitation and supports both screens and windows in a single
request.
WebRTC now supports this type of capture in a new method called
called `CreateGenericCapturer`. The `desktopCapturer` implementation has
been modified to use it. Additionally, Chromium has been patched to use
same generic capturer to ensure that the source IDs remain valid for
`getUserMedia`.
2023-07-21 16:03:01 -07:00