Samuel Attard
0ac883c6d4
Remove the race condition between new process creation and context release ( #12342 )
...
* Remove the race condition between new process creation and old process releasing remote context
Previously there was a race condition where the getId() method would return the new context ID even
though the release was for the old context. This changes it to send the "initial" context ID with
the release message to ensure there is no race.
* fetch context ID from remote in sandbox mode
2018-03-20 15:54:47 +11:00
Shelley Vohr
31d688ad3d
Check menu.popup options are an object ( #12325 )
...
* check menu.popup options are an object
* Add a spec for menu.popup options check
* remove stray .only
2018-03-17 06:31:10 +09:00
Samuel Attard
4b476f13bb
Revert "Fixes electron/electron#12147" ( #12293 )
...
* Revert "Set appropriate defaults for webview options (#12271 )"
This reverts commit c2673aa970
.
* Revert "Fixes electron/electron#12147 (#12193 )"
This reverts commit f54c94d6c9
.
2018-03-15 16:18:36 +09:00
Charles Kerr
c2673aa970
Set appropriate defaults for webview options ( #12271 )
...
* Persist defaults to webPreferences object to JS land can read the inferred values instead of just user defined values
* Test inherited default propogation
* Refactor to remove coupling from fetching values and defaults
* Test description type
* Fix up tests
2018-03-15 13:56:46 +09:00
nous-
f54c94d6c9
Fixes electron/electron#12147 ( #12193 )
2018-03-15 13:29:32 +09:00
Charles Kerr
e400585a0e
Apply further ES6 bikeshedding
2018-03-13 17:09:47 +09:00
Charles Kerr
2d90e763ad
Use idiomatic ES6 when merging options
2018-03-13 16:23:39 +09:00
Charles Kerr
379bd79de4
Remove unnecessary work when merging options
2018-03-13 16:18:50 +09:00
Charles Kerr
685948bcaa
Parent's visibility trumps inherited 'show' option
2018-03-13 00:28:34 +09:00
Samuel Attard
795447f61a
Implement dialog (alert/confirm) blocking as a user switch after the first dialog
...
* This is to enable more browser-like behavior so that users who run third-party code
will not be DOS'ed with alerts and confirms. This is already handled like this
in most major browsers so this will greatly help these developers
2018-03-06 11:19:15 +09:00
Shelley Vohr
199cf31b9e
deprecate screen.getMenuBarHeight
2018-03-05 19:45:51 -05:00
Cheng Zhao
35cbe9d140
Fix dockMenu not being referenced in JavaScript ( #12062 )
...
* Fix dockMenu not being referenced in JavaScript
* spec: Test garbage collecting dock menu
2018-02-26 22:15:06 -08:00
shelley vohr
18362eb948
improve Menu and MenuItem testing ( #12015 )
...
* split menu/menuitem and add some tests
* fix ipc send issue
* feedback: make tests less brittle
* clean up MenuItem accelerator and label tests
2018-02-23 07:53:59 -06:00
John Kleinschmidt
2a97e48465
Merge pull request #11968 from electron/refactor-menu-popup
...
Refactor menu.popup
2018-02-21 14:29:52 -05:00
shelley vohr
193febd18c
deprecate boolean highlightMode param ( #11993 )
...
* deprecate boolean highlightMode param
* add process.noDeprecations check
* fix native method override
* add todo
2018-02-20 22:30:32 -06:00
shelley vohr
719e5a93b4
deprecation for webContents.openDevTools ( #11986 )
...
* deprecate old openDevTools param
* add deprecation check and existence check
* fix method issues
2018-02-20 22:30:02 -06:00
Charles Kerr
f59d078eea
Use more idiomatic JS in WebContents' init()
2018-02-20 19:20:11 -06:00
Charles Kerr
9c56b81b71
Throw an error if menu.popup() has no window
2018-02-20 18:38:05 -06:00
Charles Kerr
5a25b88b50
Fix browserWindow detection in menu.popup()
2018-02-20 18:35:39 -06:00
Charles Kerr
708f39a1a5
update a few menu.popup() calls to use the new API
2018-02-20 14:02:24 -06:00
Shelley Vohr
5065e159f1
positionItem => positioningItem
2018-02-20 11:28:34 -05:00
Cheng Zhao
dc62e51ba4
Fix the cyclic reference in menu delegate ( #11967 )
...
* Fix the cyclic reference in menu delegate
* Fix menu tests due to delegate change
2018-02-20 10:11:35 -06:00
Shelley Vohr
fb7fb4972d
options all the things
2018-02-20 11:10:53 -05:00
Shelley Vohr
211b542ae4
remove setZoomLevelLimits
2018-02-20 08:57:48 -05:00
Shelley Vohr
56f06187d5
forgot to remove old method
2018-02-19 21:03:10 -05:00
Shelley Vohr
6e11a3e53d
add restructured window.popup
2018-02-19 20:59:27 -05:00
Shelley Vohr
cd9e7142e4
add conditional for menu.popup(window, callback)
2018-02-19 13:06:37 -05:00
Samuel Attard
a20b379f26
fix windows tests
2018-02-16 16:02:10 +11:00
Samuel Attard
6318cd781d
Update to use Squirrel.Mac that supports CDN releases
2018-02-15 14:00:46 +11:00
acheronfail
d1d50a4c92
Implement App-Scoped Security scoped bookmarks ( #11711 )
...
* implementation of security scoped bookmarks
* option is now only available on mas builds
2018-02-12 13:25:06 -05:00
Samuel Attard
66b57858b8
Fix child touch bar items not updating ( #11812 )
...
* Fix child touch bar items not updating
Deep children of a TouchBar didn't cause the top level touch bar to update, now they do
Fixes #11761 .
* Remove unused newValue property in TB setter
2018-02-12 12:53:04 -05:00
kaylie
3c64062f69
Replace custom function with Object.values()
2018-02-05 20:03:28 -08:00
shelley vohr
5240352326
Remove extra menu separators ( #11827 )
...
* add function to remove leading/trailing separators
* change const name for clarity
* add spec to check filtered separators
* clean method and add edge case spec per review
2018-02-05 11:55:12 -06:00
Cheng Zhao
8ae3d9dd0b
Simplify the public PowerObserver interface
2018-02-05 15:28:58 +09:00
Thiago de Arruda
56b53e71aa
Implement powerMonitor 'shutdown' event for Linux.
...
The event is emitted when the OS is rebooting/shutting down, and allows
an electron app to call `e.preventDefault()` in order to delay shutdown
and exit cleanly.
2018-02-05 15:21:31 +09:00
Shelley Vohr
db6d84de74
don't inherit isBrowserView for spawned child windows
2018-02-01 00:09:37 -05:00
Samuel Attard
32a1395bcf
Merge pull request #11565 from electron/add-load-file-helper
...
Add window.loadFile and webContents.loadFile helper methods
2018-01-23 09:08:23 +11:00
Cheng Zhao
bd271cffb9
Throw when inAppPurchase is used on unsupported platforms
2018-01-10 18:53:55 +09:00
Cheng Zhao
ac6f895f64
Turn InAppPurchase into an EventEmitter
2018-01-10 16:37:05 +09:00
Adrien Fery
b2542a27c3
Update code style
2018-01-10 13:14:18 +09:00
Adrien Fery
eb2520488f
Adapt code style
2018-01-10 13:14:18 +09:00
Adrien Fery
f3ae566164
Add in-app purchase for MacOS
2018-01-10 13:14:18 +09:00
Zeke Sikelianos
eb89e12c5b
Merge pull request #11532 from sethlu/camelcase-menuitem-role
...
Make MenuItem roles camelCase-compatible
2018-01-04 09:53:58 -08:00
Samuel Attard
1553b54779
Add window.loadFile and webContents.loadFile helper methods
2018-01-04 11:38:56 +13:00
Cheng Zhao
46330ac2a9
Remove the closed event of Menu
...
The callback of Menu.popup does more things, and there is actually no
request for the closed event.
2018-01-01 17:22:07 +09:00
Cheng Zhao
73d78d345a
Make callback work for old-style Menu.popup call
...
While the old-style Menu.popup has been deprecated, it is still being
used widely in apps and even in Electron itself.
2018-01-01 17:17:01 +09:00
Cheng Zhao
7b01a8b860
Add callback parameter to Menu.popup
2018-01-01 16:26:19 +09:00
Zhuo Lu
b8ec84c761
Fix syntax
2018-01-01 02:23:32 +08:00
Zhuo Lu
d45914c3f7
MenuItem roles camelCase-compatible
2017-12-28 13:28:20 +08:00
Kyle Corry
5aac091f40
Add Support for Pop!_OS GNOME Session
...
Similar to this PR: https://github.com/electron/electron/pull/10355 , Pop!_OS suffers from the same problem. Using Ubuntu AppIndicator will not show the icon currently unless the XDG_CURRENT_DESKTOP variable is modified. This commit will add support for pop so that this workaround is not needed.
Ref: https://github.com/pop-os/pop/issues/84
2017-12-21 14:16:15 -05:00