Charles Kerr
062d14e553
perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set ( #45143 )
...
* perf: cache whether or not ELECTRON_DEBUG_NOTIFICATIONS env var is set
* chore: remove unused #include
2025-01-08 20:46:17 -06:00
Charles Kerr
24dc9ddf5c
fix: remove use of banned std::to_string() ( #44514 )
...
Use base::NumberToString() instead
Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-features.md#std_sto_i_l_ul_ll_ull_f_d_ld_to_string_banned
2024-11-04 16:42:42 -05:00
Charles Kerr
9df092e034
fix: remove use of deprecated API base::Hash() ( #44076 )
2024-10-02 16:36:06 -04:00
Charles Kerr
45bae950d5
chore: remove unused base/ includes ( #43688 )
2024-09-12 16:05:37 +02:00
Charles Kerr
60c4c9fec6
chore: remove unused #includes ( #42971 )
...
* chore: iwyu buildflags.h
* chore: iwyu dictionary.h
* chore: iwyu arguments.h
* chore: iwyu values.h
* chore: iwyu compiler_specific.h
* chore: iwyu binder_map.h
* chore: iwyu <vector>
* chore: iwyu <set>
* chore: iwyu raw_ptr
* chore: iwyu gfx/canvas.h
* chore: iwyu gfx/color_utils.h
* chore: iwyu base/strings/stringprintf.h
* chore: iwyu base/task/thread_pool.h
* chore: iwyu base/no_destructor.h
* chore: iwyu base/path_service.h
* chore: iwyu base/files/file_pathh
* chore: iwyu base/strings/sys_string_conversions.h
* chore: iwyu base/logging.h
* chore: iwyu base/command_line.h
* chore: iwyu base/files/file_util.h
* chore: iwyu base/files/scoped_file.h
* chore: iwyu base/strings/utf_string_conversions.h
* chore: iwyu base/environment.h
* chore: iwyu base/scoped_observation.h
* chore: iwyu base/strings/string_split.h
* chore: iwyu base/strings/pattern.h
* chore: iwyu base/json/string_escape.h
* chore: iwyu base/json/json_reader.h
* chore: iwyu base/memory/singleton.h
* chore: iwyu base/observer_list.h
* chore: iwyu base/timer/timer.h
* fixup! chore: iwyu values.h
* chore: iwyu shell/browser/browser.h
* chore: iwyu base/stl_util.h
* chore: iwyu base/strings/string_util.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu base/memory/ref_counted.h
* chore: iwyu base/environment.h
* chore: iwyu content/public/browser/browser_thread.h
* chore: remove unused typedef gin_helper::EventEmitter::ValueArray
* chore: iwyu gin/wrappable.h
* chore: iwyu shell/common/gin_helper/function_template_extensions.h
* chore: iwyu shell/common/gin_converters/login_item_settings_converter.h
* chore: iwyu shell/common/gin_helper/arguments.h
* chore: iwyu ui/gfx/skia_util.h
* chore: iwyu ui/gfx/geometry/rect.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu base/strings/strcat.h
* chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu shell/browser/javascript_environment.h
* fixup! chore: iwyu gfx/canvas.h
* fixup! chore: iwyu content/public/browser/browser_thread.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
2024-07-22 11:31:32 +02:00
BILL SHEN
3ffa35dc8d
fix: calculate a hash for the Tag property of ToastNotification. ( #42239 )
...
* fix: calculate a hash for the Tag property of ToastNotification.
* fix: calculate a hash for the Tag property of ToastNotification.
---------
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-05-24 21:20:59 +02:00
Charles Kerr
b428315c6d
perf: remove unnecessary .c_str() calls ( #41869 )
...
* perf: remove unnecessary c_str() call when invoking promise.RejectWithErrorMessage()
RejectWithErrorMessage() takes a std::string_view
* perf: remove unnecessary c_str() call when invoking Environment::SetVar()
the val arg to Environment::SetVar() takes a const std::string&
* refactor: use string_view variant of base::UTF8ToWide()
* perf: remove unnecessary c_str() call when instantiating a ScopedHString
ScopedHString has always taken a StringPiece
* refactor: use simpler invocation of base::make_span()
* perf: remove unnecessary c_str() call when calling base::CommandLine::HasSwitch()
HasSwitch() already takes a string_piece
* perf: remove unnecessary c_str() call when calling net::HttpResponseHeaders::AddHeader()
AddHeader() already takes a StringPiece arg
* perf: omit unnecessary str -> wstr -> str conversion in DesktopCapturer::UpdateSourcesList()
this conversion was made redundant by c670e38
2024-04-16 19:48:54 -04:00
Charles Kerr
4164ef93ad
refactor: remove banned std::to_string() calls ( #41087 )
...
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo()
* refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED()
* refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete()
* refactor: do not use banned std::to_string() in SetCrashKey()
* chore: remove unused #include
2024-01-24 16:43:31 -06:00
Shelley Vohr
666907d50d
fix: Windows Toast notification dismissal from Action Center ( #40197 )
...
* fix: Windows Toast notification dismissal from Action Center
* docs: note Toast behavior in event
* chore: address feedback from review
2023-10-17 19:33:00 -04:00
electron-roller[bot]
61374019c0
chore: bump chromium to 103.0.5046.0 (main) ( #33906 )
...
* chore: bump chromium in DEPS to 103.0.5020.0
* chore: bump chromium in DEPS to 103.0.5022.0
* chore: bump chromium in DEPS to 103.0.5024.0
* chore: update patches
* 3587410: [Printing] Remove JobEventDetails
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3587410
* chore: bump chromium in DEPS to 103.0.5026.0
* chore: update patches
* 3577218: WebUI: Delete webui_resources.grd and related GN targets.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3577218
* chore: bump chromium in DEPS to 103.0.5028.0
* chore: update patches
* 3579297: Convert UpdatePrintSettings() to use non-deprecated base::Value APIs.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3579297
* 3560622: serial: Add SerialPort.forget() method
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560622
* 3581708: Restore original display when moving from tab-fullscreen to browser-fullscreen.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3581708
* chore: fix authorization flags lint error
* 3583363: Remove net wrappers around base/strings/escape.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3583363
* fixup! 3560622: serial: Add SerialPort.forget() method
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560622
* 3587589: Reland "Propagate the MIME type from DownloadTargetDeterminer to DownloadItem"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3587589
* 3584006: Remove IsRenderViewLive from content public
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3584006
* 3596174: [api] Remove APIs for resurrecting finalizers
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3596174
* 3368244: Hook SnapshotForContentAnalysis renderer API to scan system prints
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3368244
* chore: bump chromium in DEPS to 103.0.5030.0
* chore: update patches
* chore: bump chromium in DEPS to 103.0.5032.0
* chore: bump chromium in DEPS to 103.0.5034.0
* chore: bump chromium in DEPS to 103.0.5036.0
* chore: update patches
* 3586363: Introduce PrintRenderFrame.PrintWithParams() for batch printing to PDF
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3586363
* 3593199: Remove content::PermissionType references and replace them with blink::PermissionType
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3593199
* 3368244: Hook SnapshotForContentAnalysis renderer API to scan system prints
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3368244
* chore: lint
* chore: bump chromium in DEPS to 103.0.5038.0
* chore: update patches
* fixup! 3560622: serial: Add SerialPort.forget() method
* 3606495: mac screen capture: add metric
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3606495
* chore: bump chromium in DEPS to 103.0.5040.0
* chore: update patches
* 3590840: Add IPs to DnsOverHttpsServerConfig
https://chromium-review.googlesource.com/c/chromium/src/+/3590840
* stub functions for ElectronSerialDelegate and SerialChooserController to fix link
* 3566412: [base] Remove base/android dependency on post_task.h and officially remove post_task.h!
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* 3347944: [content] No longer hand-off whole MainFunctionParams to BrowserMainParts
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3347944
* fixup! 3566412: [base] Remove base/android dependency on post_task.h and off…
e3ea3e1
…icially remove post_task.h!
* chore: update process_singleton patches for content::GetIOThreadTaskRunner({})
Ref: 2015655: [BrowserThread] Migrate co/pub/br and co/br/scheduler to the new API | https://chromium-review.googlesource.com/c/chromium/src/+/2015655
* chore: migrate base::DeleteSoon to content::GetUIThreadTaskRunner({})->DeleteSoon
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* chore: remove duplicate functions for RevokePortPermissionWebInitiated & GetPortInfo
* chore: migrate Linux/Windows methods off of post_task.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* 64908: Stop building legacy SwiftShader GL in Chromium
https://swiftshader-review.googlesource.com/c/SwiftShader/+/64908
* 3573245: Added Themed versions of RoundedRectBackground and RoundedRectBorder.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3573245
* chore: bump chromium in DEPS to 103.0.5042.0
* chore: update patches
* 3571804: [api] Advance API deprecation for V8 version v10.2
https://chromium-review.googlesource.com/c/v8/v8/+/3571804
* fixup! 3571804: [api] Advance API deprecation for V8 version v10.2
* build: fix run-clang-format extension matching
* lint
* fix windows build
* how is clang-format still not working for me
* chore: update patches
* 3623985: Replace ad-hoc SetPublicFirstPartySets calls with method in ContentBrowserClient.
https://chromium-review.googlesource.com/c/chromium/src/+/3623985
* no need to implement WillProvidePublicFirstPartySets; the default is false
* 3601036: [QT] Introduce ui/views/linux_ui/linux_ui_factory.*
https://chromium-review.googlesource.com/c/chromium/src/+/3601036
* 3583363: Remove net wrappers around base/strings/escape.h
https://chromium-review.googlesource.com/c/chromium/src/+/3583363
* lint
* chore: bump chromium in DEPS to 103.0.5044.0
* fix conflicts
* chore: update patches
* upgrade nan
* pin version of nan in tests
* replace my hacky deprecated override fix with the fix from upstream
* revert runtime dcheck in v8
* pin nan version at root too
* refactor: tell gyp to use c++17 when building with our node
* Revert "refactor: tell gyp to use c++17 when building with our node"
This reverts commit 41a03a5799a8f40f31555d73d20ea865acfcd192.
* Undo the reversion of 41a03a5799a8f40f31555d73d20ea865acfcd192.
This reverts commit 54440abc598153bd7e259be4a908f0ecc0b33348.
* disable sequential/test-cpu-prof-kill for now
* also sequential/test-diagnostic-dir-cpu-prof
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <japthorp@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-17 12:48:40 -04:00
electron-roller[bot]
28ada6ea8b
chore: bump chromium to 100.0.4857.0 (main) ( #32419 )
...
* chore: bump chromium in DEPS to 99.0.4819.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4824.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4827.0
* chore: update patches
* 3352511: PiP: Add inkdrop and pointer cursor to PiP window buttons
https://chromium-review.googlesource.com/c/chromium/src/+/3352511
* 3309164: webhid: Show FIDO devices in the chooser if allowed
https://chromium-review.googlesource.com/c/chromium/src/+/3309164
* 3297868: hid: Add experimental HIDDevice.forget()
https://chromium-review.googlesource.com/c/chromium/src/+/3297868
* 3362491: [Extensions] Move i18n API to //extensions
https://chromium-review.googlesource.com/c/chromium/src/+/3362491
* MCC Refactor step0: Allow embedders to register associated_interface binders with RenderFrameHostImpl::associated_registry_.
https://chromium-review.googlesource.com/c/chromium/src/+/3281481
* 3352616: [Gtk] Remove libgtk from the link-line
https://chromium-review.googlesource.com/c/chromium/src/+/3352616
* 3249211: Clear-Site-Data support for partitioned cookies
https://chromium-review.googlesource.com/c/chromium/src/+/3249211
* [Extensions][COIL] Use [allow|block]list in //extensions/common
https://chromium-review.googlesource.com/c/chromium/src/+/3372668
* Begin ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3376154
* [Code Health] Refactor PrefService GetDict + GetList to use base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3343526
* 3354997: [CodeHealth] Remove deprecated SetDictionary method
https://chromium-review.googlesource.com/c/chromium/src/+/3354997
* 3287323: Add LacrosPrefStore for lacros settings
https://chromium-review.googlesource.com/c/chromium/src/+/3287323
* 3365916: [PA] Clean up remaining lazy commit code
https://chromium-review.googlesource.com/c/chromium/src/+/3365916
* [MPArch] Target the external protocol error at the responsible frame.
https://chromium-review.googlesource.com/c/chromium/src/+/3011560
* Pass origin to RegisterNonNetworkSubresourceURLLoaderFactories
https://chromium-review.googlesource.com/c/chromium/src/+/3350608
* Linux: Send OSCrypt raw encryption key to the Network Service
https://chromium-review.googlesource.com/c/chromium/src/+/3320484
* [PlzServiceWorker] Remove remaining references to PlzServiceWorker.
https://chromium-review.googlesource.com/c/chromium/src/+/3359441
* chore: fixup for lint
* 3327621: Fix tablet mode detection for Win 11.
https://chromium-review.googlesource.com/c/chromium/src/+/3327621
* 3342428: ax_mac: move AXTextMarker conversion utils under ui umbrella
https://chromium-review.googlesource.com/c/chromium/src/+/3342428
* 3353974: Mac: Use base::Feature for overlay features
https://chromium-review.googlesource.com/c/chromium/src/+/3353974
* chore: bump chromium in DEPS to 99.0.4828.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4837.0
* chore: update patches
* chore: update patches
* 3379142: Drop FALLTHROUGH macro
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3379142
* 3381749: C++17: Allow use of std::map::try_emplace and std::map::insert_or_assign
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3381749
* chore: bump chromium in DEPS to 99.0.4839.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4840.0
* chore: bump chromium in DEPS to 99.0.4844.0
* 3395881: [api] Deprecate Local<v8::Context> v8::Object::CreationContext()
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3395881
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4845.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4847.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4849.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4851.0
* chore: bump chromium in DEPS to 100.0.4853.0
* update patches
* chore: update patches
* update patches
* 3383599: Fonts Access: Remove prototype that uses a font picker.
https://chromium-review.googlesource.com/c/chromium/src/+/3383599
* 3404768: Remove ALLOW_UNUSED macros
https://chromium-review.googlesource.com/c/chromium/src/+/3404768
* 3374762: Remove ignore_result.h
https://chromium-review.googlesource.com/c/chromium/src/+/3374762
* 3399305: [unseasoned-pdf] Apply proper frame offsets for touch selections
https://chromium-review.googlesource.com/c/chromium/src/+/3399305
* 3402210: [Extensions] Don't trigger unload event for already unloaded extension
https://chromium-review.googlesource.com/c/chromium/src/+/3402210
* 3410912: Combine URLLoaderClient OnReceiveResponse and OnStartLoadingResponseBody.
https://chromium-review.googlesource.com/c/chromium/src/+/3410912
* 3370428: Make the AuthSchemes policy support dynamic refresh
https://chromium-review.googlesource.com/c/chromium/src/+/3370428
* 3407603: Finish ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3407603
* 3378352: ozone/x11: move code from //ui/p/x11 to //ui/ozone/p/x11
https://chromium-review.googlesource.com/c/chromium/src/+/3378352
* 3370810: Delete chrome/service, AKA the Cloud Print service process.
https://chromium-review.googlesource.com/c/chromium/src/+/3370810
* chore: bump chromium in DEPS to 100.0.4855.0
* chore: update patches
* fixup! 3370810: Delete chrome/service, AKA the Cloud Print service process.
* revert 3348007 to fix windows build
* 3318572: [Code health] Fix gn check errors in //extensions/browser:*
https://chromium-review.googlesource.com/c/chromium/src/+/3318572
* fix printing.patch
* fix iwyu issue
* 3408515: win: Make ShorcutOperation an enum class and modernize names
https://chromium-review.googlesource.com/c/chromium/src/+/3408515
* 3388333: [UIA] Remove dead code accessibility_misc_utils.h/cc
https://chromium-review.googlesource.com/c/chromium/src/+/3388333
* fix windows build? i hope
* patch gn visibility of //ui/ozone/platform/x11
* missing include base/logging.h
* use BUILDFLAG for USE_NSS_CERTS
https://chromium-review.googlesource.com/c/chromium/src/+/3379123
* defined(OS_*) ==> BUILDFLAG(IS_*)
https://bugs.chromium.org/p/chromium/issues/detail?id=1234043
* fixup! 3404768: Remove ALLOW_UNUSED macros
* another attempt to fix windows build
* temporarily disable the custom scheme service worker test
https://github.com/electron/electron/issues/32664
* fix loading mv3 extensions
not sure what cl broke this unfort.
* fixup! 3404768: Remove ALLOW_UNUSED macros
* patch nan
https://chromium-review.googlesource.com/c/v8/v8/+/3395880
* fix node test
* fix nullptr in FindPdfFrame
* patch perfetto to fix build issue on win-ia32
https://source.chromium.org/chromium/_/android/platform/external/perfetto.git/+/bc44c3c7533c00e56f88c06c592d634aecc884be
* fix build for linux-x64-testing-no-run-as-node
* fix patch
* skip <webview>.capturePage() test
https://github.com/electron/electron/issues/32705
* test: fix failing tests of focus/blur events of WebContents (#32711 )
* inherit stdio from app module test child processes
this prevents them from timing out due to full stdout buffers
* test to see if we can get better logs on windows ci
* try again for appveyor log things
* skip contentTracing tests on ia32
* ci: disable gpu compositing
* drop applied patch
* fix merge fail
* Revert "ci: disable gpu compositing"
This reverts commit 0344129fcb19ea3e87e06c1110d751f22eba3fec.
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2022-02-09 18:58:52 -08:00
Cheng Zhao
21f6937728
chore: remove unneeded conversions between wstring and u16string ( #30047 )
2021-07-12 13:33:26 +09:00
David Sanders
81c5da5221
chore: use =default for default constructors/destructors ( #29511 )
2021-06-04 13:16:13 +09:00
David Sanders
93c9374e95
chore: trim unused STL includes ( #29414 )
2021-06-01 10:34:44 +09:00
John Kleinschmidt
2d3c65beca
2757472: Reland "Reland "[LSC] Remove base::string16 alias""
...
https://chromium-review.googlesource.com/c/chromium/src/+/2757472
2021-03-18 15:55:51 -04:00
Michaela Laurencin
0195319b75
fix: notifications successfully never timeout with included flag ( #25820 )
...
Co-authored-by: mlaurencin <mlaurencin@microsoft.com>
2020-10-09 08:26:39 -07:00
bitdisaster
b43859f098
feat: custom toast xml and failure reporting for notifications ( #25401 )
...
* allow custom toast xml and report failures
* docs
* tests
* don't use namespaces
* lint doesn't like trailing commas
* addressing feedback
2020-09-29 12:20:10 -07:00
Samuel Attard
184e72fafd
revert: "fix: reply notifs sometimes destroyed too early" ( #25247 )
...
* Revert "fix: reply notifs sometimes destroyed too early (#25086 )"
This reverts commit bea6c9e4e1
2020-09-02 10:02:47 +09:00
Shelley Vohr
bea6c9e4e1
fix: reply notifs sometimes destroyed too early ( #25086 )
...
* fix: reply notifs sometimes destroyed too early
* Fix windows build
2020-08-23 21:27:46 -07:00
Shelley Vohr
f80a17c5be
feat: allow Linux/Windows users to set notification timeout ( #20153 )
...
* feat: allow Linux users to set notification timeout
* implement on windows
2019-10-09 11:22:21 -04:00
Electron Bot
eb2d2264d0
chore: bump chromium to 63be48daea281d4f8c834c2e707a7 (master) ( #19923 )
2019-09-18 15:58:00 -04:00
Samuel Attard
34c4c8d508
refactor: rename the atom namespace to electron
2019-06-19 17:33:28 -07:00
Samuel Attard
2160c1fcc9
refactor: replace includes for atom with shell
2019-06-19 17:33:28 -07:00
Samuel Attard
d7f07e8a80
refactor: rename the atom directory to shell
2019-06-19 17:33:28 -07:00
