shelley vohr
18362eb948
improve Menu and MenuItem testing ( #12015 )
...
* split menu/menuitem and add some tests
* fix ipc send issue
* feedback: make tests less brittle
* clean up MenuItem accelerator and label tests
2018-02-23 07:53:59 -06:00
Zhuo Lu
d45914c3f7
MenuItem roles camelCase-compatible
2017-12-28 13:28:20 +08:00
Zhuo Lu
dcdc3621ac
Rename roles
2017-11-27 17:26:22 +09:00
Zhuo Lu
5d44dbaf54
Redesign recent documents role API
...
- For more flexibility in designing the recent documents menu, now there can be one menu item (known issue: you may specify more but AppKit doens't display more than one) in the submenu list, rather than separating the labels with a tab.
- Also added is the role `clearrecent` that can be given to a menu item that can clear the recent documents.
2017-11-27 17:26:22 +09:00
Zhuo Lu
0b9cea334f
Specify "Clear Menu" through label option
...
Like a bit of a hack right now, conforming to the existing menu item definition
2017-11-27 17:26:22 +09:00
Zhuo Lu
4da2eb9366
Introduce openrecent role
...
- Does not yet accept any options except label--"Clear Menu" can't be modified through exposed node API
- If `openrecent` is present across multiple menu items, the last seen will be visible in the main menu due to that it is designed to behave like a singleton
2017-11-27 17:26:22 +09:00
Kevin Sawicki
8b4bf1f29e
🎨
2017-03-29 12:29:36 -07:00
mst128256
6ae198a625
Empty objects within default menu replaced by nulls
2017-03-29 12:50:31 +02:00
mst128256
9e471d8f1c
Added specs
2017-03-24 12:14:08 +01:00
mst128256
76ee7fda2b
Fixed linting
2017-03-13 14:26:34 +01:00
mst128256
8aba640250
added default menu items for 'Edit' and 'Window' #2814
2017-03-09 16:01:33 +01:00
Kevin Sawicki
fb08f56fc8
Add forcereload menu item role
2017-02-03 09:39:41 -08:00
Kevin Sawicki
88959079bd
Add toggledevtools menu item role
2016-11-17 10:57:20 -08:00
Kevin Sawicki
0698b5f1be
Add reload menu item role
2016-11-17 10:57:20 -08:00
Yuya Ochiai
43f955194e
🏁 Use Ctrl+Y as the accelerator of redo on Windows
2016-09-18 17:07:34 +09:00
Kevin Sawicki
af607f8b67
🎨 function -> =>
2016-08-08 11:09:30 -07:00
Kevin Sawicki
bcc372568f
Add zoom menu item roles
2016-08-08 11:09:30 -07:00
Milan Burda
edc1a9614c
Add macOS specific speaking roles for MenuItem
2016-08-08 00:02:32 +02:00
Feross Aboukhadijeh
d6a7ced32c
MenuItem: Use 'Close Window' for 'close' role label
...
On OS X, the standard label that's used for the 'close' role is 'Close
Window'. You can see this in the default macOS apps from Apple.
2016-07-25 15:13:17 -07:00
Kevin Sawicki
f9a8bd3ea5
Call role method on focused web contents
2016-07-13 14:16:56 -07:00
Kevin Sawicki
e02cf5905c
Execute command on devtools web contents when focused
2016-07-12 13:24:53 -07:00
Kevin Sawicki
1e0e5b0eff
Use CommandOrControl+Q for quit role on Linux
2016-07-07 09:19:20 -07:00
Kevin Sawicki
c686997209
Ctrl -> Control for consistency
2016-06-22 16:56:45 -07:00
Kevin Sawicki
6165908ba7
Incorporate review feedback
2016-06-22 15:26:17 -07:00
Kevin Sawicki
be642612c0
Export app before requiring modules
2016-06-22 15:21:45 -07:00
Kevin Sawicki
ece319a687
🎨
2016-06-22 14:14:32 -07:00
Kevin Sawicki
30e3a6ed83
Add app require
2016-06-22 13:59:49 -07:00
Kevin Sawicki
66f2fb2fe4
Add execute helper to roles file
2016-06-22 13:48:26 -07:00
Kevin Sawicki
653370974a
🎨 Sort roles alphabetically
2016-06-22 13:15:20 -07:00
Kevin Sawicki
c0562d16d5
Add more role defaults
2016-06-22 13:09:49 -07:00
Kevin Sawicki
888068b597
Add default help/window labels
2016-06-22 13:09:49 -07:00
Kevin Sawicki
13a6d32ee9
Add default label/accelerator to role menu items
2016-06-22 13:09:48 -07:00
Kevin Sawicki
25b2724ab9
Add menu item role defaults
2016-06-22 13:09:48 -07:00
