Electron Bot
504cdb13f0
Bump v8.0.0-nightly.20190904
2019-09-04 08:32:24 -07:00
Cheng Zhao
b601f3a031
chore: remove native_mate (Part 1) ( #20085 )
...
* move Destroyable utilities out of native_mate
* do not set "destroy" in ObjectTemplateBuilder
* remove ObjectTemplateBuilder::MakeDestroyable
* do not pollute gin namespace
* add more comments
* remove hack of Arguments
2019-09-04 11:14:16 +09:00
Cheng Zhao
96b42bddb8
fix: implement ses.getBlobData() for NetworkService ( #20041 )
...
* pass data pipe to JS
* implement reading buffer
* re-enable ses.getBlobData test
* remove AtomBlobReader
2019-09-04 07:54:14 +09:00
Samuel Attard
cc9436f288
chore: add SetGTKDarkThemeEnabled(enabled) internal helper to allow dynamic theme selection on linux ( #19964 )
...
This is just a after-creation setter for the `darkTheme` constructor option. This is delibrately
a method and not a property as there is no getter.
2019-09-03 12:59:48 -07:00
Electron Bot
39475f9404
Bump v8.0.0-nightly.20190903
2019-09-03 08:32:24 -07:00
Electron Bot
614079654c
Bump v8.0.0-nightly.20190902
2019-09-02 08:34:32 -07:00
Electron Bot
51015c5b48
Bump v8.0.0-nightly.20190901
2019-09-01 08:31:00 -07:00
Samuel Attard
c621a36320
fix: ensure that the "top" coordinate of the inner frame is correct ( #20051 )
...
On multi-monitor setups where the monitors are not all origined at 0 on
the Y coordinate (E.g. vertical stacked monitors) the maximize
calculation was incorrect as it assumed top was "0". This instead
adjusts the math to calculate the correct top value.
2019-08-30 15:45:59 -07:00
Electron Bot
e96a042223
Bump v8.0.0-nightly.20190830
2019-08-30 08:32:04 -07:00
Shelley Vohr
5cbbd489d5
fix: honor cursor blink rate ( #20020 )
...
* fix: honor cursor blink rate on macOS
* fix: honor cursor blink rate on Linux
* fix: honor cursor blink rate on Windows
* refactor: clean up os_win cursor blink logic
* remove unneeded include
2019-08-30 09:39:46 -05:00
Samuel Attard
654338693f
fix: Revert "fix: make sure that menu bar gets focus even when you click an item to focus it first ( #19710 )" ( #20019 )
...
This reverts commit 27b2747b61
.
2019-08-29 15:06:39 -07:00
Electron Bot
6b55584923
Bump v8.0.0-nightly.20190829
2019-08-29 08:31:27 -07:00
Alexey Kuzmin
c03288f458
chore: add missing includes ( #20003 )
2019-08-29 15:57:11 +09:00
Jeremy Apthorp
90d62e5b98
fix: nws13n: make ses.setUserAgent work ( #20014 )
...
* refactor tests to better control window creation
* fix: nws13n: make ses.setUserAgent work
2019-08-29 15:50:14 +09:00
Cheng Zhao
b3947d6a83
chore: cache URLLoaderFactory per-session ( #19998 )
...
* cache the URLLoaderFactory in AtomBrowserContext
* use cached loader factory in AtomURLLoaderFactory
2019-08-29 15:07:46 +09:00
Milan Burda
eed72c35d7
feat: add session.downloadURL() ( #19889 )
2019-08-28 20:27:20 -07:00
Milan Burda
01fdb80f7c
refactor: implement isRemoteModuleEnabled via getLastWebPreferences() ( #19220 )
2019-08-28 15:57:03 -07:00
Charles Kerr
217ed9aabc
fix: gtk_init() called 2x in AtomBrowserMainParts ( #19986 )
...
Fixes #19984 .
2019-08-28 12:36:03 -05:00
Electron Bot
3bc5302d78
Bump v8.0.0-nightly.20190828
2019-08-28 08:31:11 -07:00
Charles Kerr
987300c97a
refactor: omit redundant map searches ( #19929 )
...
* refactor: don't walk maps twice to remove elements
* refactor: don't walk maps twice to read elements
* refactor: don't walk maps twice to insert elements
* refactor: don't walk map 3x on UvTaskRunner timeout
* refactor: more don't-walk-maps-twice cleanup
* fixup! refactor: don't walk maps twice to insert elements
* refactor: don't walk containers twice when erasing
* refactor: omit excess lookups in RemoteObjectFreer
2019-08-28 09:39:21 -05:00
Heilig Benedek
27ce6a9cd3
fix: handle WM_GETMINMAXINFO instead of letting chromium do it ( #19928 )
...
* fix: remove WM_GETMINMAXINFO workaround since it's no longer needed
* fix: handle WM_GETMINMAXINFO ourselves
* fix: remove part of the chromium WM_GETMINMAXINFO handler
2019-08-28 09:34:34 +09:00
Marat Abdullin
ae9424d93a
feat: add "accessibleTitle" property to a BrowserWindow instance ( #19698 )
...
Sometimes it's necessary to convey more information about the window to screen reader users only (simply putting everything to the window title might be unnecessarily noisy).
For example, Chromium uses that technique to tell screen reader users that the window is in incognito mode (the incognito window looks differently and doesn't have «incognito» in the title, but for blind users the screen reader will announce that it's incognito).
2019-08-28 00:35:34 +02:00
Jeremy Apthorp
1dcda7b809
chore: DCHECK for correct thread in EventEmitter::EmitWithSender ( #19959 )
2019-08-27 15:15:52 -07:00
Jeremy Apthorp
4b8e1588b4
fix: remove unused header from extensions-only file ( #19947 )
2019-08-27 10:59:22 -07:00
Cheng Zhao
4eee71ffbf
feat: migrate webRequest module to NetworkService (Part 9) ( #19976 )
...
* no need to get WebContents for URLLoaderFactory
* consult embedder for network_factory created in net module
* set disable_web_security to false
* re-enable webRequest tests in net module
2019-08-27 09:12:33 -07:00
Electron Bot
bdb20d53cb
Bump v8.0.0-nightly.20190827
2019-08-27 08:31:13 -07:00
Charles Kerr
7e61cd0dfb
fix: i18n of gtk msgbox buttons ( #19904 )
...
* fix: i18n of gtk msgbox buttons
similar to #19756 (12df0e8
) but for messageboxes
* refactor: DRY the gtk+ button mnemonics
* fix: don't compile gtk_util on non-Linux platforms
rename from `gtk_util.[cc,h]` to `util_gtk.[cc,h]` so that it gets
picked up by the `extra_source_filters` rule in `BUILD.gn`.
* fix: make linter happy
It really shows that I cannot build locally atm... :P
2019-08-27 09:57:12 -05:00
Samuel Attard
4e809f0048
fix: ensure that reloads retain modified window background colors ( #19967 )
2019-08-26 23:14:23 -07:00
Heilig Benedek
d04072d1eb
fix: don't call SetBounds on restore ( #19886 )
2019-08-26 14:04:20 -07:00
Kuts Alexey
cddbddc543
feat: HTTP preconnect feature minimal for electronjs ( #18671 )
2019-08-26 09:47:32 -07:00
Electron Bot
c57db7f163
Bump v8.0.0-nightly.20190826
2019-08-26 08:32:02 -07:00
Milan Burda
94c6b256de
refactor: simplify ShowSaveDialog, make consistent with ShowOpenDialog ( #19924 )
2019-08-26 13:12:09 +02:00
Heilig Benedek
f6c523db13
fix: adjust window size in NCCALCSIZE instead of adding insets ( #19883 )
2019-08-26 10:03:57 +09:00
Charles Kerr
080fdb3817
fix: command-line scheme switch values' spillover ( #19912 )
...
* fix: command-line scheme switch values' spillover
The value of one of the scheme command-line switches
shouldn't spill over into other switches.
Fixes #19911
* chore: make linter happy
2019-08-26 09:40:44 +09:00
Electron Bot
1eda92859f
Bump v8.0.0-nightly.20190825
2019-08-25 08:31:03 -07:00
Electron Bot
f54bc1cb2e
Bump v8.0.0-nightly.20190824
2019-08-24 08:31:28 -07:00
Electron Bot
b7d25ccb77
chore: bump chromium to 62327c655093c821aa0fcfc6db53f5fd943e08c7 (master) ( #19792 )
...
* chore: bump chromium in DEPS to f3bf493731e868e1f5f48e7e1adc02ea5eccfbbd
* chore: bump chromium in DEPS to 4db0c87d4aa6f27ffa0b5fc77d20e10047962484
* chore: bump chromium in DEPS to d933a504c264dc8fe85267f47aef3588531875b5
* chore: bump chromium in DEPS to 34afdb68980f581ae911b85b727bc17e126cf5f9
* update disable-redraw-lock.patch
https://chromium-review.googlesource.com/c/chromium/src/+/1600387
* update desktop_media_list.patch
https://chromium-review.googlesource.com/c/chromium/src/+/1729156
* update notification_provenance.patch
https://chromium-review.googlesource.com/c/chromium/src/+/1742779
* update printing.patch
https://chromium-review.googlesource.com/c/chromium/src/+/1646772
* update verbose_generate_bpad_syms.patch
https://chromium-review.googlesource.com/c/chromium/src/+/1745986
* update patch metadata
* remove printing_compositor manifests
https://chromium-review.googlesource.com/c/chromium/src/+/1742734
* update for URLLoaderFactoryType enum
https://chromium-review.googlesource.com/c/chromium/src/+/1754716
* remove gin string16 converter
https://chromium-review.googlesource.com/c/chromium/src/+/1750093
* ClearCompositorFrame() has been removed
https://chromium-review.googlesource.com/c/chromium/src/+/1746301
* message_loop -> message_loop_current
https://chromium-review.googlesource.com/c/chromium/src/+/1738552
* include resource_response header
* pdf compositor no longer uses service manager
https://chromium-review.googlesource.com/c/chromium/src/+/1742734
* chore: bump chromium in DEPS to 00d5933101d8d8dc9546eadbe7ee1b41077e6db1
* pane focus fns aren't pure virtual anymore
https://chromium-review.googlesource.com/c/chromium/src/+/1708767
* fix: make std::hash value-non-const
broken by https://chromium-review.googlesource.com/c/chromium/src/+/1711202
* update swiftshader in zip_manifests
https://swiftshader-review.googlesource.com/c/SwiftShader/+/34911
* address feedback from @deepak1556
* don't enable kLegacyWindowsDWriteFontFallback
https://chromium-review.googlesource.com/c/chromium/src/+/1753006
* chore: bump chromium in DEPS to 84497314005e1968da06804f8fde539d9872310e
* update printing.patch
remove bottom diff owing to https://chromium-review.googlesource.com/c/chromium/src/+/1678182 and update for https://chromium-review.googlesource.com/c/chromium/src/+/1678182
* convert CookieChangeListener to new Mojo types
https://chromium-review.googlesource.com/c/chromium/src/+/1753371
* rename ui::ClipboardType -> ui::ClipboardBuffer
https://chromium-review.googlesource.com/c/chromium/src/+/1758730
* logging::LoggingSettings log_file -> log_file_path
https://chromium-review.googlesource.com/c/chromium/src/+/1699477
* roll DEPS to latest lkgr
* fix: override GetFontLookupTableCacheDir()
When Chromium goes to use its fallback font table creation code paths,
it creates the cache directory it uses by calling
GetFontLookupTableCacheDir() with a path that doesn't exist in Electron.
To ensure that a legitimate file path is created, we need to override it
with Electron's DIR_USER_DATA so it doesn't use chrome::DIR_USER_DATA.
* chore: bump chromium in DEPS to 6758a0879931bc4df630a80a36c82d7855ae3155
* update pthread_fchdir patch
https://chromium-review.googlesource.com/c/chromium/src/+/1759149
* update printing patch
* update cookie usage and fn signatures
https://chromium-review.googlesource.com/c/chromium/src/+/1758437
* chore: bump chromium in DEPS to bdaca97e1cc27fb977e56f30f74cdb906da9527e
* remove fix_make_std_hash_value-non-const.patch
https://chromium-review.googlesource.com/c/chromium/src/+/1762335
* Convert enum to enum class for FocusManager::FocusChangeReason
https://chromium-review.googlesource.com/c/chromium/src/+/1767281
* roll DEPS to latest lkgr
* update dom_storage_limits.patch
https://chromium-review.googlesource.com/c/chromium/src/+/1767556
2019-08-23 18:14:23 -07:00
Shelley Vohr
c89debd19a
refactor: use Error util when only throwing errors ( #19837 )
2019-08-23 15:49:54 -07:00
Milan Burda
81e9dab52f
refactor: replace ipcRendererUtils.invoke() with ipcRendererInternal.invoke() ( #19574 )
2019-08-23 15:45:50 -07:00
Shelley Vohr
698120daf0
fix: crash on input file handler dialog ( #19897 )
...
* fix: crash on input file handler dialog
* invert cancellation logic
2019-08-23 14:18:30 -07:00
Electron Bot
6144408f3a
Bump v8.0.0-nightly.20190823
2019-08-23 08:31:55 -07:00
Samuel Attard
6a3922d330
refactor: make util::Promise type safe when chaining in native ( #19809 )
...
* refactor: make util::Promise type safe when chaining in native
* fixup! refactor: make util::Promise type safe when chaining in native
* chore: remove spare brackets
2019-08-22 17:03:28 -07:00
Cheng Zhao
ab0bf6d238
fix: notify views of content view size change ( #19878 )
2019-08-22 14:16:56 -07:00
Electron Bot
268094e0ef
Bump v8.0.0-nightly.20190822
2019-08-22 08:31:04 -07:00
Heilig Benedek
9ccd6aa0dd
feat: enable picture-in-picture mode for video tags ( #17686 )
...
* feat: enable picture in picture mode for video tags
* test: add test to verify picture in picture support
* lint: fix indent
* fix: clean up after rebase
* test: update test with 16:9 test video
* fix: .paches after rebase
2019-08-22 19:17:50 +09:00
John Kleinschmidt
46b6bcd99b
chore: Update comment for desktop_capturer ( #19848 )
...
* chore: Update comment for desktop_capturer
* Guard TopLevelWindow::MoveAbove with ENABLE_DESKTOP_CAPTURER
* Fix lint errors
2019-08-21 15:16:43 -07:00
Shelley Vohr
5e525b3e0f
fix: add default media usage strings to info.plist ( #19871 )
2019-08-21 13:14:25 -07:00
Electron Bot
3bd829aee0
Bump v8.0.0-nightly.20190821
2019-08-21 08:31:24 -07:00
Heilig Benedek
3f49f984e6
fix: race condition in NodeStreamLoader ( #19811 )
...
* fix: race condition in NodeStreamLoader
* nit: add comments
2019-08-21 12:23:46 +09:00
Cheng Zhao
b7defaaf6a
feat: migrate webRequest module to NetworkService (Part 8) ( #19841 )
...
* fix: fill uploadData property
* fix: requestHeaders in onBeforeSendHeaders
* fix: responseHeaders in onHeadersReceived
* fix: header keys should not be lowercased
* fix: gin::Dictionary::Get succeeds even though key does not exist...
* fix: throw for invalid filters
* test: re-enable api-web-request-spec
* chore: do not use deprecated base::Value API
2019-08-21 11:14:21 +09:00
Electron Bot
a4c0f26f06
Bump v8.0.0-nightly.20190820
2019-08-20 08:32:09 -07:00
Erick Zhao
145b4fae94
feat: implement will-move
event on macOS ( #19641 )
2019-08-20 07:53:43 -07:00
Cheng Zhao
cd1b15a155
feat: migrate webRequest module to NetworkService (Part 7) ( #19820 )
...
* fix: gin treats Function as Dictionary when doing convertions
* fix: check if listener exists
* fix: listener callback should be executed in next tick
* feat: make InProgressRequest work
* test: re-enable protocol test that relies on webRequest
* chore: merge conditions
2019-08-20 20:46:20 +09:00
Shelley Vohr
1dc02e6dbc
fix: fall back to default logs path in getPath('logs') ( #19653 )
2019-08-19 15:16:00 -07:00
Heilig Benedek
b33558d822
refactor: mojofy autofill renderer->browser ( #18760 )
...
* re-implement renderer->browser calls with mojo
* lint
* fix: clean up after rebase
* lint
* fix: lazy load autofill drivers
2019-08-19 13:13:24 -07:00
Shelley Vohr
43e6d7fe88
chore: add error throwing utility ( #19803 )
...
* chore: add error throwing utility
* feedback from review
* DRY out repeated isolate calls
2019-08-19 09:10:18 -07:00
Electron Bot
8f1c51eaea
Bump v8.0.0-nightly.20190819
2019-08-19 08:32:31 -07:00
Electron Bot
090786b037
Bump v8.0.0-nightly.20190818
2019-08-18 08:31:14 -07:00
Electron Bot
dba3927b4e
Bump v8.0.0-nightly.20190817
2019-08-17 08:31:36 -07:00
Electron Bot
2c002a3342
Bump v8.0.0-nightly.20190816
2019-08-16 08:32:35 -07:00
Cheng Zhao
2595cb5698
fix: compilation failure after chromium upgrade ( #19787 )
2019-08-16 07:55:34 -07:00
Cheng Zhao
c3bb73a711
feat: migrate webRequest module to NetworkService (Part 6) ( #19752 )
...
* Implement OnBeforeSendHeaders
* Pass the request
* Handle simple listeners
* Handle response listeners
* Read responses from listener
2019-08-16 10:19:05 +09:00
Electron Bot
db21391156
chore: bump chromium to cbeb16cf544f79c1990f1eae4d4fe (master) ( #19610 )
...
Co-authored-by: Erick Zhao <erickzhao@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by Micha Hanselmann <DeerMichel@github.com>
2019-08-15 13:50:58 -07:00
Shelley Vohr
12df0e8994
fix: use GTK3 stock i18n strings ( #19756 )
2019-08-15 10:31:07 -07:00
Electron Bot
ca0cf5415e
Bump v8.0.0-nightly.20190815
2019-08-15 08:31:20 -07:00
Julien Isorce
680399f476
feat: Implement BrowserWindow.getMediaSourceId() and BrowserWindow.moveAbove(mediaSourceId) ( #18926 )
...
* feat: Implement BrowserWindow.moveAbove(mediaSourceId)
BrowserWindow.{focus,blur,moveTop}() are not enough in some
situations. For example when implementing an overlay that
follows another window that can lose focus. In that case
it is useful to move the overlay above the tracked window.
sourceId is a string in the format of DesktopCapturerSource.id,
for example "window:1869:0".
Notes: Added BrowserWindow.moveAbove(mediaSourceId)
https://github.com/electron/electron/issues/18922
* feat: Implement BrowserWindow.getMediaSourceId
Return the Window id in the format of DesktopCapturerSource's id.
For example "window🔢 0".
https://github.com/electron/electron/issues/16460
Notes: Added BrowserWindow.getMediaSourceId
2019-08-15 15:51:15 +09:00
Micha Hanselmann
d0c7a91a50
move image converter to gin ( #19655 )
2019-08-15 11:18:34 +09:00
Heilig Benedek
27b2747b61
fix: make sure that menu bar gets focus even when you click an item to focus it first ( #19710 )
2019-08-14 18:11:41 -07:00
Samuel Attard
efa1818cb4
feat: add new nativeTheme API ( #19656 )
...
* feat: add new nativeTheme API
* chore: deprecate and clean up old systemPreferences theme APIs in favor of new nativeTheme module
* chore: clean up and deprecate things per feedback
* chore: add tests for deprecate and clean up invert impl
* build: when is a boolean not a boolean???
2019-08-14 13:42:55 -07:00
Electron Bot
246187a20f
Bump v8.0.0-nightly.20190814
2019-08-14 08:31:05 -07:00
Micha Hanselmann
4c54cfc692
move net converter to gin ( #19734 )
2019-08-14 14:15:34 +09:00
Erick Zhao
5d892a557f
fix: proper l10n on Linux dialog buttons ( #19725 )
...
* fix: proper l10n on linux dialog
* switch string
2019-08-13 20:22:25 -07:00
Shelley Vohr
28466a39d8
feat: add property customization to save dialogs ( #19672 )
2019-08-13 13:40:07 -07:00
Shelley Vohr
e1824c00a9
feat: macOS removal fallback when moveItemToTrash fails ( #19700 )
...
* feat: macOS removal fallback when moveItemToTrash fails
* platform_util shouldn't know about mate::Arguments
* pull full_path from args as well
2019-08-13 12:31:53 -07:00
Shelley Vohr
b5798326e8
feat: add dontAddToRecent to windows showOpenDialog ( #19669 )
2019-08-13 08:48:22 -07:00
Electron Bot
fee84de782
Bump v8.0.0-nightly.20190813
2019-08-13 08:33:27 -07:00
Micha Hanselmann
ba5ee79af8
move file dialog converter to gin ( #19709 )
2019-08-13 14:49:48 +09:00
Cheng Zhao
69eac0d9d2
feat: migrate webRequest module to NetworkService (Part 5) ( #19714 )
...
* Pass WebRequest to ProxyingURLLoaderFactory
* Call WebRequestAPI in InProgressRequest
* Store the listeners
* Pass the request and response
* Add stub to handle the events
* Use extensions::WebRequestInfo
* Make sure webRequest is managed by Session
* chore: make creation of WebRequestNS more clear
* fix: check WebContents for service workers
2019-08-13 14:47:35 +09:00
Erick Zhao
f654da9f56
feat: add about panel customization on Windows ( #19420 )
2019-08-12 16:32:51 -07:00
Cheng Zhao
04dbd5c53f
fix: don't handle browser messages before document element is created ( #19718 )
...
* fix: don't handle browser messages before document element is created
* fix: bind ElectronApiServiceImpl later
DidCreateDocumentElement is called before the ElectronApiServiceImpl
gets bound.
* chore: add comment
2019-08-12 10:38:41 -07:00
Electron Bot
398c5d553d
Bump v8.0.0-nightly.20190812
2019-08-12 08:32:19 -07:00
Electron Bot
39f0bd3e82
Bump v8.0.0-nightly.20190811
2019-08-11 08:31:23 -07:00
Cheng Zhao
2dffc9f6eb
feat: migrate webRequest module to NetworkService (Part 4) ( #19679 )
...
* chore: use gin in WebRequest
* Add stubs for APIs
2019-08-11 13:24:51 +09:00
Electron Bot
bc0a2d1b28
Bump v8.0.0-nightly.20190810
2019-08-10 08:31:20 -07:00
Erick Zhao
1749af9707
fix: avoid losing focus on inputs when opening menu (Windows/Linux) ( #19657 )
...
* remove cause of issue
* remove comment
2019-08-09 14:10:11 -07:00
Micha Hanselmann
57507ca37c
refactor: move native window gin converter ( #19577 )
...
* move native window gin converter
* extract to new file
2019-08-09 13:43:18 -07:00
Shelley Vohr
7861e9f728
feat: allow customization of print page header and footer ( #19688 )
...
* feat: allow customization of more print settings
* address feedback from @jkleinsc
* header and footer are optional
2019-08-09 13:16:25 -07:00
Electron Bot
84cbc1d6c0
Bump v8.0.0-nightly.20190809
2019-08-09 08:32:09 -07:00
Milan Burda
03debb4ef9
feat: add tray.focus() ( #19548 )
2019-08-09 07:43:48 -07:00
Milan Burda
0fb3c8cb7c
feat: add new options to tray.displayBalloon() ( #19544 )
2019-08-08 14:43:33 -07:00
Pedro Pontes
da29ce355f
fix: always use new site instance for a new navigation. ( #18860 )
2019-08-08 11:48:33 -07:00
Electron Bot
7a9e6659f0
Bump v8.0.0-nightly.20190808
2019-08-08 08:32:04 -07:00
Micha Hanselmann
9eb89b4ac7
fix: return correct bounds on will-resize ( #19639 )
2019-08-07 19:58:56 -07:00
Electron Bot
67169a5d0c
Bump v8.0.0-nightly.20190807
2019-08-07 08:31:14 -07:00
Robo
eebea63bed
chore: remove pre network service classes from shell/browser/net ( #19644 )
...
* refactor: rm IOThread class
* chore: rm expose-net-observer-api.patch
* chore: rm unused shell/browser/net/ classes
* chore: mv CertVerifierClient to separate header
* chore: rm url_request_context_getter references
2019-08-07 11:04:09 -04:00
Shelley Vohr
9c7a216814
fix: crash on print cancellation and silent print settings ( #19598 )
...
* fix: crash on print cancellation
* fix: update printing patch for new options
* refactor: use DictionaryValue for printBackground
2019-08-07 10:47:24 -04:00
Micha Hanselmann
a8861e6a66
move gurl converter to gin ( #19578 )
2019-08-07 16:18:26 +09:00
Erick Zhao
8a9a5d69b6
fix: normalize behavior of win.setOpacity()
for invalid number values across operating systems ( #19535 )
...
* fix: define behavior for out-of-bounds setOpacity
* fix linux issue
* fix getOpacity behaviour
* wrong variable
* normalize more stuff
* docs
* test: use ifdescribe helper
* Update spec-main/api-browser-window-spec.ts
Co-Authored-By: Charles Kerr <ckerr@github.com>
* fixes
* more tests!!!
* Update shell/browser/native_window_views.cc
Co-Authored-By: Charles Kerr <ckerr@github.com>
* Update shell/browser/native_window_mac.mm
Co-Authored-By: Charles Kerr <ckerr@github.com>
2019-08-07 16:17:32 +09:00
Cheng Zhao
761a4deab3
feat: associate InProgressRequest with requests ( #19648 )
2019-08-07 09:21:53 +09:00
CezaryKulakowski
50cc54e50b
fix: keep references to active menus created by api Menu ( #19427 )
...
Without this such menus would be destroyed by js garbage collector even
when they are still displayed.
2019-08-06 14:55:00 -07:00