mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
21883 commits 1 branch 410 tags 2.1 GiB
Commit graph

43 commits

Author SHA1 Message Date
Samuel Attard
fde3137b90
 		fix: update the FileSelectHelper to support the new promise API (#18288) 
* fix: update the FileSelectHelper to support the new promise API

Fixes #18254

So it turns out we've successfully introduced a way to write
non-typesafe C++.

This fixes two things:
* Uses the object the promise resolves
* Ensures we attach the Then handler before moving the promise

* fix: also fix misuse of Promise::Then in the download manager
 2019-05-14 15:46:53 -07:00
Shelley Vohr
cc00fa8874 chore: convert base::Bind instances across some files (#18112) 2019-05-03 08:49:26 +09:00
Shelley Vohr
82a076855b fix: incorrect default path setting for dl items (#17773) 2019-04-15 14:11:20 -04:00
Shelley Vohr
6cb7b8d3a4
 		feat: promisify dialog.showSaveDialog() (#17054) 
* feat: promisify dialog.showSaveDialog()

* address some feedback from review

* filename => filePath

* fix last filename => filePath
 2019-03-05 13:48:20 -08:00
Birunthan Mohanathas
6c77c220f7 chore: Fix typo in AtomDownloadManagerDelegate::OnDownloadSaveDialogDone (#16646) 
I believe the existing code was fine, but better be safe than sorry.
This typo was introduced in #16612.
 2019-01-31 20:18:20 +09:00
Birunthan Mohanathas
927aac306f fix: use async save dialog for anchor download attribute (#16612) 2019-01-31 11:06:55 +09:00
deepak1556
321f87fe61 Complete TaskPriority::BACKGROUND->BEST_EFFORT mass rename 
https://chromium-review.googlesource.com/c/chromium/src/+/1153461
 2018-12-03 20:07:40 +05:30
Samuel Attard
c9007557e5 chore: post_task and friends now live under base/task 
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1161088
 2018-12-03 20:07:38 +05:30
Heilig Benedek
ca2d74e118 feat: add methods to allow customization of save dialog during will-download event (#15497) 
* feat: add method to DownloadItem that allows customization of dialog options

* docs: add docs for get/setSaveDialogOptions

* add missing copy constructor for DialogSettings on mac and linux

* fix: don't filter dialog options for mas build, don't return properties

* test: add test for get/setSaveDialogOptions

* fix: remove openDevtools added for debugging

* test: fix failing test because of new event parameter

* docs: use SaveDialogOptions instead of Object
 2018-11-08 10:51:06 -04:00
Jeremy Apthorp
34e54b93a4 Remove WebContentsUserData::kLocatorKey 
https://chromium-review.googlesource.com/c/chromium/src/+/1093015
 2018-10-09 14:38:00 -07:00
Aleksei Kuzmin
7fc3bcaa02 chore: run clang-format 
- atom/
 - brightray/
 - chromium_src/
 2018-09-19 17:18:10 +02:00
Aleksei Kuzmin
160b165358 move DownloadInterruptReasons from content/ to components/download 
https://chromium-review.googlesource.com/897967
 2018-06-19 11:49:40 +10:00
Aleksei Kuzmin
7fc8814d13 move some files from content/public/browser to components/download/public/core 
https://chromium-review.googlesource.com/891686
 2018-06-19 11:49:40 +10:00
Aleksei Kuzmin
4e580d5b39 Move download_item.h from content/public to components/download 
https://chromium-review.googlesource.com/907687
 2018-06-19 11:49:40 +10:00
deepak1556
e3c580e905 Move away from BrowserThread::FILE 
* Migrate TtsPlatformImplLinux away from using BrowserThread::FILE.
  https://chromium-review.googlesource.com/c/chromium/src/+/570022
* Move PdfConverter off the FILE thread.
  https://chromium-review.googlesource.com/c/chromium/src/+/592393
* https://chromium.googlesource.com/chromium/src/+/master/docs/task_scheduler_migration.md
 2018-06-19 11:49:40 +10:00
Milan Burda
45e78728bd chore: move more constants to options_switches.h/cc (#13093) 
* Add options::kNativeWindowOpen

* Add options::kSandbox

* Add options::kPlugins

* Add options::kWebSecurity

* Add options::kAllowRunningInsecureContent

* Add options::kOffscreen
 2018-05-29 03:09:51 -05:00
Robo
ff571f3b5d Part I: Move from base::Bind to base::BindOnce and remove unneeded base::Passed (#12661) 2018-04-20 19:55:05 +09:00
Jeremy Apthorp
a635f078c6 [chromium-style] auto variable type must not deduce to a raw pointer type 2018-04-19 11:10:52 -07:00
Shelley Vohr
c6f4bbd143
 		also format missing .cc files 2018-04-18 20:48:45 -04:00
Cheng Zhao
8fc5c6c862
 		Refactor NativeWindow (Part 3): Remove is_offscreen_dummy from NativeWindow (#12503) 
* Don't use is_offscreen_dummy in MessageBox

* Don't use is_offscreen_dummy in DownloadManagerDelegate

* Don't use is_offscreen_dummy in CommonWebContentsDelegate

* Remove is_offscreen_dummy from NativeWindow
 2018-04-03 12:19:35 +09:00
deepak1556
a518c5c3c4 derefence weak ptr only on the same sequence runner it was created in 2018-01-02 16:37:06 +09:00
Cheng Zhao
7e0593950c Code style fixes 2017-11-13 16:13:54 +09:00
Heilig Benedek
f8b3009ebf restructure code to use web_preferences if possible 2017-11-13 15:50:49 +09:00
Aleksei Kuzmin
0adc887b32 [downloads] Allow download target determination to indicate an error. 
https://chromium-review.googlesource.com/c/465526/
 2017-08-15 16:19:20 +03:00
Kevin Sawicki
867bb5a94e Add DialogSettings helper struct 2017-02-09 10:13:11 -08:00
deepak1556
94faaf7d58 provide a default file name for downloads 2016-09-16 16:02:57 +05:30
Kevin Sawicki
6285500cdc Sort includes alphabetically 2016-08-26 15:30:02 -07:00
Kevin Sawicki
cf93e3e713 Check download item save path before prompting 2016-08-25 14:34:48 -07:00
Kevin Sawicki
0ad8c66b65 Use selected dialog path as item save path 2016-07-27 17:31:26 -07:00
Ben Gotow
84cce6c2c1 Don't default to "Open", "Save", just let OS decide 2016-05-15 01:03:32 -05:00
Ben Gotow
40c531737d Add buttonLabel param to showOpen/showSave dialogs 2016-05-15 01:03:32 -05:00
Brian R. Bondy
2da39d31aa Update to new pref service location in components 2016-05-13 11:07:17 +09:00
deepak1556
46208b5b3e session: dont attach download dialog to deleted webContents window 2016-04-27 20:00:31 +05:30
Paul Betts
4503aafe64 int32 => int32_t 2016-03-10 17:06:21 +09:00
Cheng Zhao
50d69fd9bb Get rid of SavePathData 2016-02-02 20:11:39 +08:00
Robo
c14dd71df1 browser: change location of default download dir 2016-01-21 13:51:37 +05:30
Haojian Wu
0861d5d44b Redefine 'will-download' design. 2015-09-24 16:04:44 +08:00
Haojian Wu
22168bc6d8 Allow emitting 'done' event when user cancel the download saving dialog. 2015-09-21 21:44:18 +08:00
Haojian Wu
87b9b0bc31 Implement session.setOpenDownloadDialog() API. 2015-09-20 18:45:34 +08:00
Haojian Wu
877830e4a1 No need for default_download_path_ member. 2015-07-29 14:04:14 +08:00
Haojian Wu
fef53d18c4 Add session.setDownloadPath API. 2015-07-26 16:51:27 +08:00
Cheng Zhao
2bfa9da82e Store NativeWindow's weak ptr in WebContents 2015-06-24 22:14:46 +08:00
deepak1556
8f429bc25a browser: creating download manager delegate to handle downloads 2015-06-23 17:54:07 +05:30