Athul Iddya
905e41bbdd
fix: use StartUpdating method for PipeWire capturer ( #38833 )
...
* fix: use StartUpdating method for PipeWire capturer
Fixed a crash related to PipeWire capturer by adapting to Chromium's
interface changes. Chromium expects a call to
`NativeDesktopMediaList::StartUpdating` with an implementation of
`DesktopMediaListObserver` for delegated capturers like PipeWire. This
interface allows listening to user permission events and listing
sources only after the user has made a choice on the permission dialog.
The interface has been implemented by an inner class to allow listening
to screen and window capture permissions concurrently using two
instances of the class. A patch that was resetting the capturer on the
first refresh has been changed to exclude PipeWire. PipeWire capturer
object will follow the lifecycle of `NativeDesktopMediaList`, as is the
case in Chromium.
Fixes #37463
* fix: wait for thumbnails from PipeWire when necessary
The PipeWire stream starts after the dialog is dismissed. If the sources
are listed immediately afterwards, the thumbnail may not have been
generated by that time. Explicitly wait for both thumbnail generation
and a selection on the source dialog before listing sources.
2023-07-11 10:21:11 +02:00
electron-roller[bot]
16f459228b
chore: bump chromium to 108.0.5329.0 (main) ( #35628 )
...
Co-authored-by: Samuel Attard <sattard@salesforce.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2022-10-03 13:21:00 -07:00
electron-roller[bot]
b0036ea43a
chore: bump chromium to 107.0.5286.0 (main) ( #35590 )
...
* chore: bump chromium in DEPS to 107.0.5286.0
* 3866335: media: Rename KeySystemProperties to KeySystemInfo - file renaming
https://chromium-review.googlesource.com/c/chromium/src/+/3866335
* 3864686: [PA] Introduce *Scan buildflag
https://chromium-review.googlesource.com/c/chromium/src/+/3864686
* chore: fixup patch indices
* 3849359: Remove unused PrefValueStore::Delegate
https://chromium-review.googlesource.com/c/chromium/src/+/3849359
* 3873005: [CodeHealth] Modernising extensions Tab utils
https://chromium-review.googlesource.com/c/chromium/src/+/3873005
* 3846595: Auto-select PipeWire target once selection is made
https://chromium-review.googlesource.com/c/chromium/src/+/3846595
* 3826169: [json-schema-compiler] Support abs::optional<bool>
https://chromium-review.googlesource.com/c/chromium/src/+/3826169
* fixup! Remove unused PrefValueStore::Delegate
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2022-09-08 16:23:08 -07:00
David Sanders
5d120359f6
chore: used nested namespaces ( #34737 )
2022-06-29 12:55:47 -07:00
electron-roller[bot]
28ada6ea8b
chore: bump chromium to 100.0.4857.0 (main) ( #32419 )
...
* chore: bump chromium in DEPS to 99.0.4819.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4824.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4827.0
* chore: update patches
* 3352511: PiP: Add inkdrop and pointer cursor to PiP window buttons
https://chromium-review.googlesource.com/c/chromium/src/+/3352511
* 3309164: webhid: Show FIDO devices in the chooser if allowed
https://chromium-review.googlesource.com/c/chromium/src/+/3309164
* 3297868: hid: Add experimental HIDDevice.forget()
https://chromium-review.googlesource.com/c/chromium/src/+/3297868
* 3362491: [Extensions] Move i18n API to //extensions
https://chromium-review.googlesource.com/c/chromium/src/+/3362491
* MCC Refactor step0: Allow embedders to register associated_interface binders with RenderFrameHostImpl::associated_registry_.
https://chromium-review.googlesource.com/c/chromium/src/+/3281481
* 3352616: [Gtk] Remove libgtk from the link-line
https://chromium-review.googlesource.com/c/chromium/src/+/3352616
* 3249211: Clear-Site-Data support for partitioned cookies
https://chromium-review.googlesource.com/c/chromium/src/+/3249211
* [Extensions][COIL] Use [allow|block]list in //extensions/common
https://chromium-review.googlesource.com/c/chromium/src/+/3372668
* Begin ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3376154
* [Code Health] Refactor PrefService GetDict + GetList to use base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3343526
* 3354997: [CodeHealth] Remove deprecated SetDictionary method
https://chromium-review.googlesource.com/c/chromium/src/+/3354997
* 3287323: Add LacrosPrefStore for lacros settings
https://chromium-review.googlesource.com/c/chromium/src/+/3287323
* 3365916: [PA] Clean up remaining lazy commit code
https://chromium-review.googlesource.com/c/chromium/src/+/3365916
* [MPArch] Target the external protocol error at the responsible frame.
https://chromium-review.googlesource.com/c/chromium/src/+/3011560
* Pass origin to RegisterNonNetworkSubresourceURLLoaderFactories
https://chromium-review.googlesource.com/c/chromium/src/+/3350608
* Linux: Send OSCrypt raw encryption key to the Network Service
https://chromium-review.googlesource.com/c/chromium/src/+/3320484
* [PlzServiceWorker] Remove remaining references to PlzServiceWorker.
https://chromium-review.googlesource.com/c/chromium/src/+/3359441
* chore: fixup for lint
* 3327621: Fix tablet mode detection for Win 11.
https://chromium-review.googlesource.com/c/chromium/src/+/3327621
* 3342428: ax_mac: move AXTextMarker conversion utils under ui umbrella
https://chromium-review.googlesource.com/c/chromium/src/+/3342428
* 3353974: Mac: Use base::Feature for overlay features
https://chromium-review.googlesource.com/c/chromium/src/+/3353974
* chore: bump chromium in DEPS to 99.0.4828.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4837.0
* chore: update patches
* chore: update patches
* 3379142: Drop FALLTHROUGH macro
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3379142
* 3381749: C++17: Allow use of std::map::try_emplace and std::map::insert_or_assign
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3381749
* chore: bump chromium in DEPS to 99.0.4839.0
* chore: update patches
* chore: bump chromium in DEPS to 99.0.4840.0
* chore: bump chromium in DEPS to 99.0.4844.0
* 3395881: [api] Deprecate Local<v8::Context> v8::Object::CreationContext()
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3395881
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4845.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4847.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4849.0
* chore: update patches
* chore: bump chromium in DEPS to 100.0.4851.0
* chore: bump chromium in DEPS to 100.0.4853.0
* update patches
* chore: update patches
* update patches
* 3383599: Fonts Access: Remove prototype that uses a font picker.
https://chromium-review.googlesource.com/c/chromium/src/+/3383599
* 3404768: Remove ALLOW_UNUSED macros
https://chromium-review.googlesource.com/c/chromium/src/+/3404768
* 3374762: Remove ignore_result.h
https://chromium-review.googlesource.com/c/chromium/src/+/3374762
* 3399305: [unseasoned-pdf] Apply proper frame offsets for touch selections
https://chromium-review.googlesource.com/c/chromium/src/+/3399305
* 3402210: [Extensions] Don't trigger unload event for already unloaded extension
https://chromium-review.googlesource.com/c/chromium/src/+/3402210
* 3410912: Combine URLLoaderClient OnReceiveResponse and OnStartLoadingResponseBody.
https://chromium-review.googlesource.com/c/chromium/src/+/3410912
* 3370428: Make the AuthSchemes policy support dynamic refresh
https://chromium-review.googlesource.com/c/chromium/src/+/3370428
* 3407603: Finish ScopedUserPrefUpdate migration to modern base::Value
https://chromium-review.googlesource.com/c/chromium/src/+/3407603
* 3378352: ozone/x11: move code from //ui/p/x11 to //ui/ozone/p/x11
https://chromium-review.googlesource.com/c/chromium/src/+/3378352
* 3370810: Delete chrome/service, AKA the Cloud Print service process.
https://chromium-review.googlesource.com/c/chromium/src/+/3370810
* chore: bump chromium in DEPS to 100.0.4855.0
* chore: update patches
* fixup! 3370810: Delete chrome/service, AKA the Cloud Print service process.
* revert 3348007 to fix windows build
* 3318572: [Code health] Fix gn check errors in //extensions/browser:*
https://chromium-review.googlesource.com/c/chromium/src/+/3318572
* fix printing.patch
* fix iwyu issue
* 3408515: win: Make ShorcutOperation an enum class and modernize names
https://chromium-review.googlesource.com/c/chromium/src/+/3408515
* 3388333: [UIA] Remove dead code accessibility_misc_utils.h/cc
https://chromium-review.googlesource.com/c/chromium/src/+/3388333
* fix windows build? i hope
* patch gn visibility of //ui/ozone/platform/x11
* missing include base/logging.h
* use BUILDFLAG for USE_NSS_CERTS
https://chromium-review.googlesource.com/c/chromium/src/+/3379123
* defined(OS_*) ==> BUILDFLAG(IS_*)
https://bugs.chromium.org/p/chromium/issues/detail?id=1234043
* fixup! 3404768: Remove ALLOW_UNUSED macros
* another attempt to fix windows build
* temporarily disable the custom scheme service worker test
https://github.com/electron/electron/issues/32664
* fix loading mv3 extensions
not sure what cl broke this unfort.
* fixup! 3404768: Remove ALLOW_UNUSED macros
* patch nan
https://chromium-review.googlesource.com/c/v8/v8/+/3395880
* fix node test
* fix nullptr in FindPdfFrame
* patch perfetto to fix build issue on win-ia32
bc44c3c753
* fix build for linux-x64-testing-no-run-as-node
* fix patch
* skip <webview>.capturePage() test
https://github.com/electron/electron/issues/32705
* test: fix failing tests of focus/blur events of WebContents (#32711 )
* inherit stdio from app module test child processes
this prevents them from timing out due to full stdout buffers
* test to see if we can get better logs on windows ci
* try again for appveyor log things
* skip contentTracing tests on ia32
* ci: disable gpu compositing
* drop applied patch
* fix merge fail
* Revert "ci: disable gpu compositing"
This reverts commit 0344129fcb19ea3e87e06c1110d751f22eba3fec.
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2022-02-09 18:58:52 -08:00
Milan Burda
c4ea33d1bf
chore: add ELECTRON_ prefix to C++ include guards ( #31925 )
2021-11-22 16:34:31 +09:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
electron-roller[bot]
87f7625c5d
chore: bump chromium to 96.0.4664.4 (main) ( #31317 )
...
* chore: bump chromium in DEPS to 96.0.4662.0
* chore: bump chromium in DEPS to 96.0.4663.0
* chore: update patches
* [Extensions] Remove RuntimeData entirely
https://chromium-review.googlesource.com/c/chromium/src/+/3177328
* Make helper macros behave consistently for //content/public UserData types
https://chromium-review.googlesource.com/c/chromium/src/+/3198788
* Enabling sandboxing for the speech recognition service browser tests
https://chromium-review.googlesource.com/c/chromium/src/+/3146090
* [devtools] Add 'RegisterPreference' host binding
https://chromium-review.googlesource.com/c/chromium/src/+/3162281
* [Reland][Extensions]: Add persistAcrossSessions flag (scripting API)
https://chromium-review.googlesource.com/c/chromium/src/+/3175161
* [Bluetooth] Add Passkey prompt dialog for bonding.
https://chromium-review.googlesource.com/c/chromium/src/+/2841104
* Clipboard: Remove ReadImage path in browser
https://chromium-review.googlesource.com/c/chromium/src/+/3194826
* Split printing metafile code into its own target.
https://chromium-review.googlesource.com/c/chromium/src/+/3164925
* Cleanup unused DesktopMediaListObserver params
https://chromium-review.googlesource.com/c/chromium/src/+/3179203
* Remove base::DictionaryValue::GetBinary
https://chromium-review.googlesource.com/c/chromium/src/+/3201974
* Window Placement: change RWHV::GetDisplayList to GetScreenInfos
https://chromium-review.googlesource.com/c/chromium/src/+/3138774
* Add a preview to the Tab Capture picker dialog
https://chromium-review.googlesource.com/c/chromium/src/+/3045268
* Add service-based usage to update print settings
https://chromium-review.googlesource.com/c/chromium/src/+/3155426
* chore: bump chromium in DEPS to 96.0.4664.2
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4664.4
* chore: update patches
* chore: bump chromium in DEPS to 97.0.4666.0
* Revert "chore: bump chromium in DEPS to 97.0.4666.0"
This reverts commit d73caae8ba4b39efc9b3ea4de52685b9c92ef3d0.
* Reland "Block external protocol handler with sandbox."
https://chromium-review.googlesource.com/c/chromium/src/+/3198263
* fixup for lint
* Add CookiePartitionKeychain parameter to CookeManager.GetCookieList.
https://chromium-review.googlesource.com/c/chromium/src/+/3206016
* Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry
https://chromium-review.googlesource.com/c/chromium/src/+/3200392
* fixup Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry
* ozone: //chrome/browser clean up from USE_X11
https://chromium-review.googlesource.com/c/chromium/src/+/3186490
* content: don't load v8 snapshot in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/3183394
* [devtools] Add 'RegisterPreference' host binding
https://chromium-review.googlesource.com/c/chromium/src/+/3162281
* 3186491: Add 'devtools.sync_preferences' preference
https://chromium-review.googlesource.com/c/chromium/src/+/3186491
* 2951147: DCHECK accessible names for focusable Views
https://chromium-review.googlesource.com/c/chromium/src/+/2951147
* 3201014: Use real font size for calculation of SmallTextRatio
https://chromium-review.googlesource.com/c/chromium/src/+/3201014
* fixup Clipboard: Remove ReadImage path in browser
* chore: update patches
* fix: disable PlzServiceWorker to fix custom protocol SW script loading
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3199761
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-10-21 11:51:36 -07:00
Jeremy Rose
1dcb8a370e
refactor: simplify desktop_capturer patch ( #30685 )
2021-09-03 16:37:36 -07:00
Samuel Maddock
4057e6b56e
fix: DesktopCapturer gc'd prior to capture completion ( #28273 )
...
desktopCapture.getSources() returns a promise which should resolve
when capturing finishes. Internally it creates an instance of
DesktopCapturer which is responsible for resolving or rejecting
the promise.
Between the time DesktopCapturer starts capturing frames and when
it finishes, it's possible for its handle to be GC'd leading to
it never resolving.
These changes pin the instance of DesktopCapturer until it either
finishes or errors.
fixes #25595
2021-03-18 13:43:35 -07:00
Jeremy Rose
9f4a097e03
feat: remove getMediaSourceIdForWebContents() ( #25414 )
...
This reverts commit 204f001c5d
.
2020-09-14 10:38:05 -07:00
Jeremy Judeaux
204f001c5d
feat: add desktopCapturer.getMediaSourceIdForWebContents() to get stream source id from web contents ( #22701 )
...
* feat: add desktopCapturer.getMediaSourceIdForWebContents() to get stream source id from web contents
* Cleanup from #22701 PR comments
2020-05-26 16:34:24 -04:00
Jeremy Apthorp
a824e12275
refactor: ginify desktopCapturer ( #22746 )
2020-03-19 11:35:11 -07:00
Jeremy Apthorp
d9321f4df7
chore: rename atom -> electron ( #21986 )
2020-02-04 12:19:40 -08:00