Cheng Zhao
3a1d6d2ce1
feat: migrate protocol module to NetworkService (Part 11) ( #18706 )
...
* Pipe data into HTTP protocol handlers
* Remove unused parameters
* Remove "sending request of http protocol urls" test
Sending request to "http://" in "file://" violates CORS rules and always
fail, before NetworkService somehow Chromium still sent a request even
though the request failed with CORS error, so the test passes while the
test is not valid. With NetworkService no request is sent at all and the
test jsut fails.
So this is an ancient invalid test, as sending http requests have been
fully covered in other tests, I am removing this test.
2019-06-11 14:07:58 +09:00
Electron Bot
d008d217f9
chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) ( #18505 )
...
* chore: bump chromium in DEPS to 07463d3cd628b037c11f36022cb4c788db4628e3
* chore: update patches
* fix: Don't leak system network context when nw service is disabled
https://chromium-review.googlesource.com/c/chromium/src/+/1632494
NetworkService is now deleted by using SequnceLocalStorageSlot
on the IO thread when the service is disabled, which expects
all associated NetworkContexts on that sequence to be destroyed.
* chore: bump chromium in DEPS to 7c16850e7e40990e141f47101b737ec1092175a1
* fix: Destroy all network contexts before primary network context
* Simplify out-of-process service registration
https://chromium-review.googlesource.com/c/chromium/src/+/1615882
* [ThreadPool] Rename base::ThreadPool to base::ThreadPoolInstance
https://chromium-review.googlesource.com/c/chromium/src/+/1634851
* chore: update patches
* fix: -Winconsistent-missing-override warnings
* chore: bump chromium in DEPS to 93ebfaccc12715df1d5426797998eed0932f7ae1
* Change CreateBrowserMainParts to return unique_ptrs
https://chromium-review.googlesource.com/c/chromium/src/+/1632532
* chore: update patches
* chore: bump chromium in DEPS to e656555ffb87bdd05e248d0a3ef9dd9d3433e17b
* chore: bump chromium in DEPS to 111e7a8d2e3ae9d70e535009d6afb066ac906063
* chore: bump chromium in DEPS to 9b6b84670d32a7aff41ce73adc0eeee67d364989
* chore: update patches
* chore: remove ShouldInterceptResourceAsStream as it is removed upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1639597
* chore: remove ResourceDispatcherHostCreated as it is removed upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1610892
* chore: CreateWithStrongBinding --> CreateWithSelfOwnedReceiver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1636722
* chore: rename all blink media enums
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1639237
* chore: add accidentally removed patch content back
2019-06-03 20:44:12 -07:00
Jeremy Apthorp
2dbd2c07e4
refactor: nws13n: session.allowNTLMCredentialsForDomains ( #18129 )
2019-05-29 16:43:06 -07:00
Jeremy Apthorp
f4c792d014
feat: enable reporting api ( #18255 )
2019-05-29 16:33:19 -07:00
Shelley Vohr
9af5072115
chore: remove last instances of base::Bind ( #18178 )
...
* chore: remove last instances of base::Bind
* MessageBoxCallback is a OnceCallback
* convert permission helepr cbs to Once
* convert ResponseCallback to Once
2019-05-29 13:02:15 -07:00
Cheng Zhao
00964b98b9
feat: migrate protocol module to NetworkService (Part 10) ( #18464 )
...
* Explicitly call OnReceiveRedirect for redirections
* Better way for detecting redirection
* Create new loader for redirections
2019-05-28 15:08:50 +09:00
Cheng Zhao
54cbe5f749
feat: migrate protocol module to NetworkService (Part 9) ( #18374 )
...
* Compare final data instead of url
The behavior of did-finish-load and getURL has changed for redirects when
using NetworkService, so the test fails for NetworkService.
Comparing the finally received data makes the test more reliable.
* Implement intercept APIs
* Setting mimeType should set "content-type" header
* Passing no argument should not throw JS error
* Don't access api namespace in ProxyingURLLoaderFactory
* No need to create AtomURLLoaderFactory every time
* No use of weak factory
2019-05-24 11:28:00 +09:00
Jeremy Apthorp
53954494a9
chore: bump chromium to 54af93edd956a53c786668bc0e253 (master)
2019-05-23 13:35:41 -07:00
Cheng Zhao
e1a2cc7f36
feat: migrate protocol module to NetworkService (Part 8) ( #18361 )
...
* Add ProxyingURLLoaderFactory
* Intercept file:// protocol to support asar archives
2019-05-22 10:43:37 +09:00
Nitish Sakhawalkar
2d14a0e90d
Update changed APIs/deps
...
Use brotli by default (36d58dd325
)
Update Mac ui headers (897636c9f8
)
Update AtomBrowserClient::HandleExternalProtocol API (cb656e1fd1
)
2019-05-16 18:47:42 -07:00
Cheng Zhao
2ad62cedc3
feat: migrate protocol module to NetworkService (Part 7) ( #18290 )
...
* fix: make IsProtocolHandled return true for builtin schemes
* fix: return ERR_NOT_IMPLEMENTED for wrong arg
* Initial work of AsarURLLoader
* Put normal file logics in AsarURLLoader
* Implement asar file reading
* Don't change URL for unpacked file
* Fix cpplint warning
2019-05-15 08:29:58 +09:00
Jeremy Apthorp
78d45a17c8
fix: default enable_negotiate_port to false ( #18251 )
2019-05-13 11:28:01 -07:00
Cheng Zhao
326215e1f1
feat: migrate protocol module to NetworkService (Part 6) ( #18223 )
...
* fix: start node strem asyncly
* fix: headers value may be a list
* fix: simply destruct on finish/error
* fix: class may destruct immediately after subscribing "data"
* fix: send meaningful error
* fix: must always provide a response body
* fix: handle the case when one write can not write all data
* fix: handle connection error
2019-05-11 15:15:01 +09:00
Cheng Zhao
237f74a01f
feat: migrate protocol module to NetworkService (Part 5) ( #18170 )
...
* fix: always have head.headers available
* fix: use StringDataPipeProducer to write string
It can handle large strings correctly.
* fix: override RegisterNonNetworkSubresourceURLLoaderFactories
* fix: add dummy uninterceptProtocol implementation
* fix: jquery error handler can pass empty string
For some errors jquery would pass empty string in the error handler,
which makes tests pass when they should fail.
* chore: fix cpplint warnings
* fix: guard RegisterNonNetworkSubresourceURLLoaderFactories call
It may be called even when NetworkService is not enabled.
* test: disable protocol.interceptHttpProtocol test
2019-05-07 11:33:05 +09:00
Shelley Vohr
0755857a0c
chore: convert more files away from base::Bind ( #18121 )
...
* chore: convert more files away from base::Bind
* use BindOnce for JsAsker
2019-05-03 12:08:41 -07:00
Milan Burda
c25c31e018
refactor: convert C++ enums to C++11 enum classes ( #18087 )
2019-05-03 14:11:41 -04:00
Cheng Zhao
0a6eb8afca
feat: migrate protocol module to NetworkService (Part 4) ( #18084 )
...
* Parse stream protocol handler
* Pipe node stream to mojo
* Merge the parser for headers
* Add ToDict helper to simplify code
* Simplify dispatching logic
* Add an experimental API for returning any type of response
* Fix subscribing event
* URL loaders' lifetime is independent of the factory
* HandleError helper is no longer needed
* Rename "SendResponse" => "StartLoading" to follow naming conventions
* Delete when connection error happens
* Fix cpplint warning
2019-05-03 09:48:51 +09:00
Shelley Vohr
cc00fa8874
chore: convert base::Bind instances across some files ( #18112 )
2019-05-03 08:49:26 +09:00
Samuel Attard
d4f5ebefe6
feat: allow setting of global fallback user agent ( #18016 )
...
* feat: allow setting of global fallback user agent
* spec: add tests for app.set/getUserAgentFallback
2019-05-01 16:34:42 -07:00
Shelley Vohr
f316c8470c
chore: convert session base::Bind instances ( #18038 )
...
Convert instances of base::Bind to base::BindOnce and base::BindRepeating as applicable in the session module as well as in Autofill popups.
2019-05-01 13:45:08 -07:00
Electron Bot
2616911f7a
chore: bump chromium to 7dff37844cb3 (master) ( #18059 )
2019-04-30 17:18:22 -07:00
Cheng Zhao
277f93653e
feat: migrate protocol module to NetworkService (Part 3) ( #18030 )
...
* Implement http protocol handler
* File protocol handler also accepts options
* Http protocol should inherit headers by default
* Only inherit necessary headers
* Slightly reorder logics
2019-04-30 09:47:04 +09:00
Cheng Zhao
6f83977f47
feat: migrate protocol module to NetworkService (Part 2) ( #17965 )
...
* Pass protocol type and handler to factory
* Add converter for network::ResourceRequest
* Implement Buffer and String protocol handler
* Implement file protocol
2019-04-29 11:37:45 +09:00
Robo
e1e055a837
fix: allow creating service for temporary partitions (nws13n) ( #17930 )
2019-04-24 09:30:53 +09:00
Cheng Zhao
132137081a
feat: migrate protocol module to NetworkService (Part 1) ( #17899 )
2019-04-23 14:39:20 -07:00
Electron Bot
716cb28430
chore: bump chromium to 1e9f9a24aa12 (master) ( #17880 )
...
* chore: bump chromium in DEPS to 1e9f9a24aa12bea9cf194a82a7e249bd1242ec4f
* chore: update patches
* Make WebContents' theme color a base::Optional<SkColor>
https://chromium-review.googlesource.com/c/chromium/src/+/1540022
* update autofill patch for incorrect header includes
* Move Shell messages to web_test and rename to BlinkTest.
https://chromium-review.googlesource.com/c/chromium/src/+/1525181
* Make PlatformNotificationServiceImpl a KeyedService.
https://chromium-review.googlesource.com/c/chromium/src/+/1336150
* Move MediaPlayerId to its own file.
https://chromium-review.googlesource.com/c/chromium/src/+/1547057
* Remove net/base/completion_callback.h, which is no longer used
https://chromium-review.googlesource.com/c/chromium/src/+/1552821
* AW NS: support file scheme cookies
https://chromium-review.googlesource.com/c/chromium/src/+/1533486
* Remove SecurityInfo and adapt remaining consumers
https://chromium-review.googlesource.com/c/chromium/src/+/1509455
* Remove deprecated type-specific number to string conversion functions
https://chromium-review.googlesource.com/c/chromium/src/+/1545881
* DevTools: Adding new performance histograms for launch of top 4 tools
https://chromium-review.googlesource.com/c/chromium/src/+/1506388
* Update include paths for //base/hash/hash.h
https://chromium-review.googlesource.com/c/chromium/src/+/1544630
* build: Disable ensure_gn_version gclient hook for mac CI checkout
* update patches
* use maybe version of v8::String::NewFromTwoByte
* bump appveyor image version
* fix mac ci hopefully
* Convert enum to enum class for MenuAnchorPosition
https://chromium-review.googlesource.com/c/chromium/src/+/1530508
* use maybe version of ToObject
* RenderViewHost::GetProcess is no longer const
* Unrefcount AuthChallengeInfo
https://chromium-review.googlesource.com/c/chromium/src/+/1550631
* MenuButtonController takes Button rather than MenuButton
https://chromium-review.googlesource.com/c/chromium/src/+/1500935
* add //ui/views_bridge_mac to deps to fix link error
* forward declare views::Button in atom::MenuDelegate
* more v8 patches
* base/{=> hash}/md5.h
https://chromium-review.googlesource.com/c/chromium/src/+/1535124
* gfx::{PlatformFontWin => win}::*
https://chromium-review.googlesource.com/c/chromium/src/+/1534178
* fix v8 patches
* [base] Rename TaskScheduler to ThreadPool
https://chromium-review.googlesource.com/c/chromium/src/+/1561552
* use internal_config_base for bytecode_builtins_list_generator
avoids windows link errors
* FIXME: temporarily disable v8/breakpad integration
* FIXME: temporarily disable prevent-will-redirect test
* FIXME: disable neon on aarch64 pending crbug.com/953815
* update to account for WebCursor refactor
https://chromium-review.googlesource.com/c/chromium/src/+/1562755
* enable stack dumping on appveyor
* Revert "FIXME: disable neon on aarch64 pending crbug.com/953815"
This reverts commit 57f082026be3d83069f2a2814684abf4dc9e7b53.
* fix: remove const qualifiers to match upstream
* fix: remove const qualifiers to match upstream in cc files as well
* don't throw an error when testing if an object is an object
* use non-deprecated Buffer constructor
* Remove net::CookieSameSite::DEFAULT_MODE enum value
https://chromium-review.googlesource.com/c/chromium/src/+/1567955
* depend on modded dbus-native to work around buffer deprecation
https://github.com/sidorares/dbus-native/pull/262
* revert clang roll to fix arm build on linux
* fixup! depend on modded dbus-native to work around buffer deprecation
need more coffee
* update coffee-script
* robustify verify-mksnapshot w.r.t. command-line parameters
* Revert "robustify verify-mksnapshot w.r.t. command-line parameters"
This reverts commit a49af01411f684f6025528d604895c3696e0bc57.
* fix mksnapshot by matching args
* update patches
* TMP: enable rdp on appveyor
* Changed ContentBrowserClient::CreateQuotaPermissionContext() to return scoped_refptr.
https://chromium-review.googlesource.com/c/chromium/src/+/1569376
* Make content::ResourceType an enum class.
https://chromium-review.googlesource.com/c/chromium/src/+/1569345
* fixup! Make content::ResourceType an enum class.
* turn off rdp
* use net::CompletionRepeatingCallback instead of base::Callback<void(int)>
* remove disable_ensure_gn_version_gclient_hook.patch
* copy repeating callback instead of std::move
* fix lint
* add completion_repeating_callback.h include
2019-04-20 10:20:37 -07:00
Samuel Attard
2fda0bdc89
chore: enable_data_url_support does not exist anymore
2019-04-02 14:43:06 -07:00
deepak1556
515c927b14
fixup! enable_file_url_support and enable_data_url_support have been removed
2019-04-02 14:43:05 -07:00
Samuel Attard
ab92cfd174
fix: enable_file_url_support and enable_data_url_support have been
...
removed
Unsure how the change in default of file_url_support affects us
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337
2019-04-02 14:43:04 -07:00
Samuel Attard
2bf740d2fe
fix: remove enable_data_url_support from OnNetworkServiceCreated
...
data URLs are _always_ enabled in the network service now and this is
enforced in the Content layer.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1512337
2019-04-02 14:43:04 -07:00
Robo
6c20c6e668
refactor: Enable network service (Part 1) ( #17431 )
...
* Convert InspectableWebContentsImpl::LoadNetworkResource to SimpleURLLoader
https://bugs.chromium.org/p/chromium/issues/detail?id=721408
* Plumb creation of network context with the service
2019-03-26 10:10:48 +09:00
deepak1556
bfe876afcd
Use IPEndPoint instead of HostPortPair
...
https://chromium-review.googlesource.com/c/chromium/src/+/1473094
2019-03-08 15:06:16 -08:00
deepak1556
3f4f774838
Remove const interfaces from content::ResourceRequestInfo.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1474632
2019-03-08 15:06:16 -08:00
deepak1556
611b36719b
Remove channel_id_path from NetworkContextParams (and other related places)
...
https://chromium-review.googlesource.com/c/chromium/src/+/1435678
2019-03-08 15:04:32 -08:00
Robo
d4d6b9862f
fix: make StreamSubscriber ref counted ( #17221 )
...
It is owned by URLRequestStreamJob on the IO thread once request starts,
but if the ownership was abondoned while transfering it to IO thread
which is possible when a request is aborted, then we need to make sure
its destroyed on the right thread to avoid lock in v8.
2019-03-07 20:50:03 +05:30
Robo
7936237677
build: enable gn check for //electron:electron_lib ( #17100 )
...
* build: enable gn check for //electron:electron_lib
* ci: add gn check step
* ci: set depot_tools path
* chrome_key_systems_provider.h nogncheck
* chore: fix gn check errors on windows
* chore: gn check //electron:electron_app
2019-03-05 10:38:55 +05:30
deepak1556
86a94126fb
Convert ProxyResolutionServiceProvider to use Network Service.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1419264
2019-02-14 23:59:24 +05:30
deepak1556
3898a44e88
Increase scope of URLLoader::FollowRedirect() API implementation.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1369856
2019-02-14 23:59:23 +05:30
deepak1556
e1502f6953
Move GetUserAgent from ContentClient to ContentBrowserClient
...
https://chromium-review.googlesource.com/c/chromium/src/+/1352086
2019-02-14 23:59:22 +05:30
deepak1556
92cfc4a62d
fix: update deprecated v8 api usage
2019-02-14 23:59:21 +05:30
Jeremy Apthorp
63bf370cc0
fix: registerStreamProtocol callback with large chunks ( #16532 )
2019-01-25 10:57:26 -08:00
Jeremy Apthorp
d0621db8fd
Remove ResourceContext::GetRequestContext since it's no longer used.
...
https://chromium-review.googlesource.com/c/1352035
2019-01-22 10:32:05 -08:00
Jeremy Apthorp
fd7b49b32b
remove OnAreExperimentalCookieFeaturesEnabled
...
https://chromium-review.googlesource.com/c/1287209
2019-01-22 10:32:03 -08:00
Jeremy Apthorp
d36a6de25c
OnCanEnablePrivacyMode -> OnForcePrivacyMode
...
https://chromium-review.googlesource.com/c/1343051
2019-01-22 10:32:03 -08:00
Robo
52fe92d02e
feat: Upgrade to Chromium 71.0.3578.98 ( #15966 )
2019-01-11 17:00:43 -08:00
David Baker
cc85946f55
feat: Support response headers in File protocol handler ( #16098 )
...
* feat: Support response headers in File protocol handler
* bugfix: Null check headers value & fix tests
* refactor: Use non-deprecated FindKeyOfType
2018-12-18 23:17:02 -07:00
deepak1556
7a68d632e6
fix: use proxy lookup api of network context to resolve proxies
2018-12-03 20:07:42 +05:30
deepak1556
f7f09b028b
Introduce explicit configuration to CertVerifier
...
https://chromium-review.googlesource.com/c/chromium/src/+/1122709
2018-12-03 20:07:41 +05:30
deepak1556
97aa7b8e68
Use CompletionOnceCallback in URLFetcherResponseWriter.
...
https://chromium-review.googlesource.com/c/chromium/src/+/1155087
2018-12-03 20:07:41 +05:30
deepak1556
0f9dd3736c
Move CRLSets to being part of CertVerifier::Config
...
https://chromium-review.googlesource.com/c/chromium/src/+/1132706
2018-12-03 20:07:39 +05:30