Samuel Attard
ba6d9291d2
build: add import/order eslint rule ( #44108 )
...
build: add import/order eslint rule (#44085 )
* build: add import/order eslint rule
* chore: run lint:js --fix
2024-10-03 15:21:54 -07:00
Samuel Attard
5bdaa42b01
build: update some build dependencies ( #44071 )
...
* build: update some build dependencies (#43882 )
* build: update some build dependencies
* build: fix eslint issues after updating
* build: disable ts check on busted js example
* build: update internal types for stricter event handling
* restore url.parse behavior
* fix typing issues
* sigh
* build: update easy deps
* build: skip woa engines check
* build: s/colors/chalk
* build: node 20 on windows
2024-10-01 13:14:08 -07:00
Calvin
5951712f2e
build: fix clang format location helper ( #42926 )
...
* build: fix clang format location helper (again)
* use gclient sync in lint workflow for downloading clang-format
2024-07-17 11:30:36 +02:00
trop[bot]
2c3a9fd3c5
build: remove klaw dependency ( #42701 )
...
* refactor: remove klaw dependency
Node 20 added recursive readdir() so klaw is not needed
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! refactor: remove klaw dependency
findMatchingFiles returns a Promise<string[]>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-06-28 10:11:42 +02:00
Charles Kerr
61ddb1aa07
chore: bump pylint to 2.17 ( #41576 )
...
* build: bump pylint to 2.17
Xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5062345
* fix pylint consider-using-f-string warnings pt 1: use flynt for automated fixes
* fix pylint consider-using-f-string warnings pt 2: manual fixes
* fix pylint consider-using-with warnings
* fix pylint line-too-long warnings
* fix pylint unspecified-encoding warnings
* fix py lint consider-using-generator warning
* fixup! fix pylint unspecified-encoding warnings
* fix pylint line-too-long warnings
2024-03-21 09:48:23 -04:00
Milan Burda
3394ee71f0
chore: fix import from patches.py in script/lib/git.py ( #41430 )
2024-02-26 11:36:30 +09:00
Charles Kerr
6a616ab70c
feat: allow custom refs for patch import & export ( #41306 )
...
* feat: allow custom refs for patch import & export
feat: add Patch-Dir metainfo, a sibling to Patch-Filename
* chore: copyediting
* refactor: minor copyediting
2024-02-12 10:05:53 -06:00
Charles Kerr
b253d52faf
build: export matching patches ( #41174 )
...
* build: make patches/config.json an array of objects
This file was previously an object of patch_dir keys to repo values;
Now is an array of objects containing `patch_dir` and `repo` properties.
This makes other per-target properties (e.g. `grep`) possible.
* build: include Note metadata when exporting patches
* build: support keyword filtering in export_patches()
* build: add optional `--grep` arg to git-export-patches script
* build: update export_all_patches to understand new config file
* fixup! build: update export_all_patches to understand new config file
chore: make lint happy
* fixup! build: make patches/config.json an array of objects
chore: fix oops
* refactor: remove support for the old file format
There is more code using config.json than I thought, so the
effort-to-reward of supporting the old format is not worth it.
* build: update apply_all_patches to understand new config file
* build: update lint.js to understand new config file
* build: update patches-mtime-cache.py to understand new config file
* fixup! build: update apply_all_patches to understand new config file
fix: oops
* fixup! build: update apply_all_patches to understand new config file
fix minor syntax wart
* fixup! build: support keyword filtering in export_patches()
refactor: use idiomatic python
* refactor: warn if config.json has an invalid repo
2024-02-08 13:47:59 -05:00
David Sanders
425efb5e47
chore: remove py2 compatibility code ( #40375 )
2023-11-01 10:20:32 -04:00
Cheng Zhao
e613595982
build: allow overriding electron version ( #39974 )
2023-09-27 14:49:10 +09:00
Milan Burda
ef6569b7d3
chore: cleanup unusued variables + enable linting ( #38898 )
2023-06-26 02:51:54 -07:00
Milan Burda
abec9ead06
refactor: use node scheme imports in scripts ( #38846 )
...
* refactor: use node scheme imports in script
* refactor: use node scheme imports in build
2023-06-22 16:21:42 +02:00
David Sanders
9ccf2275d2
chore: migrate to @electron/lint-roller for Markdown linting ( #38191 )
2023-05-08 12:50:42 +02:00
Shelley Vohr
ee966ad6ec
build: remove unused python code ( #37351 )
2023-02-21 09:48:52 +01:00
David Sanders
dc972b3919
chore: remove old script code for ATOM_SHELL_ ( #37140 )
...
The TODO is from 2016, seems like it's time
2023-02-06 13:07:45 -08:00
David Sanders
ca3145a547
chore: use vscode-markdown-languageservice for link linting ( #36901 )
...
* chore: use vscode-markdown-languageservice for docs link linting
* docs: make links relative
2023-01-24 09:00:25 +01:00
Shelley Vohr
c953109f01
build: remove older branch migration helpers ( #36888 )
...
* build: remove older branch migration helpers
* chore: fix typo
2023-01-12 12:05:26 -05:00
Robert Günzler
ab890fb8c3
fix: strip branded binaries ( #36641 )
...
When creating branded release builds and using scripts/strip-binaries.py
on Linux, the final artifacts end up unstripped due to the static set of
binaries considered for stripping.
With this patch the name of the electron binary is taken from the
BRANDING.json `project_name` key.
Signed-off-by: Robert Günzler <r@gnzler.io>
Signed-off-by: Robert Günzler <r@gnzler.io>
2022-12-13 17:01:20 -05:00
Keeley Hammond
b71cccb0d6
ci: bake appveyor images automatically, run sync on depshash change ( #35396 )
...
* chore: update yml formatting for parser
* ci: bake appveyor images automatically, run sync on depshash change
* chore: clean up .yml files
* chore: bump to e-110.0.5415.0
2022-11-21 10:24:26 -05:00
Samuel Attard
99a34d5209
build: strip v in the getElectronVersion helper
2022-10-26 17:56:30 -07:00
Samuel Attard
b13f776d1b
build: ensure get-version runs in the electron git checkout ( #36128 )
2022-10-25 11:27:10 -07:00
Samuel Attard
7ca2bb5f9c
build: determine electron version from tags not files ( #36106 )
...
* build: determine electron version from tags not files
* build: make electron_version dependent on packed-refs and git HEAD
* build: do not delete electron/.git
* build: do not revert a commit we didn't make
* build: gen version file instead of just writing it
* build: update cache and ninja targets
* build: copy resource.h to generated electron.rc
* build: electron_win32_resources should be public deps
* build: also copy the icon
2022-10-24 23:44:43 -07:00
John Kleinschmidt
07c3e62d68
build: fix export patches to work when source directory does not exist ( #35432 )
2022-08-24 17:37:11 -04:00
David Sanders
5fee5b0e22
chore: chunk filenames when linting C++ files ( #34237 )
...
* chore: chunk filenames when linting C++ files
* chore: refactor code for better readability
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: further tweak
* chore: limit all platforms to 4095 characters on command line
* chore: use python3
* Revert "chore: use python3"
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
2022-06-22 19:23:11 +09:00
electron-roller[bot]
61374019c0
chore: bump chromium to 103.0.5046.0 (main) ( #33906 )
...
* chore: bump chromium in DEPS to 103.0.5020.0
* chore: bump chromium in DEPS to 103.0.5022.0
* chore: bump chromium in DEPS to 103.0.5024.0
* chore: update patches
* 3587410: [Printing] Remove JobEventDetails
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3587410
* chore: bump chromium in DEPS to 103.0.5026.0
* chore: update patches
* 3577218: WebUI: Delete webui_resources.grd and related GN targets.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3577218
* chore: bump chromium in DEPS to 103.0.5028.0
* chore: update patches
* 3579297: Convert UpdatePrintSettings() to use non-deprecated base::Value APIs.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3579297
* 3560622: serial: Add SerialPort.forget() method
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560622
* 3581708: Restore original display when moving from tab-fullscreen to browser-fullscreen.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3581708
* chore: fix authorization flags lint error
* 3583363: Remove net wrappers around base/strings/escape.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3583363
* fixup! 3560622: serial: Add SerialPort.forget() method
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3560622
* 3587589: Reland "Propagate the MIME type from DownloadTargetDeterminer to DownloadItem"
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3587589
* 3584006: Remove IsRenderViewLive from content public
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3584006
* 3596174: [api] Remove APIs for resurrecting finalizers
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/3596174
* 3368244: Hook SnapshotForContentAnalysis renderer API to scan system prints
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3368244
* chore: bump chromium in DEPS to 103.0.5030.0
* chore: update patches
* chore: bump chromium in DEPS to 103.0.5032.0
* chore: bump chromium in DEPS to 103.0.5034.0
* chore: bump chromium in DEPS to 103.0.5036.0
* chore: update patches
* 3586363: Introduce PrintRenderFrame.PrintWithParams() for batch printing to PDF
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3586363
* 3593199: Remove content::PermissionType references and replace them with blink::PermissionType
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3593199
* 3368244: Hook SnapshotForContentAnalysis renderer API to scan system prints
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3368244
* chore: lint
* chore: bump chromium in DEPS to 103.0.5038.0
* chore: update patches
* fixup! 3560622: serial: Add SerialPort.forget() method
* 3606495: mac screen capture: add metric
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3606495
* chore: bump chromium in DEPS to 103.0.5040.0
* chore: update patches
* 3590840: Add IPs to DnsOverHttpsServerConfig
https://chromium-review.googlesource.com/c/chromium/src/+/3590840
* stub functions for ElectronSerialDelegate and SerialChooserController to fix link
* 3566412: [base] Remove base/android dependency on post_task.h and officially remove post_task.h!
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* 3347944: [content] No longer hand-off whole MainFunctionParams to BrowserMainParts
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3347944
* fixup! 3566412: [base] Remove base/android dependency on post_task.h and off…
e3ea3e1
…icially remove post_task.h!
* chore: update process_singleton patches for content::GetIOThreadTaskRunner({})
Ref: 2015655: [BrowserThread] Migrate co/pub/br and co/br/scheduler to the new API | https://chromium-review.googlesource.com/c/chromium/src/+/2015655
* chore: migrate base::DeleteSoon to content::GetUIThreadTaskRunner({})->DeleteSoon
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* chore: remove duplicate functions for RevokePortPermissionWebInitiated & GetPortInfo
* chore: migrate Linux/Windows methods off of post_task.h
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3566412
* 64908: Stop building legacy SwiftShader GL in Chromium
https://swiftshader-review.googlesource.com/c/SwiftShader/+/64908
* 3573245: Added Themed versions of RoundedRectBackground and RoundedRectBorder.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3573245
* chore: bump chromium in DEPS to 103.0.5042.0
* chore: update patches
* 3571804: [api] Advance API deprecation for V8 version v10.2
https://chromium-review.googlesource.com/c/v8/v8/+/3571804
* fixup! 3571804: [api] Advance API deprecation for V8 version v10.2
* build: fix run-clang-format extension matching
* lint
* fix windows build
* how is clang-format still not working for me
* chore: update patches
* 3623985: Replace ad-hoc SetPublicFirstPartySets calls with method in ContentBrowserClient.
https://chromium-review.googlesource.com/c/chromium/src/+/3623985
* no need to implement WillProvidePublicFirstPartySets; the default is false
* 3601036: [QT] Introduce ui/views/linux_ui/linux_ui_factory.*
https://chromium-review.googlesource.com/c/chromium/src/+/3601036
* 3583363: Remove net wrappers around base/strings/escape.h
https://chromium-review.googlesource.com/c/chromium/src/+/3583363
* lint
* chore: bump chromium in DEPS to 103.0.5044.0
* fix conflicts
* chore: update patches
* upgrade nan
* pin version of nan in tests
* replace my hacky deprecated override fix with the fix from upstream
* revert runtime dcheck in v8
* pin nan version at root too
* refactor: tell gyp to use c++17 when building with our node
* Revert "refactor: tell gyp to use c++17 when building with our node"
This reverts commit 41a03a5799a8f40f31555d73d20ea865acfcd192.
* Undo the reversion of 41a03a5799a8f40f31555d73d20ea865acfcd192.
This reverts commit 54440abc598153bd7e259be4a908f0ecc0b33348.
* disable sequential/test-cpu-prof-kill for now
* also sequential/test-diagnostic-dir-cpu-prof
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: Jeremy Rose <japthorp@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-05-17 12:48:40 -04:00
Keeley Hammond
0696320d28
build: remove S3 uploads ( #34104 )
2022-05-05 21:40:34 -07:00
Jeremy Rose
c0d442364a
build: explicitly run scripts with python3 ( #33720 )
...
* build: explicitly run scripts with python3
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2022-04-12 13:21:55 +02:00
Samuel Attard
204b53e7b8
build: upload to AZ as well as S3 ( #33573 )
...
* build: upload to AZ aswell as S3
* fix: provide env to azput
2022-04-04 02:32:57 -07:00
David Sanders
45e2f86fe0
chore: fix pylint-2.7 errors ( #33233 )
2022-03-21 11:11:21 +09:00
BIKI DAS
fdb60240f3
fix: removed unused imported Objects ( #33304 )
2022-03-21 10:21:21 +09:00
Micha Hanselmann
a1c01ded9c
fix: really strip crashpad handler binary ( #33126 )
2022-03-07 14:49:50 -05:00
Juan Cruz Viotti
7442905dd2
build: Support cygwin in script/lib/util.py ( #32731 )
...
Running a build on Cygwin or MSYS2 otherwise fails.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
2022-02-03 15:57:21 -05:00
Marek Šuppa
c6d061c2d4
Update config.py ( #32666 )
...
* Fix missing comma
2022-01-31 10:57:52 +01:00
Jeremy Rose
84e2460012
fix: strip crashpad_handler binary ( #32540 )
2022-01-19 19:48:48 -08:00
Romain Pokrzywka
483808a8cf
fix: Support running git-[im,ex]port-patches with Python3 too ( #32303 )
...
* script: Python3 compatibility for utf8 conversion
The unicode() method has been renamed to str() in Python3,
add a wrapper around it to support running against both versions.
* script: don't require python2 for git-[import,export]-patches
The scripts work just fine with python3 too, so use the generic
python executable as the script interpreter.
Most setups don't even require or provide python 2 anymore,
so this saves one from having to install it just for the scripts.
2022-01-10 16:47:55 -05:00
Alexey Kuzmin
2d111a4e25
chore: fix pylint ( #31138 )
...
* chore: fix pylint
* chore: fix linter errors
2021-09-29 13:10:13 -04:00
Juan Cruz Viotti
f9213faec5
build: support building Electron on msys2 ( #29449 )
...
Electron already seems to support `cygwin`, so `msys` is a natural
addition. This is the only required change as far as I can see on my
local development environment, as otherwise the build scripts don't
realize that msys = windows.
Notes: none
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
2021-06-02 16:29:19 +09:00
Jeremy Rose
f664f37793
refactor: getCurrentBranch respects main ( #29369 )
2021-05-27 17:32:16 -07:00
Samuel Attard
56c3103e73
build: remove dead python methods and helper ( #28884 )
2021-04-28 00:39:30 -07:00
Samuel Attard
e373df3bc3
build: actually use SSL when downloading things via python ( #28885 )
2021-04-28 00:38:49 -07:00
Samuel Attard
3879e9e065
build: remove the vendor directory ( #28883 )
...
The `vendor` directory is a remnant of times long since gone when we had
brightray and libchromiumcontent (never forget). It is currently the
hope to a single header file that afaics we do not need anymore and
randomly pyyaml gets cloned there but that is easily movable.
This commit removes all references to the vendor directory from scripts,
docs, helpers, etc. and removes the directory itself.
2021-04-28 00:38:08 -07:00
Samuel Attard
e323bfe661
refactor: remove unneeded patch_count variable ( #28467 )
2021-04-02 08:27:35 +09:00
Samuel Attard
ba3b2189ad
build: fix unicode patch file comparison in git.py ( #28454 )
...
This caused some patches to fail incorrectly as the patch file included
non-ascii characters, we have to manually convert using the utf8 charset
2021-03-31 13:48:21 -07:00
Samuel Maddock
b9b734c9c4
fix: export patches not retaining CRLF line endings ( #28360 )
...
When a patch targets a file using CRLF line endings, they need to be
retained in the patch file. Otherwise the patch will fail to apply
due to being unable to find surrounding lines with matching whitespace.
2021-03-25 14:49:53 +09:00
Shelley Vohr
a433fdd3d4
build: show more info about exported patches ( #27148 )
2021-01-04 11:24:59 -08:00
Samuel Attard
b894151745
build: update npx.py to support npx@7 ( #26662 )
...
* build: update npx.py to support npx@7
* build: set npm_config_yes for all npx callsites
2020-11-23 21:26:54 -08:00
Samuel Attard
946802600b
chore: move upload-to-github to TS ( #26390 )
2020-11-09 13:57:53 -08:00
David Sanders
e9cd227b5b
build: Python3 compat and Win line-endings fixes ( #26091 )
2020-10-30 19:05:38 +09:00
David Sanders
c27e5fdbb6
chore: fix linter errors ( #25996 )
2020-10-19 20:55:27 +09:00
Jeremy Rose
8243255316
fix: s3put not replacing enough \\ ( #25866 )
2020-10-13 11:02:25 +09:00