electron-roller[bot]
dd03cceda0
chore: bump chromium to 137.0.7128.1 (main) ( #46482 )
...
* chore: bump chromium in DEPS to 137.0.7107.0
* chore: bump chromium in DEPS to 137.0.7109.0
* chore: bump chromium in DEPS to 137.0.7111.0
* chore: bump chromium in DEPS to 137.0.7113.0
* 6384240: Remove double-declaration for accessibility on macOS | https://chromium-review.googlesource.com/c/chromium/src/+/6384240
* 6422872: Remove unused includes in isolation_info_mojom_traits.h | https://chromium-review.googlesource.com/c/chromium/src/+/6422872
* chore: update patches
* 6400733: Avoid ipc_message_macros.h usage in some foo_param_traits_macros.h files | https://chromium-review.googlesource.com/c/chromium/src/+/6400733
* chore: update patches
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* chore: iwyu
* refactor: prefer value initialization over memset()
From the looks up upstream commits in base/, it looks like memset()
could trigger `-Wunsafe-buffer-usage` warnings soon?
Value initialization is more C++ish and less error-prone anyway,
due to memset()'s easily swappable parameters.
* refactor: NotifyIcon::InitIconData() returns a NOTIFYICONDATA
This follows F.20 in the C++ Core Guidelines and also removes the need
for memset()
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- strcmp()
* fixup! 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* 6433203: Add a PassKey to RegisterDeleteDelegateCallback(). | https://chromium-review.googlesource.com/c/chromium/src/+/6433203
* chore: bump chromium in DEPS to 137.0.7115.0
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* chore: update patches
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* fix: add pragma for MacSDK unsafe buffers | 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
* chore: bump chromium in DEPS to 137.0.7117.0
* chore: update patches
* chore: update filesnames.libcxx.gni
* 6431756: Replace SetOwnedByWidget() bool arg with a PassKey. | https://chromium-review.googlesource.com/c/chromium/src/+/6431756
* 6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* 6428345: Remove ExtensionService usage from ChromeExtensionRegistrarDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/6428345
* 6384315: Migrate extensions_enabled from ExtensionService to Registrar | https://chromium-review.googlesource.com/c/chromium/src/+/6384315
* 6428749: [extensions] Refactor ExtensionService for AddNewAndUpdateExtension. | https://chromium-review.googlesource.com/c/chromium/src/+/6428749
* chore: bump chromium in DEPS to 137.0.7119.0
* 6440290: corner-shape: support inset shadow | https://chromium-review.googlesource.com/c/chromium/src/+/6440290
* 6429230: FSA: Move blocked paths to the PermissionContext class | https://chromium-review.googlesource.com/c/chromium/src/+/6429230
* chore: update patches
* chore: bump chromium in DEPS to 137.0.7121.0
* chore: update patches
* fix: partially revert 6443473: Remove ItemDelete from the Mac version of AppleKeychain | https://chromium-review.googlesource.com/c/chromium/src/+/6443473
* fix: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 137.0.7123.0
* chore: update patches
* chore: "grandfather in" electron views too
Lock further access to View::set_owned_by_client() | https://chromium-review.googlesource.com/c/chromium/src/+/6448510
* chore: update feat_corner_smoothing_css_rule_and_blink_painting.patch
corner-shape: support inset shadow | https://chromium-review.googlesource.com/c/chromium/src/+/6440290
* refactor: grandfather in AutofillPopupView as a subclass of WidgetDelegateView
Add a PassKey for std::make_unique<WidgetDelegateView>() | https://chromium-review.googlesource.com/c/chromium/src/+/6442265
* Provide dbus appmenu information on Wayland | https://chromium-review.googlesource.com/c/chromium/src/+/6405535
* [extensions] Move OnExtensionInstalled out of ExtensionService. | https://chromium-review.googlesource.com/c/chromium/src/+/6443325
* refactor: grandfather in NativeWindowViews for delete callbacks
6433203: Add a PassKey to RegisterDeleteDelegateCallback(). | https://chromium-review.googlesource.com/c/chromium/src/+/6433203
* chore: merge the four "grandfather" patches into one
* [A11yPerformance] Remove IsAccessibilityAllowed() | 6404386: [A11yPerformance] Remove IsAccessibilityAllowed() | https://chromium-review.googlesource.com/c/chromium/src/+/6404386
NB: the changes here are copied from the upstream changes in
chrome/browser/ui/webui/accessibility/accessibility_ui.cc
* 6420753: [PermissionOptions] Use PermissionDescriptorPtr in PermissionController | https://chromium-review.googlesource.com/c/chromium/src/+/6420753
* 6429573: [accessibility] Move mode change out of AccessibilityNotificationWaiter | https://chromium-review.googlesource.com/c/chromium/src/+/6429573
* chore: e patches all
* 6419936: [win] Change ScreenWin public static methods to virtual | https://chromium-review.googlesource.com/c/chromium/src/+/6419936
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- fprintf()
- fputs()
- snprintf()
- vsnprintf()
* fix: size conversion FTBFS on Win
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- wcscpy_s()
* 6423410: Enable unsafe buffer warnings for chromium, try #3 . | https://chromium-review.googlesource.com/c/chromium/src/+/6423410
remove all uses of:
- wcsncpy_s()
* chore: update mas_avoid_private_macos_api_usage.patch.patch
6394283: Remove double-declaration for accessibility on iOS | https://chromium-review.googlesource.com/c/chromium/src/+/6394283
Lots of context shear in this commit but the only interesting part is:
-+ return nullptr;
++ return {};
Which is needed because the return type is sometimes not a pointer.
* chore: e patches all
* chore: disable -Wmacro-redefined warning in electron_main_win.cc
* chore: bump chromium in DEPS to 137.0.7123.5
* refactor: patch electron PermissionTypes into blink
6387077: [PermissionOptions] Generalize PermissionRequestDescription | https://chromium-review.googlesource.com/c/chromium/src/+/6387077
* chore: e patches all
* chore: remove the box_painter_base.cc part of feat_corner_smoothing_css_rule_and_blink_painting.patch
as per code review @ https://github.com/electron/electron/pull/46482#pullrequestreview-2777338370
* test: enable window-smaller-than-64x64 test on Linux
* chore: bump chromium in DEPS to 137.0.7124.1
* chore: bump chromium in DEPS to 137.0.7125.1
* chore: bump chromium in DEPS to 137.0.7127.3
* 6459201: [Extensions] Remove ExtensionSystem::FinishDelayedInstallationIfReady() | https://chromium-review.googlesource.com/c/chromium/src/+/6459201
* 6454796: [Extensions] Move (most) registrar delayed install logic to //extensions | https://chromium-review.googlesource.com/c/chromium/src/+/6454796
* chore: bump chromium in DEPS to 137.0.7128.1
* chore: e patches all
* chore: node ./script/gen-libc++-filenames.js
* [views] Gate DesktopWindowTreeHostWin::window_enlargement_ behind flag
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6428649
* feat: allow opt-out animated_content_sampler.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6438681
* Trigger CI
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2025-04-22 15:53:29 -04:00
Calvin
f15fa56e38
refactor: reduce & remove no-op MicrotasksScope calls ( #46681 )
...
* fix: do not run microtasks in V8Serializer in browser process
* Remove no-op MicrotasksScope in `shell/browser/api/electron_api_auto_updater.cc`
This call was added in https://github.com/electron/electron/pull/40576 as an expansion of `gin_helper::EmitEvent`.
Since this only runs in the browser process and `bool ignore_browser_checkpoint = true` this code is a no-op.
Node should perform a microtask checkpoint if necessary in `node::MakeCallback`.
* Remove no-op MicrotasksScope in `shell/common/api/electron_bindings.cc`
This method is only called by the browser process. The containing function, `ElectronBindings::DidReceiveMemoryDump`, is only used in two places:
* `ElectronBindings::GetProcessMemoryInfo` in the same file, which has a `CHECK` that it's running in the browser process at the top.
* From `shell/browser/api/electron_api_web_contents.cc`, which is only run in the browser process.
Added a DCHECK for clarity and validation.
* Replace `gin_helper::MicrotasksScope` with `v8::MicrotasksScope` in `shell/renderer/`
The browser check is unnecessary in the renderer. Since `gin_helper::MicrotasksScope` will always act exactly like `v8::MicrotasksScope`, it's clear to just use the v8 object directly. This also brings them in line with the many other uses of `v8::MicrotasksScope` in `shell/renderer/`.
2025-04-19 12:18:03 -05:00
electron-roller[bot]
9c019b6147
chore: bump chromium to 136.0.7095.0 (main) ( #46118 )
...
* chore: bump chromium in DEPS to 136.0.7076.0
* chore: bump chromium in DEPS to 136.0.7077.0
* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) | https://chromium-review.googlesource.com/c/chromium/src/+/6368856
* 6356528: Clean up LegacyRenderWidgetHostHWND code | https://chromium-review.googlesource.com/c/chromium/src/+/6356528
* chore: export patches
* 6339113: [Viewport Segments] Add CDP commands to override Viewport Segments without overriding other device properties. | https://chromium-review.googlesource.com/c/chromium/src/+/6339113
* 6352169: [DevTools][MultiInstance] Support new tab in another window on Android | https://chromium-review.googlesource.com/c/chromium/src/+/6352169
* 6368856: Migrate absl variant.h and utility.h in content (part 2/2) | https://chromium-review.googlesource.com/c/chromium/src/+/6368856
* 6360858:Clickiness: Wire response from URLLoader to DB, add e2e tests| https://chromium-review.googlesource.com/c/chromium/src/+/6360858
* chore: bump chromium in DEPS to 136.0.7079.0
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7081.0
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7083.0
* 6361987: Remove double-declaration with gfx::NativeView and gfx::NativeWindow | https://chromium-review.googlesource.com/c/chromium/src/+/6361987
* chore: export patches
* chore: bump chromium in DEPS to 136.0.7087.0
* chore: export patches
* fix: include node patch for missing AtomicsWaitEvent
https://chromium-review.googlesource.com/c/chromium/src/+/6385540
* build: add depot_tools python to path
* fix: cppgc init and unregistering v8 isolate
https://chromium-review.googlesource.com/c/v8/v8/+/6333562
CppGc is now initialized earlier so Node can skip reinitializing it.
Additionally, gin::IsolateHandle was attempting to destruct an already destructed
v8::Isolate upon electron::JavaScriptEnvironment destruction. By removing the call
to NodePlatform::UnregisterIsolate, this fixes the crash on app shutdown.
* fix: unregister isolate after destruction
See code comment.
* chore: bump chromium in DEPS to 136.0.7095.0
* chore: sync patches
* fix: add script_parsing::ContentScriptType parameter
https://chromium-review.googlesource.com/c/chromium/src/+/6298395
* fix: migrate content::BrowserAccessibilityState methods
https://chromium-review.googlesource.com/c/chromium/src/+/6401437
https://chromium-review.googlesource.com/c/chromium/src/+/6383275
* feat: enableHappyEyeballs option for host resolver
https://chromium-review.googlesource.com/c/chromium/src/+/6332599
* fix: add new cookie exclusion reason
https://chromium-review.googlesource.com/c/chromium/src/+/6343479
* fix: add new url loader method
https://chromium-review.googlesource.com/c/chromium/src/+/6337340
* fix: add new cppgc header file for electron_node headers
https://chromium-review.googlesource.com/c/v8/v8/+/6348644
* fix: disable CREL on Linux ARM64
https://chromium-review.googlesource.com/q/I3a62f02f564f07be63173b0773b4ecaffbe939b9
* fixup! fix: add new cppgc header file for electron_node headers https://chromium-review.googlesource.com/c/v8/v8/+/6348644
* chore: update corner smoothing patch
* fixup! chore: update corner smoothing patch
* chore: disable NAN weak tests
These two tests are incompatible with a V8 change that disallows running JS code from a weak finalizer callback.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4733273
* test: fix task starvation in node test
A V8 change makes these contexts get collected in a task that is posted
and run asynchronously. The tests were synchronously GC'ing in an
infinite loop, preventing the task loop from running the task that would
GC these contexts.
This change should be upstreamed in some way.
Ref: https://chromium-review.googlesource.com/c/v8/v8/+/4733273
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
2025-04-03 19:02:49 -05:00
Shelley Vohr
d2c2261c58
fix: hard crash on invalid command line switches ( #46004 )
...
* fix: hard crash on invalid command line switch
* Update docs/api/command-line.md
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
* chore: feedback from review
* docs: Add breaking change note
---------
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2025-03-26 08:14:03 -05:00
Robo
041ada1586
build: match upstream with unsafe buffer paths ( #45853 )
...
* build: match upstream with unsafe buffer paths
* Don't assume STL iterators are pointers
Refs https://issues.chromium.org/issues/328308661
* chore: spanify process_singleton_win.cc
2025-03-06 16:04:18 -05:00
Charles Kerr
69eb076bca
refactor: do not use AdaptCallbackForRepeating() in electron_api_url_loader.cc ( #45771 )
...
refactor: do not use AdaptCallbackForRepeating in electron_api_url_loader.cc
2025-02-24 11:09:01 -05:00
Charles Kerr
2a383e9ddd
refactor: use C++20's contains() method ( #45742 )
...
* chore: use std::map<>::contains() instead of count() or find()
* chore: use std::map<>::contains() instead of base::Contains()
2025-02-21 17:33:43 -06:00
electron-roller[bot]
612da3ec47
chore: bump chromium to 135.0.7027.0 (main) ( #45677 )
...
* chore: bump chromium in DEPS to 135.0.7021.0
* chore: bump chromium in DEPS to 135.0.7023.0
* chore: update patches
* chore: gen-libc++-filenames.js
* [Extensions] Add a BUILD.gn file for the chrome.system.display API.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6227347
* chore: bump chromium in DEPS to 135.0.7025.0
* fixup! [Extensions] Add a BUILD.gn file for the chrome.system.display API.
* [DevTools] Add support for automatic workspace folders.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6275926
* Add UseCounter for potential PNA 2.0 breakage
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6259197
* Remove references to NavigationEntry/Controller in Zoom code.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6258070
* chore: update patches
* Allow DevTools to record UmaHistogramMediumTimes
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6183713
* chore: update patches
* [gpu] Remove unnecessary media_buildflags include
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6286526
* chore: bump chromium in DEPS to 135.0.7027.0
* chore: update patches
* Remove type alias
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6280957
* [Refactor] Make ExtensionRegistrar a browser keyed service.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6285230
* Remove unused functions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6278736
* chore: IWYU
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-02-21 14:46:51 -08:00
Charles Kerr
aa06b065c0
chore: bump chromium to 134.0.6998.10 (main) ( #45564 )
...
* chore: bump chromium to 134.0.6992.0
* chore: add BrowserProcessImpl::CreateGlobalFeaturesForTesting() stub
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6216193
Remove GlobalFeatures from TestingBrowserProcess::Init
* chore: bump chromium to 134.0.6994.0
* 6208630: Mac sandbox: don't use protobuf for policy serialization | https://chromium-review.googlesource.com/c/chromium/src/+/6208630
* [PDF] Remove HasUnsupportedFeature Mojo interface
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6220800
* 6217444: Remove scoped_gdi_object.h type aliases. | https://chromium-review.googlesource.com/c/chromium/src/+/6217444
* chore: bump chromium to 134.0.6998.10
* 6221378: Revert [OBC] Exclude Aliasing Cookies in FilterCookiesWithOptions() | https://chromium-review.googlesource.com/c/chromium/src/+/6221378
* Update ExtensionPrefs::GetDisableReasons to return DisableReasonSet
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6218840
change copied from 6218840 extensions/shell/browser/shell_extension_loader.cc
* 6218402: Typemap ui.gfx.DXGIHandle <=> gfx::DXGIHandle | https://chromium-review.googlesource.com/c/chromium/src/+/6218402
* chore: disable flaky contentTracing test
not new to this roll; it is happening in main as well
* fixup! chore: disable flaky contentTracing test
---------
Co-authored-by: alice <alice@makenotion.com>
2025-02-11 17:26:39 -06:00
Milan Burda
517935cd55
refactor: only pass v8::Context to gin_helper::MicrotasksScope constructor ( #45484 )
...
refactor: forward v8::Context to v8::MicrotasksScope constructor
2025-02-07 10:44:19 +09:00
Robo
bec6ddda70
feat: route deprecated sync clipboard read through permission checks ( #45377 )
...
* feat: route deprecated clipboard commands through permission checks
* docs: address review feedback
* fix: enable checks for child windows
2025-02-05 15:13:29 +09:00
Robo
ecd5d0a3a4
fix: crash in gin::wrappable::secondweakcallback ( #45368 )
2025-01-29 10:20:37 -08:00
David Lönnhager
ae56a03e33
fix: crash parsing CLSID in shell.readShortcutLink() ( #45195 )
...
* fix: crash parsing CLSID in shell.readShortcutLink
* fix: ignore clsid if it could not be set
2025-01-27 15:22:56 -05:00
electron-roller[bot]
7d05b78479
chore: bump chromium to 133.0.6920.0 (main) ( #45055 )
...
* chore: bump chromium in DEPS to 133.0.6902.0
* chore: bump chromium in DEPS to 133.0.6903.0
* chore: update patches
* Update PdfViewer Save File Picker to use showSaveFilePicker.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6074308
* Code Health: Clean up stale MacWebContentsOcclusion
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* Change RenderProcessHost::GetID to RenderProcessHost::GetDeprecatedID
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6065543
* [WebRTC] Make WebRTC IP Handling policy a mojo enum
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6063620
* chore: gen filenames.libcxx.gni
* Remove allow_unsafe_buffers pragma in //printing
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6092280
* refactor: to use ChildProcessId where possible
Refs https://issues.chromium.org/issues/379869738
* [Win] Update TabletMode detection code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6003486
* chore: bump chromium in DEPS to 133.0.6905.0
* chore: update patches
* Reland "Move global shortcut listener to //ui/base"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6099035
* [shared storage] Implement the batch `with_lock` option for response header
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6072742
* chore: bump chromium in DEPS to 133.0.6907.0
* chore: bump chromium in DEPS to 133.0.6909.0
* chore: bump chromium in DEPS to 133.0.6911.0
* chore: bump chromium in DEPS to 133.0.6912.0
* chore: update patches
* WebUI: Reveal hidden deps to ui/webui/resources.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6096291
* chore: bump chromium in DEPS to 133.0.6913.0
* chore: bump chromium in DEPS to 133.0.6915.0
* Code Health: Clean up stale base::Feature "AccessibilityTreeForViews"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6104174
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fix: remove fastapitypedarray usage
* chore: update patches
* chore: script/gen-libc++-filenames.js
* Code Health: Clean up stale base::Feature "WinRetrieveSuggestionsOnlyOnDemand"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6109477
* fix: empty suggestions with windows platform checker
Amends the fix from https://github.com/electron/electron/pull/29690
since the feature flag is no longer available. We follow the
same pattern as //chrome/browser/renderer_context_menu/spelling_menu_observer.cc
to generate the suggestion list on demand when context menu action
is invoked.
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
* fixup! fix: empty suggestions with windows platform checker
* fixup! fix: empty suggestions with windows platform checker
* revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* Revert "revert: 6078344: Code Health: Clean up stale MacWebContentsOcclusion | https://chromium-review.googlesource.com/c/chromium/src/+/6078344 "
This reverts commit 9cacda452ed5a072351e8f5a35b009d91843a08c.
* chore: bump to 133.0.6920.0, update patches
* Revert "6078344: Code Health: Clean up stale MacWebContentsOcclusion"
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/6078344
* fixup! Update PdfViewer Save File Picker to use showSaveFilePicker.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2025-01-10 10:52:34 -06:00
electron-roller[bot]
e0f72dc332
chore: bump chromium to 133.0.6887.0 (main) ( #44986 )
...
* chore: bump chromium in DEPS to 133.0.6887.0
* chore: update render_widget_host_view_base.patch
trivial manual intervention needed due to header context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5952851
* chore: update osr_shared_texture_remove_keyed_mutex_on_win_dxgi.patch
trivial manual intervention needed due to header context shear
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6068570
* chore: e patches all
* Remove ClipboardFormatType::GetType()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6075792
* Remove raw byte range methods from network::ResourceRequestBody
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6038757
* fix: update patches/chromium/fix_crash_loading_non-standard_schemes_in_iframes.patch:wq
Refs https://issues.chromium.org/issues/40092527
* fix: windows gn check
* chore: update patches/chromium/render_widget_host_view_base.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-12-18 15:45:19 +09:00
electron-roller[bot]
cf5a4640f5
chore: bump chromium to 133.0.6878.0 (main) ( #44831 )
...
* chore: bump chromium in DEPS to 133.0.6858.0
* chore: bump chromium in DEPS to 133.0.6860.0
* chore: update patches
v8/revert_fastapi_remove_dynamic_overload_resolution.patch had some additions due to https://chromium-review.googlesource.com/c/v8/v8/+/6023139
* 6044060: Reland "Moves shared GN templates into //build/config/apple."
https://chromium-review.googlesource.com/c/chromium/src/+/6044060
* Revert "6023139: [fastapi] Add support for attribute setters"
https://chromium-review.googlesource.com/c/v8/v8/+/6023139
* Update printing.patch
The removed include is present in the original source file now, just slightly before where it was being added.
6015430: Reduce platform-like buildflags in sandbox code
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/6015430
* 6039836: Migrate Command::IsMediaKey to be a member of ui::Accelerator
https://chromium-review.googlesource.com/c/chromium/src/+/6039836
* 6038659: [CodeHealth] Clean up the feature ZstdContentEncoding
https://chromium-review.googlesource.com/c/chromium/src/+/6038659
* chore: bump chromium in DEPS to 133.0.6862.0
* chore: update patches
* 72747: crypto: switch to C++
https://boringssl-review.googlesource.com/c/boringssl/+/72747
* fixup! 72747: crypto: switch to C++ https://boringssl-review.googlesource.com/c/boringssl/+/72747
* chore: gen libc++ filenames
* 6042601: [shared storage] Implement with_lock option for methods from response headers
https://chromium-review.googlesource.com/c/chromium/src/+/6042601
* chore: bump chromium in DEPS to 133.0.6864.0
* chore: bump chromium in DEPS to 133.0.6866.0
* chore: bump chromium in DEPS to 133.0.6868.0
* chore: bump chromium in DEPS to 133.0.6870.0
* chore: bump chromium in DEPS to 133.0.6872.0
* chore: bump chromium in DEPS to 133.0.6874.0
* chore: bump chromium in DEPS to 133.0.6876.0
* 6039992: Fix false activation logic for context menu. | https://chromium-review.googlesource.com/c/chromium/src/+/6039992
* chore: update patches
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6878.0
* chore: update patches
* [Build] Organize //components/dbus into a single component
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6055280
* Merge //components/dbus/* into a single //components/dbus, which
matches how most components are organized. This avoids having
many small shared libraries which incurs unnecessary overhead.
* Limit visibility of //components/dbus/* to //components/dbus
* fixup! Update _LIBCPP_ABI_VERSION to always have a default value while keeping unstable false due to changes in llvm https://github.com/llvm/llvm-project/pull/112094
* 6040416: Let s know which widget the input came on. | https://chromium-review.googlesource.com/c/chromium/src/+/6040416
* 6056267: [MPArch guest view] Fix authentication for MPArch guests | https://chromium-review.googlesource.com/c/chromium/src/+/6056267
* make_span() is deprecated: https://issues.chromium.org/issues/341907909
* fixup: https://issues.chromium.org/issues/341907909
* chore: delete extra bracket from removing make_span commit
* fixup: 6059305: Make WTF::UTF8ConversionMode a scoped enum | https://chromium-review.googlesource.com/c/chromium/src/+/6059305
* 6051058: CookieInclusionStatus: Remove ctors which bypass invariants | https://chromium-review.googlesource.com/c/chromium/src/+/6051058
* 6038981: Remove most remaining CHECK(false)s | https://chromium-review.googlesource.com/c/chromium/src/+/6038981
* build: use third_party/simdutf in Node.js
* chore: node ./script/gen-libc++-filenames.js
* chore: fix strict-cast conversion error in subspan()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: fix strict-cast conversion error in base::as_bytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: fix strict-cast conversion error in span.split_at()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6044946
* chore: use shorthand target name
* chore: better docs in build_add_public_config_simdutf_config.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: alice <alice@makenotion.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-12-10 13:16:07 -06:00
Charles Kerr
f7e823ac80
refactor: return-braced-init-list pt 2 of 2 ( #44870 )
...
* refactor: more return-braced-init-list, this time for v8 and gin objects
* refactor: more return-braced-init-list, this time for v8, gin, std, and base objects
2024-11-29 11:44:33 -06:00
Charles Kerr
f595443a22
refactor: fix modernize-return-braced-init-list warnings ( #44838 )
...
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
* refactor: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
NB: using the braced-initializer list uncovered an error here:
the float returned by std::floor() can't be implicitly cast to
an int. This is solved by using base::ClampFloor<int>() instead.
std::floor()
2024-11-27 09:41:46 +09:00
Charles Kerr
024fee4e44
fix: modernize-use-nodiscard clang-tidy warnings ( #44808 )
2024-11-25 10:48:28 -05:00
electron-roller[bot]
7e7010dacf
chore: bump chromium to 133.0.6852.0 (main) ( #44748 )
...
* chore: bump chromium in DEPS to 133.0.6847.0
* chore: bump chromium in DEPS to 133.0.6848.0
* chore: update patches
* implement extensions::GlobalShortcutListener::ExecuteCommand stub
https://chromium-review.googlesource.com/c/chromium/src/+/5871484
* fix: ismediakey patch, oops
* fix: another missing bracket
* chore: bump chromium in DEPS to 133.0.6850.0
* chore: update patches
* SharedStorageOperationPtr -> SharedStorageModifierMethodPtr
https://chromium-review.googlesource.com/c/chromium/src/+/5990970
* build GlobalShortcutListenerLinux
https://chromium-review.googlesource.com/c/chromium/src/+/5871484
* chore: bump chromium in DEPS to 133.0.6851.0
* fix: include full type for network::mojom::SharedStorageModifierMethod
* chore: update patches
* chore: bump chromium in DEPS to 133.0.6852.0
* chore: update patches
* build: remove duplicated icudtl.dat and snapshot_blob.bin
https://chromium-review.googlesource.com/c/chromium/src/+/5999387
* fix: include static methods in node tests involving call stacks
https://chromium-review.googlesource.com/c/v8/v8/+/5907815
* revert: moved code in picture-in-picture.patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-11-25 10:45:47 -05:00
Charles Kerr
86962ba2c3
fix: clang-tidy performance-inefficient-vector-operation warnings ( #44743 )
...
* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()
* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
2024-11-20 18:11:00 -06:00
electron-roller[bot]
43ed763f18
chore: bump chromium to 133.0.6846.0 (main) ( #44665 )
...
* chore: bump chromium in DEPS to 133.0.6836.0
* chore: bump chromium in DEPS to 133.0.6838.0
* chore: update patches
* 6006096: [Sync ESB] Integrate Chrome Toast UI
https://chromium-review.googlesource.com/c/chromium/src/+/6006096
* Confine enable_device_bound_sessions buildflag to //net
https://chromium-review.googlesource.com/c/chromium/src/+/6014679
* revert [api] Delete deprecated struct FastApiTypedArray
https://chromium-review.googlesource.com/c/v8/v8/+/5982984
Also
https://chromium-review.googlesource.com/c/v8/v8/+/5979766/1
* fixup revert [api] Delete deprecated struct FastApiTypedArray
* Migrate remaining NOTREACHED()s in chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5998172
* [Reland][Extensions] Remove ExtensionHostDelegate::GetJavaScriptDialogManager()
https://chromium-review.googlesource.com/c/chromium/src/+/6020106
* Remove NOTREACHED_IN_MIGRATION()
https://chromium-review.googlesource.com/c/chromium/src/+/6021996
* Remove Lock screen apps [#8 ] : remove lock screen extension
https://chromium-review.googlesource.com/c/chromium/src/+/6005846
* Reland "Add CrashReporterClient::GetProductInfo(ProductInfo*)"
https://chromium-review.googlesource.com/c/chromium/src/+/6012631
* Ozone/Wayland: remove lacros specific window states
https://chromium-review.googlesource.com/c/chromium/src/+/6011215
* chore: bump chromium in DEPS to 133.0.6840.0
* chore: bump chromium in DEPS to 133.0.6841.0
* chore: bump chromium in DEPS to 133.0.6844.0
* implement virtual WebContents::CanUserEnterFullscreen
* OnSearchifyStateChange -> OnSearchifyStarted
* regen libc++ filenames
* chore: bump chromium in DEPS to 133.0.6846.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-11-19 19:52:20 -08:00
Charles Kerr
ac61c74ddc
fix: bugprone-narrowing-conversions warnings in NativeImage ( #44708 )
...
* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_
- fix signed / unsigned math by using base/numerics/safe_conversions
- make memory_usage_ an int64_t so it can safely take the size_t
returned by computeByteSize()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image.cc:155:26: warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int32_t' (aka 'int') is implementation-defined [bugprone-narrowing-conversions]
155 | new_memory_usage = image_skia->bitmap()->computeByteSize();
* fix: bugprone-narrowing-conversions warnings in NativeImage::CreateFromBitmap()
`SkImageInfo::MakeN32()` and `SkBitmap::allocN32Pixels()` both take int
width and height args, but we were feeding them unsigned ints.
../../electron/shell/common/api/electron_api_native_image.cc:508:36: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
508 | auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:508:43: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
508 | auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:524:25: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
524 | bitmap.allocN32Pixels(width, height, false);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:524:32: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
524 | bitmap.allocN32Pixels(width, height, false);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:528:48: warning: narrowing conversion from 'double' to 'float' [bugprone-narrowing-conversions]
528 | gfx::ImageSkia::CreateFromBitmap(bitmap, scale_factor);
2024-11-19 16:04:18 -06:00
Robo
0d6743e79b
fix: destroy url loader wrapper when JS env exits ( #44574 )
...
* fix: destroy url loader wrapper when JS env exits
* Revert "fix: destroy url loader wrapper when JS env exits"
This reverts commit 419151a98a16814ea63e9abc197c6ae27f48128c.
* Revert "Revert "fix: destroy url loader wrapper when JS env exits""
This reverts commit 4b401b03c62aca79498660f995825491ae52f179.
* fix: double free of JSChunkedDataPipeGetter
* fix: crash on process exit after stream completes
2024-11-19 11:32:48 -05:00
Charles Kerr
5d0d15a0b3
perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals ( #44412 )
...
* perf: prefer NewFromUtf8Literal() over NewFromUtf8() for string literals
the string length is known at compile time and no need to call ToLocalChecked()
* perf: string length is known when calling NewFromUtf8(), so use it
* perf: remove unnecessary calls to c_str()
these just force the code being called to have to recalculate the string length
2024-10-28 14:12:32 +01:00
Charles Kerr
83d7040096
fix: -Wunsafe-buffer-usage warning in didRegisterForRemoteNotificationsWithDeviceToken ( #44348 )
...
* chore: move as_byte_span() to new shell/common/mac_util.h
this way it can be used by multiple mm files
* fix: -Wunsafe-buffer-usage warnings in UNNotificationResponseToNSDictionary
* refactor: use base::HexEncode() instead of rolling our own
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
* fixup! chore: move as_byte_span() to new shell/common/mac_util.h
fix: move mac_util to the right place in filenames.gni
2024-10-23 14:18:22 -05:00
electron-roller[bot]
36b7cf341e
chore: bump chromium to 131.0.6776.0 (main) ( #44137 )
...
* chore: bump chromium in DEPS to 131.0.6763.0
* chore: bump chromium in DEPS to 131.0.6764.0
* update patches
* chore: bump chromium in DEPS to 131.0.6766.0
* chore: update patches
* Use PathInfo in FileSystemAccess code
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5872329
* Modernize image utilities.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905226
* [DevTools] move feature flags to the devtools directory
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5913878
* chore: bump chromium in DEPS to 131.0.6768.0
* chore: update patches
* Remove experimental credshelper flags
Refs 4017a6c8b4https://chromium-review.googlesource.com/c/chromium/src/+/5917286
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5905621
* chore: script/gen-libc++-filenames.js
* chore: bump chromium in DEPS to 131.0.6770.0
* chore: update patches
* chore: bump chromium in DEPS to 131.0.6772.0
* chore: update patches
* [UI] Add alias for mojo version of `MenuSourceType`
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5803393
* Update Background Color for Task Manager Refresh
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5875259
* chore: bump chromium in DEPS to 131.0.6774.0
* chore: bump chromium in DEPS to 131.0.6776.0
* chore: update patches
* chore: update filenames.libcxx.gni
* esm: remove --no-import-harmony-assertions
https://github.com/nodejs/node/pull/54890
* 5507047: [import-attributes] Remove support for import assertions
| https://chromium-review.googlesource.com/c/v8/v8/+/5507047
* fixup: Change gfx::[PNG|JPEG]Codec::Decode to return a SkBitmap
* chore: bump chromium in DEPS to 131.0.6778.0
* Revert "chore: bump chromium in DEPS to 131.0.6778.0"
This reverts commit fb9092fc51700651aa4a245931f71ec1ca55a274.
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Jeremy Rose <nornagon@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-10-15 11:51:11 -04:00
Charles Kerr
3d2f68a9df
refactor: spanify image utils ( #44127 )
...
* refactor: electron::util::AddImageSkiaRepFromJPEG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromPNG() takes a span arg
* refactor: electron::util::AddImageSkiaRepFromBuffer() takes a span arg
* feat: add Node-buffer-to-base-span helper function
* refactor: electron::api::NativeImage::CreateFromPNG() now takes a span param
* refactor: electron::api::NativeImage::CreateFromJPEG() now takes a span param
* refactor: use base::as_byte_span()
* fix: -Wunsafe-buffer-usage warning in NativeImage::CreateFromNamedImage()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: error: function introduces unsafe buffer manipulation [-Werror,-Wunsafe-buffer-usage]
131 | {reinterpret_cast<const uint8_t*>((char*)[png_data bytes]),
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
132 | [png_data length]});
| ~~~~~~~~~~~~~~~~~~
../../electron/shell/common/api/electron_api_native_image_mac.mm:131:11: note: See //docs/unsafe_buffers.md for help.
* chore: add // SAFETY comment for Node-buffer-to-span func
* chore: add // SAFETY comment for NSData-to-span func
2024-10-10 09:34:55 -04:00
Charles Kerr
6f88f0c795
perf: use ArrayBuffer::Data() instead of GetBackingStore()->Data() ( #44067 )
...
perf: use ArrayBuffer::Data() API
Replace our `GetBackingStore()->Data()` calls with this instead.
Explained by the V8 docs, ArrayBuffer.Data() is
> More efficient shortcut for GetBackingStore()->Data(). The
> returned pointer is valid as long as the ArrayBuffer is alive.
2024-10-01 10:04:57 -07:00
Charles Kerr
53e89b565d
fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer() ( #43795 )
...
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()
* chore: add a DCHECK to confirm the BigBuffer is full
2024-09-19 23:10:35 -05:00
electron-roller[bot]
4bcbc955dd
chore: bump chromium to 130.0.6695.0 (main) ( #43454 )
...
* chore: bump chromium in DEPS to 130.0.6673.0
* chore: bump chromium in DEPS to 130.0.6675.0
* chore: bump chromium in DEPS to 130.0.6677.2
* chore: bump chromium in DEPS to 130.0.6679.0
* 5802981: [Partitioned Popins] UKM
https://chromium-review.googlesource.com/c/chromium/src/+/5802981
* 5799275: ash: Create //chrome/browser/ui/ash/web_view
https://chromium-review.googlesource.com/c/chromium/src/+/5799275
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5805208: Move third_party/jacoco to a cipd/ subdirectory.
https://chromium-review.googlesource.com/c/chromium/src/+/5805208
* chore: fixup patch indices
* 5771091: Introduce InputManager class for handling input in Viz.
https://chromium-review.googlesource.com/c/chromium/src/+/5771091
* 5498921: [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager
https://chromium-review.googlesource.com/c/chromium/src/+/5498921
* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url
https://chromium-review.googlesource.com/c/chromium/src/+/5791853
* 5801311: Don't use int for bindings
https://chromium-review.googlesource.com/c/chromium/src/+/5801311
* 5548827: [Web Install] Define the web-app-installation PermissionPolicy
https://chromium-review.googlesource.com/c/chromium/src/+/5548827
* 5786325: Add Infrastructure for Hand tracking permission
https://chromium-review.googlesource.com/c/chromium/src/+/5786325
* chore: fixup patch indices
* chore: bump chromium in DEPS to 130.0.6681.0
* [Views AX] Move BrowserAccessibility* to //ui/accessibility/platform
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5520052
* chore: e patches all
* Don't have default arguments on virtual functions in render_frame_host.h
https://chromium-review.googlesource.com/c/chromium/src/+/5809399
* test: log if loadURL fails in base url test
* chore: bump chromium in DEPS to 130.0.6683.2
* chore: fix support_mixed_sandbox_with_zygote.patch
content: restore old DisableJit behavior
https://chromium-review.googlesource.com/c/chromium/src/+/5804255
* chore: update patch indices
* chore: bump chromium in DEPS to 130.0.6685.0
* Parallel process launching
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* chore: update feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch
No manual changes; patch applied with fuzz 1
* chore: e patches all
* chore: bump chromium in DEPS to 130.0.6687.0
* chore: bump chromium in DEPS to 130.0.6689.0
* chore: bump chromium in DEPS to 130.0.6691.0
* chore: bump chromium in DEPS to 130.0.6693.0
* chore: update patches
* chore: bump chromium in DEPS to 130.0.6695.0
* chore: free up macos disk space as soon as possible
* 5824143: Use checked in source lists for third_party/boringssl
https://chromium-review.googlesource.com/c/chromium/src/+/5824143
* chore: update patches
* 5824122: Extensions: Add a new view type enum for developer tools contexts
https://chromium-review.googlesource.com/c/chromium/src/+/5824122
* 5806109: Option for JavaScriptExecuteRequestForTests() to ignore content settings
https://chromium-review.googlesource.com/c/chromium/src/+/5806109
* build: free up disk space on gn check too
* 5799369: [Refactoring] Make allow_http1_for_streaming_upload flags false.
https://chromium-review.googlesource.com/c/chromium/src/+/5799369
* fixup! 5015584: Parallel process launching | https://chromium-review.googlesource.com/c/chromium/src/+/5015584
* Disable failing test for short-term
See: https://github.com/electron/electron/issues/43730
* oops
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
2024-09-17 18:12:11 -07:00
Samuel Attard
c1c8fbfd9a
build: make is_mas_build a generated header instead of config ( #43737 )
2024-09-17 01:38:56 -07:00
Charles Kerr
b6bf277b6f
refactor: reduce code duplication in gin_helper::Promise ( #43716 )
...
* refactor: move scope scaffolding into SettletScope
idea stolen from SpellCheckScope
* refactor: move impl of PromiseBase::RejectPromise() to the cc file
* chore: remove unused #include
2024-09-16 23:08:40 -05:00
Charles Kerr
3dd7e46291
refactor: avoid minor code repetition in native_image.cc ( #43689 )
...
chore: delegate handle creation in NativeImage::Resize()
chore: delegate handle creation in NativeImage::Crop()
chore: delegate handle creation in NativeImage::CreateEmpty()
2024-09-12 10:56:15 -05:00
Charles Kerr
45bae950d5
chore: remove unused base/ includes ( #43688 )
2024-09-12 16:05:37 +02:00
Charles Kerr
3fde574db1
fix: -Wunsafe-buffer-usage warnings in url-loader ( #43564 )
...
Use v8::ArrayBufferView::CopyContents() instead of doing the pointer
math + memcpy() ourselves. This not only solves the buffer warnings,
but may also avoid some additional overhead:
> Copy the contents of the ArrayBufferView's buffer to an
> embedder defined memory without additional overhead that
> calling ArrayBufferView::Buffer might incur.
2024-09-05 20:22:03 -05:00
Charles Kerr
8ae5aacc8c
refactor: declare gin::Wrapper subclasses as final ( #43527 )
...
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
2024-09-04 18:40:02 -05:00
David Sanders
56829f75c1
chore: cleanup include groupings ( #43478 )
2024-08-26 10:44:20 -04:00
Charles Kerr
5a1eeea102
perf: prefer GURL string_view getters ( #43443 )
...
* chore: avoid double-call to url.scheme() in WebContentsZoomController::SetZoomMode()
* perf: use gurl.scheme_piece() in GetAppInfoHelperForProtocol()
* perf: use gurl.scheme_piece() in Browser::GetApplicationNameForProtocol()
* refactor: add std::less<> to HandlersMap
This lets us search it using string_view keys
* refactor: ProtocolRegistry::FindRegistered() now takes a std::string_view
* perf: use gurl.scheme_piece() in InspectableWebContents::LoadNetworkResource()
* refactor: ProtocolRegistry::FindIntercepted() now takes a std::string_view
* perf: use gurl.scheme_piece() in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL()
* perf: use gurl.scheme_piece() in ProxyingURLLoaderFactory::CreateLoaderAndStart()
* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::GetWebUIType()
* perf: use gurl.host_piece() in ElectronWebUIControllerFactory::CreateWebUIControllerForURL()
2024-08-23 17:15:45 -05:00
Robo
9b166b3ed4
feat: support app#login event for utility process net requests ( #42631 )
...
* feat: support app#login event for utility process net requests
* chore: address review feedback
* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
2024-08-14 11:36:47 +09:00
electron-roller[bot]
c9b7806418
chore: bump chromium to 129.0.6650.0 (main) ( #43266 )
...
* chore: bump chromium in DEPS to 129.0.6645.0
* chore: update patches
* chore: bump chromium in DEPS to 129.0.6646.0
* refactor: remove ppapi dependency
PPAPI removal - https://issues.chromium.org/issues/40511450
PDF viewer migration - https://issues.chromium.org/issues/40511452
* chore: update patches
* chore: enable `content_enable_legacy_ipc`
We were indirectly relying on this via `enable_ppapi=true`, with
633a57d9b62da7850ef7946f6b101ed440d04cdd ppapi is now disabled and
this commit makes the dependency explicit.
* fix: gn check
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-08-12 10:28:33 +02:00
Charles Kerr
23bcca3ffc
refactor: put empty virtual function definitions in header ( #43285 )
...
* refactor: in FramelessView, move empty function decls to header
* refactor: in electron::api::WebContents, move empty function decls to header
* refactor: in electron::api::NativeWindow, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::OffScreenRenderWidgetHostView, move empty function decls to header
* refactor: in auto_updater::AutoUpdater, move empty function decls to header
* refactor: in electorn::api::FrameSubscriber, move empty function decls to header
* refactor: in electorn::api::SimpleURLLoaderWrapper, move empty function decls to header
* refactor: in electorn::InspectableWebContents, move empty function decls to header
* refactor: in electorn::OffScreenVideoConsumer, move empty function decls to header
* refactor: in electron::OffScreenWebContentsView, move empty function decls to header
* refactor: in electron::TrayIcon, move empty function decls to header
* refactor: in electron::ViewsDelegate, move empty function decls to header
* refactor: in electron::MediaCaptureDevicesDispatcher, move empty function decls to header
* refactor: in electron::UsbChooserContext::DeviceObserver, move empty function decls to header
* refactor: in electron::ProxyingWebSocket, move empty function decls to header
* refactor: in electron::Notification, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* Revert "refactor: in electron::PlatformNotificationService, move empty function decls to header"
This reverts commit 9103750d03b9ba1ceccba43d11dfdc2404ff6191.
* refactor: in electron::ElectronPDFDocumentHelperClient, move empty function decls to header
* refactor: in electron::api::SpellCheckClient, move empty function decls to header
* refactor: in electron::ElectronExtensionHostDelegate, move empty function decls to header
* refactor: in electron::PlatformNotificationService, move empty function decls to header
* refactor: in electron::NativeWindowViews, move empty function decls to header
* chore: move SetTouchBar() back to cc
* Revert "refactor: in auto_updater::AutoUpdater, move empty function decls to header"
This reverts commit c43d6862d32c74f63f82700a7546a732ac05ecb8.
2024-08-12 09:56:51 +02:00
Charles Kerr
6877671390
fix: gin_helper::MicrotasksScope instantiation ( #43185 )
2024-08-05 08:24:27 -05:00
electron-roller[bot]
20e77afe0f
chore: bump chromium to 129.0.6634.0 (main) ( #43189 )
...
* chore: bump chromium in DEPS to 129.0.6634.0
* chore: update chore_add_electron_deps_to_gitignores.patch
no manual changes. patch applied with fuzz 1.
* chore: e patches all
* chore: update call to gfx::Image::CreateFrom1xPNGBytes()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5743597
The call now takes a base::span
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-04 07:31:31 -05:00
Charles Kerr
e7ca92a574
chore: remove unused internal env.unSetVar() ( #43148 )
...
chore: remove unused unSetVar JS binding
Added in Oct 2020 (b33f2260#25623 ) but never used
2024-08-01 18:41:41 -05:00
Charles Kerr
45e5ccc55e
chore: remove unused KeyWeakMap JS bindings ( #43111 )
...
The last three pieces of code that used it were removed in:
- Oct 2020 (8df4faa8#25711 )
- Jun 2020 (e1e73fa5#24115 )
- Jun 2020 (c0182bca#24116 ).
2024-07-31 16:37:04 -05:00
Charles Kerr
1bcc566ad8
chore: remove unused & undocumented function v8Util.deleteHiddenValue() ( #43090 )
...
chore: remove unused v8Util.deleteHiddenValue()
Its last use was removed in Nov 2020 by c8d77cae4a#26659 )
2024-07-30 15:25:37 -05:00
Charles Kerr
47dde3b6e2
chore: remove unused class electron::ObjectLifeMonitor ( #43089 )
...
* chore: remove unused electron::ObjectLifeMonitor
The last users were removed in June 2020 e1e73fa5f#24115 )
and May 2020 9d7ba982#23592 ).
* fixup! chore: remove unused electron::ObjectLifeMonitor
fix: oops
2024-07-30 08:25:28 -05:00
Charles Kerr
e70ce89235
chore: more iwyu ( #43063 )
...
* chore: iwyu shell/browser/electron_pdf_document_helper_client.h
* chore: iwyu shell/browser/hid/electron_hid_delegate.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu shell/browser/usb/electron_usb_delegate.h
* chore: iwyu shell/browser/browser_observer.h
* chore: iwyu shell/browser/bluetooth/electron_bluetooth_delegate.h
* chore: iwyu shell/browser/serial/electron_serial_delegate.h
* chore: iwyu shell/browser/api/frame_subscriber.h
* chore: iwyu mojo/public/cpp/bindings/
* chore: iwyu components/
* chore: iwyu extensions/
* chore: iwyu shell/common/gin_helper/
* chore: iwyu v8/
* chore: iwyu base/containers/linked_list.h
* chore: iwyu shell/browser/native_window.h
* chore: iwyu shell/browser/api/electron_api_base_window.h
* chore: iwyu shell/common/node_includes.h
* chore: iwyu gin/handle.h
* chore: iwyu base/functional/callback.h
* chore: iwyu ui/gfx/
* chore: iwyu content/public/browser/render_frame_host.h
* fix: mac
* fix: mac
* fix: win
* chore: iwyu base/files/file_path.h
* chore: iwyu base/unguessable_token.h
* chore: iwyu ui/display/screen.h
* chore: iwyu chrome/browser/predictors/preconnect_manager.h
* chore: iwyu base/observer_list_types.h
* chore: iwyu content/public/browser/web_contents.h
* chore: iwyu chrome/browser/devtools/devtools_eye_dropper.h
* chore: iwyu shell/browser/ui/inspectable_web_contents.h
* chore: iwyu content/public/browser/keyboard_event_processing_result.h
* chore: iwyu net/cookies/canonical_cookie.h
* chore: iwyu net/base/address_list.h
* chore: iwyu net/cert/x509_certificate.h
* chore: iwyu net/cookies/cookie_change_dispatcher.h
* chore: iwyu net/dns/public/host_resolver_results.h
* fix: mac
* Revert "chore: iwyu net/cert/x509_certificate.h"
This reverts commit 002896f71146e90f1e29e090a1d6eede48cee11e.
2024-07-29 12:42:57 -05:00
electron-roller[bot]
92496c1930
chore: bump chromium to 129.0.6616.0 (main) ( #43012 )
...
* chore: bump chromium in DEPS to 128.0.6613.0
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076
* chore: export patches
* chore: 5725076: Update EventType names | https://chromium-review.googlesource.com/c/chromium/src/+/5725076 for windows
* chore: bump chromium in DEPS to 129.0.6614.0
* 5725672: Add a feature to limit the number of preconnect in LoadingPredictor | https://chromium-review.googlesource.com/c/chromium/src/+/5725672
* chore: bump chromium in DEPS to 129.0.6616.0
* chore: e patches all and resolve conflict in patches/v8/fix_disable_scope_reuse_associated_dchecks.patch
* 5730656: Show an error dialog when UpdatePrintSettings() fails | https://chromium-review.googlesource.com/c/chromium/src/+/5730656
* chore: gen-libc++-filenames
* 5729956: Finally remove string_piece.h | https://chromium-review.googlesource.com/c/chromium/src/+/5729956
* chore: replace all references of base::StringPiece with std::string_view
* chore: remove more references of stringPiece in favor of string_view
* chore: rename string_piece variables to string_view
* 5508795: Remove the NotificationService | https://chromium-review.googlesource.com/c/chromium/src/+/5508795
* 5734053: Revert Rename GlobalFeatures to GlobalDesktopFeatures. | https://chromium-review.googlesource.com/c/chromium/src/+/5734053
* chore: resolve conflict with main without merge
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Alice Zhao <alice@makenotion.com>
2024-07-29 09:37:35 -04:00
