trop[bot]
509801d77b
fix: showMessageDialog should center dialog to parent ( #48214 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-09-05 15:21:41 +02:00
trop[bot]
750ef114bc
fix: ensure dragging works again after emitting contextmenu event ( #48225 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-29 12:51:29 -04:00
trop[bot]
3faad259e8
fix: snapped restoration after minimization ( #48155 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-25 09:57:09 +02:00
trop[bot]
2a9780141c
fix: net.isOnline
always true in utility processes ( #48153 )
...
* fix: net.isOnline always true in utilityProcesses
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update shell/services/node/node_service.cc
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-22 13:22:30 -04:00
Shelley Vohr
79b71dfe50
feat: allow macOS tray to maintain position ( #48078 )
2025-08-20 13:05:08 -04:00
trop[bot]
49f2343ed0
fix: system accent color parsing hex order ( #48109 )
...
fix: system accent color parsing
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-19 12:46:47 +02:00
Keeley Hammond
3f92511cde
fix: ensure snapshot is valid ( #48104 )
...
feat: add support for embedder snapshot validation
2025-08-18 14:37:48 -07:00
trop[bot]
e94855be21
fix: avoid deprecated login item methods ( #48095 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@anthropic.com>
2025-08-18 12:00:32 +02:00
trop[bot]
ea7e51a8b2
fix: shell.openPath
should be non-blocking ( #48087 )
...
fix: shell.openPath should be non-blocking
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-16 09:38:06 +02:00
trop[bot]
f4e6a361de
fix: re-entrancy issues in webContents.loadURL()
( #48044 )
2025-08-12 13:42:25 +02:00
trop[bot]
c72e0bd90b
feat: add {get|set}AccentColor
on Windows ( #48018 )
...
* feat: add setAccentColor on Windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: unify GetSystemAccentColor
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: remove redundant parsing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fixup documentation
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/browser-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/base-window.md
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-10 21:46:33 +02:00
trop[bot]
b6dbb2bab7
fix: window accentColor
should adhere to native window behavior ( #48012 )
...
* fix: window accentColor should adhere to native window behavior
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: address review feedback
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: remove duplicate UpdateWindowAccentColor call in ctor
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: add NativeWindow::IsActive() (#47148 )
this was already present on macOS; use in NativeWindowViews too
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-08-08 22:22:34 +02:00
trop[bot]
7133cbab7f
feat: add app.getRecentDocuments()
( #47925 )
...
feat: add app.getRecentDocuments()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-06 19:35:00 +02:00
Shelley Vohr
e6ac03d0ee
fix: abnormal behavior of windows background material ( #47957 )
2025-08-05 16:34:17 +02:00
trop[bot]
c787127e91
fix: default to system accent color on invalid user color ( #47921 )
...
fix: default to system accent color on invalid user color"
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-05 15:08:55 +02:00
trop[bot]
61ba91a254
fix: crash on window.close()
with webContents
on blur ( #47953 )
...
fix: crash on window.close with WebContentsView on blur
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-08-04 15:42:55 +02:00
trop[bot]
d2af972af4
fix: window content protection on older Windows versions ( #47888 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-07-25 12:42:20 -04:00
trop[bot]
c41d692473
fix: webContents.downloadURL()
did not support referer header ( #47866 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: xufuhang <576484918@qq.com>
2025-07-23 14:22:30 +02:00
trop[bot]
b180cfee6c
fix: dialog file filters and macOS app bundles ( #47840 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-07-21 16:29:48 +02:00
trop[bot]
4a81ae7954
refactor: reduce scope of temporaries when getting dictionary values ( #47831 )
...
refactor: reduce scale of temporaries when getting dictionary values
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-07-21 10:26:59 -04:00
trop[bot]
440fb9a73e
fix: handle missing NativeWindowMac
in ElectronNSWindow
( #47811 )
...
fix: handle missing NativeWindowMac in ElectronNSWindow
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-07-18 10:09:40 +02:00
trop[bot]
9d7adf22af
fix: deprecation warning crash when no Node.js environment available ( #47770 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-07-16 12:19:51 -07:00
trop[bot]
c9c4c36a72
fix: fullscreen for windows without rounded corners ( #47683 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-07-08 15:21:41 +02:00
trop[bot]
e39cf315dc
fix: accent color should reflect system settings without restart ( #47657 )
...
fix: accentColor should reflect system settings without restart
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-07-04 10:57:23 +02:00
trop[bot]
ceefcd1d32
fix: crash on source capture with empty thumbnail size ( #47651 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-07-03 19:19:12 +02:00
Shelley Vohr
729ceb4360
fix: add back fallback wasm-trap handling ( #47623 )
2025-07-03 09:32:00 -04:00
trop[bot]
387394e084
refactor: avoid copies of large objects in range based for loops ( #47604 )
...
* Avoid copies of large objects in range-based for-loops.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6527689
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* Avoid copies of large objects in range-based for-loops in Browser::ShowAboutPanel()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-06-30 10:59:59 +02:00
trop[bot]
78f78bf8be
perf: avoid copying a vector when calling ConvertToWeakPtrVector() ( #47602 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-06-30 10:29:16 +02:00
trop[bot]
5eb6cec6e9
refactor: sync IsKillURL() with upstream impl in extension_tab_util.cc ( #47594 )
...
Use base::MakeFixedFlatSet()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-06-27 21:07:48 -05:00
trop[bot]
bddc661684
refactor: make context bridge's private keys hidden, constexpr string_views ( #47587 )
...
* refactor: local functions GetPrivate(), SetPrivate() now take std::string_views
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make local keys std::string_views instead of C-style char arrays
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make local keys constexpr
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move local keys into local anonymous namespace
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-06-27 12:42:36 -05:00
trop[bot]
33d23f5e00
refactor: remove stray .c_str()
calls for absl::StrFormat()
( #47576 )
...
refactor: remove stray .c_str() calls for absl::StrFormat()
StrFormat() understands std::string, std::string_view
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-06-26 08:18:10 -05:00
trop[bot]
13ceef30b7
feat: support customizing window accent color on Windows ( #47538 )
...
* fix: support window accent color in frameless windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: allow customization
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/structures/base-window-options.md
Co-authored-by: Will Anderson <andersonw@dropbox.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-25 22:51:42 +02:00
trop[bot]
d4a93c896d
fix: ensure /dev/null
fd is closed on failure ( #47541 )
...
* fix: ensure /dev/null fd is closed on failure
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: ignore closehandle for windows
Co-authored-by: Robo <hop2deep@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>
2025-06-24 14:22:56 -04:00
trop[bot]
cd42e9ba05
feat: add support for --no-experimental-global-navigator ( #47417 )
...
chore: add support for --no-experimental-global-navigator
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-06-24 14:42:46 +02:00
trop[bot]
2d9cb53a86
refactor: simplify titlebar overlay initialization ( #47523 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-06-23 21:56:52 +02:00
trop[bot]
f9cba35a25
feat: support HIDDevice.collections
( #47484 )
...
* feat: support HIDDevice.collections
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/structures/hid-device.md
Co-authored-by: Erick Zhao <ezhao@slack-corp.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-18 20:46:59 +02:00
trop[bot]
e98530ab7d
refactor: move gin::Converter<PreloadScript>
impl to a .cc file ( #47467 )
...
refactor: move gin::Converter<PreloadScript> impl to a .cc file
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-06-16 10:55:01 -04:00
trop[bot]
573c8aa656
refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> ( #47452 )
...
* refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-06-13 10:03:05 +02:00
trop[bot]
351e6e36f4
fix: rework lifetime mgmt of ClearDataTask
/ClearDataOperation
( #47411 )
...
* fix: rework lifetime mgmt of ClearDataTask/ClearDataOperation
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update shell/browser/api/electron_api_session.cc
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-12 12:24:50 +02:00
trop[bot]
55557dd3a6
fix: crash calling Fetch.continueResponse
with WebContentsView
( #47442 )
...
fix: crash calling Fetch.continueResponse with WebContentsView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-11 16:28:41 -05:00
trop[bot]
cac475579e
fix: printing PDF via webContents.print()
( #47400 )
...
fix: printing PDF via webContents.print()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-10 16:10:44 -04:00
trop[bot]
b328de39e5
feat: [net] add "priority" option to net.request ( #47320 )
...
document the default value of priority option
Update the priority test to not use the httpbin.org as server
Fixed the lint errors
Fixed the build error
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Zeeker <13848632+zeeker999@users.noreply.github.com>
2025-06-08 13:01:32 +02:00
trop[bot]
bb09671746
feat: allow intercepting mouse events ( #47365 )
...
* feat: allow intercepting mouse events
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: add specs
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update spec/api-web-contents-spec.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-05 18:35:33 +02:00
trop[bot]
a0633d9e25
feat: expose win.isContentProtected()
( #47311 )
...
* feat: expose win.isContentProtected()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: remove stray _isContentProtected
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-05 15:47:23 +02:00
electron-roller[bot]
63c7215cd1
chore: bump node to v22.16.0 (36-x-y) ( #47214 )
...
* chore: bump node in DEPS to v22.16.0
* crypto: remove BoringSSL dh-primes addition
https://github.com/nodejs/node/pull/57023
* tools: enable linter in test/fixtures/test\-runner/output
https://github.com/nodejs/node/pull/57698
* src: improve thread safety of TaskQueue
https://github.com/nodejs/node/pull/57910
* buffer: define global v8::CFunction objects as const
https://github.com/nodejs/node/pull/57676
* src: disable abseil deadlock detection
https://github.com/nodejs/node/pull/57582
* zlib: fix pointer alignment
https://github.com/nodejs/node/pull/57727
* chore: fixup patch indices
* src: set default config as node.config.json
https://github.com/nodejs/node/pull/57171
* src: update std::vector<v8::Local<T>> to use v8::LocalVector<T>
https://github.com/nodejs/node/pull/57578
* test: disable chmod tests failing in Docker
https://github.com/nodejs/node/issues/58326
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-06-04 15:03:35 +02:00
trop[bot]
2336cd67b7
fix: addChildView() crashes when adding a closed WebContentsView ( #47340 )
...
fix: addChildView() crashes when add a closed WebContentsView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sida Zhu <zhusida@bytedance.com>
2025-06-04 14:08:44 +02:00
trop[bot]
3da28fd115
fix: regression with directory selection in macOS dialogs ( #47278 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2025-05-27 11:17:09 -04:00
trop[bot]
45542e197b
fix: titlebar showing in content protected window ( #47264 )
...
Closes https://github.com/electron/electron/issues/47152 .
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-27 14:24:21 +02:00
trop[bot]
0c226d8d79
chore: debug crash on DevTools SetOwnerWindow ( #47262 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2025-05-26 20:33:02 -07:00
trop[bot]
38e990c6e0
refactor: use base::fixed_flat_set
in NativeWindowViews::SetAlwaysOnTop()
( #47239 )
...
refactor: use base::fixed_flat_set in NativeWindowViews::SetAlwaysOnTop()
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2025-05-23 12:58:24 -05:00