Kevin Sawicki
ba03f04017
Disable getFileIcon specs on Linux CI
2017-02-07 18:24:35 -08:00
Kevin Sawicki
82ac4ddf19
Large is only 48x48 on Linux
2017-02-07 11:20:27 -08:00
Kevin Sawicki
dddc6aec49
Tweak spec descriptions
2017-02-07 10:21:20 -08:00
Kevin Sawicki
683a758dab
Call done instead of skip
2017-02-07 10:16:09 -08:00
Yury Solovyov
a9dae243b4
Fix large icon spec
2017-02-07 09:55:18 -08:00
Yury Solovyov
bcf0964c61
Fix more review
2017-02-07 09:55:18 -08:00
Yury Solovyov
c36cdb8580
Properly skip large size test on macOS
2017-02-07 09:54:22 -08:00
Yury Solovyov
1aa4fcae08
Lint tests
2017-02-07 09:54:22 -08:00
Yury Solovyov
00748889f9
Add tests
2017-02-07 09:54:22 -08:00
Cheng Zhao
c72438f09f
WebInspector has been split up
2017-02-06 10:34:29 -08:00
Kevin Sawicki
1c6a07c68d
Clear Update.exe login item settings in afterEach
2017-02-06 08:34:35 -08:00
Kevin Sawicki
e2501a80e4
Add path and args to LoginItemSettings struct
2017-02-06 08:34:35 -08:00
Charlie Hess
d2ffd87668
I will never appreciate standard.
2017-02-06 08:34:35 -08:00
CharlieHess
852e158cc6
Make sure the spec takes arguments into account.
2017-02-06 08:34:35 -08:00
Charlie Hess
4fce00148d
Add a spec for this behavior on Windows.
2017-02-06 08:34:35 -08:00
Kevin Sawicki
daff671afc
Add protocol constant
2017-02-02 12:48:09 -08:00
Kevin Sawicki
a60f341968
Add procotol client specs on Windows
2017-02-02 12:48:09 -08:00
Kevin Sawicki
604c2470bc
Merge pull request #8561 from liusy182/!-liusy182-br
...
add 'code' property in 'before-input-event''s 'input' argument
2017-02-02 10:33:20 -08:00
liusi
87392ff046
'before-input-event' is missing the code property #8471
2017-02-02 16:23:07 +08:00
Kevin Sawicki
dc1c11a841
Merge pull request #8487 from leethomas/feature/osx-relative-window-levels
...
Feature/macOS relative window levels
2017-01-30 15:34:24 -08:00
Kevin Sawicki
94cb605993
Use strictEqual for global variable asserts
2017-01-30 10:08:12 -08:00
Kevin Sawicki
e99b1709d9
Redeclare process/global as strings
2017-01-30 09:58:44 -08:00
Kevin Sawicki
4e5b8ac3ee
Remove throws and assert object directly
2017-01-30 09:38:15 -08:00
James Ide
0430380de1
Update the Node submodule to use the new module wrapper
...
See the fixed issue for the context. This pulls in a vendored copy of Node that includes the described patch.
Fixes #8358
Test Plan: Built Electron and verified it loaded the sample app correctly and that the module wrapper is the new one by viewing Node's source code in the Blink Inspector.
Added specs and tested with `npm test -- --grep "global variables"`
2017-01-30 09:37:14 -08:00
leethomas
edbb786fb4
use kCGMinimumWindowLevelKey to get the minimum level
2017-01-26 19:12:10 -08:00
Kevin Sawicki
76e5589a31
Schedule function after executeJavaScript completes
2017-01-26 16:15:10 -08:00
Kevin Sawicki
e683f28e32
Require a non-empty drag image to prevent crash
2017-01-26 15:46:04 -08:00
Kevin Sawicki
8ce1930f0d
Add specs for missing startDrag options
2017-01-26 15:46:04 -08:00
Kevin Sawicki
06c025050e
Fix typo in spec description
2017-01-26 14:46:51 -08:00
Kevin Sawicki
1004d205d8
Add spec for unhandledRejection event in main process
2017-01-26 14:46:50 -08:00
Kevin Sawicki
24fb560a9d
Add failing spec for uncaught main process errors
2017-01-26 14:46:50 -08:00
Kevin Sawicki
2cfa67bdff
Remove linter warning
2017-01-26 09:59:07 -08:00
Kevin Sawicki
a851695bb9
Clear interval before setting new one
2017-01-26 09:57:53 -08:00
Kevin Sawicki
e2e33a8cf0
Guard against destroyed window or web contents
2017-01-26 09:57:00 -08:00
Kevin Sawicki
515f689814
Use helper function to show last dev tools panel
2017-01-26 09:42:45 -08:00
leethomas
9e189b9d2d
fix js lint errors
2017-01-26 07:14:47 -08:00
leethomas
1234b61fa6
spec to ensure an error is thrown when relativeLevel is set out of bounds
2017-01-25 19:39:57 -08:00
Kevin Sawicki
104cae8f68
Only call getNativeHandle on macOS
2017-01-25 14:26:05 -08:00
Kevin Sawicki
2ad46f1842
Add failing spec for empty image crashes
2017-01-25 14:26:05 -08:00
Kevin Sawicki
8e69f94df0
Merge pull request #8357 from electron/remote-events-error-message
...
Don't crash when calling stale remote listeners
2017-01-25 14:23:57 -08:00
Kevin Sawicki
330ac5f266
Fix standard linting error
2017-01-25 12:36:55 -08:00
Kevin Sawicki
56a8eb3a94
Check that sender is a WebContents instance
2017-01-25 12:36:55 -08:00
Charlie Hess
f6410d3b77
Assert that listener count decreases after a remove event.
2017-01-25 12:36:55 -08:00
Charlie Hess
c213971a2d
Write a warning instead of crashing.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
45986405b8
Assert remote event names
2017-01-25 12:36:55 -08:00
Charlie Hess
b04db2e546
Add a spec for the "renderer window closed" error.
2017-01-25 12:36:55 -08:00
Kevin Sawicki
f104e019be
Run crash reporter server specs on CI
2017-01-25 10:36:16 -08:00
Kevin Sawicki
8e39aea34a
Merge pull request #8478 from deepak1556/load_url_max_char_patch
...
WebContents: emit did-fail-load event when url exceeds character limit
2017-01-25 09:46:40 -08:00
deepak1556
d8a16a8ffb
fix spec
2017-01-25 14:20:33 +05:30
Kevin Sawicki
170c51ae85
Add spec for crashing node process
2017-01-24 13:49:45 -08:00