Cheng Zhao
3094f62f0b
fix: use webContentsId with contextId together ( #13749 )
...
After after using `processId-contextCounter` as contextId, it may happen
that contexts in different WebContents sharing the same renderer process
get the same contextId. Using webContentsId as part of key in
ObjectsRegistry can fix this.
2018-07-24 16:21:38 +09:00
Cheng Zhao
305e3aad40
refactor: remove private webContents.getId() API ( #13674 )
2018-07-23 18:08:36 +09:00
Jeremy Apthorp
16b66db9c7
build: [gn] working on 32bit windows
2018-07-19 17:04:44 -07:00
Cheng Zhao
e2029435c4
fix: use context counter as contextId
...
For sandboxed renderer it may not have a node::Environment in the context,
using a increasing counter as contextId works for all cases.
2018-07-19 11:00:10 -07:00
Shelley Vohr
6045d1218a
refactor: remove experimentalCanvasFeatures property ( #13684 )
2018-07-16 13:32:42 -07:00
Milan Burda
5b0a898dd2
refactor: SHOpenFolderAndSelectItems does not have to be dynamically resolved
2018-07-12 22:28:44 +02:00
John Kleinschmidt
e922b1733b
Merge pull request #13636 from nornagon/gn-release
...
build: [gn] release build
2018-07-12 10:45:21 -04:00
Cheng Zhao
4cdb1b8fc3
fix double-freeing remote references
...
After the page does navigations, garbage collection can still happen in
the old context. This commit changes to store references to remote objects
by _pages_, instead of by _WebContents_.
2018-07-12 10:44:26 +09:00
Cheng Zhao
9cbbb2a6c4
add API to return an unique ID for page
2018-07-12 10:44:26 +09:00
Jeremy Apthorp
03131c5e77
build: [gn] node as a static lib
2018-07-11 10:43:52 -07:00
Jeremy Apthorp
810909425e
chore: breakpad #include compatibility between GN and GYP
2018-07-09 16:53:06 -07:00
Jeremy Apthorp
d6af3bfcd2
chore: fix more chromium-style errors in windows code ( #13487 )
...
Finding more chromium-style linting errors as I build more of the windows code :)
2018-06-28 14:20:11 -07:00
Shelley Vohr
003a92e099
refactor: remove deprecated GetAs methods ( #13425 )
...
* refactor: remove deprecated GetAs methods
* restructure URLRequestAsyncAsarJob on win
* fix: add string conversion header
2018-06-27 14:52:48 -07:00
Samuel Attard
92588be2bd
refactor: add promise helper and change whenReady to be native impl ( #13115 )
...
* Add promise helper and change whenReady to be native impl
* remove commented code
* add GetInner helper to dedupe promise code
* add Promise.reject helper to be consistent with JS
* fix linting
* update promise impl per feedback
* remove param name from unused isolate
* Use non-depreceated resolvers for promises
* Add thread dchecks for promise helper, intiialize promise pointer to nullptr
2018-06-27 16:06:08 -05:00
Shelley Vohr
e9971173d4
fix: inline vector allocation ( #13449 )
...
* fix: inline vector allocation
* remove size_t static cast
2018-06-27 12:57:10 -07:00
Shelley Vohr
1dde9492c9
refactor: remove deprecated CreateWithCopiedBuffer ( #13436 )
...
* refactor: remove deprecated CreateWithCopiedBuffer
* fix: add missing vector includes
* fix std::vector<char> allocation
2018-06-26 15:08:27 -07:00
Jeremy Apthorp
4255384abc
chore: [gn] remove vendor/ from windows include paths ( #13432 )
2018-06-26 15:03:56 +10:00
Jeremy Apthorp
78bc1081fd
chore: fix some more warnings in windows build ( #13431 )
...
Remove an unused function and fix an int type comparison warning. Only showed up when building with GN.
2018-06-26 02:00:20 +02:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
Jeremy Apthorp
8ccb5cc6eb
chore: Annotate fallthrough switch paths with FALLTHROUGH
...
The compiler was throwing errors about unannotated fallthroughs when
building with GN.
2018-06-20 14:38:18 -07:00
Shelley Vohr
c20e0c30a2
src: base::Value::HasKey(key) => base::Value::FindKey(key) ( #13312 )
2018-06-20 13:07:10 +10:00
Milan Burda
d5d5386017
use std::make_unique<T>
2018-06-19 10:20:39 +02:00
Aleksei Kuzmin
c786abf1e9
Add gfx:PointF support to mate::Converter
...
It's needed by atom_api_screen, BuildPrototype function on Windows.
2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
81398c1fde
Use Chromium 66.0.3359.181 and Node.js 10.2.0
2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
016ac8ff6e
Set CHROME_VERSION_STRING to 66.0.3359.117
2018-06-19 11:49:43 +10:00
Tomas Rycl
7ca1b0704d
Rename ScopedWindowsThreadEnvironment::succeeded() to Succeeded()
...
https://chromium-review.googlesource.com/742447
2018-06-19 11:49:43 +10:00
Tomas Rycl
1ac0ab2b71
Include missing "windows.h" and fix headers ordering
...
For PCWSTR on line 198.
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
f6648a0d4d
Remove ScopedComPtr and scoped_comptr.h
...
https://chromium-review.googlesource.com/726461
2018-06-19 11:49:43 +10:00
Aleksei Kuzmin
ac33694028
Update chrome_version.h
2018-06-19 11:49:43 +10:00
deepak1556
405adb938b
Permissions: Remove CONTENT_SETTINGS_TYPE_PUSH_MESSAGING
...
https://chromium-review.googlesource.com/c/chromium/src/+/758456
2018-06-19 11:49:42 +10:00
deepak1556
c4b8e106c0
Create network_converter for services/network/* types
2018-06-19 11:49:42 +10:00
deepak1556
f1e2304585
Remove OSCertHandle typedefs, use smart pointers for CRYPTO_BUFFER ownership.
...
https://chromium-review.googlesource.com/c/chromium/src/+/775540
2018-06-19 11:49:42 +10:00
deepak1556
77f427acc8
Check for key system support using new mojo service KeySystemSupport
...
https://chromium-review.googlesource.com/c/chromium/src/+/834764
2018-06-19 11:49:42 +10:00
Aleksei Kuzmin
e1f25253db
REVIEW: Don't use removed and deprecated Value::To* APIs
...
See https://chromium-review.googlesource.com/848782 for removed APIs.
2018-06-19 11:49:42 +10:00
Aleksei Kuzmin
a218c9696c
Fix error: no matching constructor for initialization of 'v8::TryCatch'
...
The deprecated constructor has been removed
in https://chromium-review.googlesource.com/848782
2018-06-19 11:49:42 +10:00
deepak1556
2f7c413199
v8: set fatal error handler per isolate
2018-06-19 11:49:42 +10:00
deepak1556
eab4227cbf
Make Origin(const GURL&) constructor private.
...
https://chromium-review.googlesource.com/c/chromium/src/+/729284
2018-06-19 11:49:42 +10:00
Aleksei Kuzmin
1a11bb936b
ui::Display cleanup: some enums --> enum classes
...
https://chromium-review.googlesource.com/915211
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
4602d940cf
Add missing header
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
2c4bbacec1
Remove base::Value::GetType()
...
https://chromium-review.googlesource.com/718458
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
37168c0a95
Move ResourceRequestBody to services/network in preparation of moving content/network.
...
https://chromium-review.googlesource.com/864422
2018-06-19 11:49:41 +10:00
Aleksei Kuzmin
a315d6330c
Remove base::Value::IsType
...
https://chromium-review.googlesource.com/659798
2018-06-19 11:49:40 +10:00
Aleksei Kuzmin
2f11870970
Update Chrome version
2018-06-19 11:46:59 +10:00
Aleksei Kuzmin
79010b9e06
Set CHROME_VERSION_STRING to 66.0.3359.66
2018-06-19 11:46:58 +10:00
Samuel Attard
72c7fe5e56
Bump chromium version
2018-06-19 11:46:58 +10:00
Zhuo Lu
ab24a1e36d
feat: netLog API for dynamic logging control ( #13068 )
...
* Introduce `net.{start|stop}Logging()`
- Slight regression right now as Electron won't automatically start logging net-logs at launch, will soon be fixed
- To implement callback for async controls
* Add `net.isLogging` & optional callback param for `net.stopLogging()`
* Fix small regression on --log-net-log
--log-net-log should work again
* Error on empty file path
* Only start with valid file path
* Remove unused var
* Allow setting log file path before URLRequestContextGetter starts logging
* Add net log tests
* Remove redundant checks
* Use brightray::NetLog
* Clean up code
* Should automatically stop listening
* 🎨 Attempt to fix styles
* Only run non-null callback
* Dump file to tmpdir
* Simplify net log spec
Spawned Electron process on Linux CI can fail to launch
* Separate netLog module
* Remove net logging test from net spec
* Add tests for netLog
* Fix header guard
* Clean up code
* Add netLog.currentlyLoggingPath
* Callback with filepath
* Add test for case when only .stopLogging() is called
* Add docs
* Reintroduce error on invalid arg
* Update copyright
* Update error message
* Juggle file path string types
2018-06-19 11:45:58 +10:00
Cheng Zhao
70e17b5f8f
feat: add LabelButton API
2018-06-18 16:51:36 +09:00
Cheng Zhao
c8e8cb86ce
feat: add Button API
2018-06-18 16:51:36 +09:00
Cheng Zhao
ba3700141f
feat: add TextField API
2018-06-18 16:51:36 +09:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00