Shelley Vohr
da67cbf551
feat: add property support for remainder of BrowserWindow ( #22771 )
...
Adds property-based support for the remainder of primitive gette/setter pairs on `BrowserWindow`.
Namely:
- `win.simpleFullScreen`
- `win.title`
- `win.visibleOnAllWorkspaces`
- `win.documentEdited`
- `win.representedFilename`
- `win.shadow`
- `win.kiosk`
- `win.menuBarVisible`
2020-04-01 08:22:32 -07:00
Cheng Zhao
14051ff945
test: do not trigger unhandled promise rejections ( #22922 )
2020-04-01 09:45:39 -04:00
Cheng Zhao
e6f2605ad0
fix: webRequest module should work with file:// protocol ( #22903 )
...
* fix: override file:// instead of intercepting
* test: webRequest module should work with file://
* fix: service work with file:// url
* fix: original_response_headers can be null
* fix: only register file:// when necessary
2020-04-01 16:38:40 +09:00
Robo
bac1c7f532
fix: ensure standard schemes are registered in nw service process ( #22867 )
...
* fix: ensure standard schemes are registered in nw service process
Refs https://github.com/electron/electron/pull/20546
* chore: add test
* chore: apply suggestions from code review
Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org>
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org>
2020-03-31 19:33:16 -07:00
Jeremy Apthorp
765c08c600
refactor: ginify Notification ( #22821 )
2020-03-31 11:42:32 -07:00
Samuel Attard
fea3366bc7
fix: propagate preferred color scheme to the renderer ( #22896 )
...
* fix: do not crash if the window is closed syncronously with a nativeTheme change
* fix: propogate preferred color scheme to the renderer and keep it up to date
2020-03-30 15:39:50 -07:00
Jeremy Apthorp
a3e28788ce
refactor: ginify Tray ( #22822 )
...
* refactor: ginify Tray
* lint
* improve argument parsing logic
* remove redundant imports from tray.js
* new Tray produces an instanceof Tray
* make Constructible generic
* lint
* clean up on exit
2020-03-30 10:32:02 +09:00
Jeremy Apthorp
ac501e8194
fix: heap-use-after-free in tray.popUpContextMenu ( #22842 )
2020-03-26 18:30:21 -07:00
Heilig Benedek
74372d65ae
feat: enhance native window.open to match the custom implementation's behavior ( #19703 )
...
Co-authored-by: Andy Locascio <andy@slack-corp.com>
2020-03-26 11:05:45 -07:00
Jeremy Apthorp
b327478cf0
fix: prevent remote from messing with constructor names ( #22820 )
2020-03-25 13:13:10 -07:00
CezaryKulakowski
bdef77bad8
fix: don't allow window to go behind menu bar on mac ( #22770 )
2020-03-25 11:13:43 +09:00
Jeremy Apthorp
07cd70a37e
refactor: ginify powerMonitor ( #22751 )
2020-03-24 09:03:29 -07:00
Samuel Attard
e678794dd0
build: fix beta version bumper logic for betas beyond 10 ( #22810 )
2020-03-24 09:04:12 -04:00
Samuel Attard
af46c1ed8d
fix: allow net requests to use Same-Site cookies ( #22788 )
2020-03-20 16:39:03 -07:00
Samuel Attard
60bd52880f
feat: add support for net requests to use the session cookie store ( #22704 )
2020-03-20 15:56:02 -07:00
Samuel Attard
5d657dece4
build: enable JS semicolons ( #22783 )
2020-03-20 13:28:31 -07:00
Samuel Attard
b87b501161
build: update eslint + eslint plugins ( #22777 )
...
* build: run eslint --fix
* chore: manually fix all hasOwnProperty errors
* chore: manually fix all void 0 vs undefined errors
* chore: manually fix all async-in-promise errors
* chore: manually fix lexical declaration in case block
2020-03-20 11:12:18 -04:00
Samuel Attard
aa15a2cc03
build: update typescript and webpack ( #22776 )
2020-03-19 16:55:49 -07:00
Cheng Zhao
47e27aee5b
test: no need to loadURL in menu test ( #22737 )
2020-03-19 10:49:40 +09:00
Jeremy Apthorp
c4a7eade28
refactor: ginify session.netLog ( #22732 )
2020-03-18 16:46:05 -07:00
Samuel Attard
e58a35e5aa
chore: fix net specs when rerunning locally ( #22745 )
2020-03-18 16:35:23 -07:00
Shelley Vohr
fc661ec56b
chore: update app module property support ( #22713 )
2020-03-18 10:06:41 -07:00
Samuel Attard
1ea21e42bb
chore: refactor all the net specs to be async with better error handling ( #22731 )
2020-03-18 08:59:44 -07:00
Shelley Vohr
674e4a9fdd
chore: more modules to dual prop/fn support ( #22688 )
2020-03-17 18:06:52 -07:00
Shelley Vohr
97d8caa1e0
chore: support props/fns for BrowserWindow ( #22686 )
2020-03-16 14:03:35 -07:00
Shelley Vohr
a4c4c86b9d
fix: crash on invalid zoomFactor ( #22673 )
2020-03-13 16:13:05 -07:00
Jeremy Apthorp
9c5874306d
fix: crash when destroying WebContentsView during GC ( #22674 )
2020-03-13 10:33:37 -07:00
Shelley Vohr
1b353d1ed3
chore: revert deprecated WebContents properties ( #22640 )
...
* chore: revert deprecated WebContents properties
* Fix failing zoomFactor test
2020-03-13 10:16:08 -07:00
Jeremy Apthorp
0c02d794c9
feat: add onclose method to MessagePort ( #22532 )
...
* feat: add onclose method to MessagePort
* more scope, more good
* de-flake GC test
2020-03-13 10:00:50 -07:00
Jeremy Apthorp
b4d07f76d3
feat: MessagePorts in the main process ( #22404 )
2020-03-11 18:07:54 -07:00
Erick Zhao
34e004015d
feat: add API to check if session is persistent ( #22622 )
2020-03-11 16:02:22 +09:00
Jeremy Apthorp
19314d3caf
fix: remove catch-all HandleScope ( #22531 )
2020-03-10 18:16:58 -07:00
Shelley Vohr
b607cfa220
test: test setPath for errors thrown ( #22626 )
2020-03-10 09:03:52 -07:00
Alexey Kuzmin
bf75e5a91f
build: fix build without built-in spellchecker ( #22594 )
2020-03-10 18:39:40 +09:00
Erick Zhao
3ff98e15d0
fix: prevent in-memory sessions from writing to custom spellchecker dictionary ( #22157 )
...
* fix: prevent in-memory sessions from writing to custom dictionary
* docs
* spec
2020-03-10 16:45:43 +09:00
Cheng Zhao
8075a55815
test: disable spellchecker context menu test for arm ( #22590 )
2020-03-10 11:13:41 +09:00
Samuel Attard
3e2cec83d9
feat: programmatically modify traffic light positioning ( #22533 )
...
* setter
* getter
* specs and docs
* fixup
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2020-03-05 14:22:12 -08:00
John Kleinschmidt
0201b3e571
feat(extensions): add chrome.tabs.connect API ( #22457 )
...
* feat(extensions): add chrome.tabs.connect API
* test(extensions): verify that chrome.tabs.connect port communication works
2020-03-05 09:59:32 -05:00
John Kleinschmidt
d6701ff435
feat(extensions): add chrome.i18n API ( #22455 )
...
* feat(extensions): implement chrome.i18n API
* refactor(extensions): use forward declaration for ScriptExecutor
* fix(extensions): add message filter to handle i18n GetMessageBundle
* test(extensions): add chrome.i18n tests
* fix(extensions): message filter lint error
* fix: remove exclusive test
* fix(extensions): format api feature arrays
Co-Authored-By: Jeremy Apthorp <nornagon@nornagon.net>
* fix(extensions): uncomment chrome.i18n usage in old extensions test
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-05 09:56:21 -05:00
Samuel Attard
2563681583
fix: disable contextBridge object identity caching ( #21803 )
...
* fix: disable contextBridge object identity caching
* cleanup
* chore: make non-const references raw pointers
* fix: zero-param constructors are not explicit
* refactor: use base::LinkedList
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-03 23:18:22 -08:00
Electron Bot
39baf68790
chore: bump chromium to 5b340c815ce15ab2efcf277ed19e9 (master) ( #22064 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: loc <andy@slack-corp.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
2020-03-03 13:35:05 -08:00
Cheng Zhao
0e0c8e7c6f
test: give arm machines more time to load spellchecker ( #22494 )
2020-03-03 15:03:54 +09:00
Erick Zhao
01c597a646
test: add specs for custom dictionary API ( #22158 )
...
* tests
* test: add specs for custom dictionary API
* await
2020-03-02 16:57:46 -08:00
CezaryKulakowski
0bc906853e
fix: call focus on native window on call to webContents.focus on mac ( #22323 )
...
* fix: call focus on native window on call to webContents.focus on mac
On mac call to web_contents()->Focus() is not enough so it's
necessary to call it on native window.
* fixup! fix: call focus on native window on call to webContents.focus on mac
* fixup! fix: call focus on native window on call to webContents.focus on mac
* test: close all windows after test
* fix: also match the behavior on Linux
Co-authored-by: Cheng Zhao <zcbenz@github.com>
2020-03-02 16:51:02 +09:00
Cheng Zhao
4c6150ea3d
fix: make webRequest work for CORS preflight requests ( #22407 )
...
* fix: support CORS preflight
* test: webRequest should work for CORS requests
2020-03-02 10:23:43 +09:00
Shelley Vohr
2c974915a3
fix: do not call close on sheets themselves ( #22410 )
2020-02-28 23:10:21 +00:00
Samuel Attard
4323b6d618
chore: add tests for the spellchecker ( #22099 )
...
* chore: add tests for the spellchecker
* chore: do not run spellchecker tests on windows
2020-02-26 17:29:19 -08:00
Samuel Attard
ee04c7f7ee
fix: allow persistent media salts ( #22386 )
...
* fix: allow persistent media salts
* chore: add regression test for persistent media device ids across reloads
2020-02-26 16:03:55 -08:00
Erick Zhao
85ef762269
fix: guard against duplicate TouchBarItem IDs ( #22272 )
...
* feat: Add OtherItemsProxy touchbar item
* review!
* fix: guard against duplicate TouchBarItem IDs
* add spec
2020-02-26 22:12:56 +00:00
Samuel Attard
12c1d4411d
chore: add deprecation warning on setting app.allowRendererProcessReuse to false ( #22337 )
...
* chore: add deprecation warning on setting app.allowRendererProcessReuse to false
* fix: no deprecation warnings in process reuse spec
* chore: add test for new deprecate removeProperty behavior
2020-02-26 14:03:52 -08:00