Cheng Zhao
67f052a6e1
Merge pull request #12168 from electron/easier-web-contents-preferences
...
Cleanup the static methods of WebContentsPreferences
2018-03-22 15:58:04 +09:00
Cheng Zhao
05fcec829e
Use Clone explicitly instead of MergeDictionary
2018-03-22 15:29:20 +09:00
Cheng Zhao
0abbedcdae
Fix error caused by refactor
2018-03-22 15:21:56 +09:00
Cheng Zhao
6df2326a30
Cleanup the static methods of WebContentsPreferences
...
The static methods are totally unnecessary, and it makes code harder to
understand since we are using different ways to do the same things.
2018-03-22 15:21:56 +09:00
Cheng Zhao
001275339b
Hide WebContentPreferences::GetWebContentsFromProcessID from public
2018-03-22 15:20:03 +09:00
Cheng Zhao
3d47a8a2fd
Remove the static getter methods from WebContentsPreferences
2018-03-22 15:20:03 +09:00
Cheng Zhao
887bc12350
Add WebContentsPreferences::From that checks parameter
2018-03-22 15:16:26 +09:00
Cheng Zhao
9772777919
web_prefrences() => dict()
...
Having property name being the same with class name is making code
harder to understand, and dict is much shorter.
2018-03-22 15:15:30 +09:00
Zeke Sikelianos
d323ce2c42
Merge pull request #12399 from electron/now-we-call-ourselves-electrocats
...
now we call ourselves electrocats
2018-03-21 17:06:59 -07:00
Zeke Sikelianos
7c0c798c90
now we call ourselves electrocats
2018-03-21 16:50:52 -07:00
Shelley Vohr
05dc04dacc
don't check darkmode for drawStatusBarBackgroundInRect ( #12395 )
2018-03-21 19:03:57 -04:00
Charles Kerr
0d7becff87
Use the appname as the tray icon's default tooltip ( #12388 )
...
This makes an upstream DCHECK happy in AppIndicatorIcon::SetToolTip.
Empty tooltip strings are discouraged, as discussed in commit log
b6c510aa543193337041517c2d70113840189b06.
Fixes #12386 .
2018-03-21 12:15:30 -05:00
htk3
6fa4ec22c5
fix broken fragment link in ipc-main.md ( #12389 )
2018-03-21 12:05:27 -05:00
bughit
37eccbcd33
Update 3 (of Visual Studio 2017) is leftover from 2015 ( #12372 )
...
does not apply to 2017
it's not clear to me that it's possible to download a non current version of vs2017
but if a specific version is required the directions should explain how to get it
2018-03-20 16:15:59 -05:00
Zeke Sikelianos
e3dfffb77b
add docs/development/README.md ( #12373 )
2018-03-20 15:36:48 -04:00
John Kleinschmidt
060b592fc8
Merge pull request #12348 from electron/fix-browser-view-draggable-region
...
Update draggable regions when changing BrowserView
2018-03-20 10:40:27 -04:00
Cheng Zhao
cd30a4e2d4
Merge pull request #11459 from electron/upgrade-to-chromium-63
...
Upgrade to Chromium 63
2018-03-20 17:25:34 +09:00
Cheng Zhao
c70150847d
Ignore warning LNK4199
...
We are now sharing the /DELAYLOAD settings between configurations.
2018-03-20 10:13:17 +03:00
Cheng Zhao
2e94a730cc
Isolate the code using content::WebContentsImpl
2018-03-20 10:13:17 +03:00
Gellert Hegyi
a9cdd6614a
fixes class name
2018-03-20 10:13:17 +03:00
Gellert Hegyi
0ad8815bbc
fixes offscreen rendering issues
2018-03-20 10:13:17 +03:00
Cheng Zhao
d4969783d7
Avoid including web_contents_impl.h
...
This can fix the build error caused by duplicate typedefs.
2018-03-20 10:13:17 +03:00
deepak1556
f5e1ee010b
FIXME: disable pdf viewer feature
2018-03-20 10:13:17 +03:00
deepak1556
e24c0dda5d
add features module to detect availability of build time features at runtime
2018-03-20 10:13:17 +03:00
deepak1556
4b39d17e5f
move pdf viewer behind feature flag
2018-03-20 10:13:17 +03:00
deepak1556
c1908147a9
Fix windows build
2018-03-20 10:13:17 +03:00
John Kleinschmidt
6aebae5a98
Remove custom appveyor config
2018-03-20 10:13:17 +03:00
Aleksei Kuzmin
714a793a0e
Update to the latest libcc with Ch63
2018-03-20 10:13:17 +03:00
Cheng Zhao
94fce43ed9
Emit document-start for the correct env
...
This fixes the crash in RunScriptsAtDocumentStart when "affinity" option
is specified. Previously we were assuming only one main frame exists in
the renderer process, but the "affinity" option breaks this option.
There is also a bug that "node::Environment::GetCurrent" does not return
nullptr for context without a env in it, I'm not sure whether it is a
bug of Node or V8.
2018-03-20 10:13:17 +03:00
deepak1556
c3f8f6bc42
re-use request context from IOThread
2018-03-20 10:13:17 +03:00
Cheng Zhao
97fcf7079b
Update chrome_version.h
2018-03-20 10:13:17 +03:00
Cheng Zhao
cb4c54eec1
Use 60 as module version for V8 6.3
2018-03-20 10:13:17 +03:00
deepak1556
9702898dcd
AccessTokenStore is only needed to initialize network location service
2018-03-20 10:13:17 +03:00
deepak1556
97eb7f2c98
REVIEW: ContentBrowserClient now provides geolocation api key and request context
2018-03-20 10:13:16 +03:00
deepak1556
f9de29ed8c
Enable node crypto spec
2018-03-20 10:13:16 +03:00
Cheng Zhao
246f6318e4
Fix release build on Windows
2018-03-20 10:13:16 +03:00
Aleksei Kuzmin
d5ecbfc539
spec: Do not assume en-US locale to be the current
2018-03-20 10:13:16 +03:00
John Kleinschmidt
750c3d05aa
debug build issues
2018-03-20 10:13:16 +03:00
John Kleinschmidt
dfc4dbdbd3
Drop clone folder
2018-03-20 10:13:16 +03:00
John Kleinschmidt
d58b366123
Add whole appveyor config
2018-03-20 10:13:16 +03:00
John Kleinschmidt
d90b600bc1
Use visual studio 17 image
2018-03-20 10:13:16 +03:00
Aleksei Kuzmin
d3afb595dc
Tab Capture in VIZ: CopyOutputRequest/Result API changes.
...
https://chromium-review.googlesource.com/637003
2018-03-20 10:13:16 +03:00
Aleksei Kuzmin
639be7f7bc
Simplify transparent backgrounds
...
https://chromium-review.googlesource.com/669646
2018-03-20 10:13:16 +03:00
Cheng Zhao
b6b7707dc3
Fix Windows linking error
2018-03-20 10:13:16 +03:00
Cheng Zhao
624e09533c
Avoid using deprecated skia size methods
2018-03-20 10:13:16 +03:00
Cheng Zhao
42938de973
Build with Visual Studio 2017
2018-03-20 10:13:16 +03:00
deepak1556
e6d38cb64e
update node ref to fix --typed_array_max_size_in_heap error
2018-03-20 10:13:16 +03:00
Nitish Sakhawalkar
524f56354c
Fix webview resize test
2018-03-20 10:13:16 +03:00
deepak1556
5e9da04ab7
update libcc ref to disable ScriptForbuddenScope check
2018-03-20 10:13:16 +03:00
deepak1556
f4ee48eaf4
v8-platform header is not required explicitly
2018-03-20 10:13:16 +03:00