Shelley Vohr
1f246229b1
test: convert node spec to expect ( #15345 )
2018-10-24 11:23:12 +11:00
Jeremy Apthorp
9474fc0082
chore: electron alias should be defined with public_deps ( #15349 )
2018-10-23 17:22:41 -07:00
Jeremy Apthorp
af339f44f4
chore: remove disable_scroll_begin_dcheck.patch ( #15233 )
2018-10-23 17:21:47 -07:00
Jeremy Apthorp
d03527ae47
build: skip pyproto/ resources in zip.py ( #15348 )
2018-10-23 17:19:02 -07:00
Shelley Vohr
40874ddec6
fix: update fs methods for options param ( #15323 )
...
* fix: update fs methods for options param
* fix: update rest of fs methods with changes
2018-10-23 15:14:05 -07:00
Milan Burda
465dee2c33
refactor: eliminate brightray::BrowserMainParts ( #15336 )
2018-10-23 13:15:55 -07:00
Charles Kerr
869e0ab14d
fix: honor dialog.showMessageBox()'s Icon argument on Linux ( #15326 )
...
* Don't call gtk_widget_show_all() on popup dialog.
Fixes #15317 .
Notes: Fixed incorrect display of some GtkMessageDialog icons.
The issue is caused because GtkMessageDialog contains an icon widget
which is not shown when there's no associated icon. Our call to
`gtk_widget_show_all()` overrides this, showing the uninitialized
icon widget.
This PR fixes the issue by calling `gtk_widget_show()` where needed
and removing use of `gtk_widget_show_all()` in the message dialog.
* use gtk_dialog_set_default_response() for default
* fix: support icons on gtk+ messageboxes.
2018-10-23 12:44:47 -05:00
Cheng Zhao
260778e0fb
feat: add MdTextButton to View APIs ( #15328 )
...
* view: make button focusable by default
* view: add MdTextButton
* view: add common methods to LabelButton
2018-10-23 10:57:13 -04:00
Masato Kinugawa
43a8b6039e
docs: Fix CSP header setting of sample code ( #15313 )
...
* Fix CSP header setting of sample code
Patch for #15310
* Update docs/tutorial/security.md
Co-Authored-By: masatokinugawa <masatokinugawa+github@gmail.com>
2018-10-23 10:38:48 -04:00
Nitish Sakhawalkar
ca4b4709e5
fix: Native window close crash ( #15327 )
2018-10-23 10:35:00 -04:00
Milan Burda
809bd3757b
refactor: eliminate brightray::MainDelegate ( #15333 )
2018-10-23 14:16:13 +02:00
Milan Burda
fbbb704146
refactor: eliminate brightray::BrowserClient ( #15320 )
2018-10-23 10:45:41 +02:00
Martin Mädler
a4fefbe836
docs: update Windows build instructions ( #14797 )
2018-10-22 16:40:39 -04:00
Alexey Kuzmin
5e199152e2
ci: run unittests on clean Chromium ( #15125 )
...
* ci: run unittests on clean Chromium
* test: add '--run-only-disabled-tests' flag to "script/native-tests.py"
* ci: add a job to run only disabled unittests
* test: use a different GN config for the native tests
* test: enable blink_common_unittests
* test: disable WeakPtrDeathTest*
2018-10-22 16:12:19 -04:00
Michelle Tilley
13247e592b
fix: correct reversed logic in NativeWindowMac::SetEnabled ( #15257 )
2018-10-22 13:01:45 -07:00
Jeremy Apthorp
044e43397f
build: reenable -fwhole-program-vtables ( #15228 )
2018-10-22 12:07:46 -07:00
Cheng Zhao
cb9be091aa
refactor: remove potential double free when managing WebContents ( #15280 )
...
* refactor: remove -new-contents-created event
Chromium expects us to take ownership of WebContents in AddNewContents,
we should not create V8 wrapper in WebContentsCreated, otherwise we
would have WebContents being managed by 2 unique_ptr at the same time.
* refactor: make CreateAndTake take unique_ptr
2018-10-22 13:02:25 -05:00
Milan Burda
e8e7edf017
refactor: eliminate brightray::ContentClient ( #15303 )
2018-10-22 19:04:23 +02:00
Samuel Attard
9262731f2c
docs: we don't emit an event object for session-created ( #15236 )
2018-10-20 19:46:21 -07:00
Alexey Kuzmin
ba7ce7225b
build: document env vars expected to be set for the CI configs ( #15129 )
...
* ci: add a var for a full path to an Electron build config
* ci: document external environment variables used by the CI build configs
2018-10-20 01:44:36 +02:00
Shelley Vohr
939ee94e67
spec: increase MAS timeout for login items ( #15291 )
2018-10-19 13:11:11 -07:00
Shelley Vohr
f9f34fd628
fix: ability to fetch separators by id ( #15290 )
2018-10-19 13:09:40 -07:00
Milan Burda
6d844a0b67
refactor: move media/net from brightray to atom ( #15288 )
2018-10-19 14:51:43 -04:00
Milan Burda
6f3c46cc7e
refactor: move devtools from brightray to atom ( #15234 )
2018-10-19 15:50:30 +02:00
Samuel Attard
122017e6fa
fix: trim app name and productName ( #15269 )
...
Fixes #15245
2018-10-19 23:57:55 +11:00
Samuel Attard
16dcc464cf
chore: make macOS release builds higher priority to skip the queue ( #15276 )
...
Release builds should be run before branch builds on our limited macOS
infra.
Refs: https://docs.microsoft.com/en-us/rest/api/vsts/build/builds/queue?view=vsts-rest-4.1#queuepriority
2018-10-19 23:56:40 +11:00
Cheng Zhao
94aa0762f0
refactor: remove WebContents::CreateFrom ( #15241 )
2018-10-19 17:52:07 +09:00
Alexey Kuzmin
b3f134de06
test: asyncawaitify one of sandbox related tests ( #15252 )
2018-10-19 14:28:23 +11:00
Charles Kerr
363712d057
fix: make release-artifact-cleanup executable ( #15225 )
...
* fix: make release-artifact-cleanup executable
* fix misc issues in cleanup script
2018-10-18 20:20:43 -07:00
Samuel Attard
8bc0c343fa
fix: convert wstring to string on windows in node_bindings ( #15266 )
2018-10-19 13:11:43 +11:00
Andy Dill
37f2113032
feat: expose setBackgroundThrottling api ( #15104 )
2018-10-19 11:32:22 +11:00
Eric
10db2bce4e
fix: loading of devtools extensions on startup ( #13844 )
...
* Fix loading of devtools extensions on startup
The persisted DevTools Extensions were not being loaded correctly at startup. The `addDevToolsExtension` function was not defined when it was being called. An error was being thrown and ignored, so the whole thing would fail silently. I moved the code to load the extensions to the end of the event handler, so now it works.
* fixup: remove trailing spaces to unblock CI
* fixup: add logging when the Electron Enable Logging env var is set
* Fix linter error on undefined srcDirectory
* fixup: catch exception when loading extension
* Revert "fixup: catch exception when loading extension"
This reverts commit 42c2cf95bcaab8abfc5fbecbe4365d3adfe36d5b.
2018-10-19 11:22:42 +11:00
Nitish Sakhawalkar
c0db0011ec
fix: Convert to lower case in upload symbols script ( #15258 )
...
* fix: Convert to lower case in upload symbols script
* fix: Convert to lower case in upload symbols script
2018-10-19 11:18:35 +11:00
Jeremy Apthorp
4de502252b
chore: roll node ( #15177 )
...
* chore: roll node
brings in electron/node#76 and electron/node#77
* chore: roll node
2018-10-19 10:58:46 +11:00
Shelley Vohr
a0b9d47d5e
fix: enable NODE_OPTIONS env var ( #15158 )
2018-10-19 10:57:28 +11:00
Michelle Tilley
51f3fb9bde
fix: correctly enable and disable windows on Windows and Linux ( #15184 )
2018-10-18 14:23:40 -07:00
Jeremy Apthorp
7cab7b6c7e
chore: don't set allow_new_privs in new processes ( #15229 )
2018-10-18 11:53:26 -07:00
Jeremy Apthorp
993c2413e8
chore: add documentation for blink_file_path.patch ( #15235 )
2018-10-18 11:40:16 -07:00
Nitish Sakhawalkar
a9ca152069
feat: Spellchecker Async Implementation ( #14032 )
...
* feat:Spellchecker Async Implementation
* Adhere to chromium style
* Updating dependency to use gh branch
* Update docs and electron-typescript-definitions module
* Fix lint
* Update electron typescript definitions version
* Update spec
* Address review
2018-10-18 11:11:53 -05:00
John Kleinschmidt
4bbb70de74
ci: make sure git directories don't have unneeded files in them ( #15247 )
2018-10-18 11:35:40 -04:00
Milan Burda
db37ab1039
feat: add remote.require() / remote.getGlobal() filtering ( #15014 )
2018-10-18 14:36:45 +11:00
Jeremy Apthorp
dffe4fdd4f
chore: remove disabling of ANGLE dchecks ( #15227 )
2018-10-17 17:00:47 -07:00
Jeremy Apthorp
ac6d815c0e
chore: remove desktop_screen_win.patch ( #15232 )
...
that function is never called with a null argument (all call-sites are guarded)
2018-10-17 16:59:46 -07:00
Jeremy Apthorp
af9cbb4514
chore: remove unnecessary build_toolchain_win_patch.patch ( #15231 )
...
it fixed an issue in the GYP build that is no longer present in the GN build
2018-10-17 16:23:00 -07:00
Jeremy Apthorp
04b7f0d2d6
chore: remove skia/dcheck.patch ( #15223 )
2018-10-17 13:46:10 -07:00
Jeremy Apthorp
65fa9d2883
chore: remove webrtc patch to disable a warning ( #15218 )
2018-10-17 12:56:08 -07:00
Milan Burda
508551b81b
fix: small refactoring regressions ( #15206 )
...
* fix: require('@electron/internal/browser/guest-view-manager')
* fix: add missing crashServicePid used by tests
2018-10-17 12:18:18 -07:00
Milan Burda
a369a4172b
refactor: move notifications from brightray to atom ( #15209 )
2018-10-17 20:01:11 +02:00
Heilig Benedek
4d085c4aae
fix: don't call ReadRawDataComplete if it's not necessary ( #15185 )
2018-10-16 21:57:26 -07:00
Adam Meyer
d43ef97a7b
add width to webview iframe ( #15195 )
2018-10-17 09:33:31 +09:00