Milan Burda
6f117b8e0c
feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue() ( #16282 )
...
* feat: add app.commandLine.hasSwitch() / app.commandLine.getSwitchValue()
* add more tests
* refactor: move appendSwitch / appendArgument to command_line module
* replace AppendSwitchASCII with AppendSwitchNative
* remove castArgs
2019-01-07 07:48:27 -08:00
Jeremy Apthorp
959c7a76e9
Merge pull request #16252 from electron/miniak/guest-view-manager
...
fix: security: improve IPC validation in guest-view-manager
2019-01-04 16:47:27 -08:00
Milan Burda
a0cdcc5f8d
security: improve IPC validation in guest-view-manager
2019-01-05 00:06:47 +01:00
Jeremy Apthorp
849dd0db64
fix: correctly pass hidden-page argument to isolated renderers ( #16258 )
2019-01-04 08:25:47 -08:00
Milan Burda
3f1d22759a
refactor: use helpers for command-line parsing in renderer/init.js ( #16239 )
2019-01-03 11:22:34 -05:00
Cheng Zhao
a5e63dc5fd
fix: don't expose isolatedWorld
to global ( #16208 )
2018-12-28 10:54:32 +09:00
Milan Burda
547097b036
security: allow to block desktopCapturer.getSources() calls ( #15964 )
...
* security: allow to block desktopCapturer.getSources() calls
* return empty instead of error
* fix: release resources of DesktopCapturer on exit
2018-12-20 11:44:30 +09:00
Alex Greenland
dc93d94bc8
fix: support async child process methods without callback in asar ( #15927 )
...
* fix: support async child process methods without callback in asar
* fix: support async child process methods without callback in asar (improved)
2018-12-18 16:27:39 +09:00
Milan Burda
7a6fe00f49
chore: simplify code for modules internally using remote.require in sandbox ( #16104 )
2018-12-17 22:47:41 +03:00
Cheng Zhao
8584c2f14b
fix: register webview in main world when using contextIsolation ( #16067 )
2018-12-14 15:38:35 +09:00
Cheng Zhao
897c6e93cb
chore: simplify main world setup of contextIsolation ( #16046 )
2018-12-13 16:25:12 -05:00
Charles Kerr
f7528a0204
fix: fix an original-fs regression introduced in 4.0 betas ( #16028 )
...
* fix: fix an original-fs regression introduced in 4.0 betas
* chore: remove cruft from earlier draft
2018-12-12 15:32:53 -06:00
Milan Burda
c65a0d90b8
chore: misc cleanup ( #16037 )
2018-12-12 15:31:16 -06:00
Milan Burda
607b53c883
security: block chrome.tabs.executeScript() for non chrome-extension: URLs ( #15929 )
2018-12-11 10:45:46 +01:00
Benjamin Pasero
c74ae107f1
fix: do not print an error for an expected condition ( #15991 ) ( #15992 )
2018-12-10 12:06:26 -08:00
Shelley Vohr
4b18a38e9f
chore: simplify promisify helper ( #15952 )
...
chore: simplify promisify helper
2018-12-10 08:13:09 -08:00
Cheng Zhao
db2fda1b6f
chore: make rpc-server reply to sender frame instead of the main frame ( #15973 )
...
* chore: make rpc-server reply to frame
* fix: check IsRenderFrameLive
2018-12-10 09:37:42 +09:00
Milan Burda
177091ca6f
chore: rename nativeRequire to potentiallyRemoteRequire ( #15971 )
2018-12-06 18:12:50 -08:00
Jeremy Apthorp
442c1b22e3
feat: webContents.loadURL returns a promise ( #15855 )
2018-12-06 12:16:19 -08:00
Milan Burda
764a10f7c7
refactor: simplify isRemoteModuleEnabled handling in sandboxed renderers ( #15961 )
2018-12-05 10:07:56 -08:00
Milan Burda
ab2a061b59
refactor: use helpers when using the remote module in sandboxed renderers ( #15960 )
2018-12-05 10:07:32 -08:00
Shelley Vohr
3f15f51615
feat: promisify app.getFileIcon() ( #15742 )
2018-12-05 08:50:12 -08:00
Milan Burda
d561c5531b
feat: deprecate modules internally using remote.require in sandboxed renderer context ( #15145 )
2018-12-05 10:34:09 +01:00
Pedro Pontes
d5d1fa8290
fix: use appropriate site instance for cross-site nav's ( #15821 )
...
* fix: use Chromium's determined new site instance as candidate when navigating.
When navigating to a new address, consider using Chromium's determined site instance
for the new page as it should belong to an existing browsing instance when the
navigation was triggered by window.open().
fixes 8100.
* Revert "fix: use Chromium's determined new site instance as candidate when navigating."
This reverts commit eb95f935654a2c4d4457821297670836c10fdfd5.
* fix: delegate site instance creation back to content when sandboxed.
* fix: ensure site isolation is on
* test: adapt ut for cross-site navigation
* fix: register pending processes during a navigation.
* refactor: dont call loadURL for a window constructed from an existing webContents.
* test: add sandboxed affinity UT's.
* fix: check affinity before deciding if to force a new site instance.
* chore: adapt subsequent patch.
* refactor: constify logically const methods.
* fix: do not reuse site instances when navigation redirects cross-site.
* test: ensure localStorage accessible after x-site redirect.
* test: adapt localStorage acess denied UT for site isolation.
* fix: do not send render-view-deleted for speculative frames.
* chore: amend tests after rebase.
* test: add ut for webContents' render-view-deleted emission
* fix: introduce current-render-view-deleted for current RVH's deletions.
Revert render-view-deleted to being emitted with any RVH's deletion.
current-render-view-deleted is emitted only when the RVH being deleted
is the current one.
* refactor: style and comments fixed.
2018-12-05 17:03:39 +09:00
Milan Burda
aa2b2f7c8f
fix: security: don't allow arbitrary methods to be invoked on webContents via IPC ( #15919 )
2018-12-04 16:12:21 +01:00
Cheng Zhao
ca7dec2082
fix: default prop of location should be empty str
2018-12-04 17:11:26 +09:00
Cheng Zhao
fc4e10b6c0
fix: set setter of window.location
2018-12-04 16:23:52 +09:00
Anrock
e80e3a53e9
feat: introduce LocationProxy for BrowserWindowProxy
2018-12-04 16:23:52 +09:00
Julien Isorce
1f55f1635f
feat: add support for DesktopCapturerSource.appIcon
...
Useful to get the icon of the application owning the source.
Only available for sources of type window, i.e. not for screen.
https://github.com/electron/electron/issues/14845
2018-12-04 15:42:49 +09:00
Shelley Vohr
a1a431eb87
fix: make windowMenu role correct on MacOS ( #15930 )
2018-12-03 11:52:46 -08:00
Samuel Attard
3ddd917ff4
Merge pull request #15405 from electron/chromium-upgrade/70
...
feat: upgrade to Chromium 70.0.3538.110
2018-12-04 03:26:49 +11:00
Milan Burda
a33eeda4f7
refactor: don't expose NavigationController as an internal module ( #15920 )
2018-12-03 17:13:09 +01:00
Samuel Attard
b1e69e1357
chore: update asar injection for new node internal module loader
2018-12-03 20:07:41 +05:30
Milan Burda
559fd5cb31
chore: remove unused module ( #15917 )
2018-12-02 14:43:04 -08:00
Milan Burda
8483cb4aa7
security: only handle related IPCs when <webview> tag is enabled ( #15859 )
...
* refactor: move guest-view-manager related IPC handling out of rpc-server
* feat: only handle related IPCs when <webview> tag is enabled
2018-11-30 18:44:38 +09:00
Shelley Vohr
41c2685204
feat: promisify win.capturePage() ( #15743 )
...
* feat: promisify win.capturePage
* mark optional arg correctly
* Add to breaking changes doc
* properly deprecate win.capturePage
* remove change from api-contract
* document both callback and promise versions
* address docs feedback
* update promisification progress doc
2018-11-27 23:50:53 -05:00
Anrock
9ff7807be8
fix: move window.open handlers from BrowserWindow to WebContents
2018-11-27 10:59:01 +09:00
Shelley Vohr
0a5f8611e8
chore: add promise api runtime flag ( #15841 )
...
* chore: add promise api runtime flag
* add promisification plan document
* fix process.md typo
2018-11-26 16:00:46 -05:00
Heilig Benedek
0242818f39
feat: add registerAccelerator flag to allow menu items to optionally skip accelerator registration ( #15723 )
...
* feat: add registerAccelerator flag to allow menu items to skip registration
* docs: add docs for registerAccelerator
* docs: re-add accidentally removed line
2018-11-26 10:43:55 -08:00
Samuel Attard
0b0a17ff91
fix: load the chrome.* API on chrome-extension pages in sandbox mode ( #15563 )
...
With mixed sandbox enabled we need to load the chrome.* APIs in the
sandbox init.js so that chrome extensions load correctly.
This mirrors the equivilant impl in `atom_renderer_client.cc`
Fixes #15561
2018-11-21 12:56:58 -05:00
Cheng Zhao
47bf8e1bb3
view: add ResizeArea class ( #15752 )
2018-11-21 22:39:59 +09:00
Pedro Pontes
57d2ae1aec
revert: "fix: window.open site instance should belong to same browsing instance ( #15216 )" ( #15757 )
...
This reverts commit 8f35198bfb
.
2018-11-20 21:28:26 +01:00
Jeremy Apthorp
90d1c0b2b6
chore: don't explicitly destroy asar archives ( #15734 )
2018-11-19 13:12:41 -08:00
Shelley Vohr
a45d5960d7
chore: allow for callback => promise deprecation ( #15758 )
...
* chore: allow for callback => promise deprecation
* cb type check is sufficient
* migrate warn to always trigger
2018-11-19 12:56:26 -05:00
Jeremy Apthorp
0642be296d
fix: crash in sandbox on linux when getting execPath ( #15701 )
2018-11-15 12:59:01 -08:00
Pedro Pontes
8f35198bfb
fix: window.open site instance should belong to same browsing instance ( #15216 )
2018-11-12 22:01:43 +01:00
Shelley Vohr
c06f023313
feat: allow partial setting of window bounds ( #15677 )
...
Extend the existing win.setBounds functionality by allowing developers to partially update bounds without being forced to pass in all four bounds values. No existing functionality is altere
2018-11-12 15:31:14 -05:00
Samuel Attard
edf063bae3
chore: remove deprecated touch-bar API ( #15650 )
2018-11-09 17:00:19 +11:00
Robo
82322968a3
refactor: printing implementation ( #15143 )
...
* refactor: basic printing
* move build files to chromium_src/BUILD.gn
* remove dependency on chrome prerender sources
* spec: move printing specs behind feature flag
* build: register pdf compositor service
2018-11-09 14:42:34 +11:00
Jeremy Apthorp
10969b8c3c
fix: make feature strings more robust to whitespace ( #15602 )
...
Fixes #15594
2018-11-06 15:52:06 -08:00