Milan Burda 
								
							 
						 
						
							
							
								
							
							
	7e7abc28f5  
						 
						
							
							
								
								
								feat: promisify netLog.stopLogging ( #16862 )  
							
							
							
						 
						
							2019-02-19 10:48:27 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	3b74837020  
						 
						
							
							
								
								
								refactor: Split 'Event' docs/types into more specific Event types ( #17038 )  
							
							... 
							
							
							
							* Event = Base event type (with preventDefault)
* IpcMainEvent = Event that ipcMain emits (with sender, reply, etc.)
* IpcRendererEvent = Event that ipcRenderer emits (with sender,
senderId, etc.)
* KeyboardEvent = Event that we emit with keyboard flags (ctrlKey,
altKey, etc.)
This will dramatically improve peoples TS experience with IPC events 
							
						 
						
							2019-02-19 09:24:19 +00:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	975a035d34  
						 
						
							
							
								
								
								chore: re-enable devtools renderer sandbox ( #16864 )  
							
							... 
							
							
							
							* chore: re-enable devtools renderer sandbox
* chore: enable sandbox for chrome extension background script host renderers 
							
						 
						
							2019-02-15 15:10:32 +05:30 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	5790869a3f 
 
						 
						
							
							
								
								
								chore: refactor browser IPC into TS and app API into TS ( #16921 )  
							
							... 
							
							
							
							* chore: refactor browser IPC into typescript
* chore: refactor app.ts into Typescript
* Refactors app.dock into cpp
* Removes app.launcher which has not existed for 3 years
* Removes 2 deprecated APIs (that have been deprecated for more than one
major)
* Refactors deprecate.ts as well 
							
						 
						
							2019-02-14 14:29:20 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	005b7d8099  
						 
						
							
							
								
								
								Print Preview: Add validity check for kSettingPagesPerSheet.  
							
							... 
							
							
							
							https://chromium-review.googlesource.com/c/chromium/src/+/1381133  
						
							2019-02-14 23:59:25 +05:30 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									deepak1556 
								
							 
						 
						
							
							
								
							
							
	547add94d0  
						 
						
							
							
								
								
								Make //ui/base/idle API synchronous  
							
							... 
							
							
							
							https://chromium-review.googlesource.com/c/chromium/src/+/1379183  
						
							2019-02-14 23:59:23 +05:30 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	de27911661 
 
						 
						
							
							
								
								
								feat: promisify webContents.savePage() ( #16742 )  
							
							... 
							
							
							
							* feat: promisify webContents.savePage()
* no need to make compatible w callbacks, we're breaking it
* fix promise resolve type
* address feedback from review
* fix promise return text
* update smoke test 
							
						 
						
							2019-02-14 09:03:28 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Stewart Lord 
								
							 
						 
						
							
							
								
							
							
	84ef9cae6c  
						 
						
							
							
								
								
								fix: send chrome.runtime/tabs.sendMessage result to correct sender ( #16945 )  
							
							... 
							
							
							
							Additionally, use `.once` instead of `.on` for result specific listeners. 
							
						 
						
							2019-02-14 06:07:55 -10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	2492f0bcac  
						 
						
							
							
								
								
								refactor: promisify prototype methods ( #16935 )  
							
							
							
						 
						
							2019-02-14 03:40:24 -10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	fed5b99a9f 
 
						 
						
							
							
								
								
								feat: promisify contentTracing.getTraceBufferUsage() ( #16600 )  
							
							... 
							
							
							
							* feat: promsify contentTracing.getTraceBufferUsage()
* deprecate getTraceBufferUsage
* address feedback from review
* properly deprecate 
							
						 
						
							2019-02-13 13:24:57 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	1f458eb177  
						 
						
							
							
								
								
								feat: promisify debugger.sendCommand() ( #16861 )  
							
							... 
							
							
							
							* remove duplicate entry for desktopCapturer.getSources
* feat: promisify debugger.sendCommand 
							
						 
						
							2019-02-13 07:23:53 -10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Maddock 
								
							 
						 
						
							
							
								
							
							
	8f6a543398  
						 
						
							
							
								
								
								feat: add chrome.runtime.getManifest ( #16891 )  
							
							... 
							
							
							
							* feat: add chrome.runtime.getManifest
* Add test for chrome.runtime.getManifest
* Use IPC utils for getManifest internals 
							
						 
						
							2019-02-13 07:16:12 -10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	01c442de64  
						 
						
							
							
								
								
								refactor: convert more files to typescript ( #16820 )  
							
							
							
						 
						
							2019-02-12 04:22:33 -10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	d8ba1278d1  
						 
						
							
							
								
								
								chore: disable the remote module in devtools / chrome extension background scripts ( #16866 )  
							
							... 
							
							
							
							* cache isRemoteModuleEnabled
* chore: disable the remote module in devtools / chrome extension background scripts 
							
						 
						
							2019-02-11 10:42:37 -10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	36ce3e9546  
						 
						
							
							
								
								
								feat: promisify webContents.printToPDF() ( #16795 )  
							
							
							
						 
						
							2019-02-11 09:20:04 -10:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	7a3d220347  
						 
						
							
							
								
								
								refactor: implement Chrome Extension APIs without the remote module ( #16686 )  
							
							... 
							
							
							
							* refactor: implement Chrome Extension APIs without the remote module
* remove unused potentiallyRemoteRequire 
							
						 
						
							2019-02-10 10:38:14 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	3f52e18a38  
						 
						
							
							
								
								
								chore: add menu-will-close comment explaining setTimeout ( #16794 )  
							
							
							
						 
						
							2019-02-08 13:38:03 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	1632c4b837  
						 
						
							
							
								
								
								refactor: implement chrome.i18n.getMessage() without the remote module ( #16739 )  
							
							... 
							
							
							
							* refactor: implement chrome.i18n.getMessage() without the remote module
* replace navigator.language with app.getLocale() 
							
						 
						
							2019-02-08 12:07:09 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	db11b9b13b 
 
						 
						
							
							
								
								
								fix: restore accidentally removed chrome-extension require ( #16819 )  
							
							
							
						 
						
							2019-02-07 12:38:57 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	4f8ebafa97  
						 
						
							
							
								
								
								chore: dont log 100000000 chars of URL ( #16800 )  
							
							
							
						 
						
							2019-02-07 08:50:47 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	26df9992cf 
 
						 
						
							
							
								
								
								build: use typescript for internal Electron JS code ( #16441 )  
							
							
							
						 
						
							2019-02-06 10:27:20 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	858781ba83 
 
						 
						
							
							
								
								
								feat: allow Menu.buildFromTemplate() to accept MenuItems ( #16697 )  
							
							... 
							
							
							
							* feat: allow Menu.buildFromTemplate to accept MenuItems
* add another spec
* fix linter error
* add submenu spec 
							
						 
						
							2019-02-06 10:04:40 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	4211a9c69f  
						 
						
							
							
								
								
								refactor: use ipcRendererUtils.invokeSync / ipcMainUtils.handleSync ( #16759 )  
							
							
							
						 
						
							2019-02-06 09:53:28 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	6d674eebb1  
						 
						
							
							
								
								
								refactor: crashReporterInit ( #16729 )  
							
							
							
						 
						
							2019-02-05 12:56:44 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	f303caa87c 
 
						 
						
							
							
								
								
								refactor: remove ServiceWorker APIs from WebContents ( #16717 )  
							
							
							
						 
						
							2019-02-04 22:22:46 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	af64140100 
 
						 
						
							
							
								
								
								refactor: enforce naming of ipcMainInternal ( #16689 )  
							
							
							
						 
						
							2019-02-04 14:49:53 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	7dc565fc2e  
						 
						
							
							
								
								
								refactor: implement inspector APIs without the remote module ( #16607 )  
							
							
							
						 
						
							2019-02-01 19:56:46 +01:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									michtsu 
								
							 
						 
						
							
							
								
							
							
	392458b252  
						 
						
							
							
								
								
								Add devtools API to inspect shared worker. ( #16615 )  
							
							
							
						 
						
							2019-02-01 10:44:24 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Charles Kerr 
								
							 
						 
						
							
							
								
							
							
	76dcbcd6ea  
						 
						
							
							
								
								
								chore: fix 'browserView' typo ( #16621 )  
							
							
							
						 
						
							2019-01-30 21:07:08 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	ba57e1d991 
 
						 
						
							
							
								
								
								feat: promisify contentTracing recording APIs ( #16584 )  
							
							... 
							
							
							
							* feat: promisify contentTracing.startRecording()
* feat: promisify contentTracing.stopRecording()
* test: convert specs for new promisified apis
* chore: deprecate and ensure legacy tests work 
							
						 
						
							2019-01-30 18:53:55 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	641b47f384 
 
						 
						
							
							
								
								
								feat: promisify contentTracing.getCategories() ( #16583 )  
							
							... 
							
							
							
							* feat: promisify contentTracing.getCategories()
* deprecate contentTracing/getCategories 
							
						 
						
							2019-01-30 12:39:55 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	dfcee48f81  
						 
						
							
							
								
								
								fix: don't forward IPC filtering events to app for dev-tools and extensions ( #16565 )  
							
							
							
						 
						
							2019-01-30 08:20:03 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	fa5442f211  
						 
						
							
							
								
								
								fix: execute session preload scripts in sandboxed renderers ( #16538 )  
							
							
							
						 
						
							2019-01-29 10:16:46 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	d105dcc0d3 
 
						 
						
							
							
								
								
								feat: promisify webContents.hasServiceWorker() ( #16535 )  
							
							... 
							
							
							
							* feat: promisify contents.hasServiceWorker()
* spec: add initial test for hasServiceWorker() 
							
						 
						
							2019-01-26 10:23:16 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	5a35c3a279 
 
						 
						
							
							
								
								
								chore: fix promisify helper ( #16544 )  
							
							... 
							
							
							
							* chore: fix promise deprecation helper
* fix deprecations
* update deprecation tests 
							
						 
						
							2019-01-25 14:23:24 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Charles Kerr 
								
							 
						 
						
							
							
								
							
							
	
	
	8396a2d504 
 
						 
						
							
							
								
								
								feat: promisify cookies api ( #16464 )  
							
							... 
							
							
							
							* feat: promisify the Cookie API
* chore: update specs to test promisified cookies
* chore: add deprecate wrapper for cookie callback API
* docs: update docs to cookie promise changes
* chore: remove redundant namespace use
* docs: improve cookie example
* docs: restore docs for cookie callback API
* chore: restore cookie callback tests
* fix: syntax of cookie promise return types 
							
						 
						
							2019-01-25 12:11:35 -06:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	cc90919384  
						 
						
							
							
								
								
								refactor: pass internal flag via IPC message struct for consistency ( #16490 )  
							
							
							
						 
						
							2019-01-23 08:24:57 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	f3e30c7ae3 
 
						 
						
							
							
								
								
								Merge remote-tracking branch 'origin/chromium-upgrade/72'  
							
							
							
						 
						
							2019-01-22 12:01:18 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	0b85fb7ea2 
 
						 
						
							
							
								
								
								Revert "feat: upgrade to Chromium 72.0.3626.52 ( #16334 )"  
							
							... 
							
							
							
							This reverts commit 1918e76913 
							
						 
						
							2019-01-22 12:01:04 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Samuel Attard 
								
							 
						 
						
							
							
								
							
							
	
	
	58a6fe13d6 
 
						 
						
							
							
								
								
								feat: preloads and nodeIntegration in iframes ( #16425 )  
							
							... 
							
							
							
							* feat: add support for node / preloads in subframes
This feature has delibrately been built / implemented in such a way
that it has minimum impact on existing apps / code-paths.
Without enabling the new "nodeSupportInSubFrames" option basically none of this
new code will be hit.
The things that I believe need extra scrutiny are:
* Introduction of `event.reply` for IPC events and usage of `event.reply` instead of `event.sender.send()`
* Usage of `node::FreeEnvironment(env)` when the new option is enabled in order to avoid memory leaks.  I have tested this quite a bit and haven't managed to cause a crash but it is still feature flagged behind the "nodeSupportInSubFrames" flag to avoid potential impact.
Closes  #10569 
Closes  #10401 
Closes  #11868 
Closes  #12505 
Closes  #14035 
* feat: add support preloads in subframes for sandboxed renderers
* spec: add tests for new nodeSupportInSubFrames option
* spec: fix specs for .reply and ._replyInternal for internal messages
* chore: revert change to use flag instead of environment set size
* chore: clean up subframe impl
* chore: apply suggestions from code review
Co-Authored-By: MarshallOfSound <samuel.r.attard@gmail.com>
* chore: clean up reply usage
* chore: fix TS docs generation
* chore: cleanup after rebase
* chore: rename wrap to add in event fns 
							
						 
						
							2019-01-22 11:24:46 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Apthorp 
								
							 
						 
						
							
							
								
							
							
	
	
	92b9525cfd 
 
						 
						
							
							
								
								
								feat: enable mixed-sandbox mode by default ( #15894 )  
							
							
							
						 
						
							2019-01-22 10:44:28 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Jeremy Apthorp 
								
							 
						 
						
							
							
								
							
							
	1918e76913  
						 
						
							
							
								
								
								feat: upgrade to Chromium 72.0.3626.52 ( #16334 )  
							
							
							
						 
						
							2019-01-22 10:39:32 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Cheng Zhao 
								
							 
						 
						
							
							
								
							
							
	03d499bf34  
						 
						
							
							
								
								
								fix: detach webview instead of destroying it  
							
							... 
							
							
							
							Chromium no longer cleans up everything when a guest webcontents is
destroyed, we have to force detaching it and let Chromium destroy everything. 
							
						 
						
							2019-01-22 10:32:06 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	6cba2c50a2  
						 
						
							
							
								
								
								feat: make ipc-message and ipc-message-sync events public ( #16468 )  
							
							
							
						 
						
							2019-01-22 08:47:58 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	7d71ad6f91  
						 
						
							
							
								
								
								fix: takeHeapSnapshot() using public IPC channel for internal implementation ( #16480 )  
							
							
							
						 
						
							2019-01-22 17:32:24 +09:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	3ca87d205f 
 
						 
						
							
							
								
								
								feat: make zoomLevel/zoomFactor sync ( #16410 )  
							
							... 
							
							
							
							* feat: make zoomLevel/zoomFactor sync
* update ts defs dep 
							
						 
						
							2019-01-20 23:40:27 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Milan Burda 
								
							 
						 
						
							
							
								
							
							
	7d4a1223fd  
						 
						
							
							
								
								
								feat: add preload-error event to webContents ( #16411 )  
							
							
							
						 
						
							2019-01-18 12:03:43 +01:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	f105c84349 
 
						 
						
							
							
								
								
								test: ensure legacy callback functions work ( #16436 )  
							
							... 
							
							
							
							* test: test legacy callback functions
* add TODO removal comments
* fix callback spec 
							
						 
						
							2019-01-17 14:17:16 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	720197f9c8 
 
						 
						
							
							
								
								
								fix: correctly handle IPC for promise-based methods ( #16433 )  
							
							
							
						 
						
							2019-01-17 12:08:54 -08:00 
							
								 
							
							
								 
							
						 
					 
				
					
						
							
								
								
									Shelley Vohr 
								
							 
						 
						
							
							
								
							
							
	
	
	1f2b02c18f 
 
						 
						
							
							
								
								
								feat: promisify protocol.isProtocolHandled() ( #16423 )  
							
							... 
							
							
							
							* feat: promisify protocol
* fix base::Bind and specs
* update documentation
* make callback-compatible
* async awaitify tests 
							
						 
						
							2019-01-17 09:05:10 -08:00