Haojian Wu
ff745e1a82
Use prefix increment in for loops.
2017-03-30 22:56:21 +02:00
Haojian Wu
8d8c7ce6ad
Correct type cast.
2017-03-30 22:53:20 +02:00
Haojian Wu
d425b63b0d
NULL => nullptr
2017-03-30 22:12:14 +02:00
Haojian Wu
00693ba075
Replace "size()" with "empty()".
2017-03-30 21:59:18 +02:00
Hansen Zhang
426563a843
#8881 - Display '&' in MenuItem label
2017-03-22 11:52:25 -04:00
Kevin Sawicki
da0d0e7aac
Merge pull request #8910 from electron/touchbar-scrubber
...
Touchbar NSScrubber
2017-03-16 09:10:59 -07:00
Kevin Sawicki
e98ac94d51
🎨
2017-03-15 11:22:31 -07:00
Kevin Sawicki
f41db87e47
Use NSZeroRect for scrubber frame
2017-03-15 09:45:50 -07:00
Kevin Sawicki
466c39ed19
Use icon for consistency with other touch bar APIs
2017-03-15 09:33:11 -07:00
Kevin Sawicki
6175ee05e2
Remove unneeded long cast
2017-03-14 13:59:29 -07:00
Kevin Sawicki
8b7675baee
Add more forward declarations for scrubber APIs
2017-03-14 13:57:39 -07:00
Samuel Attard
a55cddaa53
Add more options
2017-03-14 18:57:57 +11:00
deepak1556
15e2b2335f
address review comments
2017-03-14 00:26:27 +05:30
deepak1556
4381e0895f
propagate zoom changes to pdf plugin
2017-03-14 00:26:27 +05:30
deepak1556
eda413861a
update spec
2017-03-14 00:26:27 +05:30
deepak1556
b28e686228
code cleanup
2017-03-14 00:26:27 +05:30
deepak1556
5a8e522526
StreamManager class is no longer required.
...
Stream lifetime is managed by webui
2017-03-14 00:26:27 +05:30
deepak1556
c982af991d
request for pdf resource from the webui
2017-03-14 00:26:27 +05:30
Cheng Zhao
422b7acece
Do not store resource_path as FilePath
...
On Windows the path value returned by PathWithoutParams also uses "/" as
separator, so there is no need to use the FilePath class.
2017-03-14 00:26:27 +05:30
Cheng Zhao
cca1db47ee
Print error when path is not found
2017-03-14 00:26:27 +05:30
deepak1556
528853efbf
handle reload api call from pdf ui
2017-03-14 00:26:27 +05:30
deepak1556
b9710532e1
update api changes
2017-03-14 00:26:27 +05:30
deepak1556
3aba23b471
view_id=>stream_id and add some code comments.
2017-03-14 00:26:27 +05:30
deepak1556
e90fd1444f
move constants to atom_constants.h
2017-03-14 00:26:27 +05:30
deepak1556
671a8a2cd6
address review comments
2017-03-14 00:26:27 +05:30
deepak1556
cc09b9ac7d
BINDINGS_POLICY_WEB_UI is not required
2017-03-14 00:26:27 +05:30
Paul Betts
846d516584
Get us compiling on macOS
2017-03-14 00:26:27 +05:30
Paul Betts
8580a34f9f
Get us compiling on Win32
2017-03-14 00:26:27 +05:30
deepak1556
c15f6af892
fix crash when pdf viewer is reloaded
2017-03-14 00:25:59 +05:30
deepak1556
ddc2e0df71
code cleanup
2017-03-14 00:25:59 +05:30
deepak1556
de7dcdedba
setup strings for ui
2017-03-14 00:25:59 +05:30
deepak1556
0c7bb72891
listen to ipc messages from plugin to perform SaveAs op
2017-03-14 00:25:59 +05:30
deepak1556
fd8c450ef3
move pdfviewer ui data source to separate file
2017-03-14 00:25:59 +05:30
deepak1556
945e26750e
manage the lifetime of streams created
2017-03-14 00:25:59 +05:30
deepak1556
41c1623824
handle more messages from webui
2017-03-14 00:25:59 +05:30
deepak1556
a2db14476a
create webui message handler
2017-03-14 00:25:59 +05:30
Kevin Sawicki
268dd1a6c2
Remove unneeded include
2017-03-13 11:15:36 -07:00
Kevin Sawicki
e52ece1a1e
Implement NSScrubberDataSource in AtomTouchBar
2017-03-13 11:06:41 -07:00
Kevin Sawicki
4f31a5c452
Fix duplicate protocol method declaration
2017-03-13 10:39:42 -07:00
Kevin Sawicki
d7f458d232
Add protocol methods
2017-03-13 10:31:51 -07:00
Kevin Sawicki
2fe21ecdd0
🎨
2017-03-13 10:28:30 -07:00
Kevin Sawicki
37c9d76cd5
Take const references
2017-03-13 10:25:30 -07:00
Kevin Sawicki
634bd7b17f
Add NSScrubber forward declarations
2017-03-13 10:07:48 -07:00
Samuel Attard
a85ae27d68
Fix linting
2017-03-13 11:00:10 +11:00
Samuel Attard
25a231fc50
Initial NSScrubber implementation
2017-03-13 10:51:12 +11:00
Kevin Sawicki
5b1d5b39a2
Set automatic via else block
2017-03-10 10:11:56 -08:00
Kevin Sawicki
3349e32196
Verify selectedIndex to prevent NSRangeException
2017-03-10 10:09:18 -08:00
Kevin Sawicki
458e4be77c
Add forward declaration for 10.12 API
2017-03-10 09:53:47 -08:00
Samuel Attard
1c027c526b
Add segmented control implementation
2017-03-10 17:40:39 +11:00
Kevin Sawicki
4d6c779839
identList -> identifiers
2017-03-03 15:28:32 -08:00
Kevin Sawicki
b879872317
Always set properties in update calls
2017-03-03 15:24:32 -08:00
Kevin Sawicki
2680ee9f8f
Add support for setting TouchBarLabel text color
2017-03-03 15:14:51 -08:00
Kevin Sawicki
002369576f
Add initial touch bar docs
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ce12dcd3b4
Add live popover icon property
2017-03-03 14:00:39 -08:00
Kevin Sawicki
a34f9d3583
Support icon property to match MenuItem
2017-03-03 14:00:39 -08:00
Kevin Sawicki
506b42b563
🎨
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ecc0478e3c
Match Popover casing in macOS APIs
2017-03-03 14:00:39 -08:00
Kevin Sawicki
d1edd80ef8
Use NSTouchBar itemForIdentifier to lookup existing item
2017-03-03 14:00:39 -08:00
Kevin Sawicki
93bbe8e70b
Use device NS colors consistently
2017-03-03 14:00:39 -08:00
Kevin Sawicki
70d61869a5
Use array to create empty NSMutableArray
2017-03-03 14:00:39 -08:00
Kevin Sawicki
708ed9d1cd
Store ordered settings in AtomTouchBar
2017-03-03 14:00:39 -08:00
Kevin Sawicki
5f9e9d4b36
Add move live updating properties
2017-03-03 14:00:39 -08:00
Kevin Sawicki
61aa9bbff4
Add support for spacer items
2017-03-03 14:00:39 -08:00
Kevin Sawicki
f153d08297
Support setting the initial/available colors
2017-03-03 14:00:39 -08:00
Kevin Sawicki
347d472841
Remove unused clear method
2017-03-03 14:00:39 -08:00
Kevin Sawicki
b959f782f6
Rename instance variable maps
2017-03-03 14:00:39 -08:00
Kevin Sawicki
ec500b2852
Use scoped_nsobject to match Chrome implementation
2017-03-03 14:00:38 -08:00
Kevin Sawicki
98f5858b11
Initial support for dynamic properties
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cbb6f8c33e
Store event listeners in each TouchBar class
2017-03-03 14:00:38 -08:00
Kevin Sawicki
14ef5c5957
Reset helper when makeTouchBar is called
2017-03-03 14:00:38 -08:00
Kevin Sawicki
ca29ec0101
Use reference
2017-03-03 14:00:38 -08:00
Kevin Sawicki
f297ba987e
touchBarFromMutatableArray -> touchBarFromItemIdentifiers
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b30f7c3c94
Use std::string ctor
2017-03-03 14:00:38 -08:00
Kevin Sawicki
8500538793
Use base::SysUTF8ToNSString helper
2017-03-03 14:00:38 -08:00
Kevin Sawicki
cf7cd1f32b
hasTBDict -> hasItemWithID
2017-03-03 14:00:38 -08:00
Kevin Sawicki
b632cdd37d
Extract helper class to encapsulate touch bar items
2017-03-03 14:00:38 -08:00
Kevin Sawicki
69638a399c
Make touchBar readwrite/nullable
2017-03-03 14:00:38 -08:00
Kevin Sawicki
52905ae9b3
Get compiling against 10.10 SDK
2017-03-03 14:00:38 -08:00
Kevin Sawicki
be16e75be2
Support explicit cancelId on macOS
2017-02-24 09:05:55 -08:00
Kevin Sawicki
211bedf910
Invoke close callback after itemSelected runs
2017-02-22 11:47:58 -08:00
Kevin Sawicki
6a023dc4fe
Add Menu.closePopup API on macOS
2017-02-22 10:30:28 -08:00
Kevin Sawicki
70849de8c4
Mark constructor as explicit
2017-02-15 08:28:55 -08:00
Kevin Sawicki
52801c4a41
Use internal IsVisible method
2017-02-15 08:28:55 -08:00
Kevin Sawicki
db79f4f450
Implement Activate instead of CanFocus
2017-02-15 08:28:55 -08:00
Kevin Sawicki
bda8af8dd3
Just use visible state in CanFocus delegate
2017-02-15 08:28:55 -08:00
Kevin Sawicki
be79417a03
Include CanFocus on Windows and map to state
2017-02-15 08:28:55 -08:00
Kevin Sawicki
a746651d1c
Use dialog setter for consistency with other properties
2017-02-13 08:23:53 -08:00
Samuel Attard
e45d8079b8
Add support for a noResolveAliases property
2017-02-13 08:23:53 -08:00
Kevin Sawicki
f7f4de36af
Merge remote-tracking branch 'origin/master' into macos-open-save-panel
2017-02-09 11:25:05 -08:00
Kevin Sawicki
867bb5a94e
Add DialogSettings helper struct
2017-02-09 10:13:11 -08:00
Kevin Sawicki
7994acf0ea
Use CHROMEGTK_CALLBACK_0 and ignore gpointer data
2017-02-09 09:49:09 -08:00
Birunthan Mohanathas
c8c11e68c6
Add support for checkbox with dialog.showMessageBox
...
This adds the `checkboxLabel` and `checkboxChecked` options to display a
checkbox in the message box. Fixes #6048 .
2017-02-09 09:03:54 -08:00
Tan Wang Leng
347dc835b5
Fix code formatting
2017-02-09 21:51:11 +08:00
Tan Wang Leng
a4a71a1dc9
Change qualifier of ShowSaveDialog() parameter
...
The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
2017-02-09 21:50:55 +08:00
Tan Wang Leng
b0487b7d84
Fix wrong signature for gtk's ShowSaveDialog()
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1bf8270c0d
🏁 Fix dialog method calls for Windows
2017-02-09 20:10:57 +08:00
Tan Wang Leng
36209ddd90
🍎 Add additional options for Mac's open dialog
...
Support an additional attributes available in macOS's NSOpenPanel:
message.
2017-02-09 20:10:57 +08:00
Tan Wang Leng
1d612a12a1
🍎 Add additional options for Mac's save dialog
...
Support additional attributes available in macOS's NSSavePanel: message,
nameFieldLabel and showsTagField
2017-02-09 20:10:57 +08:00
Cheng Zhao
be29ea4dad
libgtk2ui => libgtkui
2017-02-06 10:34:29 -08:00
Cheng Zhao
820c0827c0
Fix cpplint warnings
2017-02-06 10:34:29 -08:00
Cheng Zhao
55d4d44f02
Fix Debug building on Windows
2017-02-06 10:34:29 -08:00
Cheng Zhao
e91eed6758
FOR_EACH_OBSERVER is removed
2017-02-06 10:34:28 -08:00
Cheng Zhao
7a7b72ce04
SimpleMenuModel::MenuClosed renamed to MenuWillClose
2017-02-06 10:34:28 -08:00
Kevin Sawicki
9fef6a1fd7
Add support for FOS_CREATEPROMPT option
2017-02-02 08:51:10 -08:00
Cheng Zhao
6e0762a540
Fix building on Windows
2017-01-19 09:05:59 +02:00
Cheng Zhao
88f6f5d1b2
Fix compilation errors for Linux
2017-01-19 09:05:59 +02:00
Cheng Zhao
497f5a1199
Update files for Chrome 54 API changes
2017-01-19 09:05:59 +02:00
Kevin Sawicki
0244a73c49
Fix cpp linter errors
2017-01-16 09:26:07 -08:00
Brian Clifton
9e0547b98f
Fix the rendering for the rounded edges
2017-01-14 01:15:22 -08:00
Brian Clifton
cf6e215a66
Properly handle borders for DPI > 100% on Windows
...
Fixes https://github.com/electron/electron/issues/4573
cc: @zcbenz, @kevinsawicki, @zeke
2017-01-13 00:18:42 -07:00
Kevin Sawicki
222734b5f5
Use correct param ordering in header file
2017-01-09 08:30:13 -08:00
Phil Christensen
2c259990da
fix permissive C++ code (MSVC /permissive-)
...
These were found by the C++ compiler group when doing "Real world code"
build tests using /permissive-. We are sharing these with you to help clean up
your code before the new version of the compiler comes out. For more information on
/permissive- see https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/ .
In paticular, see the "Do not treat copy initialization as direct initialization"
section of the blog.
2017-01-05 09:38:41 -08:00
Kevin Sawicki
8c5f26373b
Add override
2016-12-22 09:33:21 -08:00
Kevin Sawicki
87f09131aa
Observe window and only use it when it is open
2016-12-22 09:33:21 -08:00
Pedro Belo
89e8ad4947
Fix support for dragging urls in Mac
2016-11-19 21:18:24 -08:00
liusi
9e91f319c1
fix linting error
2016-11-15 13:19:34 +08:00
liusi
06cfcd612d
disable accelerator when menu item is disabled
2016-11-14 12:29:27 +08:00
Kevin Sawicki
98387e50cc
Focus window on menu bar click
2016-10-24 11:49:51 +09:00
Kevin Sawicki
9cae04edde
Remove unused ButtonListener
2016-10-03 10:26:18 -07:00
Kevin Sawicki
11684c2c73
Focus submenu buttons when clicked
2016-10-03 10:13:41 -07:00
Kevin Sawicki
b3b9994ce8
Configure ink drops on menu bar buttons ( #7397 )
...
* Add ink drop to menu bar buttons
* Pass background color to submenu button
* Sort includes
2016-09-29 09:15:12 -07:00
Cheng Zhao
cdfcca147a
Fix warning when compiling for win32 ia32 build
2016-09-02 13:59:28 +09:00
Vadim Macagon
c64294cf60
Extend the custom Jump List API
...
Add `app.getJumpListSettings()` and `app.setJumpList(callback)` that
make it possible to fully customize the Jump List of an Electron app.
It is now possible to:
- Add tasks to the standard `Tasks` category.
- Add separators to the standard `Tasks` category.
- Add custom categories containing tasks and file links.
- Add system managed Recent/Frequent categories.
- Remove the custom Jump List.
2016-09-01 09:56:14 +07:00
Kevin Sawicki
3dd5628ded
Include windows.h first
2016-08-26 16:00:05 -07:00
Kevin Sawicki
6285500cdc
Sort includes alphabetically
2016-08-26 15:30:02 -07:00
Cheng Zhao
06d2dfe119
Merge pull request #6788 from electron/felix-progress-enum
...
Use enum to declare ProgressState
2016-08-18 14:35:00 +09:00
Cheng Zhao
56d17a1449
Merge pull request #6829 from electron/fix-thumbar-buttons-vanishing
...
Save the thumbar buttons when setting them to restore later
2016-08-18 14:34:26 +09:00
Kevin Sawicki
4fc4f0ae53
Only call setCanSelectHiddenExtension for save dialogs
2016-08-16 17:22:44 -07:00
Samuel Attard
2fa7aa3c71
Save the thumbar buttons when setting them
...
Then restore the buttons when restoring the taskbar icon
2016-08-13 01:55:42 +10:00
Felix Rieseberg
8b85ee8a20
🔧 Use enum to declare ProgressState
...
As recommended in #6768 , this commit adds an enum for progress states for windows.
2016-08-10 08:56:26 -07:00
Kevin Sawicki
2802d2f3f9
Use gfx::Rect::ToRECT
2016-08-09 08:50:06 -07:00
Kevin Sawicki
5f2a13d01b
Convert dip to screen rect for thumbnail clip
2016-08-09 08:40:38 -07:00
Cheng Zhao
dd79c71302
Style fixes for SetProgressBar
2016-08-09 21:02:14 +09:00
Cheng Zhao
81244c2221
Merge pull request #6768 from electron/felix-set-progress
...
Enable mode indication for setProgressBar
2016-08-09 20:58:07 +09:00
Felix Rieseberg
73c91dae9e
🔧 Enable mode indication for setProgressBar
...
This commit enables setting a mode for the setProgressBar method.
Old behavior is kept intact, usage is entirely optional.
2016-08-08 15:52:20 -07:00
Kevin Sawicki
bcc372568f
Add zoom menu item roles
2016-08-08 11:09:30 -07:00
Kevin Sawicki
59ffe35781
Merge pull request #6765 from miniak/menu-speaking-roles
...
Add macOS specific speaking roles for MenuItem
2016-08-08 11:06:45 -07:00
Milan Burda
a6125c538e
Add BrowserWindow.prototype.setThumbnailToolTip
2016-08-08 12:05:47 +02:00
Milan Burda
edc1a9614c
Add macOS specific speaking roles for MenuItem
2016-08-08 00:02:32 +02:00
Kevin Sawicki
b2f9cce297
Add option to always highlight the tray icon
2016-07-26 13:51:43 -07:00
Cheng Zhao
b57665330c
Merge branch 'master' into chrome52
2016-07-21 05:34:36 -06:00
Cheng Zhao
d186a01815
Merge pull request #6497 from electron/windows-thumbnail
...
Add setThumbnailClip API on Windows
2016-07-15 10:18:39 +09:00
Cheng Zhao
16e43a7f15
Merge pull request #6490 from wilsonpage/add-drop-text-support
...
Add support for dropped text in osx
2016-07-15 09:12:35 +09:00
Kevin Sawicki
86218fe773
win: Add setThumbnailClip window API
2016-07-14 15:50:31 -07:00
Wilson Page
90f8a7e828
Add support for dropped text in osx
2016-07-14 18:25:58 +01:00
Cheng Zhao
7848608198
Replace DialogScope with UnresponsiveSuppressor
...
The latter is global-wide.
2016-07-11 15:29:03 +09:00
Cheng Zhao
fc72df3ba1
win: Use FOS_FORCESHOWHIDDEN for showHiddenFiles
2016-07-11 13:49:51 +09:00
Cheng Zhao
6e0fadbe26
gtk: Set show-hidden property for showHiddenFiles
2016-07-11 13:47:24 +09:00
Cheng Zhao
f08ac07737
mac: Add showHiddenFiles property for showOpenDialog
2016-07-11 13:30:18 +09:00
Haojian Wu
4ac4dacffe
Some manual change to for-ranged loop.
...
Use "const auto&" where possible.
2016-07-10 15:57:51 +02:00
