Nitish Sakhawalkar
f98454e5dd
fix: use crashpad on Windows ( #18483 )
...
* Initial changes to use crashpad for windows
* Remove crashpad patch
* Report error when failed to connect pipe
* Allow crashpad to communicate with named pipe
* Add patch to make crashpad named pipe work
* Windows also needs crashReporter on main process
* Call SetUnhandledExceptionFilter in node process
Node can also use crash reporter.
* Do not treat node process as browser process
* No more need to manually start crash service
* Use base::StringPrintf for better readbility
* Print error when pipe name not available
* Make sure pipe name is updated
Note that the crashpad may be started after renderer process gets
created.
* Fix some tests
* Update node
* Exclude crashpad files on Linux and MAS
* Fix lint warning
* Remove unused checks
* kCrashpadPipeName is only available on Windows
* Fix uploadToServer tests
* Fix extra params tests
* Fix getCrashesDirectory tests
* Run crashReporter tests on CI
* Style fixes
* Update crashreporter docs
* Rename InitBreakpad to Init
* Add comment for process_type_.empty() and UTF16ToASCII to UTF16ToUTF8.
* Update build.gn include crashpad headers
* Address comment https://github.com/electron/electron/pull/18483#discussion_r290887898
* Avoid using api::WebContents
* Put kRunAsNode in atom_constants
* Remove duplicate settings on upload params
* Fix building on macOS
* Update description for crashpad_pid_check.patch
2019-06-13 15:42:21 +09:00
Electron Bot
d008d217f9
chore: bump chromium to 2a7aff41ce73adc0eeee67d364989 (master) ( #18505 )
...
* chore: bump chromium in DEPS to 07463d3cd628b037c11f36022cb4c788db4628e3
* chore: update patches
* fix: Don't leak system network context when nw service is disabled
https://chromium-review.googlesource.com/c/chromium/src/+/1632494
NetworkService is now deleted by using SequnceLocalStorageSlot
on the IO thread when the service is disabled, which expects
all associated NetworkContexts on that sequence to be destroyed.
* chore: bump chromium in DEPS to 7c16850e7e40990e141f47101b737ec1092175a1
* fix: Destroy all network contexts before primary network context
* Simplify out-of-process service registration
https://chromium-review.googlesource.com/c/chromium/src/+/1615882
* [ThreadPool] Rename base::ThreadPool to base::ThreadPoolInstance
https://chromium-review.googlesource.com/c/chromium/src/+/1634851
* chore: update patches
* fix: -Winconsistent-missing-override warnings
* chore: bump chromium in DEPS to 93ebfaccc12715df1d5426797998eed0932f7ae1
* Change CreateBrowserMainParts to return unique_ptrs
https://chromium-review.googlesource.com/c/chromium/src/+/1632532
* chore: update patches
* chore: bump chromium in DEPS to e656555ffb87bdd05e248d0a3ef9dd9d3433e17b
* chore: bump chromium in DEPS to 111e7a8d2e3ae9d70e535009d6afb066ac906063
* chore: bump chromium in DEPS to 9b6b84670d32a7aff41ce73adc0eeee67d364989
* chore: update patches
* chore: remove ShouldInterceptResourceAsStream as it is removed upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1639597
* chore: remove ResourceDispatcherHostCreated as it is removed upstream
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1610892
* chore: CreateWithStrongBinding --> CreateWithSelfOwnedReceiver
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1636722
* chore: rename all blink media enums
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1639237
* chore: add accidentally removed patch content back
2019-06-03 20:44:12 -07:00
Samuel Attard
67b3fbca89
fix: ensure the inspector agent is shutdown before cleaning up the node env ( #18028 )
...
* fix: ensure the inspector agent is shutdown before cleaning up the node env
* spec: add tests to ensure clean shutdown with connected inspector agent
* Update node_debugger.cc
2019-04-30 15:44:40 -07:00
Electron Bot
716cb28430
chore: bump chromium to 1e9f9a24aa12 (master) ( #17880 )
...
* chore: bump chromium in DEPS to 1e9f9a24aa12bea9cf194a82a7e249bd1242ec4f
* chore: update patches
* Make WebContents' theme color a base::Optional<SkColor>
https://chromium-review.googlesource.com/c/chromium/src/+/1540022
* update autofill patch for incorrect header includes
* Move Shell messages to web_test and rename to BlinkTest.
https://chromium-review.googlesource.com/c/chromium/src/+/1525181
* Make PlatformNotificationServiceImpl a KeyedService.
https://chromium-review.googlesource.com/c/chromium/src/+/1336150
* Move MediaPlayerId to its own file.
https://chromium-review.googlesource.com/c/chromium/src/+/1547057
* Remove net/base/completion_callback.h, which is no longer used
https://chromium-review.googlesource.com/c/chromium/src/+/1552821
* AW NS: support file scheme cookies
https://chromium-review.googlesource.com/c/chromium/src/+/1533486
* Remove SecurityInfo and adapt remaining consumers
https://chromium-review.googlesource.com/c/chromium/src/+/1509455
* Remove deprecated type-specific number to string conversion functions
https://chromium-review.googlesource.com/c/chromium/src/+/1545881
* DevTools: Adding new performance histograms for launch of top 4 tools
https://chromium-review.googlesource.com/c/chromium/src/+/1506388
* Update include paths for //base/hash/hash.h
https://chromium-review.googlesource.com/c/chromium/src/+/1544630
* build: Disable ensure_gn_version gclient hook for mac CI checkout
* update patches
* use maybe version of v8::String::NewFromTwoByte
* bump appveyor image version
* fix mac ci hopefully
* Convert enum to enum class for MenuAnchorPosition
https://chromium-review.googlesource.com/c/chromium/src/+/1530508
* use maybe version of ToObject
* RenderViewHost::GetProcess is no longer const
* Unrefcount AuthChallengeInfo
https://chromium-review.googlesource.com/c/chromium/src/+/1550631
* MenuButtonController takes Button rather than MenuButton
https://chromium-review.googlesource.com/c/chromium/src/+/1500935
* add //ui/views_bridge_mac to deps to fix link error
* forward declare views::Button in atom::MenuDelegate
* more v8 patches
* base/{=> hash}/md5.h
https://chromium-review.googlesource.com/c/chromium/src/+/1535124
* gfx::{PlatformFontWin => win}::*
https://chromium-review.googlesource.com/c/chromium/src/+/1534178
* fix v8 patches
* [base] Rename TaskScheduler to ThreadPool
https://chromium-review.googlesource.com/c/chromium/src/+/1561552
* use internal_config_base for bytecode_builtins_list_generator
avoids windows link errors
* FIXME: temporarily disable v8/breakpad integration
* FIXME: temporarily disable prevent-will-redirect test
* FIXME: disable neon on aarch64 pending crbug.com/953815
* update to account for WebCursor refactor
https://chromium-review.googlesource.com/c/chromium/src/+/1562755
* enable stack dumping on appveyor
* Revert "FIXME: disable neon on aarch64 pending crbug.com/953815"
This reverts commit 57f082026be3d83069f2a2814684abf4dc9e7b53.
* fix: remove const qualifiers to match upstream
* fix: remove const qualifiers to match upstream in cc files as well
* don't throw an error when testing if an object is an object
* use non-deprecated Buffer constructor
* Remove net::CookieSameSite::DEFAULT_MODE enum value
https://chromium-review.googlesource.com/c/chromium/src/+/1567955
* depend on modded dbus-native to work around buffer deprecation
https://github.com/sidorares/dbus-native/pull/262
* revert clang roll to fix arm build on linux
* fixup! depend on modded dbus-native to work around buffer deprecation
need more coffee
* update coffee-script
* robustify verify-mksnapshot w.r.t. command-line parameters
* Revert "robustify verify-mksnapshot w.r.t. command-line parameters"
This reverts commit a49af01411f684f6025528d604895c3696e0bc57.
* fix mksnapshot by matching args
* update patches
* TMP: enable rdp on appveyor
* Changed ContentBrowserClient::CreateQuotaPermissionContext() to return scoped_refptr.
https://chromium-review.googlesource.com/c/chromium/src/+/1569376
* Make content::ResourceType an enum class.
https://chromium-review.googlesource.com/c/chromium/src/+/1569345
* fixup! Make content::ResourceType an enum class.
* turn off rdp
* use net::CompletionRepeatingCallback instead of base::Callback<void(int)>
* remove disable_ensure_gn_version_gclient_hook.patch
* copy repeating callback instead of std::move
* fix lint
* add completion_repeating_callback.h include
2019-04-20 10:20:37 -07:00
Shelley Vohr
38d75010c7
chore: rename atomBinding to electronBinding ( #17419 )
2019-03-18 12:37:06 -07:00
Nitish Sakhawalkar
e77d065875
chore: node_includes header no longer needs to be at the end of the list ( #17090 )
...
Until one of the latest version of node, the definition of the DISALLOW_COPY_AND_ASSIGN macro in node was different than in chromium. That is no longer the case, so just undefining the macro in node_includes.h works.
2019-03-11 17:13:43 -07:00
SamvelRaja
8af532ba98
feat: added process.electron to get the electron version in forked process ( #16450 )
2019-01-29 22:13:18 -08:00
Samuel Attard
c9007557e5
chore: post_task and friends now live under base/task
...
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1161088
2018-12-03 20:07:38 +05:30
deepak1556
be719a1ec3
fix: Use the new isolate initialization api
...
https://chromium-review.googlesource.com/c/chromium/src/+/1015020
2018-10-09 14:38:00 -07:00
Jeremy Apthorp
9aaedc394e
DrainBackgroundTasks -> DrainTasks
2018-10-04 00:13:37 +02:00
Robo
a24ad6bc14
build: define compile time features with buildflag header ( #14840 )
...
* build: define compile time features with buildflag header
* refactor: switch to BUILDFLAG(ENABLE_DESKTOP_CAPTURER)
* refactor: switch to BUILDFLAG(ENABLE_RUN_AS_NODE)
* refactor: switch to BUILDFLAG(ENABLE_OSR)
* refactor: switch to BUILDFLAG(ENABLE_VIEW_API)
* refactor: switch to BUILDFLAG(ENABLE_PEPPER_FLASH)
* refactor: switch to BUILDFLAG(OVERRIDE_LOCATION_PROVIDER)
* refactor: switch to BUILDFLAG(ENABLE_PDF_VIEWER)
2018-10-01 16:00:53 -04:00
Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings ( #14583 )
...
* chore: fix cpplint 'include_what_you_use' warnings
Typically by including <memory>, <utility> etc.
* chore: fix 'static/global string constant' warning
Use C style strings instead of std::string.
Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
/home/charles/electron/electron-gn/src/electron/script/cpplint.js
* refactor: remove global string variables.
Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.
The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
* fix: initializer error introduced in last commit
* fix: remove WIP file that was included by accident
* fix: include order
* fix: include order
* fix: include order
* fix: include order, again
2018-09-12 19:25:56 -05:00
Aleksei Kuzmin
7589555cec
inspector: stop dragging platform pointer
...
https://github.com/nodejs/node/commit/296fd57324
2018-09-11 20:24:03 +02:00
Samuel Attard
b7d00e26bf
Default LoadV8Snapshot changed in C66
...
CR Ref: https://chromium-review.googlesource.com/c/chromium/src/+/859577
2018-06-19 11:49:46 +10:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
Aleš Pergl
868e792572
Make run-as-node mode optional ( #11701 )
2018-01-23 18:17:15 -05:00
deepak1556
1b30cac372
Don't delay node module initialization
2018-01-02 16:37:11 +09:00
deepak1556
e30131f30b
Initialize isolate holder in standalone node mode
2018-01-02 16:37:07 +09:00
Cheng Zhao
c0c2461245
Do not create duplicate V8Platform in NodeDebugger
2017-12-22 20:29:09 +09:00
Ales Pergl
531472bad4
Create a TaskScheduler
when initializing run-as-node mode.
...
It fixes crashes when V8 tries to execute background tasks via the TaskScheduler.
2017-11-24 10:58:53 +09:00
deepak1556
538b97582a
app: add support for inspect/inspect-brk in forked node process
2017-06-13 00:23:11 +05:30
Kevin Sawicki
718cd8d711
Remove unsupported debugger in node processes
2017-05-11 15:02:27 -07:00
Kevin Sawicki
43ef4faf79
🎨
2017-01-24 14:00:03 -08:00
Kevin Sawicki
795b674996
Add StartInstance helper on CrashReporter
2017-01-24 13:54:46 -08:00
Kevin Sawicki
f1cd1c6dff
Use mate::Dictionary::CreateEmpty
2017-01-24 12:44:39 -08:00
Kevin Sawicki
4107174cfd
Group includes
2017-01-24 12:44:39 -08:00
Ramya Achutha Rao
1f07cf2545
Add crashReporter property to process
2017-01-24 12:44:39 -08:00
Ramya Achutha Rao
d4b44d8b69
Expose crash reporter start for child node processes
2017-01-24 12:44:39 -08:00
Kevin Sawicki
54e2c480cb
Upgrade to node 7.4
2017-01-19 09:05:59 +02:00
Cheng Zhao
497f5a1199
Update files for Chrome 54 API changes
2017-01-19 09:05:59 +02:00
Kevin Sawicki
a8382d6794
Moving atom_bindings include to Windows block
2016-10-12 13:48:49 -07:00
Kevin Sawicki
b01fd9715b
Only expose process.log on Windows
2016-10-12 13:48:48 -07:00
Kevin Sawicki
0740b2f66b
Reuse Log method
2016-10-12 13:48:48 -07:00
Kevin Sawicki
d686916fe2
Expose process.log when running as node
2016-10-12 13:48:48 -07:00
Cheng Zhao
b57665330c
Merge branch 'master' into chrome52
2016-07-21 05:34:36 -06:00
Cheng Zhao
cef86f5257
Use node::FreeEnvironment
2016-07-21 16:43:21 +09:00
Cheng Zhao
7d42797c1f
Update node headers including
2016-07-21 00:57:34 -06:00
Cheng Zhao
1ba3907038
Update to API changes of Chrome 52
2016-07-04 15:32:43 +09:00
Cheng Zhao
4b675a741d
Init feature list in node process
...
It is a new dependency of gin.
2016-05-23 13:01:47 +09:00
Cheng Zhao
2d410ede48
Initialize things in the same sequence with main process
2015-10-21 16:24:54 +08:00
Cheng Zhao
599e9b90bb
Provide task runner for the node mode
2015-09-03 17:50:24 +09:00
Cheng Zhao
573c959a75
Use our debugger implementation in Node
2015-08-27 13:16:19 +08:00
Cheng Zhao
7423c89968
Fix compilation warnings caused by chrome44 update
2015-08-11 10:08:34 +08:00
Haojian Wu
d003b1bb57
LoadV8Snapshot has been moved from gin::IsolateHolder to gin::V8Initializer.
2015-08-11 09:48:29 +08:00
Cheng Zhao
88a1c7973c
Set node::node_isolate to fix crash
2015-04-20 14:32:41 +08:00
Cheng Zhao
7a52a4cff1
Also enable the debugger
2015-04-20 14:10:15 +08:00
Robo
ee08d98d2e
node: start debugger for node run during a forked process
2015-04-20 14:06:56 +08:00
Cheng Zhao
c62c943bdb
Define our own Node entry
...
Chromium's V8 is using external startup snapshot file while Node does
not, so we have to use Chromium's gin for V8 initialization.
2015-03-18 09:57:45 +08:00