Shelley Vohr
75f32afcd5
clean up excess code from generateGroupId
2017-10-24 00:24:57 -04:00
Shelley Vohr
f93121b226
don't reassign parameters in Menu.prototype.popup
2017-10-24 00:07:39 -04:00
Shelley Vohr
b1e707d535
abstract out switch case from Menu.prototype.insert
2017-10-23 23:46:39 -04:00
Shelley Vohr
7c0f7329d9
appease the linter overlords
2017-10-23 22:35:42 -04:00
Shelley Vohr
508b614769
remove excess code in delegate
2017-10-23 22:33:23 -04:00
Shelley Vohr
9b364d5be3
refactor menuWillShow
2017-10-23 22:22:39 -04:00
Shelley Vohr
9038987e1d
significant cleanup; all tests still passing
2017-10-23 20:04:22 -04:00
Zeke Sikelianos
1672fd22e1
Merge pull request #10874 from Toinane/master
...
Update OSR with more details
2017-10-23 15:54:31 -07:00
Shelley Vohr
3fc5d51a96
clean up delegate
2017-10-23 18:35:16 -04:00
Shelley Vohr
577c0042b0
update to ES6
2017-10-23 14:47:47 -04:00
Toinane
db5a429948
fixe grammar
2017-10-23 18:36:52 +02:00
Shelley Vohr
87802b2c17
initial port of things into a Menu class
2017-10-23 12:11:59 -04:00
John Kleinschmidt
66846bff97
Automate release ( #10827 )
...
* Create prepare-release script
* Add script to merge release
* Cleanup/add logging
* Move release process out of upload.py
* Add cleanup release branch
* Update release doc to reflect new scripts
* Fix to allow running with notesOnly
Also fixup release name and body when beta release.
* Fix issues found during release
* Use getRelease instead of getAssets
github.repos.getAssets is limited to 30 entries which means we may not get back the file we are looking for.
* Documentation corrections
2017-10-23 11:02:50 -04:00
John Kleinschmidt
67f0eb7b3b
Merge pull request #10873 from ahmedmohamedali/fix_issue_10697
...
Fixes #10697
2017-10-23 09:32:28 -04:00
Shelley Vohr
61a93c711c
clean up popup
2017-10-23 00:47:02 -04:00
Shelley Vohr
f9c3123f5f
clean up menuWillShow
2017-10-23 00:16:35 -04:00
Shelley Vohr
1cd53768ab
clean up indexToInsertByPosition
2017-10-22 23:57:23 -04:00
Shelley Vohr
b7ebee985b
refactor indexOfItemById
2017-10-22 23:51:33 -04:00
Toinane
42f51850cc
Update OSR with more details
2017-10-22 00:15:30 +02:00
Ahmed Mohamed Ali
463260b249
Electron crashes if user clicks Dev Tools & Zoom options #10697
2017-10-21 22:21:24 +02:00
Taeho Kim
f8048977ac
📝 Use separate entitlements for login helper
2017-10-21 20:52:20 +09:00
Ahmed Mohamed Ali
1e9942c1bf
Fix js coding style errors
2017-10-20 08:46:41 +02:00
Ted Kim
4119da607f
Implement login helper to manage login item in Mac App Store build
2017-10-20 11:44:19 +09:00
Ahmed Mohamed Ali
9f3cfa2dbd
Fix crash that happens when the PDF viewer is refreshed.
...
The root cause is the PdfViewerHandler instanceis destroyed but not removed from the list of observer in WebContentsZoomController
2017-10-19 16:27:08 +02:00
Ahmed Mohamed Ali
44f91e12e1
Add tests for fix described in #10793
2017-10-19 16:15:02 +02:00
Zeke Sikelianos
306b627090
Merge pull request #10839 from qazbnm456/update_docs
...
[docs] update app.md
2017-10-18 20:35:11 -07:00
John Kleinschmidt
90e7d7e112
v1.8.2-beta.1
2017-10-18 16:49:32 -04:00
Boik
7be79613b8
according to https://github.com/electron/electron/pull/10670 , update app.md
2017-10-19 00:56:05 +08:00
Ahmed Mohamed Ali
05035eb1e3
Fix linefeeds
2017-10-18 17:36:56 +02:00
John Kleinschmidt
cf12d31875
Merge pull request #10834 from Vehemos/master
...
Updated online-offline-events.md
2017-10-18 10:06:27 -04:00
Sarthak Tripathi
32f92f7a90
Updated online-offline-events.md
...
Improved readability and simplicity.
2017-10-18 19:26:19 +05:30
Sarthak Tripathi
392f4b44f0
Updated online-offline-events.md
...
Added links, removed grammatical error.
2017-10-18 19:11:05 +05:30
John Kleinschmidt
a65ab1d5a7
Merge pull request #10829 from zombieleet/master
...
update docs to show usage of ipcRenderer.sendTo
2017-10-18 09:33:57 -04:00
John Kleinschmidt
57537ea10e
Merge pull request #10810 from qazbnm456/add_error_code_to_session_set_certificate_verify_proc
...
Add error code to session.setCertificateVerifyProc
2017-10-18 09:33:37 -04:00
John Kleinschmidt
51cbd977f0
Merge pull request #10534 from robbix1206/npx_in_quickstart
...
[Docs] Add npx command for node version 8.2.0 and later in quickstart guide
2017-10-18 09:32:30 -04:00
Sarthak Tripathi
392e88db34
Updated online-offline-events.md
...
Added more info, to clarify things.
2017-10-18 16:28:18 +05:30
73mp74710n
0a0897ef28
Update ipc-renderer.md
2017-10-18 02:52:02 +01:00
73mp74710n
5b193bad4b
Merge pull request #1 from zombieleet/zombieleet-patch-1
...
update docs to show usage of ipcRenderer.sendTo
2017-10-18 02:35:51 +01:00
73mp74710n
c647b0c65e
update docs to show usage of ipcRenderer.sendTo
2017-10-18 02:35:19 +01:00
Zeke Sikelianos
9193720789
Merge pull request #10825 from electron/vanessayuenn-patch-1
...
Fix link to version change rules
2017-10-17 14:53:02 -07:00
Vanessa Yuen
3208a77bf3
Fix link to version-change-rules
2017-10-17 13:37:05 -04:00
John Kleinschmidt
cbda307ebf
Merge pull request #10696 from primalmotion/patch-1
...
🍎 skip tabbing category if macOS < Sierra
2017-10-17 10:24:11 -04:00
Cheng Zhao
0358862066
Merge pull request #10812 from electron/fix_symbol_file_names
...
Use real shared library names for symbol files
2017-10-17 15:27:35 +08:00
Cheng Zhao
d901504ea9
Merge pull request #10804 from robinwassen/optional-cpplint
...
cpplint skip to run if dependencies has not been bootstrapped
2017-10-17 15:26:49 +08:00
Cheng Zhao
4dc74776c1
Merge pull request #10709 from electron/fix-notification-actions-hs
...
Fix notification actions not working on High Sierra
2017-10-17 15:18:53 +08:00
Zeke Sikelianos
71f13620d3
Merge pull request #10795 from samthomson/docs/shell-open-external
...
updated docs
2017-10-16 19:32:09 -07:00
Zeke Sikelianos
a914d3c534
Merge pull request #10612 from electron/notification-docs-fix
...
Add `string` to notification doc
2017-10-16 19:31:47 -07:00
Vanessa Yuen
242a55aa60
Merge pull request #10740 from demopark/patch-1
...
Add notification docs translation in Chinese
2017-10-16 21:16:47 -04:00
Vanessa Yuen
9045171ad7
Merge pull request #10748 from demopark/patch-2
...
Add notifications tutoral in Chinese
2017-10-16 21:07:23 -04:00
Vanessa Yuen
e5797a57a7
Merge pull request #10749 from demopark/patch-3
...
Add notification-action.md file in Chinese
2017-10-16 21:03:32 -04:00
