taoky
4f76fff978
fix: don't do self-destroy in LibnotifyNotification::Dismiss() ( #41691 )
...
Callers of Notification::Dismiss() assume that the notification
instance is not deleted after the call, but this was not the case
for LibnotifyNotification:
- Destroy() would get `this` deleted.
- notify_notification_close() in portal environment triggers
LibnotifyNotification::OnNotificationClosed(), and finally calls
Destroy()
This patch removes all Destroy() in Dismiss(), and adds a boolean
to tell whether notify_notification_close() is running, to avoid crash
under portal environment.
Fixes #40461 .
2024-03-27 10:53:23 +01:00
electron-roller[bot]
8f7a48879e
chore: bump chromium to 119.0.6045.0 (main) ( #40076 )
...
* chore: bump chromium in DEPS to 119.0.6045.0
* chore: update patches
* 4864948: Remove legacy-legacy
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4864948
* 4907760: Remove ui/base/glib/glib_signal.h
https://chromium-review.googlesource.com/c/chromium/src/+/4907760
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2023-10-05 19:59:39 -04:00
John Kleinschmidt
3dbc0a365f
chore: enable check raw ptr fields ( #38167 )
2023-05-11 16:07:39 -04:00
Milan Burda
c4ea33d1bf
chore: add ELECTRON_ prefix to C++ include guards ( #31925 )
2021-11-22 16:34:31 +09:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
David Sanders
93c9374e95
chore: trim unused STL includes ( #29414 )
2021-06-01 10:34:44 +09:00
Milan Burda
ddf3ef0a5f
refactor: use C++11 class member variable initialization ( #27477 )
2021-01-26 12:16:21 -06:00
Samuel Attard
34c4c8d508
refactor: rename the atom namespace to electron
2019-06-19 17:33:28 -07:00
Samuel Attard
56930338e8
chore: fix linting after shell rename
2019-06-19 17:33:28 -07:00
Samuel Attard
2160c1fcc9
refactor: replace includes for atom with shell
2019-06-19 17:33:28 -07:00
Samuel Attard
d7f07e8a80
refactor: rename the atom directory to shell
2019-06-19 17:33:28 -07:00
