Shelley Vohr
02710ef574
refactor: make templateImage a property on nativeImage ( #18124 )
...
* refactor: make templateImage a property on nativeImage
* Update docs/api/native-image.md
Co-Authored-By: codebytere <codebytere@github.com>
* fix nativeImage prototype deprecation
* update for new property name
* Update docs/api/native-image.md
Co-Authored-By: codebytere <codebytere@github.com>
2019-05-07 06:52:07 -07:00
Milan Burda
5e7c828c9e
fix: copy pixels in AddImageSkiaRepFromBuffer ( #17843 )
2019-04-18 09:16:34 +09:00
Milan Burda
3c2ff97a16
fix: copy pixels in NativeImage::CreateFromBitmap ( #17844 )
2019-04-18 09:16:06 +09:00
Milan Burda
95df531b33
fix: add missing buffer size check in nativeImage ( #17465 )
2019-03-26 10:13:39 +09:00
Milan Burda
3a091cdea4
refactor: implement clipboard APIs without the remote module ( #17200 )
2019-03-15 17:32:04 -07:00
Milan Burda
878538f2e8
feat: add safer nativeImage.createFromBitmap(), which does not decode PNG/JPEG ( #17337 )
2019-03-14 11:00:38 -07:00
Milan Burda
df7dc9396e
fix: don't crash when nativeImage.createFromBuffer() called with invalid buffer ( #17344 )
2019-03-13 08:26:11 -07:00
Nitish Sakhawalkar
e77d065875
chore: node_includes header no longer needs to be at the end of the list ( #17090 )
...
Until one of the latest version of node, the definition of the DISALLOW_COPY_AND_ASSIGN macro in node was different than in chromium. That is no longer the case, so just undefining the macro in node_includes.h works.
2019-03-11 17:13:43 -07:00
Robo
5afb7dc715
refactor: load electron builtin modules with process._linkedBinding ( #17247 )
...
* refactor: load electron builtin modules with process._linkedBinding
NODE_BUILTING_MODULE_CONTEXT_AWARE and process.binding are
removed in https://github.com/nodejs/node/pull/25829 . This changes
uses the alternative available without any functionality change.
* chore: roll node
2019-03-08 10:29:52 -08:00
Robo
52fe92d02e
feat: Upgrade to Chromium 71.0.3578.98 ( #15966 )
2019-01-11 17:00:43 -08:00
Samuel Attard
9d72bd4de4
chore: update CreateSkBitmapFromHICON usage for new API (no pointer)
...
refs: https://chromium-review.googlesource.com/c/chromium/src/+/1234372
2018-12-03 20:07:42 +05:30
Charles Kerr
d663b4eaee
fix: fix gn cpplint warnings ( #14583 )
...
* chore: fix cpplint 'include_what_you_use' warnings
Typically by including <memory>, <utility> etc.
* chore: fix 'static/global string constant' warning
Use C style strings instead of std::string.
Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
/home/charles/electron/electron-gn/src/electron/script/cpplint.js
* refactor: remove global string variables.
Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.
The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
* fix: initializer error introduced in last commit
* fix: remove WIP file that was included by accident
* fix: include order
* fix: include order
* fix: include order
* fix: include order, again
2018-09-12 19:25:56 -05:00
Jeremy Apthorp
6f91af9343
chore: fix various chromium-style errors in windows ( #13394 )
...
These errors weren't previously picked up because the GN build wasn't running on Windows.
2018-06-25 22:30:00 +02:00
Milan Burda
28fd571d0c
refactoring: use std::make_unique<T> ( #13245 )
2018-06-18 16:32:55 +09:00
Shelley Vohr
22fed0c798
remove nativeImage.createFromBuffer() deprecation
2018-05-23 09:43:58 -07:00
Shelley Vohr
c6f4bbd143
also format missing .cc files
2018-04-18 20:48:45 -04:00
Robo
c1404ff2c1
vendor: Update native mate to fix v8 DCHECK crash ( #12534 )
...
* update native_mate ref
* Remove MarkHighMemoryUsage api
2018-04-05 00:47:18 -05:00
Cheng Zhao
624e09533c
Avoid using deprecated skia size methods
2018-03-20 10:13:16 +03:00
shelley vohr
0e5b6f9300
Upgrade to node v9.3.0 ( #11507 )
...
* update submodule refs for node v9.3.0
* Define "llvm_version" for Node.js build
* NODE_MODULE_CONTEXT_AWARE_BUILTIN -> NODE_BUILTIN_MODULE_CONTEXT_AWARE
* update NodePlatform to MultiIsolatePlatform
* fix linting error
* update node ref
* REVIEW: Explicitly register builtin modules
https://github.com/nodejs/node/pull/16565
* update libcc ref
* switch libcc to c62
* REVIEW: Address node api changes
- Always start the inspector agent for https://github.com/nodejs/node/pull/17085
- Set the tracing controller for node https://github.com/nodejs/node/pull/15538
- Isolate data creation now requires plaform https://github.com/nodejs/node/pull/16700
2018-02-23 10:22:00 +09:00
deepak1556
e03f7baa60
gfx::Image::SwapRepresentations is removed in favor of std::move
...
https://chromium-review.googlesource.com/c/chromium/src/+/588033
2018-02-23 10:21:23 +09:00
shelley vohr
a2856db982
Remove nativeImage deprecated methods ( #11978 )
...
* remove deprecated nativeimage methods
* remove .only from spec
2018-02-20 09:15:27 -06:00
deepak1556
1d95241185
FIXME: refactor and remove usage of ScopedAllowIO where possible
2018-01-02 16:37:06 +09:00
Aleksei Kuzmin
b9ed7380aa
Explicitly set alpha type of bitmaps with JPEG data to opaque
...
Actually fixes #11245 .
2017-11-30 17:56:32 +01:00
Samuel Attard
2c7787900f
Follow style guide
2017-10-10 17:20:55 +11:00
Samuel Attard
9308c96f95
Appease the linting overlords
2017-10-10 17:17:51 +11:00
Samuel Attard
767a178bd1
Do not throw if the named image can not be found
2017-10-10 03:18:44 +11:00
Samuel Attard
e027ba9c47
Add nativeImage.createFromNamedImage API
2017-10-10 03:13:40 +11:00
Cheng Zhao
6ee95f9529
Fix crash when converting invalid image to JPEG
2017-07-31 15:48:54 +09:00
Cheng Zhao
a6c8329a68
Remove unneeded heap allocation
2017-07-31 15:45:59 +09:00
Heilig Benedek
bf58373a40
fix NativeImage size hint crashing when image is created from path
2017-05-11 11:38:34 +02:00
Heilig Benedek
6f80379b30
use computeSize64 instead of getSize
2017-05-10 22:19:05 +02:00
Heilig Benedek
5c690ea46e
don't store isolate_ in NativeImage and tune size hints
2017-05-10 22:19:05 +02:00
Heilig Benedek
576b702e8b
update native_mate and use the MarkHighMemoryUsage API to speed up garbage collection
2017-05-10 22:19:05 +02:00
Heilig Benedek
3b94d268eb
lint fix 📝
2017-05-10 22:19:05 +02:00
Heilig Benedek
1fcf6ea73f
add size hints to NativeImages to make node GC aware of the high amount of memory used by the instances
2017-05-10 22:19:05 +02:00
Kevin Sawicki
7e039d92ec
Support adding representation from data URL
2017-03-09 09:56:42 -08:00
Kevin Sawicki
d67863aa9f
Add addRepresentation buffer support
2017-03-09 09:56:42 -08:00
Kevin Sawicki
8852b128ec
Add GetScaleFactorFromOptions helper
2017-03-07 12:27:55 -08:00
Kevin Sawicki
82a81bb26e
Support scale factor to buffer APIs
2017-03-07 12:27:55 -08:00
Kevin Sawicki
e4ead6d018
Remove hasRepresentation and just use 1x png result
2017-03-07 12:27:55 -08:00
Kevin Sawicki
c11cdf321b
Support toPNG on image without 1x representation
2017-03-07 12:27:55 -08:00
Kevin Sawicki
86babdd412
Remove unused include
2017-03-07 12:27:55 -08:00
Kevin Sawicki
0bbbeb307e
Support toDataURL without 1x representation
2017-03-07 12:27:55 -08:00
Kevin Sawicki
e1281342f6
Return empty buffers when image is empty
2017-01-25 14:26:05 -08:00
Kevin Sawicki
8680a08a8d
Add deprecated comment to scaleFactor parameter
2016-12-14 10:18:01 -08:00
gellert
a609e52a14
moves bitmap parameters to options object
2016-12-13 21:32:17 +01:00
gellert
39875c90f1
adds bitmap support to createFromBuffer
2016-12-13 21:32:17 +01:00
Kevin Sawicki
abffd98e29
Resize images with preserve aspect ratio
2016-10-05 11:02:58 -07:00
Kevin Sawicki
56f9cc683a
bounds -> rect
2016-10-05 11:02:57 -07:00
Kevin Sawicki
2b4fff70d5
Add initial crop method
2016-10-05 11:02:57 -07:00