Rob Brackett
c1b1348735
Add resourceType arg to webContents did-get-response-details event.
...
Fixes #5074 and follows @zcbenz's recommendation to expose ResourceTypeToString from atom_network_delegate publicly.
Also adds testing for other arguments to the `did-get-response-details` events, since there were no existing tests for them.
2016-04-08 11:19:36 -07:00
Cheng Zhao
2f6796bd7f
Disable throttling in tests
2016-04-08 15:57:14 +09:00
Cheng Zhao
82856eb099
Merge pull request #5029 from Mr0grog/5013-add-main-frame-param-for-did-fail-load
...
Add `isMainFrame` param to WebContents `did-fail-load` event
2016-04-07 20:22:02 +09:00
Cheng Zhao
dd283ff8d7
spec: We should not use pre release of Node
2016-04-05 19:53:07 +09:00
Cheng Zhao
c562b24df8
spec: Add test case for #5028
2016-04-05 17:08:27 +09:00
Rob Brackett
f12f87d6f0
Add isMainFrame as last argument to WebContents did-fail-load event.
...
Fixes #5013 .
2016-04-04 19:26:06 -07:00
Cheng Zhao
19a172f2f5
Remove the hacks because of transparent background
2016-04-02 21:21:30 +09:00
Kevin Sawicki
527ff66115
Pull app/session from remote
2016-04-01 16:59:13 -07:00
Kevin Sawicki
3695e38719
Remove duplicate require
2016-04-01 16:53:44 -07:00
Kevin Sawicki
7734f6af62
Remove semicolons
2016-04-01 16:52:55 -07:00
Kevin Sawicki
909ed54bef
Remove stray log
2016-04-01 16:52:28 -07:00
Kevin Sawicki
230ed78dd6
Remove lint warnings
2016-04-01 16:51:17 -07:00
Kevin Sawicki
ef2a28ca86
Listen for browser-window-created event for asserts
2016-04-01 16:50:20 -07:00
Kevin Sawicki
fd12e1f506
Add failing spec for webview nodeIntegration inheritance
2016-04-01 16:47:17 -07:00
Kevin Sawicki
4890734f66
Add missing title param
2016-04-01 16:42:53 -07:00
Kevin Sawicki
9e66df23d0
Add clearer assertion of process being undefined
2016-04-01 16:40:33 -07:00
Kevin Sawicki
d7b1792503
Use template strings
2016-04-01 16:39:31 -07:00
Kevin Sawicki
2713580d09
Remove stray log
2016-04-01 16:39:31 -07:00
Kevin Sawicki
777704e659
Add failing spec for nodeIntegration inheritance
2016-04-01 16:39:06 -07:00
Kevin Sawicki
3c96d7b726
Rename atom.asar to electron.asar in specs
2016-04-01 16:12:57 -07:00
Cheng Zhao
b35f4c1805
spec: Fix failing test due to path delimiter
2016-04-01 16:42:44 +09:00
Cheng Zhao
247b3f3605
Fix the background color in test app
2016-04-01 16:35:19 +09:00
Cheng Zhao
b9ead472a5
spec: Remote object should be referenced by methods in its prototype chain
2016-04-01 15:35:34 +09:00
Cheng Zhao
f36851fcff
spec: Remote object should be referenced by its members
2016-04-01 15:05:05 +09:00
Zeke Sikelianos
7c58f7fb02
eradicate all per-file eslint globals
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
6425ef4261
restrict mocha scope to /spec; break out link tasks
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
b5afad9da7
avoid using eslint comment exceptions
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
e6698102c9
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
cfdfdc8ccc
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
14fb3c4598
throw error if it exists
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
c5f70c8d99
dance around error checking with this one weird trick
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
5e4696f4a7
standardize more
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
9db733a4ff
mostly more globals
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
c4b6cf4a8e
do more manual cleanup and specify globals
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
f47fa25e39
tiptoe
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
f35f362272
autoformat more files
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
bd9b0b8ed3
wrap conditional, because return can only be used in a function
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
3855a774ab
autoformat more easy files
2016-03-30 17:00:31 -07:00
Cheng Zhao
e08b48ab48
Merge pull request #4840 from atom/undefined-menu-accelerator
...
Undefined menu accelerator
2016-03-21 21:02:44 +09:00
Zeke Sikelianos
827730144b
style nit
2016-03-18 10:53:49 -07:00
Zeke Sikelianos
e9ba5abe03
test for null accelerator too
2016-03-17 16:14:31 -07:00
Zeke Sikelianos
87395cdef8
add failing spec for undefined accelerator
2016-03-17 16:09:16 -07:00
Kevin Sawicki
737ffd8d7c
Improve deprecated message on webPreferences options
2016-03-17 13:37:08 -07:00
Kevin Sawicki
2acfb8ad82
node-integration -> nodeIntegration
2016-03-17 13:37:07 -07:00
Kevin Sawicki
1b6e01ce6d
Add missing semicolons
2016-03-17 13:37:07 -07:00
Kevin Sawicki
1e8e8f18b4
Add failing specs for deprecated options usage
2016-03-17 13:37:07 -07:00
Kevin Sawicki
5c9b19b508
web-preferences -> webPreferences
2016-03-17 13:37:07 -07:00
Cheng Zhao
081ab17e13
Merge pull request #4791 from atom/nativeimage-as-nsimage
...
Convert NativeImage instances to OS-specific representations
2016-03-17 21:49:46 +09:00
Paul Betts
148014f99a
Fix spec failure
2016-03-16 12:42:23 -07:00
Paul Betts
fa197ad583
Fix failing test
2016-03-16 12:40:28 -07:00
