trop[bot]
e4bcd82590
fix: webContents.navigationHistory
should be enumerable ( #42182 )
...
fix: webContents.navigationHistory should be enumerable
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-05-15 10:49:24 +02:00
Alice Zhao
c82ec0c72b
test: remove hardcoded url ( #41706 )
2024-03-27 10:53:02 +01:00
Alice Zhao
c57ce31e84
test: fix flaky tests in webContents.navigationHistory
( #41705 )
...
test: fix flaky tests by replacing real urls with data urls
2024-03-27 13:49:11 +09:00
Alice Zhao
00e3445f8a
feat: add navigationHistory.getEntryAtIndex(int index)
method ( #41577 )
2024-03-21 14:59:23 -07:00
John Kleinschmidt
1036d824fe
ci: use CircleCI hosted macOS arm64 runners for testing ( #41649 )
2024-03-21 14:07:18 -04:00
Shelley Vohr
d5912fd05a
fix: webContents.print options should be optional ( #41467 )
2024-02-29 10:19:44 -05:00
marekharanczyk
398ca2a019
fix: make sure invalid URL loads promises are fulfilled. ( #41194 )
...
* fix: make sure invalid URL loads promisses are fulfilled.
* fixup! fix: make sure invalid URL loads promisses are fulfilled.
2024-02-05 16:36:51 +09:00
Shelley Vohr
6df3443617
fix: validate printToPDF
margins
against pageSize
( #41157 )
...
fix: validate margins against pageSize
2024-01-31 10:48:41 +01:00
Shelley Vohr
6786fde576
docs: document printToPDF
generateDocumentOutline
option ( #41156 )
...
* doc: document printToPDF generateDocumentOutline option
* doc: ready event to whenReady
2024-01-30 09:55:03 -06:00
Tamás Zahola
a94fb2cb5d
fix: don't reject loadURL()
promise from did-fail-load
- use did-finish-load
instead ( #40661 )
2023-12-12 11:45:14 -08:00
Albert Xing
3609fc7402
fix: clean up devtools frontend_host on webcontents destroy ( #40666 )
...
* fix: clean up devtools frontend_host on destroy
* chore: use IsInPrimaryMainFrame instead of IsInMainFrame
* test: add a test for re-opening devtools
2023-12-01 11:37:52 -08:00
Milan Burda
67894f1493
test: convert a few more specs to async/await ( #40313 )
2023-11-17 10:44:03 +01:00
Milan Burda
657e88b173
chore: remove deprecated crashed
and renderer-process-crashed
events ( #40115 )
2023-10-18 12:05:41 +02:00
Milan Burda
2c88626b51
chore: revert deprecate as an internal module ( #40146 )
...
Revert "chore: restore deprecate as an internal module (#40124 )"
This reverts commit 737e3de3fa
.
2023-10-10 11:50:47 -04:00
Shelley Vohr
86df4db6f1
fix: crash when calling non-reentrant function in loadURL
( #40143 )
2023-10-10 12:46:04 +02:00
Milan Burda
24bc0ee5c7
test: fix "crashed event does not crash main process when destroying WebContents in it" ( #40135 )
2023-10-09 09:56:48 +02:00
Milan Burda
737e3de3fa
chore: restore deprecate as an internal module ( #40124 )
...
* Revert "refactor: don't expose deprecate as an internal module (#35311 )"
This reverts commit 8424779906
.
* check crashed event warnings
2023-10-09 08:55:16 +09:00
Shelley Vohr
ec9c8476fe
fix: keyCode
s being incorrectly converted in webContents.sendInputEvent()
( #39776 )
...
fix: sendInputEvent keyCodes being incorrectly converted
2023-09-12 11:28:45 +02:00
David Sanders
c96bb9958f
chore: remove deprecated webContents.getPrinters()
( #39663 )
2023-09-05 10:16:41 +02:00
Milan Burda
d76a35afe4
test: remove a few casts to any ( #39713 )
2023-09-05 11:22:41 +09:00
Milan Burda
f27b034045
test: convert a few more specs to async/await ( #39712 )
2023-09-04 12:33:29 +02:00
Milan Burda
0b0707145b
refactor: replace .forEach()
with for-of
( #39691 )
...
* refactor: replace `.forEach()` with `for-of`
* refactor docs/fiddles/features/web-hid/renderer.js
2023-08-31 23:36:43 +09:00
Tomasz
f30fbebb98
fix: promise resolved to early when browser initiated in-page navigation v2 ( #39597 )
2023-08-28 12:37:28 -04:00
wanted002
e14964ccd0
feat: add setter and getter apis to specify udp port range for webrtc ( #39046 )
...
* feat:Add setter and getter apis to specify udp port range for webrtc (issue#9042)
* lint error fix for PR#39046
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for codereview
* fix lint error
* fix lint errors in file api-web-contents-spec.ts
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from itsananderson
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from jkleinsc
* fix lint error
* feat: add setter and getter apis to specify udp port range for webrtc (issue#9042) , changed for review from codebyter
2023-08-24 17:21:22 -04:00
Shelley Vohr
2affecd4dd
feat: allow generating accessible pdf with printToPDF
( #39563 )
...
* feat: allow generating accessible pdf with printToPDF
* docs: mark generateTaggedPDF experimental
2023-08-24 11:01:59 -04:00
wgsheng
127584dc37
feat: add a 'title' parameter to openDevTools()
( #39047 )
...
* [Feature Request]: Add a parameter to openDevTools() that sets the DevTools window title bar
* all titles->title
* add GetDevToolsTitle(),update docs
* fix:lint error
* fix:lint error
* add setDevToolTitle
* lint errror
* lint errror
* ling errror (.md)
* build error
* build error in mac
* build error
* build error
* change docs
* std::string->std::u16string
* lint error
* build error
* build error
2023-08-15 14:32:53 +09:00
David Sanders
effafdf498
test: use as const to remove some usages of as any ( #39475 )
2023-08-15 10:24:32 +09:00
Shelley Vohr
117d5310f5
revert: promise resolved too early when browser initiates in-page navigation ( #39481 )
...
This reverts commit a0effaf9b8
.
2023-08-14 13:13:15 +09:00
Tomasz
a0effaf9b8
fix: promise resolved to early when browser initiated in-page navigation ( #39260 )
2023-08-09 16:06:39 +02:00
Milan Burda
c9bae5da8e
refactor: use optional catch binding ( #39232 )
2023-07-27 10:53:45 -04:00
Milan Burda
9226cc662b
refactor: use types for once() return values in spec ( #38872 )
2023-06-22 14:38:52 -04:00
Milan Burda
d78f37ec8f
refactor: use node scheme imports in spec ( #38487 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-06-15 10:42:27 -04:00
Samuel Attard
46458ab517
build: update typescript-generator and docs-parser ( #38747 )
...
* build: update typescript-generator and docs-parser
* again...
* build: handle more specific pageSize types
2023-06-13 16:22:53 -07:00
Shelley Vohr
c0d9764de9
fix: webContents.print
parameter validation error ( #38614 )
2023-06-09 21:41:01 +02:00
Milan Burda
0294debc31
build: remove enable_picture_in_picture build flag ( #38620 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-06-07 23:56:31 -07:00
Black-Hole️
141f65b291
fix: webContents return type incorrect ( #38026 )
...
* fix: webContents type incorrect
* fix: ci failed
* fix: ci failed 2
2023-04-24 10:28:21 -04:00
Calvin
b8a21dbcd7
test: migrate to helpers & disabled tests list ( #37513 )
...
* test: migrate to helpers & disabled tests list
* can't disable a test suite
* correct condition
* address review comments
2023-04-04 09:48:51 -04:00
Shelley Vohr
512e56baf7
feat: expose audio-state-changed
on webContents
( #37366 )
...
feat: expose audio-state-changed on webContents
2023-03-06 17:00:24 +01:00
Shelley Vohr
9b20b3a722
chore: improve contents.takeHeapSnapshot
error messages ( #37434 )
...
* chore: improve contents.takeHeapSnapshot error messages
* fix wstring conversion issue
2023-03-01 10:50:36 -05:00
Jeremy Rose
a3e3efe4c4
test: use node helpers for events.once and setTimeout promise ( #37374 )
2023-02-23 15:53:53 -08:00
Milan Burda
f97d68c4bf
test: convert functions to async & eliminate duplicates ( #37316 )
...
test: convert functions to async
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-20 12:30:57 +01:00
Milan Burda
cf10c19c33
test: cleanup let xyz = null as unknown as T; ( #37335 )
2023-02-19 01:24:24 -08:00
Milan Burda
ee87438d28
test: use async helpers to simplify tests ( #37314 )
...
test: use async helpers to simplify the tests
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-17 12:32:39 -06:00
Milan Burda
ea848bc1c5
test: use webContents.create() in type-safe way ( #37281 )
...
test: use (webContents as typeof ElectronInternal.WebContents).create()
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-16 15:41:41 +01:00
Milan Burda
beed240454
test: use render-process-gone event in tests ( #37280 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-02-16 01:25:41 -08:00
Jeremy Rose
71944f2c3b
refactor: simplify events ( #37099 )
2023-02-13 13:39:18 -08:00
electron-roller[bot]
d02c9f8bc6
chore: bump chromium to 111.0.5544.3 (main) ( #36820 )
...
* chore: bump chromium in DEPS to 111.0.5522.0
* chore: bump chromium in DEPS to 111.0.5524.0
* chore: bump chromium in DEPS to 111.0.5526.0
* chore: bump chromium in DEPS to 111.0.5528.0
* chore: update patches/chromium/mas_avoid_usage_of_private_macos_apis.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4132807
Fix simple code shear
* chore: update patches/chromium/unsandboxed_ppapi_processes_skip_zygote.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4130675
Fix simple code shear
* chore: update patches/chromium/hack_plugin_response_interceptor_to_point_to_electron.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/disable_unload_metrics.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126173
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/feat_add_data_parameter_to_processsingleton.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/chromium/preconnect_manager.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4144281
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches/v8/force_cppheapcreateparams_to_be_noncopyable.patch
https://chromium-review.googlesource.com/c/v8/v8/+/3533019
Fix simple code shear; applied cleanly w/patch-fuzz
* chore: update patches
* chore: update patches/chromium/add_maximized_parameter_to_linuxui_getwindowframeprovider.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4128765
Upstream added a new call to HeaderContext(), whose signature we have patched
* chore: bump chromium in DEPS to 111.0.5530.0
* chore: update patches
* Move ChildProcessHost* from content/common to content/browser
Xref: Move ChildProcessHost* from content/common to content/browser
* Remove RenderViewHostChanged
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103
[upstream removal of RenderViewHostChanged]
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4092763
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4093234
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133892
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134103
[examples of upstream code adjusting to the change]
Upstream handles this change in roughly two approaches:
1. Move the code over to RenderFrameHostChanged(old_host, new_host)
but test for new_host->IsInPrimaryMainFrame() before acting
2. Migrate to the PrimaryPageChanged(page) API and use
page.GetMainDocument() to get the RenderFrameHost.
I've chosen 1. because electron_api_web_contents needed that pointer
to old_host to call RemoveInputEventListener(), but I may be missing
some context & would appreciate review on this commit.
* Make electron/shell/browser/relauncher_win.cc use <winternl.h>
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4129135
Many internal Windows types are now available in winternl.h
so upstrem no longer defines the types themselves.
* Move ChildProcessHost* from content/common to content/browser
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4134795
* fixup! Make electron/shell/browser/relauncher_win.cc use <winternl.h>
winternl.h does not define the field we need, so clone the struct Chromium was using into unnamed namespace
* fixup! Move ChildProcessHost* from content/common to content/browser
chore: update #includes too
* chore: bump chromium in DEPS to 111.0.5532.0
* chore: sync patches/chromium/pepper_plugin_support.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
manually reync patch; no code changes
* chore: sync patches/chromium/mas_no_private_api.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4143865
the content/common/pseudonymization_salt.cc patch is no longer needed
* chore: sync patches/chromium/mas_disable_remote_accessibility.patch
patch-fuzz update; no manual changes
* chore: sync patches/chromium/build_do_not_depend_on_packed_resource_integrity.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4111725
manually reync patch; no code changes
* chore: sync patches/chromium/create_browser_v8_snapshot_file_name_fuse.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
manually reync patch; no code changes
* chore: sync patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/4127230
patch-fuzz update; no manual changes
* chore: rebuild patches
* fixup! Remove RenderViewHostChanged
Use PrimaryPageChanged()
* chore: remove unused method TabsUpdateFunction::OnExecuteCodeFinished()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133991
This private, already-unused function showed up as a FTBFS because it
took a base::ListValue parameter and ListValue was removed upstream.
* task posting v3: remove includes of runner handles and IWYU task runners
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4133323
* chore: lint
* chore: more lint
* fixup! task posting v3: remove includes of runner handles and IWYU task runners
macOS, too
* fixup! task posting v3: remove includes of runner handles and IWYU task runners
* chore: bump chromium in DEPS to 111.0.5534.0
* chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141862
patch-fuzz update; no manual changes
* chore: sync patches/chromium/logging_win32_only_create_a_console_if_logging_to_stderr.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4153110
Sync to minor upstream changes. Add const correctness.
* chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch
https://chromium-review.googlesource.com/c/chromium/src/+/4141862
patch-fuzz update; no manual changes
* chore: patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
sync https://chromium-review.googlesource.com/c/v8/v8/+/4147787
patch-fuzz update; no manual changes
* chore: update patches
* chore: bump chromium in DEPS to 111.0.5536.0
* chore: sync patches/chromium/allow_new_privileges_in_unsandboxed_child_processes.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863
Sync with upstream code changes. Minor code golf for readability.
Note: upstream is laying groundwork for being able to work off of env vars
instead of switches. Doesn't affect us yet but worth being aware of.
> + // Environment variables could be supported in the future, but are not
> + // currently supported when launching with the zygote.
* chore: update patches/chromium/feat_expose_raw_response_headers_from_urlloader.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4126836
patch-fuzz update; no manual changes
* chore: sync electron/patches/chromium/feat_configure_launch_options_for_service_process.patch
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4141863
manual sync
* chore: sync electron/patches/v8/fix_build_deprecated_attribute_for_older_msvc_versions.patch
https://chromium-review.googlesource.com/c/v8/v8/+/4147788
fuzz-patch
* chore: rebuild patches
* chore: bump chromium in DEPS to 111.0.5538.0
* chore: bump chromium in DEPS to 111.0.5540.0
* chore: update patches
* Remove sdk_forward_declarations
https://chromium-review.googlesource.com/c/chromium/src/+/4166680
* task posting v3: Remove task runner handles from codebase entirely
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4150928
* Cleanup child_process_launcher_helper*
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863
* fix: utilityprocess spec on macOS
* fix: build on windows
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4141863
* chore: fix lint
* chore: bump chromium 111.0.5544.3
* chore: gen filenames.libcxx.gni
* Add check for Executable+Writable handles in renderer processes.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3774416
* fixup! Add check for Executable+Writable handles in renderer processes.
* 4143761: [110] Disable SwiftShader for WebGL on M1 Macs.
https://chromium-review.googlesource.com/c/chromium/src/+/4143761
(cherry picked from commit 2f74db3c2139424c416f92d9169aeaa8a2f9c1ec)
* chore: bump chromium to 111.0.5555.0
* 56085: Remove hmac.h include from ssl.h.
https://boringssl-review.googlesource.com/c/boringssl/+/56085
* 4167020: Remove forwarding headers
https://chromium-review.googlesource.com/c/chromium/src/+/4167020
* chore: bump chromium to 111.0.5559.0
* 4181044: Restrict WebCursor usage to RenderWidgetHostViewAura
https://chromium-review.googlesource.com/c/chromium/src/+/4181044
* 4189437: views: rename ink_drop_host_view to ink_drop_host
https://chromium-review.googlesource.com/c/chromium/src/+/4189437
* chore: bump chromium to 111.0.5560.0
* 4167016: win7dep: remove non aeroglass code
https://chromium-review.googlesource.com/c/chromium/src/+/4167016
* fixup after rebase: Remove forwarding header
s https://chromium-review.googlesource.com/c/chromium/src/+/4167020
* 4125755: Reland "Reject getDisplayMedia calls without user activation"
https://chromium-review.googlesource.com/c/chromium/src/+/4125755
* test: add workaround
* chore: update patches
* fix: alter coreModuleRegExp to prevent arm crash
* Revert "fix: alter coreModuleRegExp to prevent arm crash"
This reverts commit 7e50630c98137831a711c5abdbc8809e60cf1d73.
* 4218354: Disable the use of preserve_most on arm64 Windows
https://chromium-review.googlesource.com/c/v8/v8/+/4218354
* chore: review changes
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2023-02-03 12:43:42 +01:00
Milan Burda
4bc6b15f53
refactor: move spec helpers to spec/lib ( #37010 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
2023-01-25 13:01:25 -08:00
Milan Burda
5fd7a43970
test: replace (webContents as any).destroy() with webContents.destroy() ( #36653 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2022-12-14 16:07:38 -05:00
Shelley Vohr
8b430c9d26
test: re-enable window.open referrer test ( #36155 )
...
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2022-11-01 11:11:11 -04:00