trop[bot]
bd70c3a740
refactor: update chrome.scripting extensions api impls ( #43290 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-12 12:09:34 +02:00
trop[bot]
997afe62f2
chore: remove unused Notification fields icon_path_, has_icon_ ( #43295 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b584
)
Last use of `has_icon_` was removed on May 30, 2017 (5048425e
)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-12 12:09:25 +02:00
trop[bot]
dd1dcad81c
fix: system-context-menu with frameless BrowserWindows ( #43274 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-11 21:30:37 +02:00
trop[bot]
10dd33c16e
fix: check screen capture permissions in desktopCapturer
( #43271 )
...
fix: check screen capture permissions in desktopCapturer
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-11 21:30:27 +02:00
trop[bot]
c3a7f0001c
fix: accidental handle copying in a range loop ( #43281 )
...
fix: accidental handle copying
Xref: https://github.com/electron/electron/pull/37857
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-10 09:59:36 +02:00
trop[bot]
a780a75dec
build: fix build when enable_pdf_viewer
and enable_electron_extensions
disabled ( #43250 )
...
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-08 10:59:15 +02:00
trop[bot]
36cebb95c6
refactor: simplify window moveAbove/moveTop
impl on macOS ( #43201 )
...
refactor: simplify window moveAbove/moveTop impl on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-06 16:41:49 -04:00
trop[bot]
be842d6267
perf: avoid redundant calls to GetView() ( #43229 )
...
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* perf: avoid discarded GetView() call
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-06 13:23:21 -05:00
trop[bot]
17cb664e39
perf: don't build unused vectors in HidChooserContext ( #43214 )
...
* refactor: remove unused code in HidChooserContext::DeviceRemoved()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use structured bindings for readability
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-06 09:57:00 -05:00
trop[bot]
54b31f153c
fix: gin_helper::MicrotasksScope instantiation ( #43209 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-05 21:46:51 -05:00
trop[bot]
1c368f13f8
fix: take bluetooth serial ports into account in serial.getPorts()
( #43170 )
...
* fix: take bluetooth serial ports into account in serial.getPorts()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: remove port.path.LossyDisplayName()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-01 23:10:46 -07:00
trop[bot]
cdb0540cf0
fix: handle failing to enter fullscreen on macOS ( #43154 )
...
* fix: handle failing to enter/exit fullscreen on macOS
On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>
* refactor: remove fail to exit fullscreen handlers
Seem to be unnecessary since the window exits fullscreen anyway.
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>
2024-08-01 14:50:23 +02:00
Shelley Vohr
832090d01c
feat: add transparency checking to nativeTheme
( #43137 )
...
feat: add transparency checking to nativeTheme
2024-08-01 12:14:07 +02:00
trop[bot]
31551aba9d
fix: vibrant view is inserted into Views API hierarchy ( #43128 )
...
* fix: vibrant view is inserted into Views API hierarchy (#42263 )
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>
* Update shell/browser/native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-31 19:59:27 -05:00
Keeley Hammond
24db198d52
fix: remove InspectableWebContentsViewMac ( #43096 )
...
* fix: remove InspectableWebContentsViewMac (#43033 )
* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )"
This reverts commit e67ab9a93d
.
* build: fix gn check
* chore: implement setCornerRadii in inspectable_web_contents_view_mac
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: pass in cornerRadii value in setCornerRadii
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: forward declaration
* 5578714: Remove 0-arg (default) constructor for views::Widget::InitParams.
https://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fix: contents_web_view_ -> contents_view_
* chore: remove extraneous includes
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: remove custom border radius feat (#42320 )
* fix: fix views::Widget::InitParams params
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-30 14:51:51 -04:00
trop[bot]
35b73514b7
fix: showInactive
window not showing ( #43102 )
...
fix: showInactive window not showing
Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-30 13:02:03 -05:00
trop[bot]
6322c329bf
fix: always terminate active Node Streams ( #43071 )
...
`.destroy()` is an important method in the lifecycle of a Node.js
Readable stream. It is typically called to reclaim the resources
(e.g., close file descriptor). The only situations where calling
it manually isn't necessary are when the following events are
emitted first:
- `end`: natural end of a stream
- `error`: stream terminated due to a failure
Prior to this commit the ended state was incorrectly tracked together
with a pending internal error. It led to situations where the request
could get aborted during a read and then get marked as ended (having
pending error).
With this change we disentangle pending "error" and "destroyed" cases to
always properly terminate an active Node.js Readable stream.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
2024-07-27 14:47:12 -05:00
trop[bot]
b6e19c5a45
chore: avoid crash while notification removal ( #43061 )
...
* avoid crash of operation on an invalid entry while erase set iterator.
Co-authored-by: bill.shen <shenyb32768@gmail.com>
* fix notification removal crash due to the nullptr presenter
Co-authored-by: bill.shen <shenyb32768@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: bill.shen <shenyb32768@gmail.com>
2024-07-26 16:32:43 -04:00
trop[bot]
871136bf91
refactor: move safe_storage functions into anonymous namespace ( #43051 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-25 22:32:17 +02:00
trop[bot]
94381733ff
fix: File System API permissions should reset on WebContents destruction ( #43048 )
...
fix: active File System API permissions should reset on WebContents destruction
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-25 16:01:56 -04:00
trop[bot]
139abe73a1
fix: desktopCapturer breaks BrowserWindow resizable on macOS ( #43044 )
...
* fix: desktopCapturer breaks BrowserWindow resizable on macOS
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: oops fix showing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-25 15:35:23 +02:00
trop[bot]
097a3e9024
chore: use v8::Local<>, not v8::Handle<> ( #43037 )
...
v8::Handle is an alias for v8::Local that "is kept around for historical
reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-25 11:00:05 +02:00
trop[bot]
9e14f8d828
feat: emit an event when accessing restricted path in File System Access API ( #42994 )
...
* fix: show a dialog when accessing restricted path in File System Access API
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: allow overriding initial blocked paths
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: fix doc
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/session.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: change block to deny for consistency
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-24 13:23:33 -04:00
trop[bot]
b288f3ee59
refactor: remove WindowListObserver::OnWindowAdded() ( #42984 )
...
refactor: remove WindowListObserver::OnWindowRemove()
these have never been used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-22 19:12:59 +02:00
trop[bot]
b833c3f02a
chore: remove unused BaseWindow::GetWeakPtr() ( #42988 )
...
last caller removed in 67ba3040
(#37902 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-22 10:20:27 -05:00
trop[bot]
e259dd591f
chore: remove unused typedef CreateDownloadPathCallback ( #42968 )
...
chore: remove unused typedef ElectronDownloadManagerDelegate::CreateDownloadPathCallback
use was removed in e3c580e9
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-19 21:44:54 -05:00
trop[bot]
daf8d22e07
refactor: remove unused web contents preferences methods ( #42969 )
...
* chore: remove unused WebContentsPreferences::ShouldDisableDialogs()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unused WebContentsPreferences::ShouldUseSafeDialogs()
caller removed in 85bc005c
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: remove unused WebContentsPreferences::GetSafeDialogsMessage()
caller removed in 85bc005c
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: WebContentsPreferences::GetPreloadPath() now returns a std::optional<base::FilePath>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: make WebContentsPreferences::last_preference() const
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-19 18:55:07 -05:00
trop[bot]
6c1409ae57
chore: remove unused field ElectronBrowserClient::browser_main_parts_
( #42965 )
...
chore: remove unused field ElectronBrowserClient::browser_main_parts_
caller removed in 48d0b09a
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-19 14:37:32 -05:00
trop[bot]
0d9918cd24
fix: dangling raw_ptr NodeBindings::uv_env_ ( #42955 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-19 12:26:37 -05:00
trop[bot]
bb093817ed
fix: dangling raw_ptr<views::View> in api::View ( #42951 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-17 23:31:40 -05:00
trop[bot]
1de0bb30b1
feat: add getPercentComplete
/ getCurrentBytesPerSecond
/ getEndTime
to DownloadItem ( #42915 )
...
feat: getCurrentSpeed / getPercentComplete / getEndTime on DownloadItem
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Theo Gravity <theo@suteki.nu>
2024-07-17 09:49:05 -07:00
trop[bot]
e429b6f745
fix: crash with creating OffScreenWebContentsView ( #42941 )
...
On the Mac platform, OffScreenWebContentsView uses Automatic Reference
Counting (ARC) to handle the lifecycle of offScreenView_. However, this
private member variable is not initialized and its value is undefined.
In some cases, it is initialized to a garbage value, which may cause ARC
to release the value incorrectly, resulting in a crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jinli Wu <wujinli@bytedance.com>
2024-07-17 09:10:00 -05:00
trop[bot]
e3a5895c2b
fix: getUserMedia
needs macOS system permissions check ( #42937 )
...
fix: getUserMedia needs macOS system permissions check
Closes https://github.com/electron/electron/issues/42714
Closes https://github.com/electron/electron/issues/29861
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-17 13:08:34 +02:00
trop[bot]
85cb6d9476
fix: BrowserWindow.setBackgroundColor
should work with transparency ( #42928 )
...
fix: BrowserWindow.setBackgroundColor should work with transparency
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-17 11:29:22 +02:00
trop[bot]
5029bce65c
fix: iteration issues in hid RevokeEphemeralDevicePermission
( #42901 )
...
fix: iteration issues in hid RevokeEphemeralDevicePermission
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-16 12:32:35 +02:00
trop[bot]
266b23745b
fix: File System Access API should remember last picked directory ( #42893 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-15 17:22:56 +02:00
trop[bot]
65f431ab78
fix: crash when resolving proxy due to network service restart ( #42897 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-07-15 14:50:41 +02:00
trop[bot]
5c2a8b9047
fix: desktopCapturer
and screen
display ids should match ( #42890 )
...
* fix: `desktopCapturer` and `screen` display IDs should match
Co-authored-by: clavin <clavin@electronjs.org>
* simplify wide-to-utf8 conversion
Co-authored-by: clavin <clavin@electronjs.org>
* remove unnecessary include
Co-authored-by: clavin <clavin@electronjs.org>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org>
2024-07-14 18:30:34 +02:00
trop[bot]
f392f558e0
fix: desktopCapturer
and screen
source ids should match screen ids ( #42861 )
...
* fix: desktopCapturer screen source ids should match screen ids
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: add a regression test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-11 15:47:33 -04:00
trop[bot]
e768a1f228
fix: dangling raw_ptr<Session> in UserDataLink ( #42852 )
...
* fix: dangling raw_ptr<Session> in UserDataLink
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* fixup! fix: dangling raw_ptr<Session> in UserDataLink
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-11 14:53:06 +02:00
trop[bot]
217e740791
fix: High Contrast mode not working on Windows ( #42859 )
...
Closes https://github.com/electron/electron/issues/42609
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5324688
Refs https://chromium-review.googlesource.com/c/chromium/src/+/5368321
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-10 16:48:24 -07:00
trop[bot]
dc065dfa5a
fix: potentially closed webContents in BrowserView ( #42810 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-10 15:33:27 +02:00
Shelley Vohr
56c3507ef2
refactor: run Windows SelectFileDialog
out of process ( #42825 )
...
refactor: run Windows SelectFileDialog out of process
2024-07-09 19:03:13 +02:00
trop[bot]
650b8e6777
fix: dangling raw_ptr ElectronBrowserContext::extension_system_ ( #42813 )
...
The extension system is freed by the DestroyBrowserContextServices()
call in the destructor, so we need to zero out the pointer to avoid
a dangling raw_ptr error.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-09 11:03:45 +02:00
trop[bot]
7353fa88cd
refactor: minor electron browser context cleanup ( #42815 )
...
* refactor: make DevicePermissionMap private to electron::ElectronBrowserContext
refactor: make PartitionPath private to electron::ElectronBrowserContext
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused forward declarations of v8 classes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: forward declare gin::Arguments
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use unique_ptr operator bool
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-08 13:49:23 -04:00
trop[bot]
50864bcd08
fix: multiple move() calls on the same unique_ptr ( #42821 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-07-08 13:48:47 -04:00
trop[bot]
e36d79706e
fix: video and audio capture should be separate ( #42809 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-08 16:46:41 +02:00
trop[bot]
342ef8e7e1
feat: enable Windows Control Overlay on Linux ( #42682 )
...
* feat: enable Windows Control Overlay on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: update documentation for Linux WCO
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: initial symbol painting
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: enable WCO tests for Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: add missing Layer include
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: fix gn-check failure
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: enable BrowserWindow.setTitleBarOverlay on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: fix test for maximize event on Linux
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: geometry updating on BrowserWindow.setTitleBarOverlay
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: crash when invalid titleBarStyle set
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: clean up ordering and comments
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* Update docs/api/structures/base-window-options.md
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* feat: enable customizing symbolColor
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* docs: correct symbolColor reference
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: update patches
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
* chore: remove Chrome-specific padding
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2024-07-03 16:09:12 -04:00
trop[bot]
89d09922f7
fix: use BlockedRequest
struct to handle webRequest
data ( #42751 )
...
* refactor: use BlockedRequest model to handle webRequest
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* refactor: finish de-templating
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: address some feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-03 14:46:29 +02:00
trop[bot]
2f6c4d8d24
fix: param passed to showSaveDialogSync
on Linux ( #42678 )
...
fix: pass correct param to sync functions on Linux
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-06-27 13:45:39 +02:00