Cheng Zhao
9d6f1a372e
fix: create WebContents for webview on request ( #13713 )
2018-07-21 11:11:28 +09:00
John Kleinschmidt
613b03c3c7
build: disable found-in-page event
test
...
On Windows release builds, the found-in-page event test causes the test suite to hang. If the test is run individually, it works fine, but running it as part of the whole test suite causes the test suite to hang. This works around the issue in #13704 by temporarily disabling that test.
2018-07-18 14:59:46 -04:00
PalmerAL
ffc15e02a6
fix: add native function to create preload script ( #13032 )
...
* add native function to create preload script
* add tests
* fix formatting
* fix tests
* rerun CI
2018-07-13 11:17:11 +09:00
Shelley Vohr
fa0704665f
test: temporarily disable failing specs ( #13470 )
2018-06-27 14:15:24 -07:00
Alexey Kuzmin
f4039d82c3
spec: rewrite and enable a webview's disableguestresize attr test ( #13428 )
2018-06-26 08:38:04 -07:00
Aleksei Kuzmin
5151a04613
spec: slightly rewrite webview tests
2018-06-19 13:27:49 +02:00
Aleksei Kuzmin
8f4d6a1995
Rewrite and enable one of the webview tests
2018-06-19 11:49:46 +10:00
Aleksei Kuzmin
de6a5de914
Disable all failing tests
2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
417fe29dc0
Fix the media events test
...
Playing a media now requires a user gesture.
See https://goo.gl/xX8pDD .
2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
c786abf1e9
Add gfx:PointF support to mate::Converter
...
It's needed by atom_api_screen, BuildPrototype function on Windows.
2018-06-19 11:49:45 +10:00
Aleksei Kuzmin
9b9a818c43
FIXME: Disable one of the <webview> tag tests.
2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
7e4c0b304b
Enable a few tests
2018-06-19 11:49:44 +10:00
Aleksei Kuzmin
32ff2ff8fb
FIXME: Disable some of <webview> tag tests
2018-06-19 11:49:44 +10:00
deepak1556
7b47d69efe
Remove did-get-response-details and did-get-redirect-request events
...
https://chromium-review.googlesource.com/c/chromium/src/+/805008
https://chromium-review.googlesource.com/c/chromium/src/+/786320
2018-06-19 11:49:41 +10:00
Alexey Kuzmin
0d5e98a201
Slightly rewrite <webview> tag tests ( #13122 )
2018-06-01 10:56:48 +02:00
Alexey Kuzmin
fc34076c2b
Refactor <webview> tag tests ( #12886 )
2018-05-14 17:00:49 -05:00
Alexey Kuzmin
d5dfb19508
Update some tests ( #12917 )
...
* Use Chai for webview tests
* Slightly rewrite one of the <webview> tests
"dom-ready event" > "throws a custom error..."
* Use Chai for BrowserWindow tests
* Rewrite BrowserWindow.addDevToolsExtension tests
2018-05-14 13:17:31 -05:00
Nitish Sakhawalkar
2579071b98
Deprecate did-get-response-details and did-get-redirect-request ( #12615 )
...
* Deprecate webContents events did-get-response-details and did-get-redirect-request.
* Update guest view files
* Update webview tag docs and update specs
* Update deprecate.event function
* Update comment
* Update more
* Update documentation for other deprecated event
2018-04-23 14:46:12 -05:00
Robo
65e8199a93
Enable plznavigate aka browser side navigation ( #12535 )
...
* enable plznavigate code path
* AtomBrowserClient::GetGeolocationApiKey returns the right default
* use IsLoadingToDifferentDocument to identify top level navigation in mainFrame
* use candidate site instance when available
* spec: don't test httpReferrer option for file origin
* update libcc ref
* affinity: only group same site in this mode
* plznavigate: don't emit did-get-response-details event for blob scheme
2018-04-06 16:22:52 +09:00
Nitish Sakhawalkar
524f56354c
Fix webview resize test
2018-03-20 10:13:16 +03:00
Cheng Zhao
d598aa1a67
Merge pull request #11300 from electron/external-devtools
...
Add API to set arbitrary WebContents as devtools
2017-12-05 10:35:49 +09:00
Cheng Zhao
ea9771702b
spec: setDevToolsWebContents
2017-12-01 10:35:23 +09:00
John Kleinschmidt
0ef8f58090
Remove Travis references
2017-11-30 15:39:32 -05:00
Zeke Sikelianos
c1728720a7
Merge pull request #11256 from electron/fix-11244
...
Enable "<webview> tag found-in-page event emits when a request is made"
2017-11-30 10:48:00 -08:00
Cheng Zhao
1c0ea0286e
Merge pull request #11235 from electron/standard-10
...
infra: Upgrade to StandardJS 10
2017-11-27 15:42:52 +09:00
deepak1556
084292f3ab
fix: focus the webview as a temp workaround
2017-11-25 20:18:01 +05:30
Aleksei Kuzmin
3e9f9429d1
Enable "<webview> tag found-in-page event emits when a request is made"
...
Fixes #11244 .
2017-11-25 13:21:26 +01:00
Aleksei Kuzmin
d61564bfb1
Disable "<webview> tag > found-in-page event > emits when a request is made" test
2017-11-24 10:58:53 +09:00
Felix Rieseberg
9f0df695ca
🔧 Spec: Fix style issues
2017-11-23 14:22:58 -08:00
Aleksei Kuzmin
cf749a8e18
Explicitly skip tests that should be skipped
2017-11-20 14:43:23 +01:00
Shelley Vohr
e4214a6cbe
[WIP] Upgrade more specs ( #10945 )
...
Finish upgrading specs to ES6
2017-10-27 16:45:58 -04:00
Yuya Ochiai
6326c6727e
Add did-attach-webview event
2017-10-07 22:52:20 +09:00
Aleksei Kuzmin
ba0c43e1fc
Do not run navigator.getUserMedia
related test on CI build machines
2017-08-15 16:19:22 +03:00
Kevin Sawicki
f1a72ad108
Add spec for webview visibility change on show
2017-06-14 14:11:38 -07:00
Kevin Sawicki
d2d28c42f1
Remove unused constant
2017-06-06 15:19:29 -07:00
Birunthan Mohanathas
7d2226e05e
Let Chromium manage document.visibilityState
and document.hidden
...
Chromium already includes the necessary plumbing to manage the
visibility properties and `visibilitychange` event so this gets rid of
most of our custom logic for `BrowserWindow` and `BrowserView`.
Note that `webview` remains unchanged and is still affected by the issues
listed below.
User facing changes:
- The `document` visibility properties and `visibilitychange` event are
now also updated/fired in response to occlusion changes on macOS. In
other words, `document.visibilityState` will now be `hidden` on macOS
if the window is occluded by another window.
- Previously, `visibilitychange` was also fired by *both* Electron and
Chromium in some cases (e.g. when hiding the window). Now it is only
fired by Chromium so you no longer get duplicate events.
- The visiblity state of `BrowserWindow`s created with `{ show: false }`
is now initially `visible` until the window is shown and hidden.
- The visibility state of `BrowserWindow`s with `backgroundThrottling`
disabled is now permanently `visible`.
This should also fix #6860 (but not for `webview`).
2017-06-06 15:16:01 -07:00
Kevin Sawicki
5cf4995f2e
DRY up logic to check if native modules should be loaded
2017-05-30 09:15:38 -07:00
Kevin Sawicki
9f49b71b89
Add cross-origin frame webview spec
2017-05-26 10:10:36 -07:00
Kevin Sawicki
a0571e3c72
Add failing spec for native window.open returning null without allowpopups
2017-05-26 10:10:36 -07:00
Kevin Sawicki
ef01c16c6a
Add tests for more nativeWindowOpen events
2017-05-26 10:10:36 -07:00
Kevin Sawicki
9f06b6dc21
Set allowpopups attribute in nativeWindow open specs
2017-05-26 10:10:36 -07:00
Kevin Sawicki
a32b7e5cdb
Co-locate nativeWindowOpen specs
2017-05-26 10:10:36 -07:00
Kevin Sawicki
a2a7a1d8c7
Add new-window <webview> spec with nativeWindowOpen
2017-05-26 10:10:36 -07:00
Kevin Sawicki
da2b29796f
Add same domain webview nativeWindowOpen spec
2017-05-26 10:10:36 -07:00
Kevin Sawicki
a16cd0bd03
Add failing <webview> with nativeWindowOpen spec
2017-05-26 10:10:36 -07:00
Kevin Sawicki
fd782706b2
Add explicit spec for removing preload from webview
2017-05-17 13:47:00 -07:00
Kevin Sawicki
bde13353fb
Rename option to webviewTag and default to nodeIntegration value
2017-05-17 13:12:23 -07:00
Hari Krishna Reddy Juturu
3321f7d39c
Changing command line option name
2017-05-08 17:27:31 -07:00
Hari Krishna Reddy Juturu
357caf8991
fixing spec
2017-05-06 22:41:05 -07:00
Hari Krishna Reddy Juturu
939885bc66
Remove .only on spec
2017-05-06 22:14:52 -07:00
Hari Krishna Reddy Juturu
94d054cf11
Add option to override webview security
2017-05-06 22:10:42 -07:00
Hari Krishna Reddy Juturu
b4a8ed01f1
PR 44648: Enabling creation on webview with node-integration disabled and raising events
...
- Enabling creation on webview with node-integration disabled and raising events
Conflicts:
lib/browser/guest-view-manager.js
2017-05-06 20:50:01 -07:00
Kevin Sawicki
9a4783bf34
Disable flaky post navigation spec on AppVeyor
2017-03-27 09:15:40 -07:00
deepak1556
224ffe44aa
add spec
2017-03-08 19:16:55 +05:30
Kevin Sawicki
54232ee21a
Emit event after listener is registered
2017-02-28 08:23:00 -08:00
Kevin Sawicki
1d84d83fd4
Forward webview visibility change events from browser process
2017-02-28 08:23:00 -08:00
Kevin Sawicki
6c40b1eead
Verify global.Buffer is undefined
2017-02-24 09:57:32 -08:00
Kevin Sawicki
ad03ba73a4
Upgrade node for Buffer wrapper fix
2017-02-24 09:57:32 -08:00
Kevin Sawicki
e6fec57bd8
Add failing spec for Buffer from preload required module
2017-02-24 09:57:32 -08:00
deepak1556
a57af31b99
add zoom specs based on standard protocols
2017-02-18 01:41:39 +05:30
deepak1556
403e7681c1
add basic webview zoom specs
2017-02-18 01:34:32 +05:30
Eric Brumer
87e606627c
Smaller regex now that it's case insensitive
2017-02-16 09:26:20 -08:00
Eric Brumer
7cb101b566
Case insensitive filepath
2017-02-16 09:17:37 -08:00
Eric Brumer
d97585d06d
Allow favicon.png to be on the root of any drive letter
2017-02-15 19:02:11 -08:00
Kevin Sawicki
fdc1d3d763
Add Buffer typeof assertion
2017-02-14 08:42:34 -08:00
Kevin Sawicki
70010fdb8e
Add spec for Buffer global
2017-02-14 08:42:34 -08:00
Kevin Sawicki
81addbdcbf
Remove only call
2017-02-09 11:49:14 -08:00
Kevin Sawicki
a7c050107b
Remove guest from will-attach-webview event
2017-02-09 11:47:45 -08:00
Kevin Sawicki
acff2f6baf
Adjust src from will-attach-webview
2017-02-09 11:45:07 -08:00
Kevin Sawicki
46f1a49594
new-webview -> will-attach-webview
2017-02-09 11:45:07 -08:00
Kevin Sawicki
706b9f6cbf
Add new-webview specs
2017-02-09 11:45:07 -08:00
Kevin Sawicki
b0ee46f862
Use === in specs
2017-01-19 09:05:59 +02:00
Kevin Sawicki
977680d00b
Add spec for midi without sysex permission
2017-01-19 09:05:59 +02:00
Kevin Sawicki
dcbc10ac38
Merge pull request #8417 from electron/flaky-travis-specs
...
Disable flaky specs on Travis
2017-01-17 08:48:59 -08:00
Kevin Sawicki
1d824d4645
Assert document visibility in main context
2017-01-16 13:03:38 -08:00
Kevin Sawicki
3f7b3c4bd7
Implement window overrides in main context
2017-01-16 12:38:16 -08:00
Kevin Sawicki
14a1e673c6
Add spec for webview context isolation
2017-01-16 12:38:16 -08:00
Kevin Sawicki
b6c5e9a126
Disable disableguestresize spec that times out on Travis
2017-01-16 11:48:20 -08:00
Zeke Sikelianos
6995b51f2c
set webview spec timeout to three minutes
2016-12-22 13:31:30 -08:00
Zeke Sikelianos
c989ea43f5
bump webview spec timeout to two minutes
2016-12-22 12:30:34 -08:00
Kevin Sawicki
eaa5d071ef
Remove unneeded timeout call
2016-11-29 16:27:18 -08:00
Kevin Sawicki
9e51c779e1
Assert expected height
2016-11-15 13:54:25 -08:00
Birunthan Mohanathas
2986b7bc4a
Allow webview guests to be resized manually
...
This adds the `disableguestresize` property for webviews to prevent the
webview guest from reacting to size changes of the webview element. This
also partially documents the `webContents.setSize` function in order to
manually control the webview guest size.
These two features can be combined to improve resize performance for
e.g. webviews that span the entire window. This greatly reduces the lag
described in #6905 .
2016-11-15 11:00:09 -08:00
Kevin Sawicki
18e1de105f
Add failing spec for deleted guestinstance when moving webview
2016-11-07 13:42:36 -08:00
Kevin Sawicki
b84fed5cb2
Add failing spec for hide/show reload issue
2016-11-07 13:42:36 -08:00
Kevin Sawicki
f454cb3408
Add failing spec for hide/show webview issue
2016-11-07 13:42:36 -08:00
Kevin Sawicki
73774f21b7
🎨
2016-11-07 08:28:02 -08:00
Kevin Sawicki
19a5d2ba2b
Use window close helper instead of destroying for coverage
2016-11-07 08:25:01 -08:00
Kevin Sawicki
16f57b219b
Add resize event spec
2016-11-07 08:25:01 -08:00
Kevin Sawicki
3f8e173452
Call callback asynchronously to match original issue
2016-10-31 08:54:57 -07:00
Kevin Sawicki
611614c649
Use equal/deepEqual for channel/args asserts
2016-10-31 08:54:57 -07:00
Kevin Sawicki
dda3fcef91
Add failing spec for notification permission crash
2016-10-31 08:54:56 -07:00
Paul Frazee
e7962c7ba2
fixes and tests for webview 'webpreferences' attr
2016-10-14 18:04:33 -05:00
Kevin Sawicki
e4b0577cb0
Assert key and code in keyup input event spec
2016-10-10 09:35:44 -07:00
Kevin Sawicki
3f390c6849
Ensure webviews get reset after spec finishes
2016-09-30 10:15:11 -07:00
Cheng Zhao
e3e450613d
Merge pull request #7157 from Mossop/moveguest
...
Allow moving a webcontents to a different webview
2016-09-20 14:28:42 +09:00
Dave Townsend
47df447e4f
✅ Test that replacement history entries don't break forward navigation.
...
This is a test for #7175
2016-09-16 17:08:54 -07:00
Cheng Zhao
fbac635687
Only emit finalUpdate found-in-page events
...
Since Chrome 53 all meaningful results of found-in-page are finalUpdate.
2016-09-14 16:23:01 +09:00
Cheng Zhao
18fd3e0329
Fix js linting error
2016-09-14 16:23:00 +09:00
Cheng Zhao
a510642a25
finalUpdate can be false
2016-09-14 16:23:00 +09:00