Charles Kerr
f36ceae024
chore: migrate base::StringPiece to std::string_view ( #40915 )
...
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
2024-01-10 19:00:37 -06:00
David Sanders
cf5f0419f1
chore: fix some typos ( #40506 )
2023-11-12 19:51:56 -08:00
Jeremy Rose
71944f2c3b
refactor: simplify events ( #37099 )
2023-02-13 13:39:18 -08:00
Josh Soref
ea4278754c
chore: fix spelling errors in multiple files ( #34574 )
...
* chore: fix spelling in .circleci
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in BUILD.gn
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in appveyor.yml
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in build
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in docs
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in lib
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in script
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in shell
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
* chore: fix spelling in spec-main
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2022-06-16 16:46:11 +09:00
Jeremy Rose
d8a7219d07
chore: stop using v8::Locker everywhere ( #34078 )
2022-05-05 11:50:21 -07:00
Samuel Attard
e07c2b84d7
fix: ensure ElectronBrowser mojo service is only bound to appropriate render frames ( #33323 )
...
* fix: ensure ElectronBrowser mojo service is only bound to authorized render frames
Notes: no-notes
* refactor: extract electron API IPC to its own mojo interface
* fix: just check main frame not primary main frame
2022-03-18 19:50:05 -07:00
Milan Burda
c4ea33d1bf
chore: add ELECTRON_ prefix to C++ include guards ( #31925 )
2021-11-22 16:34:31 +09:00
Milan Burda
65a980c673
refactor: replace deprecated DISALLOW_COPY_AND_ASSIGN ( #31633 )
2021-11-03 20:41:45 +09:00
electron-roller[bot]
cc01272a8d
chore: bump chromium to 96.0.4647.0 (main) ( #30814 )
...
* chore: bump chromium in DEPS to 95.0.4630.0
* 3133701: Fix chrome root store codegen for cross-compile builds.
https://chromium-review.googlesource.com/c/chromium/src/+/3133701
* 49125: Include SHA512-256 in EVP_get_digestbyname and EVP_MD_do_all.
https://boringssl-review.googlesource.com/c/boringssl/+/49125
* chore: fixup patch indices
* 3131662: [Code Health] Remove ListValue::Append(Integer|Boolean)
https://chromium-review.googlesource.com/c/chromium/src/+/3131662
* chore: bump chromium in DEPS to 95.0.4631.0
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4635.0
* chore: update patches
* chore: bump chromium in DEPS to 95.0.4636.0
* chore: bump chromium in DEPS to 95.0.4637.0
* chore: update patches
* refactor: move PlatformNotificationService into BrowserContext
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3137256
* refactor: ListValue::GetSize and ListValue::AppendString were removed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3144540
* chore: bump chromium in DEPS to 95.0.4638.0
* chore: bump chromium in DEPS to 95.0.4638.4
* chore: bump chromium in DEPS to 96.0.4640.0
* chore: bump chromium in DEPS to 96.0.4641.0
* chore: bump chromium in DEPS to 96.0.4642.0
* chore: update patches
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
* 3134756: Move extensions/browser/value_store to components/value_store.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3134756
* 3150092: [Autofill] Allow aligning Autofill suggestions to the field's center
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3150092
* chore: bump chromium in DEPS to 96.0.4643.0
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4644.0
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4645.0
* chore: update patches
* chore: bump chromium in DEPS to 96.0.4646.0
* chore: bump chromium in DEPS to 96.0.4647.0
* chore: update patches
Ref (for chromium): https://chromium-review.googlesource.com/c/chromium/src/+/3165772
* 3162087: Reland "Ensure Branch Target Identification is enabled for executable pages."
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3162087
* chore: update evert_add_inline_and_inline_origin_records_to_symbol_file.patch
Xref: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3166678
Xref: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3166674
* chore: update Allocator construction
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3135195
Change RefCount::kAllowed/Disallowed semantics into BackupRefPtr::kEnabled/Disabled
* chore: add UseConfigurablePool to v8::ArrayBuffer::Allocator invocation
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3090845
* chore: do not set network_context_params.context_name
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3155743
Remove name field from mojom::NetworkContext
* fix: use ForEachRenderFrameHost to iterate frames.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3163336
New implementation partially cribbed from
https://source.chromium.org/chromium/chromium/src/+/main:extensions/browser/script_executor.cc;drc=f894f106c6d5fac8e0b75158f622256e0f34f593;l=109
* [Blink Cleanup] Remove WebLocalFrame::RequestExecuteScriptAndReturnValue()
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3149699
ExecuteJavaScript's RequestExecuteScript() new params are cribbed from
https://chromium-review.googlesource.com/c/chromium/src/+/3149699/4/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
* Remove IsDescendantOf API on RenderFrameHost.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/3165357
function is trivial to implement, so make a local copy in anon namespace
* Rewrite IsDescendantOf check to check GetParentOrOuterDocument.
https://chromium-review.googlesource.com/c/chromium/src/+/3160061
* Remove GetFramesInSubtree from RenderFrameHost
https://chromium-review.googlesource.com/c/chromium/src/+/3163336
* fix: dump_syms for macOS
* chore: update patches
* [Code Health] Remove ListValue::AppendString and ListValue::GetSize
https://chromium-review.googlesource.com/c/chromium/src/+/3144540
* fix: gn check
https://chromium-review.googlesource.com/c/chromium/src/+/3163890
* fix: crash with Isolate::GetHeapCodeAndMetadataStatistics
https://chromium-review.googlesource.com/c/v8/v8/+/3175820
* chore: update patches
* chore: fix windows build
* Add kPrintWithPostScriptType42Fonts feature.
https://chromium-review.googlesource.com/c/chromium/src/+/3150776
* chore: update patches
* chore: fix tests
* ozone/x11: fix VA-API.
https://chromium-review.googlesource.com/c/chromium/src/+/3141878
* Revert "ozone/x11: fix VA-API."
This reverts commit 23e742acb1032bf4afc1a45e4bed38e42184fd01.
* Reland "Make Ozone/X11 default."
https://chromium-review.googlesource.com/c/chromium/src/+/3114071
* fixup Reland "Make Ozone/X11 default."
* fixup Reland "Make Ozone/X11 default." for clipboard
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: Michaela Laurencin <mlaurencin@electronjs.org>
Co-authored-by: VerteDinde <keeleymhammond@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
2021-10-05 19:21:00 -07:00
Jeremy Rose
b5cd9ce0b3
refactor: ginify WebContents ( #24651 )
2020-07-30 09:17:57 -07:00
Jeremy Apthorp
a3e28788ce
refactor: ginify Tray ( #22822 )
...
* refactor: ginify Tray
* lint
* improve argument parsing logic
* remove redundant imports from tray.js
* new Tray produces an instanceof Tray
* make Constructible generic
* lint
* clean up on exit
2020-03-30 10:32:02 +09:00
Cheng Zhao
7814c67830
fix: enter handle scope when creating custom event ( #22657 )
2020-03-16 14:20:32 +09:00
Cheng Zhao
0a741670a9
chore: remove native_mate (Part 14) ( #21365 )
...
* chore: remove uses of mate::Dictionary and mate::Handle
* chore: move CreateConstructor to gin_helper
* chore: remove native_mate
* chore: remove unneeded gin patch
2019-12-05 18:46:34 +09:00
Cheng Zhao
3ae3233e65
chore: remove native_mate (Part 12) ( #20869 )
...
* refactor: move mate::Event to gin
* refactor: move mate::Locker to gin
* refactor: convert contextBridge to gin
* refactor: convert contentTracing to gin
* refactor: remove callback converter of native_mate
* refactor: remove file_dialog_converter and native_window_converter from native_mate
* refactor: convert webFrame to gin
* refactor: move blink_converter to gin
* refactor: remove net_converter from native_mate
* refactor: remove event_emitter_caller_deprecated
* refactor: remove gurl_converter from native_mate
* refactor: remove file_path and string16_converter from native_mate
* refactor: remove image_converter from native_mate
* refactor: move value_converter to gin
2019-10-31 16:56:00 +09:00
Cheng Zhao
0fe6767d6b
chore: remove native_mate (Part 11) ( #20719 )
...
* refactor: convert Menu and globalShortcut to gin
* refactor: convert api::Cookies to gin
* refactor: convert View and WebContentsView to gin
* refactor: convert WebContents related classes to gin
* refactor: convert powerMonitor to gin
* refactor: prepare for header change
* refactor: remove last uses of mate::EventEmitter
* refactor: remove mate::EventEmitter
* refactor: move trackable_object to gin_helper
* fix: custom converter should not use Handle
* fix: no more need to check if icon is empty
It was a bug that the Handle<NativeImage> can be non-empty when the
image file does not exist. The bug was caused by the converter code
writing out the image even when the convertion fails.
The bug was work-arounded by adding an additional check, but since the
original bug had been fixed, the additional check is no longer needed.
* fix: should always set frameId even when callback is null
* fix: do not mix gin/mate handles for NativeImage
2019-10-25 22:03:28 +09:00
Cheng Zhao
be955a9721
chore: remove native_mate (Part 10) ( #20696 )
...
* refactor: remove direct uses of event_emitter_deprecated.h
* refactor: remove event_emitter_deprecated.h in api::App
* refactor: use std::move to save a copy
* fix: windows and linux builds
2019-10-24 14:47:58 +09:00
Cheng Zhao
eb0e55c514
chore: remove native_mate (Part 9) ( #20645 )
...
* refactor: remove a few uses of native_mate/gfx_converter.h
* refactor: deprecate mate::EventEmitter
* refactor: add gin_helper::EventEmitter
* refactor: convert a few classes to use gin_helper::EventEmitter
* refactor: get rid of native_mate_converters/gfx_converter.h
* fix: follow native_mate on reporting errors
* fix: gin is weak at guessing parameter types
* fix: incorrect full class name
* fix: gin::Handle does not accept null
2019-10-21 16:05:40 +09:00
