David Sanders
bc8cb75e4e
fix: properly handle optional requestHeaders with onBeforeSendHeaders ( #29798 )
2021-06-22 15:08:52 +09:00
David Sanders
98d2824c7f
refactor: migrate AdaptCallbackForRepeating to SplitOnceCallback ( #29825 )
2021-06-21 18:04:31 -07:00
David Sanders
8844034fa8
chore: tune-up electron::api::NetLog ( #29534 )
2021-06-20 18:52:28 -07:00
Milan Burda
de6696ef1d
chore: remove unused and broken ipcRendererInternal.sendTo() ( #29743 )
2021-06-17 23:26:18 -05:00
Shelley Vohr
c841247815
fix: color select eyedropper not working within DevTools ( #29729 )
2021-06-17 08:42:51 -05:00
Shelley Vohr
d59e2d7b2e
fix: draggable regions with devtools open ( #29696 )
2021-06-16 09:58:30 -07:00
Milan Burda
56ac67e059
refactor: use std::make_unique/base::MakeRefCounted when possible ( #29637 )
2021-06-15 09:37:55 +09:00
Jeremy Rose
ebf54d7cc0
refactor: use PathProvider for user-data-dir and others ( #29649 )
...
* refactor: use PathProvider for user-data-dir and others
* consolidate logic for DIR_RECENT and DIR_APP_LOGS into path provider
* fix bad include
* remove debugging code
* fix build on mac
* fix build on win
* create app logs dir on both mac and non-mac
2021-06-15 09:32:56 +09:00
Jeremy Rose
34a4e26b24
fix: check DCHECK_IS_ON() instead of #ifdef DCHECK_IS_ON ( #29620 )
2021-06-14 11:06:09 +09:00
David Sanders
fed5ad5303
fix: use correct spelling of attachment with Content-Disposition header ( #29621 )
2021-06-14 11:05:16 +09:00
electron-roller[bot]
04679121d6
chore: bump chromium to 93.0.4536.0 (main) ( #29586 )
...
* chore: bump chromium in DEPS to 93.0.4536.0
* chore: update patches
* [2918475] Make InkDrop a View class property
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918475
Replace old views::Button::ink_drop() calls with views::InkDrop::Get()
* [2935942] Convert use of gfx::ImageSkia to ui::ImageModel for WidgetDelegates
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2935942
Update GetWindowIcon(), GetWindowAppIcon(), and GetDevToolsWindowIcon()
to return ui::ImageModel instead of gfx::ImageSkia.
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2021-06-08 15:22:43 -05:00
Samuel Attard
8446ce1fc7
feat: add new imageAnimationPolicy webpref and webContents setter ( #29095 )
2021-06-08 11:00:22 +09:00
David Sanders
79cb5144ae
chore: use std::make_unique/base::MakeRefCounted when possible ( #29510 )
2021-06-08 11:00:05 +09:00
David Sanders
070f25db54
fix: make intermediates work with 'select-client-certificate' ( #29552 )
2021-06-07 06:40:43 -07:00
electron-roller[bot]
fa2db00e55
chore: bump chromium to 93.0.4532.2 (main) ( #29527 )
...
* chore: bump chromium in DEPS to 93.0.4531.0
* chore: update patches
* Remove IPC::Listener from WebContentsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/2910240
* serial: Move serial policy from profile to local state
https://chromium-review.googlesource.com/c/chromium/src/+/2914194
* chore: fix pip test
* chore: bump chromium in DEPS to 93.0.4532.2
* chore: update patches
* Follow up ColorChooser clean ups
https://chromium-review.googlesource.com/c/chromium/src/+/2928026
* Distinguish between no default printer vs. query error
https://chromium-review.googlesource.com/c/chromium/src/+/2932396
* chore: remove build_do_not_include_vr_directx_helpers_when_enable_vr.patch
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2021-06-04 19:03:31 -07:00
David Sanders
79ae8b427c
chore: return early on promise rejection ( #29279 )
2021-06-04 13:21:02 +09:00
David Sanders
81c5da5221
chore: use =default for default constructors/destructors ( #29511 )
2021-06-04 13:16:13 +09:00
Milan Burda
00693bab30
refactor: use auto env = base::Environment::Create(); everywhere ( #29502 )
2021-06-04 09:23:06 +09:00
electron-roller[bot]
8532e1239e
chore: bump chromium to 93.0.4530.0 (master) ( #29256 )
...
* chore: bump chromium in DEPS to 92.0.4512.6
* 2887336: [CaptureHandle][#2 ] Propagate CaptureHandleConfig in browser process
https://chromium-review.googlesource.com/c/chromium/src/+/2887336
* refactor: base::Optional -> absl::optional
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4514.0
* 2899417: Make build work when enable_pdf is set to false.
https://chromium-review.googlesource.com/c/chromium/src/+/2899417
* 2904731: use BrowserContext instead of Profile in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2904731
* 2295749: fix: check IsSecureEventInputEnabled in constructor before setting SetPasswordInputEnabled to true
https://chromium-review.googlesource.com/c/chromium/src/+/2295749
* 2893803: Add a GetWebView to RenderFrame.
https://chromium-review.googlesource.com/c/chromium/src/+/2893803
* 2892345: Implement WebContents::ForEachRenderFrameHost
https://chromium-review.googlesource.com/c/chromium/src/+/2892345
* chore: fixup patch indices
* 2892048: Real instance methods for BrowserContext: remaining 5 methods.
https://chromium-review.googlesource.com/c/chromium/src/+/2892048
* 2902821: [mojo] Don't require full header includes for referenced interfaces
https://chromium-review.googlesource.com/c/chromium/src/+/2902821
* 2496500: Remove last deprecated extension Event ctor.
https://chromium-review.googlesource.com/c/chromium/src/+/2496500
* chore: fixup malformed pepper support patch
* chore: bump chromium in DEPS to 92.0.4515.0
* 2908461: Add CreateEmptyPrintPagesParamsPtr() inside print_view_manager_base.cc.
https://chromium-review.googlesource.com/c/chromium/src/+/2908461
* 2880838: viz: add optional HDRMetadata to TransferableResource
https://chromium-review.googlesource.com/c/chromium/src/+/2880838
* chore: fixup patch indices
* chore: bump chromium in DEPS to 92.0.4515.5
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4515.7
* chore: bump chromium in DEPS to 92.0.4515.9
* chore: bump chromium in DEPS to 93.0.4522.0
* chore: bump chromium in DEPS to 93.0.4523.0
* chore: bump chromium in DEPS to 93.0.4524.0
* chore: update patches
* chore: enable_pak_file_integrity_checks was reverted
* chore: update patches
* refactor: base/optional was replaced with absl::optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::nullopt with absl::nullopt
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace all usages of base::make_optional with
absl::make_optional
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace WorldScriptContext() with GetScriptContextFromWorldId
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893213
* chore: clean up left over opening namespace
Refs: 95bfe6d08f
* chore: add missing base::Contains include
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2910202
* refactor: replace GetCurrentDisplayIterator with the hard checker
GetCurrentDisplay
This code looks suspicious but if the iterator was invalid before it
will also be invalid now.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2893191
* refactor: headers are now passed directly in extensions client
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2918906
* refactor: base::DictionaryValue::empty() has been removed
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2912424
* chore: add missing includes for network URLLoaderFactory
Refs: unknown, probably a side effect of header changes
* refactor: make convenience wrapper around AppendArg
There is no converter FromV8 for base::StringPiece (apparently its not
possible). So we now take in an std::string and use the construct for
StringPiece to do implicit conversion.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2905544
* chore: add patch
* chore: bump chromium in DEPS to 93.0.4525.0
* chore: update patches
* refactor: CanResize has been de-virtualized
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2485774
* chore: update resource integrity patch
* chore: add character encoding idl patch
* chore: bump chromium in DEPS to 93.0.4526.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4527.0
* chore: bump chromium in DEPS to 93.0.4528.0
* chore: update patches
* chore: update idl encoding patch
* chore: bump chromium in DEPS to 93.0.4529.0
* chore: update patches
* chore: bump chromium in DEPS to 93.0.4530.0
* chore: update patches
* fix: only SetCanResize after the widget has been initialized
* chore: add patch for vr on windows gn gen
* spec: fix focus related tests on linux due to delay in focus swap
* chore: remove new usages of base::Optional from main
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-03 01:05:04 -07:00
Milan Burda
8040cb788f
test: add spec for --require filtering in NODE_OPTIONS ( #29501 )
2021-06-03 14:46:44 +09:00
Milan Burda
44491b023a
refactor: eliminate duplicate C++ / JavaScript implementation of app.isPackaged ( #29464 )
2021-06-02 12:17:08 -07:00
David Sanders
97fde6dc9c
build: fix macOS build ( #29484 )
2021-06-02 19:42:07 +09:00
Cheng Zhao
3cfe5c6a21
fix: keep shifted character in menu accelerator ( #29202 )
...
* fix: correctly handle shifted char in accelerator
* test: use actual accelerator of NSMenuItem
* chore: simplify KeyboardCodeFromStr
* chore: GetAcceleratorTextAt is testing only
2021-06-02 16:32:48 +09:00
Sergio Padrino
abf6f5c8ba
feat: add new runningUnderARM64Translation property to detect x64 translated apps running on Windows ARM ( #29168 )
...
* feat: add new runningUnderARM64Translation property to detect x64 translated apps running on Windows ARM
* docs: add documentation for the new runningUnderARM64Translation property
* refactor: clean up `IsRunningUnderARM64Translation` Windows implementation
* Return false if IsWow64Process2 doesn't exist
* Emit deprecation warning in runningUnderRosettaTranslation
2021-06-02 16:16:33 +09:00
Samuel Maddock
f9d2a7077e
feat: include resize edge with will-resize event ( #29199 )
...
* feat: emit resize edge with will-resize event
fix: wparam type
fix: private member usage on mac
docs: will-resize event edge option
refactor: 'info' -> 'details' for better type gen
* Update docs/api/browser-window.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* Update docs/api/browser-window.md
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
2021-06-02 11:37:10 +09:00
Jeremy Rose
750a762bf0
feat: support loading debug urls with loadURL() ( #29404 )
2021-06-01 17:17:15 -07:00
David Sanders
a1a649c0d6
chore: remove duplicate option get for CustomScheme ( #29422 )
2021-06-01 17:47:12 +09:00
David Sanders
ba26580f23
chore: use consistent parameter names ( #29361 )
2021-06-01 10:46:25 +09:00
David Sanders
d18dbdd72b
fix: add service worker schemes from command line in renderer ( #29425 )
2021-06-01 10:45:23 +09:00
David Sanders
038359a7d8
chore: fix typos in comments ( #29401 )
2021-06-01 10:42:38 +09:00
David Sanders
93c9374e95
chore: trim unused STL includes ( #29414 )
2021-06-01 10:34:44 +09:00
David Sanders
9bb7051f54
chore: prefer empty() check for readability ( #29360 )
2021-05-27 13:08:30 -07:00
Milan Burda
241cceb2c9
refactor: eliminate duplicate code ( #29174 )
2021-05-24 11:32:55 +09:00
electron-roller[bot]
039f3d5cd2
chore: bump chromium to 92.0.4511.0 (master) ( #29173 )
2021-05-19 16:15:47 -07:00
John Kleinschmidt
d79ebc6dc6
fix: pdf viewer permissions ( #29210 )
...
* fix: pdf viewer permissions
* fixup for getAllExtensions
2021-05-19 16:08:24 -07:00
Robo
77297f37a3
fix: adjust initial webContents focus calculation ( #29204 )
...
* fix: adjust initial webContents focus calculation
* fix: active window check on mac
* fix: about:blank focus behavior
* chore: add spec
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2021-05-19 02:27:35 -07:00
Jeremy Rose
dcbabcb23c
refactor: remove ssl_security_state_tab_helper.patch ( #29196 )
2021-05-18 10:08:53 -07:00
Electron Bot
2eb3bddb05
chore: bump chromium to 92.0.4505.0 (master) ( #29058 )
...
* chore: bump chromium in DEPS to 92.0.4500.2
* resolve conflicts
* update patches
* chore: cherry-pick 82434206f306 from chromium (#29060 )
* fix patch
* chore: bump chromium in DEPS to 92.0.4501.0
* chore: bump chromium in DEPS to 92.0.4502.0
* chore: bump chromium in DEPS to 92.0.4503.0
* chore: update patches
* 2869869
: [Code Health] Refactor ListValue::Insert in gpu compositor
https://chromium-review.googlesource.com/c/chromium/src/+/2869869
* 2877924: Separate InkDropHost from InkDropHostView
https://chromium-review.googlesource.com/c/chromium/src/+/2877924
* chore: bump chromium in DEPS to 92.0.4504.0
* update patches
* Fixup for Separate InkDropHost from InkDropHostView
https://chromium-review.googlesource.com/c/chromium/src/+/2877924
* 2873469: Compute hashes of .pak files during the build, and check it at runtime.
https://chromium-review.googlesource.com/c/chromium/src/+/2873469
* 2874397: Remove flag to disable microtasks scope consistency checks
https://chromium-review.googlesource.com/c/v8/v8/+/2874397
* 2881471: Remove unneeded trace_event.h includes in headers.
https://chromium-review.googlesource.com/c/chromium/src/+/2881471
* 2844717: [Keyboard Tooltip] Rename RWHV*::SetTooltipText to UpdateTooltipUnderCursor
https://chromium-review.googlesource.com/c/chromium/src/+/2844717
* chore: bump chromium in DEPS to 92.0.4505.0
* chore: update patches
* 2883887: Retire ScopedObserver in /chrome/browser/predictors.
https://chromium-review.googlesource.com/c/chromium/src/+/2883887
* 2883694: Retire ScopedObserver in /chrome/browser.
https://chromium-review.googlesource.com/c/chromium/src/+/2883694
* fixup after merge
* fixup: Remove flag to disable microtasks scope consistency checks
* Temporarily disable setcallhandler-test.js nan test
This test should be renabled once https://github.com/electron/electron/pull/29028 lands
* Use gin_helper::MicrotasksScope instead of v8::MicrotasksScope
* chore: bump chromium in DEPS to 92.0.4506.0
* update patches
* Revert "update patches"
This reverts commit 333ec0d4c205bd3cbee28d2bc3d068871dbb900a.
* Revert "chore: bump chromium in DEPS to 92.0.4506.0"
This reverts commit 2bd52f8cd89b173c8b15a61d74fa7539cdbf574b.
* Fixup: Use gin_helper::MicrotasksScope instead of v8::MicrotasksScope
* Fixup: Use gin_helper::MicrotasksScope instead of v8::MicrotasksScope
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
2021-05-13 21:21:36 -04:00
Keeley Hammond
06f51b7283
fix: prevent crash on web-contents creation when error is thrown ( #28971 )
...
* fix: prevent crash when error occurs during event emitter CallMethod
* wip: emit error event within trycatch
* fix: handle uncaught exceptions within node on web_contents init
* fix: create gin_helper::CallMethodCatchException
* test: add web-contents create crash to test cases
* test: clean up test data for web-contents crash
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* fix: convert CatchException to WebContents static helper method
* fix: restore try_catch to callsite
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
2021-05-11 13:57:11 -07:00
Electron Bot
d5f2eb5a81
chore: bump chromium to 92.0.4499.0 (master) ( #29046 )
2021-05-06 15:01:04 -07:00
Milan Burda
a0589ca5d7
chore: remove unused element_instance_id_to_guest_map_ from WebViewManager ( #28979 )
2021-05-04 09:59:44 -04:00
Electron Bot
005101424a
chore: bump chromium to 92.0.4496.0 (master) ( #28907 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2021-05-03 20:13:46 -07:00
Samuel Attard
0a1b26b1d5
refactor: remove internal navigation controller ( #28839 )
2021-04-27 16:11:18 -07:00
Electron Bot
cdf04f3ae7
chore: bump chromium to 92.0.4488.0 (master) ( #28676 )
...
* chore: bump chromium in DEPS to 92.0.4478.0
* chore: update chromium patches
* chore: update v8 patches
* fix: add scale parameter to LookupIconFromFilepath
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2748317
Follow up: https://github.com/electron/electron/issues/28678
* build: depend on gtkprint config for gtk_util.h
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2824022
* build: add missing print_job_constants header
Refs: unknown
* chore: bump chromium in DEPS to 92.0.4479.0
* update patches
* chore: bump chromium in DEPS to 92.0.4480.0
* chore: bump chromium in DEPS to 92.0.4481.0
* chore: bump chromium in DEPS to 92.0.4482.2
* chore: bump chromium in DEPS to 92.0.4483.0
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4484.0
* chore: bump chromium in DEPS to 92.0.4485.0
* fix patches
* update patches
* 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
https://chromium-review.googlesource.com/c/chromium/src/+/2810414
* 2781233: NotificationService: Plumb document_url for non-persistent notifications.
https://chromium-review.googlesource.com/c/chromium/src/+/2781233
* fixup! 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
* 2836669: Refactor GTK build target and dependencies
https://chromium-review.googlesource.com/c/chromium/src/+/2836669
* chore: bump chromium in DEPS to 92.0.4486.0
* update patches
* fix DecrementCapturerCount patch
* explicitly include badging.mojom.h
* include ui/gtk/gtk_ui_factory.h for BuildGtkUi()
* fixup! 2810414: [LSC] Add PRESUBMIT check for ASCIIToUTF16("...") and UTF8ToUTF16("...")
* iwyu fix for base::size
* iwyu for TRACE_EVENT0
* 2799631: Use structured interface for DevTools messages
https://chromium-review.googlesource.com/c/chromium/src/+/2799631
* 2801573: Convert enum to enum class for Widget::InitParams::Activatable
https://chromium-review.googlesource.com/c/chromium/src/+/2801573
* 2805764: Add ContentBrowserClient support for service worker-scoped binders
https://chromium-review.googlesource.com/c/chromium/src/+/2805764
* fixup! 2799631: Use structured interface for DevTools messages
* fixup! 2805764: Add ContentBrowserClient support for service worker-scoped binders
* oops, use of linux_ui after std::move
* fix devtools message handling for null params
* disable node test parallel/test-debug-args
https://chromium-review.googlesource.com/c/v8/v8/+/2843348
* fix gn check
* chore: bump chromium in DEPS to 92.0.4487.0
* chore: update patches
* chore: bump chromium in DEPS to 92.0.4488.0
* update patches
* Remove vpython use from Chromium DEPS file
https://chromium-review.googlesource.com/c/chromium/src/+/2810121
* Partial revert "workaround: disable CFG longjmp protection for Windows on Arm"
https://chromium-review.googlesource.com/c/chromium/src/+/2788210
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
2021-04-27 14:27:34 -07:00
Samuel Attard
fa61e3b119
feat: add session.storagePath to get path on disk for session data ( #28665 )
2021-04-27 09:54:28 -07:00
Jeremy Rose
dc7fa1d9f1
refactor: be more precise when creating api::WebContents ( #23128 )
2021-04-23 13:51:37 -07:00
Samuel Maddock
43d27cc4d1
feat: add WebFrameMain.visibilityState ( #28706 )
...
* feat: add WebFrameMain.visibilityState
* docs: mention other page visibility APIs
* test: delay visibilityState check after hiding
* test: add waitForTrue to avoid flaky visibilityState test
* refactor: waitForTrue -> waitUntil
2021-04-22 12:00:58 -04:00
Samuel Attard
79077f6df9
chore: remove app.allowRendererProcessReuse ( #26874 )
2021-04-21 13:59:11 -07:00
Jeremy Rose
4ca518468d
feat: remove BrowserWindow option inheritance ( #28550 )
2021-04-21 10:55:17 -07:00
Shelley Vohr
11199d8824
feat: add BrowserWindow.isFocusable() ( #28642 )
2021-04-21 12:32:19 +02:00