trop[bot]
bfbd4a2540
fix: Improve --enable-features/--disable-features handling ( #13923 )
...
As it turns out, we can reinitialize the feature list directly after the
user JS script has been executed instead of much later. This allows
modifications to `--enable-features`/`--disable-features` to work with a
greater set of features.
2018-08-03 13:08:27 +10:00
Charles Kerr
1926eab172
Bump v3.0.0-beta.4
2018-08-01 15:13:06 -05:00
trop[bot]
9818378e2d
fix: some APIs modified for ASAR support cannot be util.promisify'ed ( #13902 )
2018-08-01 16:38:50 +10:00
trop[bot]
ad2d35c7cf
memo: Update security docs: will-navigate, new-window ( #13887 )
2018-08-01 13:25:24 +10:00
trop[bot]
13d3a055fa
fix: handle SIGINT and SIGTERM from the Electron CLI helper ( #13889 )
...
Fixes #12840
2018-08-01 13:25:04 +10:00
Charles Kerr
07b93d475d
simplify package-lock.json diffs from last commit
2018-07-31 17:36:33 -05:00
John Kleinschmidt
c9da2d7669
Merge pull request #13359 from electron/release-notes-generator
...
build: New release notes generator
2018-07-31 16:07:40 -05:00
trop[bot]
a9a5766804
chore(tests): allow usage of deprecated APIs in tests ( #13862 )
2018-07-30 15:02:59 +10:00
trop[bot]
a62cb1e84c
fix: util.promisify(setTimeout) ( #13860 )
2018-07-30 15:02:52 +10:00
trop[bot]
2bdb7a5047
fix: window.setVibrancy parameter passing (backport: 3-0-x) ( #13863 )
...
* fix: setVibrancy parameter passing
* fix: uses correct parameter types for setVibrancy
2018-07-30 13:02:32 +10:00
trop[bot]
29f70d7e35
memo: First draft: Here be dragons ( #13861 )
2018-07-30 11:44:43 +10:00
trop[bot]
91af624cb1
docs: fix electron.d.ts typings ( #13857 )
2018-07-30 11:20:19 +10:00
trop[bot]
b08df88b7c
fix: Use --enable-features and --disable-features ( #13805 )
...
Unlike Chrome, we were not using the --enable-features and
--disable-features command-line arguments to initialize
`base::FeatureList`.
2018-07-26 08:29:08 -07:00
Birunthan Mohanathas
b659ff2de3
build: Bump libcc to latest (3.0.x) ( #13822 )
...
This picks up electron/libchromiumcontent#618 .
2018-07-26 08:25:28 -07:00
trop[bot]
3ad6abc5cc
fix: check string encoding before creating value ( #13818 )
2018-07-26 19:35:18 +09:00
Cheng Zhao
a880e0222f
fix: pass scrollBounce by command line flag ( #13813 )
...
Implement the scrollBounce option by reading the command line flag in
`RenderThreadImpl::IsElasticOverscrollEnabled`, there is no more need
to set NSScrollViewRubberbanding.
2018-07-26 18:38:48 +09:00
Birunthan Mohanathas
95c69e660c
build: Bump libcc to latest (3.0.x)
...
This picks up electron/libchromiumcontent#611 and
electron/libchromiumcontent#599 .
2018-07-25 09:54:00 -07:00
trop[bot]
4333020157
fix: create WebContents for webview on request ( #13761 )
2018-07-21 16:51:31 +09:00
John Kleinschmidt
f4ff97038c
Merge pull request #13755 from trop-bot/3-0-x-bp-fix--update-rebuild-test-modules.py-for-node-10-1532100223562
...
fix: update rebuild-test-modules.py for node 10 (backport: 3-0-x)
2018-07-20 14:45:00 -04:00
John Kleinschmidt
967577c335
fix: update for node 10
2018-07-20 15:23:49 +00:00
John Kleinschmidt
8bd5c1f858
Merge pull request #13734 from electron/backport-13727-3-0-x
...
fix: use context counter as contextId (backport 3-0-x)
2018-07-20 10:17:18 -04:00
trop[bot]
2955b0168c
fix: ensure DirectX capturer is supported. (backport: 3-0-x) ( #13738 )
...
* Ensure DirectX capturer is supported.
* Actually try building on Windows.
2018-07-20 14:25:29 +10:00
Cheng Zhao
04b7c77951
fix: use webContentsId with contextId together
...
After after using `processId-contextCounter` as contextId, it may happen
that contexts in different WebContents sharing the same renderer process
get the same contextId. Using webContentsId as part of key in
ObjectsRegistry can fix this.
2018-07-20 10:53:02 +09:00
Cheng Zhao
136cf389e8
fix: use context counter as contextId (backport 3-0-x)
...
For sandboxed renderer it may not have a node::Environment in the context,
using a increasing counter as contextId works for all cases.
2018-07-19 11:27:41 -07:00
Zeke Sikelianos
8d9775b0b1
Bump v3.0.0-beta.3
2018-07-17 09:38:50 -07:00
John Kleinschmidt
9237d46dba
make sure tests don't run for GitHub releases. ( #13701 )
...
Also fix VSTS slack integration and
Update to latest libchromiumcontent
(cherry picked from commit 1c70a1cccd
)
2018-07-17 10:57:59 -05:00
John Kleinschmidt
8f8d198c5a
Merge pull request #13539 from trop-bot/3-0-x-bp-enable-webview-in-sandbox-renderer-1530547750986
...
Backport (3-0-x) - Enable webview in sandbox renderer
2018-07-17 10:01:40 -04:00
trop[bot]
fcdbb8c4a7
fix: create a window capturer correctly (backport: 3-0-x) ( #13693 )
...
* fix: create a window capturer correctly
We were incorrectly creating two screen capturers instead of a window
capturer
* spec: ensure dc tests pass
* spec: enable all tests after verifying dc tests work
2018-07-17 15:30:33 +10:00
trop[bot]
b49b071a1f
fix: remove race condition for executeJavaScript ( #13692 )
...
Replaces 'did-finish-load' with 'did-stop-loading' which semantically
maps to the events inside Chromium. Before I think we were relying
on a natural 99% winnable race condition.
Fixes #13504
2018-07-16 21:22:27 -07:00
trop[bot]
1feb45da29
docs: update second-instance event docs ( #13682 )
2018-07-16 13:57:58 -07:00
John Kleinschmidt
2c43dbdb25
Merge pull request #13680 from trop-bot/3-0-x-bp-fix-crash-when-opening-devtools-for-frameless-window-1531748442042
...
Fix crash when opening devtools for frameless window (backport: 3-0-x)
2018-07-16 10:48:37 -04:00
Cheng Zhao
7eff91dde1
spec: openDevTools should not crash for frameless window
2018-07-16 13:40:48 +00:00
Cheng Zhao
780483ff35
fix: use InspectableWebContentsView as content view
2018-07-16 13:40:48 +00:00
trop[bot]
c2f770df02
Update Windows VS2017 requirement ( #13665 )
2018-07-13 18:17:53 -05:00
John Kleinschmidt
74e6e063d4
Merge pull request #13658 from trop-bot/3-0-x-bp-fix--don't-invoke-callback-after-framesubscriber-is-destroyed-1531475760693
...
fix: don't invoke callback after FrameSubscriber is destroyed (backport: 3-0-x)
2018-07-13 11:51:07 -04:00
Cheng Zhao
7702cc1090
fix: don't invoke callback after FrameSubscriber is destroyed
2018-07-13 09:56:07 +00:00
trop[bot]
97319e5a3a
fix: remember the render_process_id when permission requests occur on the IO thread ( #13651 )
...
Fixes #13620
2018-07-13 12:50:57 +10:00
Jeremy Apthorp
041c952574
fix: enable spell checking, which broke in upgrade to ch66
...
Chromium commit [03563dd163][1] changed the way that the
spellcheck-enabled status was checked, defaulting to false.
Added the first (!) test for spellchecking, too.
Fixes #13608 .
[1]: 03563dd163
2018-07-12 13:28:15 -07:00
John Kleinschmidt
6c9b6f9cac
Merge pull request #13642 from trop-bot/3-0-x-bp-chore--updates-for-release-process-1531400155960
...
chore: Updates for release process (backport: 3-0-x)
2018-07-12 09:37:12 -04:00
John Kleinschmidt
c4884da601
Update docs to reflect current process
...
Also added troubleshooting steps.
2018-07-12 12:56:02 +00:00
John Kleinschmidt
59b05ed661
Fix Appveyor URL
2018-07-12 12:56:02 +00:00
Cheng Zhao
e3204a5ec1
Merge pull request #13637 from electron/fix-remote-3-0-x
...
fix: guard against double-freeing remote references (3-0-x)
2018-07-12 16:01:52 +09:00
Cheng Zhao
adf49daaac
fix double-freeing remote references
...
After the page does navigations, garbage collection can still happen in
the old context. This commit changes to store references to remote objects
by _pages_, instead of by _WebContents_.
2018-07-12 11:17:26 +09:00
Cheng Zhao
9431677e79
add API to return an unique ID for page
2018-07-12 11:16:13 +09:00
John Kleinschmidt
0141c083d0
Bump v3.0.0-beta.2
2018-07-10 14:12:05 -04:00
John Kleinschmidt
96b2c08293
Merge pull request #13612 from trop-bot/3-0-x-bp-build--updates-to-the-release-process-1531237367452
...
Backport (3-0-x) - build: Updates to the release process
2018-07-10 13:26:24 -04:00
John Kleinschmidt
d6f2c26b0f
Move github release checking to node.js
...
Our upload script was relying on an old python script to find the GitHub release for uploading.
2018-07-10 15:42:53 +00:00
John Kleinschmidt
d478906f9c
Update to run new AppVeyor jobs
...
AppVeyor builds got split into two jobs, `electron-x64` and `electron-ia32`
2018-07-10 15:42:53 +00:00
trop[bot]
85526c7f21
fix: fallback to FullSizeContentView for frameless window on mac ( #13600 )
...
When using `views::Widget` to create window, Chromium will automatically
use a `BridgedContentView` as content view, which however does not
support draggable regions inside it.
By fallback to `FullSizeContentView` we can work around this problem,
with the price of losing the ability to use `views::View` APIs. Since
we don't expect users to use the new `View` APIs in `BrowserWindow`
anyway, it should not be a problem.
This change does not affect users of `TopLevelWindow`, and for users of
`BrowserWindow` there is nothing to lose.
In the long term we should look into how to make draggable regions work
with `BridgedContentView`. The related Chromium code is still being
changed rapidly, we can wait until Chromium migrated its
`NativeAppWindowCocoa` class to use `views::Widget`.
2018-07-10 13:09:46 +09:00
John Kleinschmidt
f6ae438005
Merge pull request #13591 from trop-bot/3-0-x-bp-fix-failed-devtools-tests-due-to-fs.statsyncnoexception-not-working--1531147212282
...
Backport (3-0-x) - Fix failed devtools tests due to fs.statSyncNoException not working
2018-07-09 14:30:42 -04:00