trop[bot]
daca2d327f
fix: remove use of deprecated API base::Hash() ( #44101 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-02 20:46:26 -05:00
trop[bot]
9222396159
fix: ensure correct WebContents when checking PDFReadyToPrint (31-x-y) ( #44010 )
2024-10-01 18:32:31 +02:00
trop[bot]
a0802f7ce6
fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (31-x-y) ( #44036 )
...
* fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (#44014 )
* refactor: reduce code duplication in WebContentsPreferences::OverrideWebkitPrefs()
* refactor: limit scope of web_preferences temporary in ElectronBrowserClient::OverrideWebkitPrefs()
* chore: remove redundant static keyword on function in anonymous namespace
* refactor: slightly more explicit typing
* refactor: remove unnecessary utf16 -> utf8 -> utf16 conversion steps
* chore: remove unused #includes
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use string_view.rfind() instead of base::RSplitStringOnce()
base::RSplitStringOnce() does not exist in Chromium 128
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-10-01 12:17:16 -04:00
trop[bot]
0a4b0de4f7
fix: ensure SetPluginCanSave updated in PDFs ( #44020 )
...
fix: ensure SetPluginCanSave updated in PDFs
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-30 14:52:14 +02:00
trop[bot]
6010fda0c7
perf: build g_dgettext domain name at compile time ( #43986 )
...
perf: build GettextPackage name at compile time
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 18:59:06 -05:00
trop[bot]
514fc26eb2
fix: replace deprecated libnotify API calls ( #43982 )
...
notify_notification_set_hint_string() is deprecated, so let's use
notify_notification_set_hint() instead.
Xref: 2fe1748295
2024-09-26 17:08:12 -05:00
trop[bot]
328afb8a09
fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap() ( #43981 )
...
* fix: -Wunsafe-buffer-usage warnings in GdkPixbufFromSkBitmap()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: don't change previous behavior for 0-height images
Is a 0x0 image even a thing? I'm not sure; but just in case, let's
treat it the same way the previous implementation did.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-26 10:55:35 -05:00
trop[bot]
e99de2b5c6
test: ensure sender-pid hint is set in Linux notifications ( #43951 )
...
test: expect a `sender-pid` hint in Linux notifications.
This PR ensures that the `sender-pid` hint is set for new notifications.
It also updates the spec to confirm that DBus receives the hint and that
it has the correct value.
This fixes a spec failure when running libnotify >= 0.7.12 (2022-05-05).
Starting with that version, libnotify started injecting `sender-pid` if
not provided by the client. So our tests received a slightly different
DBus payload depending on what version of libnotify was installed,
causing our deep-equals tests to fail.
By always providing and testing the `sender-pid` hint, our behavior and
tests should be consistent across distros.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 14:02:07 -05:00
trop[bot]
6c1233a7d2
fix: close all open sheets before closing window on macOS ( #43953 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Beutner <beutner.john@gmail.com>
2024-09-25 13:09:40 -05:00
trop[bot]
d241d1f3b3
refactor: remove C-style void arg type for no-arg functions ( #43942 )
...
refactor: remove C-style void arg type for no-arg functions (#43884 )
A small cleanup to remove use of the C-style function declaration idiom.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-25 12:13:22 -05:00
trop[bot]
ad82142eb0
fix: detach native view when its removed from parent on macOS ( #43924 )
...
Right now DelayedNativeViewHost attaches its underlying native view
when it's being attached to a widget but it doesn't detach it when
it's being detached. It may lead to use-after-free and crash.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Cezary Kulakowski <cezary@openfin.co>
2024-09-25 13:17:47 +02:00
trop[bot]
a5f4f08a9e
fix: crash when focusing WebView webContents ( #43933 )
...
fix: crash when focusing WebView
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-25 06:17:06 -05:00
Charles Kerr
f15fea8d03
fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (31-x-y) ( #43926 )
...
* fix: -Wunsafe-buffer-usage warnings in GetNextZoomLevel() (#43803 )
* empty commit
2024-09-25 11:21:15 +02:00
trop[bot]
f387325079
fix: EyeDropper working in devtools (31-x-y) ( #43895 )
...
fix: EyeDropper working in devtools (#43685 )
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-23 22:36:18 -07:00
trop[bot]
568314240e
refactor: NotificationPresenter::Create() returns a std::unique_ptr<> ( #43805 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-20 00:18:21 -05:00
Charles Kerr
48805ee46e
refactor: remove use of deprecated API BuildServiceInstanceFor() (31-x-y) ( #43782 )
...
refactor: remove use of deprecated API BuildServiceInstanceFor() (#43690 )
* refactor: update BadgeManagerFactory
* refactor: update NetworkContextServiceFactory
* refactor: update ElectronExtensionSystemFactory
* refactor: update UsbChooserContextFactory
* refactor: update UsbHidChooserContextFactory
* refactor: update SerialChooserContextFactory
* refactor: update FileSystemAccessPermissionContextFactory
2024-09-19 10:01:00 +02:00
Charles Kerr
e62c322b2d
refactor: declare gin::Wrapper subclasses as final ( #43783 )
...
refactor: declare gin::Wrapper subclasses as final (#43527 )
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
2024-09-19 09:57:24 +02:00
trop[bot]
c5e1a336f2
fix: resizing border on Linux WCO caption buttons ( #43745 )
...
Closes https://github.com/electron/electron/issues/43714 .
Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-17 21:54:10 +02:00
trop[bot]
f93cc252ba
fix: native View wrapper crash missing when adding child view ( #43697 )
...
fix: native View wrapper crash missing when adding child view
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-12 19:20:47 +02:00
trop[bot]
2c3416627f
fix: restore Chromium default Content-Disposition header parsing ( #43669 )
...
* fix: restore Chromium default Content-Disposition header parsing
Co-authored-by: Milan Burda <milan.burda@gmail.com>
* Update api-web-request-spec.ts
Co-authored-by: Milan Burda <milan.burda@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
2024-09-10 13:27:22 -04:00
trop[bot]
43687aca8a
fix: ensure bounds stability in OnWidgetBoundsChanged ( #43658 )
...
fix: ensure bounds stability in OnWidgetBoundsChanged
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-09 21:56:42 -05:00
trop[bot]
96fe03b200
test: add -pdf-ready-to-print event to WebContents for testing ( #43651 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-09 21:56:16 -05:00
trop[bot]
4b5d29201c
chore: remove unused ConvertableToTraceFormatWrapper ( #43653 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-09-09 21:55:42 -05:00
trop[bot]
5f97f97f7c
fix: confirm a v8::Value is a v8::Object before casting it ( #43603 )
...
fix: confirm a v8::Value is a v8::Object before casting it
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-06 15:26:33 -05:00
trop[bot]
5c424edcca
refactor: NativeWindow::Create() returns a unique_ptr ( #43605 )
...
refactor: NativeWindow::Create() returns a unique_ptr
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-06 14:19:50 -05:00
trop[bot]
d025ecfa6b
fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app ( #43547 )
...
When an electron app is launched by another app ensure that the
XDG_ACTIVATION_TOKEN env var is read and used for activation using
xdg_activation_v1 protocol.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Orko Garai <orko@igalia.com>
2024-09-04 17:28:02 +02:00
trop[bot]
f7404bceea
fix: devtools dock state with WCO on linux ( #43500 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2024-08-29 13:27:14 -04:00
trop[bot]
44e57c6cbb
chore: remove unused WinFrameView::kInactiveTitlebarFeatureAlpha ( #43475 )
...
added in Aug 2021 (41646d11#29600 ) but never used
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-24 00:11:00 -05:00
trop[bot]
1b657869c2
fix: touch bar functionality on BaseWindow ( #43420 )
...
* fix: touch bar functionality on BaseWindow
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* test: add test for BaseWindow.setTouchBar
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-22 15:43:47 +02:00
trop[bot]
a7459bc93b
refactor: move impl functions into private namespace ( #43410 )
...
* refactor: move into unnamed namespace: IsKillURL()
refactor: move into unnamed namespace: ResolvePossiblyRelativeURL()
refactor: move into unnamed namespace: AllowFileAccess()
refactor: move into unnamed namespace: PrepareURLForNavigation()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetMonitors()
refactor: move into unnamed namespace: GetEDIDProperty()
refactor: move into unnamed namespace: MonitorAtomIdToDisplayId()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetPermissionInfos() } refactor: move into unnamed namespace: GetPermissionAliases()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: OnOpenExternal()
refactor: move into unnamed namespace: HandleExternalProtocolInUI()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: BindMimeHandlerService()
refactor: move into unnamed namespace: BindBeforeUnloadControl()
refactor: move into unnamed namespace: BindBadgeServiceForServiceWorker()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetClientIdPath()
refactor: move into unnamed namespace: ReadClientId()
refactor: move into unnamed namespace: WriteClientId()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: HasExplicitLogFile()
refactor: move into unnamed namespace: DetermineLoggingDestination()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetArchiveCache()
refactor: move into unnamed namespace: GetArchiveCacheLock()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetParameters()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: GetDoomed()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: move into unnamed namespace: EncodeToken()
refactor: move into unnamed namespace: PortInfoToValue()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-21 21:29:25 -05:00
Charles Kerr
aa47f3efc3
refactor: remove unused SetWMSpecState ( #43383 )
...
refactor: remove unused SetWMSpecState (#43347 )
last use removed in Aug 2022 by 53cd2315#35179
2024-08-21 10:26:30 +02:00
Charles Kerr
3596197562
chore: remove unused method Erase() ( #43382 )
...
chore: remove unused method Erase() (#43348 )
Last use removed in Mar 2018 by 4b39d17e
2024-08-21 10:15:17 +02:00
trop[bot]
b80d708fc1
feat: accept-encoding zstd ( #43301 )
...
* fix: accept-encoding zstd
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* Update shell/browser/net/system_network_context_manager.cc
Co-authored-by: Sam Maddock <smaddock@slack-corp.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* chore: make lint happy
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-16 11:24:07 +02:00
trop[bot]
a959476dc2
fix: blank page when printing pdf ( #43327 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-15 10:30:22 -04:00
trop[bot]
bd70c3a740
refactor: update chrome.scripting extensions api impls ( #43290 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-12 12:09:34 +02:00
trop[bot]
997afe62f2
chore: remove unused Notification fields icon_path_, has_icon_ ( #43295 )
...
Last use of `icon_path_` was removed on May 29, 2017 (c741b5845048425e
2024-08-12 12:09:25 +02:00
trop[bot]
dd1dcad81c
fix: system-context-menu with frameless BrowserWindows ( #43274 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-11 21:30:37 +02:00
trop[bot]
10dd33c16e
fix: check screen capture permissions in desktopCapturer ( #43271 )
...
fix: check screen capture permissions in desktopCapturer
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-11 21:30:27 +02:00
trop[bot]
c3a7f0001c
fix: accidental handle copying in a range loop ( #43281 )
...
fix: accidental handle copying
Xref: https://github.com/electron/electron/pull/37857
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-10 09:59:36 +02:00
trop[bot]
a780a75dec
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled ( #43250 )
...
build: fix build when enable_pdf_viewer and enable_electron_extensions disabled
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-08 10:59:15 +02:00
trop[bot]
36cebb95c6
refactor: simplify window moveAbove/moveTop impl on macOS ( #43201 )
...
refactor: simplify window moveAbove/moveTop impl on macOS
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-06 16:41:49 -04:00
trop[bot]
be842d6267
perf: avoid redundant calls to GetView() ( #43229 )
...
* perf: avoid double-calls to GetView()
There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:
if (auto* view = foo->GetView())
view->DoSomething();
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* perf: avoid discarded GetView() call
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-06 13:23:21 -05:00
trop[bot]
17cb664e39
perf: don't build unused vectors in HidChooserContext ( #43214 )
...
* refactor: remove unused code in HidChooserContext::DeviceRemoved()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: remove unused code in HidChooserContext::OnHidManagerConnectionError()
Co-authored-by: Charles Kerr <charles@charleskerr.com>
* refactor: use structured bindings for readability
Co-authored-by: Charles Kerr <charles@charleskerr.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-06 09:57:00 -05:00
trop[bot]
54b31f153c
fix: gin_helper::MicrotasksScope instantiation ( #43209 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-08-05 21:46:51 -05:00
trop[bot]
1c368f13f8
fix: take bluetooth serial ports into account in serial.getPorts() ( #43170 )
...
* fix: take bluetooth serial ports into account in serial.getPorts()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* chore: remove port.path.LossyDisplayName()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-08-01 23:10:46 -07:00
trop[bot]
cdb0540cf0
fix: handle failing to enter fullscreen on macOS ( #43154 )
...
* fix: handle failing to enter/exit fullscreen on macOS
On macOS, failing to enter/exit fullscreen can fail. If this happens,
properly restore the original window state.
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>
* refactor: remove fail to exit fullscreen handlers
Seem to be unnecessary since the window exits fullscreen anyway.
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com>
2024-08-01 14:50:23 +02:00
Shelley Vohr
832090d01c
feat: add transparency checking to nativeTheme ( #43137 )
...
feat: add transparency checking to nativeTheme
2024-08-01 12:14:07 +02:00
trop[bot]
31551aba9d
fix: vibrant view is inserted into Views API hierarchy ( #43128 )
...
* fix: vibrant view is inserted into Views API hierarchy (#42263 )
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>
* Update shell/browser/native_window_mac.mm
Co-authored-by: Charles Kerr <charles@charleskerr.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Hans Halverson <hans_halverson@alumni.brown.edu>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-31 19:59:27 -05:00
Keeley Hammond
24db198d52
fix: remove InspectableWebContentsViewMac ( #43096 )
...
* fix: remove InspectableWebContentsViewMac (#43033 )
* Revert "refactor: remove InspectableWebContentsViewMac in favor of the Views version (#41326 )"
This reverts commit e67ab9a93dhttps://chromium-review.googlesource.com/c/chromium/src/+/5578714
* fix: contents_web_view_ -> contents_view_
* chore: remove extraneous includes
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
* fix: remove custom border radius feat (#42320 )
* fix: fix views::Widget::InitParams params
---------
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-30 14:51:51 -04:00
trop[bot]
35b73514b7
fix: showInactive window not showing ( #43102 )
...
fix: showInactive window not showing
Refs https://github.com/electron/electron/pull/42226 and https://github.com/electron/electron/pull/43033
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-07-30 13:02:03 -05:00
