Kevin Sawicki
65abaee299
Forward will/did navigate events to extensions
2016-06-16 12:07:59 -07:00
Kevin Sawicki
64ae5cf5a1
Merge pull request #6084 from wolfgang42/master
...
Fix typo: 'arugments'
2016-06-16 10:46:58 -07:00
Wolfgang
b349c381fa
🎨 Fix typo: 'arugments'
2016-06-16 13:41:45 -04:00
Kevin Sawicki
567622c126
Drop unneeded .js extensions
2016-06-16 09:52:14 -07:00
Kevin Sawicki
3aecb11094
Extract Event clas to own file
2016-06-16 09:51:54 -07:00
Kevin Sawicki
7f9fa92e2d
Add chrome.webNavigation stubs
2016-06-16 09:46:26 -07:00
Cheng Zhao
bb10551d23
Work around a compiler bug that crashes on Windows
2016-06-16 10:55:25 +09:00
Kevin Sawicki
ae6ffa6d5e
unkown -> unknown
2016-06-14 15:47:33 -07:00
Kevin Sawicki
ee09c7534a
Only add extensions to windows and webviews
2016-06-14 15:47:33 -07:00
Kevin Sawicki
f29801ad2b
Add background page web contents type
2016-06-14 15:47:33 -07:00
Kevin Sawicki
ee0bab6389
Specify type instead of isGuest
2016-06-14 15:47:33 -07:00
Kevin Sawicki
f25c1f864b
Use RenderProcessPreferences for non-remote web contents
2016-06-14 15:47:32 -07:00
Cheng Zhao
18a38dbfc1
Fix exception in alert for inavlid parameter
2016-06-14 15:22:01 +09:00
Cheng Zhao
3f2c3e0448
Wait for current app to quit before launching new app
2016-06-14 14:31:41 +09:00
Kevin Sawicki
f67e2043c8
Add back options param
2016-06-13 09:06:42 -07:00
Kevin Sawicki
56001b481e
Emit web-contents-created on app
2016-06-13 08:59:57 -07:00
Cheng Zhao
8fe5dd22b2
Merge pull request #6018 from electron/string-map
...
Cleanup code for autoUpdater
2016-06-13 01:02:53 +00:00
Cheng Zhao
853d7b1b79
Merge pull request #5965 from electron/installed-extension-api
...
Add BrowserWindow.getDevToolsExtensions API
2016-06-13 00:45:58 +00:00
Cheng Zhao
a3786f66c9
Do not add JS wrapper for setFeedURL
...
When possible we should avoid adding wrappers in JS, it usually makes
code more difficult to mantain
2016-06-13 09:38:47 +09:00
Milan Burda
c89d8b19b6
Add optional requestHeaders argument to autoUpdater.setFeedURL + allow calling mulitple times
2016-06-12 12:46:16 +02:00
Jessica Lord
c68ca16148
Merge pull request #5974 from electron/chrome-storage-sync
...
Add chrome.storage.sync and chrome.storage.get APIs
2016-06-10 12:20:03 -07:00
Jessica Lord
39e6081a00
🔥 line
2016-06-10 09:59:47 -07:00
Kevin Sawicki
1f245d5ff6
Add getDevToolsExtensions API
2016-06-10 09:26:38 -07:00
Kevin Sawicki
0a26075699
Add BrowserWindow.isDevToolsExtensionInstalled API
2016-06-10 09:24:04 -07:00
Cheng Zhao
4373dc1eac
Merge pull request #5972 from electron/non-writeable-guest-id
...
Make guestId on BrowserWindowProxy non-writeable
2016-06-10 12:02:07 +00:00
Cheng Zhao
21081549fd
Merge pull request #5967 from electron/window-opener-webview
...
Support window.opener from windows opened from a <webview>
2016-06-10 11:52:37 +00:00
Cheng Zhao
ccaf837da4
Merge pull request #5964 from electron/manifest-errors
...
Throw errors reading/parsing manifest.json files
2016-06-10 03:28:57 +00:00
Jessica Lord
ede3dbd201
🚿 Lint
2016-06-09 16:39:24 -07:00
Jessica Lord
f121f46a24
Merge branch 'master' into chrome-storage-sync
2016-06-09 16:35:00 -07:00
Jessica Lord
dc10568917
Handle the three get cases
2016-06-09 16:26:42 -07:00
Kevin Sawicki
2efc913222
Remove standard lint warnings
2016-06-09 14:17:54 -07:00
Jessica Lord
41d6ddd588
Add storage file
2016-06-09 14:14:14 -07:00
Kevin Sawicki
01f96fe6af
Default locale to en
2016-06-09 14:00:53 -07:00
Kevin Sawicki
9f64c39f8c
Remove lint warnings
2016-06-09 13:57:08 -07:00
Kevin Sawicki
2367cd574e
Cache extension metadata
2016-06-09 13:57:08 -07:00
Kevin Sawicki
ea9d2dadf8
Add fixme for sync ipc
2016-06-09 13:57:08 -07:00
Kevin Sawicki
d4925e6226
Add initial support for placeholders and substitutions
2016-06-09 13:57:08 -07:00
Kevin Sawicki
d54de73e03
🎨
2016-06-09 13:57:08 -07:00
Kevin Sawicki
84960af793
Add initial chrome.i18n.getMessage API
2016-06-09 13:57:08 -07:00
Kevin Sawicki
939ae567ac
🎨
2016-06-09 13:53:36 -07:00
Kevin Sawicki
2f93735909
Make BrowserWindowProxy guestId non-writeable
2016-06-09 13:41:42 -07:00
Kevin Sawicki
bbc3a71c9f
Use webContents id as guest id in opened windows
2016-06-09 11:29:38 -07:00
Kevin Sawicki
ebf9773269
Use const/let and removes CoffeeScript ref vars
2016-06-09 10:35:48 -07:00
Kevin Sawicki
6d3fc611bd
Tweak duplicate extension message
2016-06-09 10:08:21 -07:00
Kevin Sawicki
f46edd5186
Throw errors reading/parsing manifest.json
2016-06-09 09:45:02 -07:00
deepak1556
4749e18fc0
fix spec and docs
2016-06-09 10:48:05 +05:30
deepak1556
b91217f29e
emit once for each session and add spec
2016-06-09 10:40:51 +05:30
deepak1556
cb5e648502
register extension handler for every session created
2016-06-09 10:40:51 +05:30
deepak1556
aa853dd3be
move protocol to session properties for working with partitions
2016-06-09 10:39:18 +05:30
Kevin Sawicki
4823a04a44
hookWindowForTabEvents -> hookWebContentsForTabEvents
2016-06-08 12:00:13 -07:00
Kevin Sawicki
11e68ff932
Only add extensions to non-remote webContents
2016-06-08 12:00:13 -07:00
Kevin Sawicki
c8c60dd313
Add devtools from web-contents-created event
2016-06-08 12:00:13 -07:00
Kevin Sawicki
d8fe5da3ea
🎨
2016-06-08 12:00:13 -07:00
Kevin Sawicki
ec8b9e3f35
Export loadDevToolsExtensions API to use in guest view manager
2016-06-08 12:00:13 -07:00
Kevin Sawicki
219d177731
Load extensions for all web contents
2016-06-08 12:00:13 -07:00
Kevin Sawicki
78e3bb0660
🎨
2016-06-08 12:00:13 -07:00
Kevin Sawicki
4c1ede32cf
Use destroyed event instead of closed event
2016-06-08 12:00:12 -07:00
Kevin Sawicki
4f46f75d8f
Load dev tools extensions in webviews
2016-06-08 12:00:12 -07:00
Kevin Sawicki
70996c79ba
Add showDefinitionForSelection webContents proxy method
2016-06-08 10:19:43 -07:00
Kevin Sawicki
4f0a52628e
Add showDefinitionForSelection to webContents/webview
2016-06-08 10:15:36 -07:00
Cheng Zhao
6c5eaf6178
Merge pull request #5923 from electron/disable-blink-features
...
Support disabling Blink features
2016-06-08 02:00:30 +00:00
Kevin Sawicki
02e0ca60ef
Use lowercase param key
2016-06-07 16:35:23 -07:00
Kevin Sawicki
cd2041375b
Add missing A in constant name
2016-06-07 16:31:16 -07:00
Kevin Sawicki
96012d6523
Remove trailing comma
2016-06-07 16:24:05 -07:00
Kevin Sawicki
ca6e3ed1ef
Add webview support for disabled blink features
2016-06-07 13:49:31 -07:00
Kevin Sawicki
ba762464d2
More let/const-ing
2016-06-07 10:29:29 -07:00
Kevin Sawicki
5c880b7c99
We -> we
2016-06-07 10:25:21 -07:00
Kevin Sawicki
ce1a9740f6
🎨 Use const and for/of loops
2016-06-07 10:24:48 -07:00
Kevin Sawicki
3bcb411e28
Don't collect unused results array
2016-06-07 10:24:33 -07:00
Cheng Zhao
3c873736d7
Add update-target-url event
2016-06-07 15:56:19 +09:00
Cheng Zhao
08f8e06c55
Merge pull request #5894 from electron/chrome-runtime-id
...
Implement chrome.runtime.id
2016-06-07 01:54:58 +00:00
Kevin Sawicki
61ce19ba7e
Set chrome.runtime.id
2016-06-06 14:42:07 -07:00
Kevin Sawicki
a906336b1e
Don't log extension id
2016-06-06 13:03:01 -07:00
Cheng Zhao
1066c1acaf
Merge pull request #5882 from electron/felix-extension-warning-2
...
Log a warning if an extension's manifest cannot be parsed
2016-06-06 06:20:02 +00:00
Cheng Zhao
ec691a3a64
Merge pull request #5870 from danhp/missing-roles
...
Add 'delete' and 'pasteandmatchstyle' roles
2016-06-06 06:16:53 +00:00
Daniel Pham
bd1eae86a1
Add 'delete' and 'pasteandmatchstyle' roles
2016-06-05 21:50:37 -04:00
Felix Rieseberg
eb62abcc23
🎨 Log a warning if an extension's manifest cannot be parsed
...
Also logs a clean warning if an extension's manifest is incomplete,
missing, or can otherwise not be parsed.
2016-06-05 18:30:49 -07:00
Felix Rieseberg
b42e6583f7
🎨 Log a warning if an extension has already been loaded
...
If an extension has already been loaded (for instance because it’s
persisted), `addDevToolsExtension` will return nothing, which is
confusing. This adds a little `console.warn` to educate people about
what’s happening.
Closes #5854
2016-06-03 14:32:22 -07:00
Cheng Zhao
0864d3b1ee
Cleanup the printToPDF code
2016-06-01 15:32:37 +09:00
Cheng Zhao
eb882855bc
Cleanup the CoffeeScript converted code
2016-06-01 15:08:51 +09:00
Cheng Zhao
5bb8da6073
Explicitly initialize session before webContents
2016-06-01 14:57:35 +09:00
Cheng Zhao
0565c42add
Merge pull request #5812 from vasumahesh1/feature-pdf
...
webContents: custom pageSize for printToPDF
2016-06-01 05:52:08 +00:00
Cheng Zhao
8dfbbcefc8
Throw error when session module is used before app is ready
2016-06-01 10:53:06 +09:00
Cheng Zhao
d105524135
Cleanup the JavaScript code of session
2016-06-01 10:42:24 +09:00
Vasu Mahesh
fc6628d159
Add: custom pageSize for printToPDF
2016-05-31 22:40:11 +05:30
Cheng Zhao
9f0fc96025
Merge pull request #5711 from electron/extension-code-cleanup
...
Implement partial chrome.* API for devtools extension
2016-05-29 23:29:08 +00:00
Cheng Zhao
5f3fdbe635
Simplify the implementation of sendToAll
2016-05-29 12:10:32 +09:00
Cheng Zhao
de001a9bbf
Use meaningful name for extensionId
2016-05-29 11:57:20 +09:00
Cheng Zhao
ec1944c146
Implement chrome.tab.onCreated/onRemoved APIs
2016-05-29 11:50:14 +09:00
Cheng Zhao
2431d886bf
Current handle sender.tab for background pages
2016-05-29 10:46:48 +09:00
Cheng Zhao
f693b042b5
Fix js lint warnings
2016-05-28 22:46:15 +09:00
Cheng Zhao
747f910ce0
Merge pull request #5736 from electron/missing-has-own-property
...
Support objects with no prototype over IPC
2016-05-28 13:42:30 +00:00
Cheng Zhao
f4fe60d126
Set default mimeType for BufferJob
2016-05-28 22:36:22 +09:00
Cheng Zhao
30dca2b4e1
Pages in chrome extension should not have node integration
2016-05-28 21:46:53 +09:00
Cheng Zhao
9ed4730cba
Pass sender for chrome.runtime.onMessage
2016-05-28 21:45:23 +09:00
Cheng Zhao
5eb9ed1729
Implement chrome.tabs.sendMessage
2016-05-28 21:35:07 +09:00
Cheng Zhao
62fb4f9820
Implement chrome.runtime.sendMessage
2016-05-28 21:23:43 +09:00
Cheng Zhao
ba315248e0
Use ipcRenderer.sendTo to get rid of routers in main process
2016-05-28 21:13:00 +09:00
Cheng Zhao
ae1f442b02
Add ipcRenderer.sendTo
2016-05-28 20:50:28 +09:00
Cheng Zhao
d55b96fdf5
Clean up the Chrome API implementation code
2016-05-28 20:33:18 +09:00
Cheng Zhao
31628abadc
Implement chrome.tabs.executeScript
2016-05-28 16:41:12 +09:00
Cheng Zhao
db94121360
Implement port.sender
2016-05-28 16:01:16 +09:00
Cheng Zhao
f5b430d9e1
Inject chrome.* to content scripts
2016-05-28 15:37:44 +09:00
Cheng Zhao
d8db695712
Handle port disconnecting
2016-05-28 12:07:08 +09:00
Cheng Zhao
599d3c147b
Background pages and content script should be loaded on startup
2016-05-28 10:39:11 +09:00
Cheng Zhao
e76c36a9a8
Make simple runtime.connect work
2016-05-28 10:26:41 +09:00
Cheng Zhao
dfe7ae2124
Add webContents.fromId
2016-05-28 10:10:24 +09:00
Kevin Sawicki
84f6015037
Call print on webContents
2016-05-27 11:11:55 -07:00
Felix Rieseberg
fa7f084625
📠 Add print() to BrowserWindowProxy
...
Closes #5685
2016-05-27 11:11:19 -07:00
Kevin Sawicki
59dd7ca9df
Guard against object with no hasOwnProperty
2016-05-27 10:46:02 -07:00
Cheng Zhao
9ab76fb884
Add webContents.sendToAll to send message to all frames
2016-05-27 16:58:49 +09:00
Cheng Zhao
c1facec5a6
No need to hijack setInjectedScriptForOrigin
2016-05-27 15:12:49 +09:00
Cheng Zhao
7e1f159185
Run content scripts at correct phase
2016-05-27 11:12:51 +09:00
Cheng Zhao
49d9446cce
Implement a simple content script injector
2016-05-27 10:29:57 +09:00
Cheng Zhao
97c04735a2
Handle unloading devtools correctly
2016-05-27 09:55:59 +09:00
Cheng Zhao
a63ff714f8
Read content_scripts to preferences
2016-05-27 09:47:37 +09:00
Cheng Zhao
b646d7a55c
The consts
2016-05-27 07:43:23 +09:00
Cheng Zhao
edd8210ae5
Add simple support for background page
2016-05-26 19:57:10 +09:00
Cheng Zhao
99c1434051
Store the original manifest file
2016-05-26 18:38:20 +09:00
Cheng Zhao
513b66f207
Cleanup chrome-extension.js after the Coffe2ES transfer
2016-05-26 18:38:20 +09:00
Cheng Zhao
f29598d907
getHostForPath => generateHostForPath
...
The original name implies no side effect, but is is not true.
2016-05-26 18:38:20 +09:00
Cheng Zhao
93b8237e1f
Merge pull request #5700 from felixrieseberg/standard-7
...
Implement JavaScript Standard Style 7
2016-05-26 04:57:36 +00:00
Cheng Zhao
8a4b7eb062
Merge pull request #5689 from cdaringe/master
...
Support non-native promises
2016-05-26 04:49:40 +00:00
Cheng Zhao
4ea7602871
Merge pull request #5684 from electron/webview-visibilitychange
...
Support document visibility and events in webviews
2016-05-26 01:07:24 +00:00
Felix Rieseberg
bef6748c06
🎨 Implement JS Standard Code Style 7
...
Updates Standard Code Style to 7 (latest major) and ensures that code
is conform.
* camelCase is now enforced
* No assignments in return statements
2016-05-25 16:20:49 -07:00
Kevin Sawicki
583bb49f6c
Get hidden state by using parent window directly
2016-05-25 10:13:12 -07:00
Kevin Sawicki
73b07f76a3
Support document visiblity state and events in webviews
2016-05-25 09:12:52 -07:00
cdaringe
32073fa079
🎨 Support non-native promises
2016-05-25 10:11:18 -06:00
Kevin Sawicki
7e209dd982
ATOM_SHELL_INTERNAL_CRASH_SERVICE -> ELECTRON_INTERNAL_CRASH_SERVICE
2016-05-25 09:08:09 -07:00
Cheng Zhao
28e2058ff1
Merge pull request #5648 from electron/chrome51
...
Update to Chrome 51
2016-05-24 10:59:11 +00:00
Cheng Zhao
cd444e82f9
Merge pull request #5666 from electron/remote-promise-reject
...
Handle rejection of remote promises
2016-05-24 04:30:25 +00:00
Kevin Sawicki
a4f94b89b4
Add comment about Module path
2016-05-23 15:15:39 -07:00
Kevin Sawicki
6ac0151e65
Remove lint warnings
2016-05-23 15:14:55 -07:00
Kevin Sawicki
19fd841c30
🎨
2016-05-23 15:14:55 -07:00
Kevin Sawicki
566b0676bc
Pre-resolve electron require path
2016-05-23 15:14:55 -07:00
Kevin Sawicki
daea448b61
.coffee -> .js
2016-05-23 15:14:55 -07:00
Kevin Sawicki
7929daa48c
Pass both callback values to then
2016-05-23 15:07:01 -07:00
Cheng Zhao
9f858e1243
Merge branch 'master' into chrome51
2016-05-23 19:49:43 +09:00
Cheng Zhao
9d82041923
Fix js lint warnings
2016-05-23 16:15:39 +09:00
Cheng Zhao
d6f9e57e33
Fix chrome.devtools not available in devtools extensions
2016-05-23 16:04:37 +09:00
deepak1556
f68d0f324f
deprecate app.allowNTLMCredentialsForAllDomains
2016-05-23 11:44:21 +05:30
deepak1556
62cad610e0
bring back app.allowNTLMCredentialsForAllDomains
2016-05-23 01:52:09 +05:30
Cheng Zhao
67d9ae27c3
Remove the JavaScript wrapper for setContextMenu
2016-05-20 16:18:38 +09:00
Cheng Zhao
8ac93e02c6
Merge pull request #5616 from electron/inherit-zoom
...
Inherit zoomFactor in webview
2016-05-20 00:27:06 +00:00
Cheng Zhao
4193fb1742
Merge pull request #5617 from electron/dont-return-from-on-functions
...
Remove returns from event listeners
2016-05-20 00:26:29 +00:00
Cheng Zhao
844f9e989b
Merge pull request #5611 from jviotti/fix/invalid-archive-asar-exec
...
Override `child_process.execFile` asar patch for `child_process.exec`
2016-05-20 00:24:10 +00:00
Kevin Sawicki
cc7395eea8
Remove returns from event listeners
2016-05-19 15:28:08 -07:00
Kevin Sawicki
4754e4aabb
Add zoomFactor to guest params
2016-05-19 14:32:16 -07:00
Kevin Sawicki
fef2f789cd
🎨
2016-05-19 14:30:53 -07:00
Juan Cruz Viotti
1a27ecdad4
Override child_process.execFile asar patch for child_process.exec
...
NodeJS implements `child_process.exec` by simply passing the whole
command to `child_process.execFile`. See:
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L90
- https://github.com/nodejs/node/blob/master/lib/child_process.js#L99
Electron patches `child_process.execFile` to add support for `asar`
archives by injecting logic that extracts the required files from the
`asar` to a temporary location before delegating the work to the
original `child_process.execFile`.
In order to decide whether to inject the custom `asar` extracting logic,
Electron makes use of a helper function called `splitPath()`. See:
- https://github.com/electron/electron/blob/master/lib/common/asar.js#L37
If the first argument of the returned array equals `true`, means that
the path is considered to be an `asar` archive, and thus the extraction
logic takes place. The problem is that if the command passed to
`child_process.execFile` *contains* a path to an asar archive, padded
with other commands/arguments, `splitPath()` will consider it to be an
`asar` archive, and will try to extract it, throwing a rightfully
`Invalid package` error.
Fixes: https://github.com/electron/electron/issues/5571
Signed-off-by: Juan Cruz Viotti <jviottidc@gmail.com>
2016-05-19 17:19:36 -04:00
Bruno Queiros
046cb0df8d
🎨 Use the same stack trace for both cases
2016-05-18 19:02:42 -03:00
Bruno Queiros
06e3e65c1b
🎨 Improve error message
2016-05-18 11:00:08 -03:00
Cheng Zhao
87c10b3ac2
Make non-public module accesible via remote
2016-05-18 13:57:48 +09:00
Cheng Zhao
90f52169af
No more need to check for nodeIntegration when creating guest view
2016-05-17 17:06:02 +09:00
Cheng Zhao
c1399f9bdc
Disable webview when nodeIntegration is off
2016-05-17 16:51:06 +09:00
Cheng Zhao
ecbb088ea6
Merge pull request #5542 from stevekinney/standardize-requires
...
Standardize requires
2016-05-16 10:42:12 +09:00
Steve Kinney
0d3d097ce8
💄 Standarize requires in JavaScript API
2016-05-15 09:41:30 -04:00
Steve Kinney
2317b56ac4
💄 Make the power-save-blocker a bit more concise
2016-05-15 09:36:13 -04:00
Ben Gotow
84cce6c2c1
Don't default to "Open", "Save", just let OS decide
2016-05-15 01:03:32 -05:00
Ben Gotow
40c531737d
Add buttonLabel param to showOpen/showSave dialogs
2016-05-15 01:03:32 -05:00
Cheng Zhao
88f3c34412
Merge pull request #5532 from stevekinney/patch-2
...
💄 Use ES6; clean up CoffeeScript conversion in BrowserWindow module
2016-05-15 12:38:28 +09:00
Steve Kinney
fd9c9c3be7
💄 Use spread operator instead of arguments object
2016-05-14 22:33:21 -04:00
Steve Kinney
236810a923
💄 Use ES6; clean up CoffeeScript conversion
...
💄 Destructure app module
Address linting errors
2016-05-14 22:33:20 -04:00
Cheng Zhao
88dc73ec3f
Merge pull request #5533 from stevekinney/patch-3
...
💄 Destructure globalShortcut module
2016-05-15 11:16:19 +09:00
Steve Kinney
c11d18fe06
💄 Destructure globalShortcut module
...
💄 Remove globalShortcut property
Add back the globalShortcut property
2016-05-14 21:53:42 -04:00
Steve Kinney
b1275420a3
Require download_items inline
2016-05-14 19:43:30 -04:00
Steve Kinney
e5036c0988
Use anonymous function for wrapping native classes
2016-05-14 12:28:28 -04:00
Steve Kinney
0785c3bd15
💄 Add spaces to comply with Standard
2016-05-14 11:31:08 -04:00
Steve Kinney
5dc88aa543
💄 Add ES6; Clean up from CoffeeScript conversion
2016-05-14 11:17:46 -04:00
Cheng Zhao
064af6ecb2
Merge branch '1-0-release'
2016-05-11 22:11:08 +09:00
Cheng Zhao
759a46f3d6
Use DoubleIDWeakMap for |rendererFunctions|
2016-05-11 20:40:48 +09:00
Kevin Sawicki
a32f50ef64
Use arrow function for this binding
2016-05-11 12:54:52 +02:00
Kevin Sawicki
1b2b7fc4ce
Listen for devtools-opened on webContents
2016-05-11 12:48:46 +02:00
Cheng Zhao
49ac160ff7
Move createIDWeakMap to v8Util
2016-05-11 19:30:06 +09:00
Cheng Zhao
04d59991b0
Use create function instead of IDWeakMap constructor
2016-05-11 16:15:32 +09:00
Cheng Zhao
2cd41b2f84
Merge branch 'master' of https://github.com/electron/electron
2016-05-11 15:15:15 +09:00
Cheng Zhao
0f52a6da39
Merge branch '1-0-release'
2016-05-11 15:14:56 +09:00
Cheng Zhao
ed70a11ff8
Merge pull request #5477 from danhp/download-bounce
...
Add API: app.dock.downloadFinished(filePath)
2016-05-11 09:41:08 +09:00
Daniel Pham
6dae07b76f
Add API: app.dock.downloadFinished(filePath)
2016-05-10 15:02:56 -04:00
Cheng Zhao
566bb1f708
Turn the exception in protocol.registerStandardSchemes to warning
2016-05-10 09:53:35 +09:00
Cheng Zhao
ab3122ef2a
No need to keep the deprecated APIs
...
They will be removed in next release.
2016-05-10 09:53:35 +09:00
Cheng Zhao
af0afecb45
Merge pull request #5406 from deepak1556/protocol_standard_scheme_patch
...
protocol: fix registerStandardSchemes api
2016-05-09 09:12:35 +09:00
deepak1556
70dac71639
delay protocol object creation
2016-05-08 16:44:14 +05:30
deepak1556
0f2ae385ed
allow protocol module initialization before app ready.
...
* ensure registerStandardSchemes can only be called before app ready
* ensure other protocol methods can only be used after app ready
2016-05-08 01:36:34 +05:30
Steve Kinney
91220f2a98
💄 Simplify conditional check for BrowserWindow
2016-05-07 09:13:40 -06:00
Steve Kinney
f3e633eb2c
💄 Use destructuring to shift arguments
2016-05-07 08:55:26 -06:00
Steve Kinney
6708e2a302
💄 Cache last argument in parseArgs
...
This is to eliminate the need to access the array twice.
2016-05-07 08:52:52 -06:00
Cheng Zhao
fd432ddbc9
Fix the toDataUrl call in desktopCapturer
2016-05-06 10:12:56 -07:00
Kevin Sawicki
7685380105
Remove crashed event forwarding
2016-05-06 10:12:56 -07:00
Kevin Sawicki
56cd57872c
Remove BrowserWindow events now on WebContents
2016-05-06 10:12:56 -07:00
Kevin Sawicki
f2d8eadf4e
Remove deprecated prototol APIs
2016-05-06 10:12:55 -07:00
deepak1556
14661819c2
move session wrapper to webcontents
2016-05-06 10:12:55 -07:00
Kevin Sawicki
30b60516fe
Initialize session explicitly
2016-05-06 10:12:55 -07:00
Kevin Sawicki
814ae7b4a4
🎨
2016-05-06 10:12:55 -07:00
Kevin Sawicki
d627ead273
Remove linter errors
2016-05-06 10:12:55 -07:00
Kevin Sawicki
16d4c436cb
Keep exporting deprecate/deprecations
2016-05-06 10:12:55 -07:00
Kevin Sawicki
7ad86a12b4
Remove empty _init
2016-05-06 10:12:54 -07:00
Kevin Sawicki
2ce4237083
Remove hideInternalModules API
2016-05-06 10:12:54 -07:00
Kevin Sawicki
dafa14fe42
Don't export deprecate API
2016-05-06 10:12:54 -07:00
Kevin Sawicki
bf91410a22
Remove deprecated main process ipc module
2016-05-06 10:12:54 -07:00
Kevin Sawicki
d988cae16d
Remove deprecated ipc module
2016-05-06 10:12:53 -07:00
Kevin Sawicki
a6cf7a1095
Remove deprecated crashReporter.start options
2016-05-06 10:12:53 -07:00
Kevin Sawicki
6f0471f6cb
Remove deprecated options check in BrowserWindow
2016-05-06 10:12:53 -07:00
Kevin Sawicki
0342db9328
Remove hyphenated options
2016-05-06 10:12:53 -07:00
Kevin Sawicki
dae68be2ce
Remove deprecated APIs
2016-05-06 10:12:53 -07:00
deepak1556
4e6b148eaa
webContents: fix executejavascript when called before page load
2016-04-28 01:54:08 +05:30
Cheng Zhao
06cf0406fe
Dereference remote objects with native code
...
Previously we rely on the v8util.setDestructor to dereference the remote
objects in JavaScript, however as documented in V8, it is forbidden to
call V8 APIs in object's destructor (e.g. the weak callback), and doing
so would result in crashs.
This commit removes the JavaScript setDestructor method, and avoids
doing the dereference work with V8.
2016-04-26 16:16:22 +09:00
Cheng Zhao
570dc7ca9b
Merge branch 'MarshallOfSound-master'
2016-04-26 11:15:56 +09:00
Samuel Attard
315cd9d2c8
Emit an error if quitAndInstall is called without an update being available
2016-04-26 11:55:57 +10:00
Cheng Zhao
a421c66f3f
Deprecate the platform-theme-changed event
2016-04-25 14:35:34 +09:00
Cheng Zhao
ddd8eae661
Move isAeroGlassEnabled and isDarkMode to systemPreferences
2016-04-25 12:35:09 +09:00
Cheng Zhao
13f8599ba1
Add systemPreferences module
2016-04-25 11:32:33 +09:00
Kevin Sawicki
08e18d46ea
Merge pull request #5244 from electron/disable-node-in-web-view-when-disabled-in-parent
...
Disable node in webviews when disabled in parent window
2016-04-22 09:05:58 -07:00
Felix Rieseberg
c0f63eed4e
🎨 Windows Store Camels
2016-04-21 19:11:25 -07:00
Kevin Sawicki
8e7bf1051d
Disable node integration on webview when disabled on window
2016-04-21 11:52:10 -07:00
Cheng Zhao
c92e622ce0
Merge pull request #5238 from electron/felix/appx-detection
...
Add Windows Store Detection
2016-04-21 16:21:38 +09:00
Felix Rieseberg
2a2a8d3263
Add Windows Store Detection
...
If we're running as a Windows Store appx package,
`process.windowsstore` will be `true`, otherwise
`undefined`.
2016-04-21 00:02:03 -07:00
Cheng Zhao
b5c1db9ad9
Guard against unexist owner when removing ref to remote object
2016-04-21 11:23:20 +09:00
Cheng Zhao
aa29dc0c8a
Merge pull request #5199 from Mr0grog/5183-disambiguate-loading-from-main-frame-loading
...
Add `isLoadingMainFrame()` to WebContents
2016-04-20 20:49:56 +09:00
Cheng Zhao
680652d01c
buffer, null, array etc. all belong to object
2016-04-20 14:32:32 +09:00
Cheng Zhao
ff1b7d18f6
Cleanup the code determining value's type
2016-04-20 14:26:49 +09:00
Rob Brackett
64a84dee3b
Add isLoadingMainFrame method to WebContents.
...
Also switch `webContents.executeJavaScript` to check it instead of `isLoading`.
There doesn’t seem to be a reasonable public way to get this information out of Chromium, so it’s synthesized here based on WebContentsObserver callbacks.
Fixes #5183 .
2016-04-18 10:37:08 -07:00
Cheng Zhao
cb947873c4
Merge pull request #5161 from electron/felix/iss5097
...
AutoUpdate Windows: Don't spawn if running
2016-04-15 20:10:03 +09:00
Felix Rieseberg
a5b93211e6
AutoUpdate Windows: Don't spawn if running
...
Previously, the auto updater would run as many squirrel processes
as told. This introduces a little change where instead of spawning
a second process, we attach to the already running process - or, if
different arguments are passed, return and emit an error.
This is not failsafe, but it ensures that we don't run into simple
race condition crashes.
Closes $5097
2016-04-14 11:22:28 -07:00
Cheng Zhao
31eb793fb0
Avoid adding a new option to webPreferences
2016-04-14 10:50:07 +09:00
Cheng Zhao
8f0e594007
Fix lint warnings
2016-04-13 23:10:31 +09:00
Cheng Zhao
43c44da50b
Correctly set initial visibilityState
2016-04-13 23:07:28 +09:00
Cheng Zhao
07a4c52919
Reduces the IPC messages used for visibilityState
2016-04-13 21:36:43 +09:00
Cheng Zhao
92882c358a
No more need to delay did-fail-load event
2016-04-13 19:33:59 +09:00
Cheng Zhao
2fbe06a2a5
Handle the Page.reload command coming from devtools
2016-04-12 16:36:12 +09:00
Cheng Zhao
a07612c1ed
Merge branch '5074-did-get-response-details-resource-type' of https://github.com/Mr0grog/electron into Mr0grog-5074-did-get-response-details-resource-type
2016-04-11 21:05:40 +09:00
Rob Brackett
15b042b5f6
Add support/tests for did-get-response-details event on <WebView>
2016-04-08 12:55:20 -07:00
Kevin Sawicki
732697a8a2
Rename ATOM_SHELL_ASAR to ELECTRON_ASAR
2016-04-08 08:53:58 -07:00
Kevin Sawicki
8d8d5878a3
Rename ATOM_ ipc event prefix to ELECTRON_
2016-04-07 09:04:55 -07:00
Rob Brackett
f12f87d6f0
Add isMainFrame as last argument to WebContents did-fail-load event.
...
Fixes #5013 .
2016-04-04 19:26:06 -07:00
Kevin Sawicki
eafe9c245b
Disable guest node integration when embedder has it disabled
2016-04-01 16:48:21 -07:00
Kevin Sawicki
e5164d2255
Check of nodeIntegration is strictly equal to false
2016-04-01 16:42:21 -07:00
Kevin Sawicki
dbe1c1d4e4
Check nodeIntegration on embedder's webPreferences
2016-04-01 16:40:50 -07:00
Kevin Sawicki
463e077c3a
Disable node on child when disabled on parent
2016-04-01 16:39:18 -07:00
Kevin Sawicki
ce95747a25
atom.asar -> electron.asar
2016-04-01 16:12:12 -07:00
Kevin Sawicki
400efa1b7d
Fallback to using the last argument as the callback
2016-04-01 12:54:06 -07:00
Kevin Sawicki
464dad3135
Store default_app in .asar archive
2016-04-01 12:40:32 -07:00
Cheng Zhao
39d2b95a33
Reference the remote object in its prototype chain's methods
2016-04-01 15:46:01 +09:00
Cheng Zhao
4ebb01f8c9
Remote object's members should reference itself
2016-04-01 15:26:30 +09:00
Robo
7016fbe258
browser: fix disposition value for new-window event
2016-04-01 08:14:29 +05:30
Cheng Zhao
7353fb4296
Merge pull request #4955 from atom/remove-node-integration-disable-path
...
Remove path for nodeIntegration value of 'disable'
2016-04-01 11:14:30 +09:00
Kevin Sawicki
f033f259b4
Only check for nodeIntegration being true
2016-03-31 08:33:38 -07:00
Zeke Sikelianos
252121ac70
give anonymous function a name
2016-03-30 17:00:35 -07:00
Zeke Sikelianos
9efd29d059
fix a minor style issue
2016-03-30 17:00:35 -07:00
Zeke Sikelianos
d5e8bb7f12
derp
2016-03-30 17:00:35 -07:00
Zeke Sikelianos
7c58f7fb02
eradicate all per-file eslint globals
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
47a61e9f27
use window.location instead of location
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
b5afad9da7
avoid using eslint comment exceptions
2016-03-30 17:00:34 -07:00
Zeke Sikelianos
6f845373a7
do not return and assign
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
42e7ee2b4a
finish standardizing!
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
4e2f1311e0
replace __proto__ with Object.setPrototype
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
2c3cacdc08
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
e6698102c9
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
cfdfdc8ccc
standardize by hand
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
fd0f9519f1
remove useless constructors
2016-03-30 17:00:33 -07:00
Zeke Sikelianos
c4b6cf4a8e
do more manual cleanup and specify globals
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
09635ae50e
reduce ignore list in favor of one-liner ignores
2016-03-30 17:00:32 -07:00
Zeke Sikelianos
3855a774ab
autoformat more easy files
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
67fa250020
standardize asar.js by hand
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
c845ea8372
autoformat more easy files
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
80f7c82f93
finish standardizing crash reporter
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
ca7b492b97
tiptoeing along, keeping the suite passing
2016-03-30 17:00:31 -07:00
Zeke Sikelianos
ee181294b3
manual syntax fixes on rpc server
2016-03-30 17:00:30 -07:00
Zeke Sikelianos
4d4f479721
manually standardize this tricky file
2016-03-30 17:00:30 -07:00
Zeke Sikelianos
4794385fac
first pass at standardizing; suite still passing!
2016-03-30 17:00:30 -07:00
Kevin Sawicki
8bcede8019
Merge pull request #4887 from sergeybekrin/master
...
Improve error reporting when passing invalid argument types for dialog API methods
2016-03-30 16:34:42 -07:00
Sergey Bekrin
4ac08870d0
Tweak error messages for dialog API
2016-03-30 23:07:13 +03:00
Kevin Sawicki
ad67070f23
Merge pull request #4861 from OctoHuman/master
...
Fix alert()
2016-03-30 12:40:41 -07:00
Cheng Zhao
e5886dda9b
Avoid re-evaluating internal modules
2016-03-27 19:16:26 +09:00
Sergey Bekrin
7f78781800
Improve error reporting when using invalid argument types for dialog API methods
2016-03-23 10:44:11 +03:00
Kevin Sawicki
2d32956903
Destructure objects
2016-03-22 13:11:42 -07:00
Kevin Sawicki
4127b524d5
Destructure params directly
2016-03-22 13:11:42 -07:00
Kevin Sawicki
43746727aa
Use direct params instead of rest params
2016-03-22 13:11:42 -07:00
Kevin Sawicki
4f4dc2f4d8
Use destructuring assigment
2016-03-22 13:11:42 -07:00
Kevin Sawicki
cbfe8b9228
Add minWidth and maxWidth to ints array
2016-03-21 09:12:47 -07:00
Cheng Zhao
a52285596e
Merge pull request #4846 from atom/rest-parameters
...
Use rest parameters
2016-03-21 21:03:28 +09:00
Cheng Zhao
e08b48ab48
Merge pull request #4840 from atom/undefined-menu-accelerator
...
Undefined menu accelerator
2016-03-21 21:02:44 +09:00
OctoHuman
116d61185a
Refix alert()
2016-03-20 03:40:12 -05:00
OctoHuman
9f6541228d
Fix alert()
2016-03-20 02:09:30 -05:00
Kevin Sawicki
a53c7529c1
Remove unneeded slice call
2016-03-18 11:54:34 -07:00
Kevin Sawicki
8889c29866
Use rest parameters
2016-03-18 11:51:02 -07:00
Kevin Sawicki
6aa452cda4
Set _setDeprecatedOptionsCheck on exports
2016-03-18 09:06:03 -07:00
Kevin Sawicki
7668c1ea0b
Use deprecate.warn instead of deprecate.log
2016-03-18 09:02:58 -07:00
Zeke Sikelianos
344dda4029
ignore set menu item fields
2016-03-17 16:20:23 -07:00
Kevin Sawicki
737ffd8d7c
Improve deprecated message on webPreferences options
2016-03-17 13:37:08 -07:00
Kevin Sawicki
c31882749d
Correct typos in comments
2016-03-17 13:37:08 -07:00
Kevin Sawicki
90d815ce6c
Add todo about removing hyphenated options
2016-03-17 13:37:08 -07:00
Kevin Sawicki
3e7501579f
Add camel case versions to ints array
2016-03-17 13:37:08 -07:00
Kevin Sawicki
a14380ed01
Set webPrereferences from features tring
2016-03-17 13:37:07 -07:00
Kevin Sawicki
15397bf879
Report deprecated BrowserWindow options
2016-03-17 13:37:07 -07:00
Kevin Sawicki
dfd13cf4ca
persistented -> persisted
2016-03-17 13:37:07 -07:00
Cheng Zhao
242be31440
Merge pull request #4805 from atom/automatically-set-app-model-id
...
Automatically set app user model ID
2016-03-17 22:21:29 +09:00
Cheng Zhao
e50ba35871
Merge pull request #4777 from deepak1556/webview_background_patch
...
webview: allow setting background color
2016-03-15 21:12:04 +09:00
Paul Betts
3ee4790dab
Automatically set app user model ID
...
We shouldn't ask users to figure out this piece of Windows Arcana when
they're using Squirrel, let's just do it automatically.
2016-03-14 20:36:48 -07:00
Robo
f8f3fba433
webview: allow setting background color
2016-03-14 15:01:36 +05:30
Cheng Zhao
b2059ec8af
Merge pull request #4774 from twolfson/dev/add.location.to.window.open.sqwished
...
Added support for window.location on window.open windows
2016-03-13 22:22:48 +09:00
Todd Wolfson
7569d180c9
Added support for window.location on window.open windows
2016-03-12 18:05:01 -06:00
Kevin Sawicki
3556507ab9
Use arrow functions for this binding
2016-03-11 14:08:14 -08:00
Kevin Sawicki
28e9d87d86
Add back return in getter
2016-03-11 11:25:56 -08:00
Kevin Sawicki
0e5e230c03
Remove lint errors due to rebase
2016-03-11 11:25:56 -08:00
Kevin Sawicki
3c11f5dc4d
Remove returns from event handlers
2016-03-11 11:25:56 -08:00
Kevin Sawicki
0ee3446109
Use undefined instead of void 0
2016-03-11 11:25:56 -08:00
Kevin Sawicki
a3f08c9b51
Use arrow functions to replace old CoffeeScript => this wrappers
2016-03-11 11:25:56 -08:00
Kevin Sawicki
6b1748d6d6
Don't collect results from delegate.menuWillShow
2016-03-11 08:55:48 -08:00
Kevin Sawicki
3a08aa37de
Don't collect results from Menu::_callMenuWillShow
2016-03-11 08:55:48 -08:00
Kevin Sawicki
93939089ec
Don't collect results in Menu.setApplicationMenu
2016-03-11 08:55:48 -08:00
Kevin Sawicki
3a1e837f8b
Don't collect results in exit event callback
2016-03-11 08:55:47 -08:00
Kevin Sawicki
5ed6c7714b
Don't return attributes from from WebViewImpl::setupWebViewAttributes
2016-03-11 08:55:47 -08:00
Cheng Zhao
6aec1e6949
Merge pull request #4714 from atom/chrome49
...
Upgrade to Chrome 49
2016-03-11 21:39:52 +09:00
Arek Sredzki
fcc1f4d7ed
Finalized browser-window show & hide events, added tests & fixed os x implementation
2016-03-10 13:51:31 -08:00
Arek Sredzki
c1267b2320
Added 'show' & 'hide' events to browser-window, fixed visibilitychange event in renderer
2016-03-10 13:51:31 -08:00
Arek Sredzki
ee61ab2d26
Cache browser visibility state & emit visibilitychange event on change
...
Fixes #3788
2016-03-10 13:51:31 -08:00
Cheng Zhao
6de9c4332f
Fix passing Promise with remote
...
Somehow using value.then.bind(value) would result in infinite loop,
could be bug of Chromium.
2016-03-10 17:06:22 +09:00
Kevin Sawicki
2e9fd7ce77
Update common api path
2016-03-08 11:22:13 -08:00
Kevin Sawicki
418efbe660
Remove unneeded resolve calls
2016-03-08 11:14:22 -08:00
Kevin Sawicki
006c77a00f
Update requires paths
2016-03-08 11:14:22 -08:00
Kevin Sawicki
70aa9b06ee
Move JavaScript to root lib/ folder
2016-03-08 11:14:21 -08:00
